Closed
Bug 86063
Opened 23 years ago
Closed 22 years ago
"Search the Web" ignores pref and goes to Netscape search page
Categories
(SeaMonkey :: Search, defect)
SeaMonkey
Search
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.1beta
People
(Reporter: mozbug, Assigned: jruderman)
References
Details
(Keywords: helpwanted)
Attachments
(1 file)
10.45 KB,
patch
|
samir_bugzilla
:
review+
hewitt
:
superreview+
|
Details | Diff | Splinter Review |
2001061421 trunk go to search -> search the web Netscape search page is loaded. It should be the search engine defined in the prefs.
me too : doing so changes my prefs , (on mac os 9.1 ,moz 0.9.1) and the search button disapears (werheas my button's prefs don't changes)
Comment 4•23 years ago
|
||
Also, clicking on the Search button with no search string in URL bar (i.e. it contains URL of current page) goes to Netscape. It should go to configured search engine. This in Win98 build 2001062815.
Comment 6•23 years ago
|
||
-> future/sgehani
Comment 7•23 years ago
|
||
Comment #4 is covered by the bug 53171
Comment 8•22 years ago
|
||
Since we now have two search menu items (in the same menu, no less), I tried to fix this. Its a 2 line change, but the problem is that I can't work out how to determine what url to go to when these items are selected. I can search for the empty string, but the search plugin stuff doesn't appear to have a field for a default uri. If I were to add one, how could I access it from within OpenSearch in navigator.js? I'm not too sure how this code works.
Updated•22 years ago
|
OS: Linux → All
Hardware: PC → All
Comment 9•22 years ago
|
||
*** Bug 138234 has been marked as a duplicate of this bug. ***
Comment 10•22 years ago
|
||
*** Bug 141497 has been marked as a duplicate of this bug. ***
Comment 11•22 years ago
|
||
C'mon why future? Surely this can't be that hard to fix. This setting is the only one that I've found is not preserved through upgrades. I wouldn't mind so much except netscape search is absolutely DIRE. For my last three searches, I did NOT GET A SINGLE HIT. (My last search was for "amavis virus scanner") Google, in stark contrast, which was my chosen pref before upgrading got hundreds of links, the first of which was the best!
Assignee | ||
Updated•22 years ago
|
Severity: normal → major
Summary: "Search the web" menu item goes to netscape search page → "Search the Web" ignores pref and goes to Netscape search page
Assignee | ||
Comment 12•22 years ago
|
||
*** Bug 146814 has been marked as a duplicate of this bug. ***
Comment 13•22 years ago
|
||
*** Bug 147199 has been marked as a duplicate of this bug. ***
Comment 14•22 years ago
|
||
*** Bug 147234 has been marked as a duplicate of this bug. ***
Comment 15•22 years ago
|
||
Sherlock plugins tell you how to search but don't tell you what the search page is. We can add an attribute to sherlock plugins that does tell you the search page and adding the attribute doesn't break anything. Plugins that don't have that attribute we should be able to guess by trimming the "action" field of the plugin. Then we need to use that anywhere we currently use "srchinternet". I think those two places are the menuitem and the search button when there is no content in the URL bar. Samir probably isn't going to do anything with this anytime soon and I'd really like to see it happen. I will take this bug and help to shephard a change in but I'm not a developer so I need someone to help with a patch. I'd love to see this changed for 1.1final on the trunk (that gives us about 5 weeks to get it done in time for 1.1beta).
Assignee: sgehani → asa
Comment 16•22 years ago
|
||
From the comment in it, it looks like attachment 87700 [details] [diff] [review] for bug 134614 addresses this as well.
Assignee | ||
Comment 17•22 years ago
|
||
This patch adds a field to search plug-ins that tells Search the Web where to go. For example, the Netscape search plug-in uses http://search.netscape.com/nscp_index.adp. If the search plug-in does not supply this URL, the new code takes the search URL and goes to the root of the site. For example, http://www.google.com/search?q= would become http://www.google.com/. The patch also makes it so pressing the Search button when the location bar is empty does the same thing as Search the Web, instead of going to a separate, hard-coded URL. This patch includes the fix for bug 134614 (add Ctrl+Shift+F shortcut for Search the Web). cvs diff -u browser/resources components/search global/resources
Comment 18•22 years ago
|
||
Comment on attachment 87738 [details] [diff] [review] patch r=sgehani
Attachment #87738 -
Flags: review+
Comment 19•22 years ago
|
||
r=aaronl for keyboard parts
Comment 20•22 years ago
|
||
Comment on attachment 87738 [details] [diff] [review] patch sr=hewitt
Attachment #87738 -
Flags: superreview+
Assignee | ||
Comment 21•22 years ago
|
||
Taking.
Assignee: asa → jruderman
Priority: P4 → --
Target Milestone: Future → mozilla1.1beta
Assignee | ||
Updated•22 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 22•22 years ago
|
||
In a fresh profile where the user has never opened the Search sidebar panel or the Internet Search prefs, something fails and triggers the fallback code. Should I investigate that or just change the fallback URL from http://home.netscape.com/bookmark/6_0/tsearch.html to http://search.netscape.com/nscp_index.adp?
Assignee | ||
Comment 23•22 years ago
|
||
*** Bug 152437 has been marked as a duplicate of this bug. ***
Assignee | ||
Comment 24•22 years ago
|
||
Fix checked in yesterday afternoon.
Status: ASSIGNED → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 25•22 years ago
|
||
Mozilla forgets your selected search engine if you install a new build into a different directory (bug 87699).
Comment 26•22 years ago
|
||
verified on win and mac. waiting on linux verification.
Comment 27•22 years ago
|
||
Search the web menu item and search button verified on Linux with LXR and Google. The new 'Ctrl+Shift+F' has made the tools menu look *AWFUL* though. Isn't there anything that can be done? Does the hotkey need to be visable? How about just mention it in the release notes. It looks /terrible/. How about something shorter like Ctrl-Z? Something... anything!
Updated•16 years ago
|
Product: Core → SeaMonkey
You need to log in
before you can comment on or make changes to this bug.
Description
•