8801 - [BETA] [FEATURE] font prefs: work with owner to finalize spec and impl

Status: VERIFIED FIXED

(SeaMonkey :: Preferences, defect, P2)

Description

[Erik van der Poel]

Figure out who owns the font picker, and work with that person to finalize the
spec and get it implemented, with all I18N issues in mind.

Comment 1

[Peter Trudelle]

That would be Eric Vaughan, evaughan

Comment 2

[Erik van der Poel]

Sorry, when I saw the term "font picker" in XPToolkit docs, I assumed it was
talking about the font prefs dialog under Edit.Preferences. In this bug report,
I'm really referring to the font prefs, so I've changed the Summary above. The
front end of the prefs is owned by Matt Fisher.

Comment 3

[Erik van der Poel]

Matt said he'd do font prefs by M9, so marking this M9.

Comment 4

[Erik van der Poel]

Won't make M10, marking M11.

Comment 5

[Frank Tang]

trudell told me they will drop font selector widget (which have both font face
selection and size selection in one widget) for M11. I told him it is ok since
we can use font face selection widget + a size menu to work around.

Comment 6

[Ben Goodger (use ben at mozilla dot org for email)]

I tried hooking up something like this the other day, for fun. I used
nsIFontEnumerator. Unfortunately, I have 388 fonts (not really that many, but
still quite a lot of DOM appends to be doing on a select widget) and it hung
mozilla every time I tried to load the font list -_-

Some people say that we need a "modern" font picking system like that
recommended at verso.com (can't remember the url, [e-mail] has it)
- one that lets you pick default serif, sans-serif, monospace, fantasy, dingbats
etc.

Comment 7

[matt]

i have the font panel in my tree with
the fontenumerator pretty much working.
I was going to try to check it in today
but i got a damn pdt+ treewidget bug.

Comment 8

[Erik van der Poel]

rgoodger, the font prefs panel that Matt is working on will have all of the CSS
generic fonts (serif, sans-serif, monospace, cursive and fantasy).

Matt, it's good to hear that you got it pretty much working. I hope you got my
email about the font pref name change. The naming scheme that I am using in the
backend code that has already been checked in is:

  user_pref("font.name.serif.x-western", "Times New Roman");
  user_pref("font.size.monospace.ja", 10);

However, the backend code does not currently dynamically update the fonts when
the prefs change. You need to quit the browser, and re-start, to take effect.

Comment 9

[Erik van der Poel]

*** Bug 7586 has been marked as a duplicate of this bug. ***

Comment 10

[Erik van der Poel]

Need to add default fonts to the default prefs file for each platform.

Comment 11

[Erik van der Poel]

*** Bug 19486 has been marked as a duplicate of this bug. ***

Comment 12

[chris hofmann]

checkin log show erik has checked in a fix for this in
nsPresContext.cpp

marking fixed to get on the testing radar.

Comment 13

[bobj]

Reopened.
This bug is not completely fixed.  There is additional work needed to
complete this feature.  Erik (and Frank for Mac) have incrementally
checked in parts to allow QA to test parts and to provide the pieces
needed to hook up the XUL pref dialog work that Matt is working on.

Comment 14

[chris hofmann]

moving the rest of the work off to m13.

Comment 15

[Erik van der Poel]

Montse, could you let me know which font names are used for the default fonts
in the various localized versions of Communicator 4.X? Thanks!

Comment 16

[Erik van der Poel]

Attachment: Patch to get Mozilla to update font prefs dynamically.

Comment 17

[Erik van der Poel]

Matt, I just attached a patch to this bug to get Mozilla to update font prefs
dynamically. So, to test your font prefs dialog in XUL/JS, you can use this
patch in your local tree, and make sure that the fonts change when you hit the
OK button in prefs. I tried it already, and it sorta works, but there is a bug
in the layout engine where the new fonts are not immediately displayed, and you
need to hide and show the window. It also doesn't relayout properly until you
do View.Reload. Anyway, this patch may help you test your XUL/JS while I'm on
vacation 12/18 to 1/5.

Comment 18

[Erik van der Poel]

Attachment: Patch to get font prefs to work on Unix.

Comment 19

[Erik van der Poel]

All, I just attached a patch to get font prefs to work on Unix. If anybody
wants to test font prefs on Unix while I'm on vacation 12/18 to 1/5, please
apply this patch to your local tree.

Comment 20

[sairuh (rarely reading bugmail)]

spam: in my testing realm, so reassigning qa contact to me, en masse.

Comment 21

[Erik van der Poel]

Created bug 24172 for adding default font names to default pref files. Closing
this bug for M13. If there are any specific bugs in this feature, please open
separate bug reports.

Comment 22

[sairuh (rarely reading bugmail)]

verif.

Comment 23

[leger]

Bulk move of all Pref UI component bugs to new Preferences component.  Pref UI 
component will be deleted.