896594 - [B2G][Leo][Settings]Display: The brightness adjustment slider is unresponsive.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[J Zimbrick]

Description:
 In the settings menu, the brightness adjustment slider is unresponsive.

Repro Steps:
1. Update Leo device to build 20130722070207.
2. Open the settings menu.
3. Scroll down to the Display option under the Personalization tab and tap it.
4. Uncheck Adjust Automatically under the display tab.
5. Attempt to slide the the brightness slider and observe that it is largely unresponsive.  It does not adjust with the user input, and most of the time does not react at all, but will sometimes seemingly randomly pick a different value.

Actual:
Brightness display slider is unresponsive.

Expected:
Brightness display slider reacts to user input.

Environmental Variables
Build ID: 20130722070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/68fb0a2e0114
Gaia: 41d10fb10be6916e6554eb440d9a97130ef23ce0
Platform Version: 18.1
RIL Version: 01.01.00.019.164 

Notes:
Repro frequency: 100% on 3 devices.
Q Analysts Team Priority: (Pri Levels: Pri 2

As far as regression windows, I change this setting on every build, this is the first time I've seen this sort of behavior with the brightness slider.

Comment 1

[Jason Smith [:jsmith]]

Can we get a specific regression window here?

Comment 2

[J Zimbrick]

Rolled back a few builds, the problem began on Sunday the 21st's build:

Environmental  Variables:
Build ID: 20130721230204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1dffc79bfac5
Gaia: 06d56e0efd1cb3bbed37fef6ee45233b86b3ae3b
Platform Version: 18.1
RIL Version: 01.01.00.019.164

Did not occur on the 20th's build.

Comment 3

[J Zimbrick]

Exact regression window:

Last passing build:
Environmental  Variables:
Build ID: 20130721230204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1dffc79bfac5
Gaia: 06d56e0efd1cb3bbed37fef6ee45233b86b3ae3b
Platform Version: 18.1
RIL Version: 01.01.00.019.164

First breaking build:
Environmental  Variables:
Build ID: 20130721070210
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1dffc79bfac5
Gaia: c4bdd3210864938b8ffd252c442ddcd442d09944
Platform Version: 18.1
RIL Version: 01.01.00.019.164

Comment 4

[J Zimbrick]

Disregard comment 3, the build numbers were swapped.

Exact regression window:

Last passing build:
Environmental  Variables:
Build ID: 20130721070210
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1dffc79bfac5
Gaia: c4bdd3210864938b8ffd252c442ddcd442d09944
Platform Version: 18.1
RIL Version: 01.01.00.019.164

First breaking build:
Environmental  Variables:
Build ID: 20130721230204
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/1dffc79bfac5
Gaia: 06d56e0efd1cb3bbed37fef6ee45233b86b3ae3b
Platform Version: 18.1
RIL Version: 01.01.00.019.164

Comment 5

[Jason Smith [:jsmith]]

Only one candidate here that likely caused this regression - bug 881727. That patch is huge, so it likely caused a regression like this.

Comment 6

[Nick Davidson]

This bug also affects sliders "Ringer & Notifications" and "Alarm" under Settings>Sound
Also it can be related to bug 802208

Comment 7

[(Inactive after June) George Duan [:gduan] [:喬智]]

Attachment: PR TO MASTER

Add pointer-events: none to fix this bug

Comment 8

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 779569 [details]
PR TO MASTER

George, nice catch! r=me.

pointer-events was declared in switches.css: label:not([for]) input + span and removed after bug 881727 lands.

Comment 9

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: https://github.com/mozilla-b2g/gaia/commit/8574aeec5cd13f0ed2460b51768599e26f722b28

Comment 14

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 8574aeec5cd13f0ed2460b51768599e26f722b28 to:
v1-train: f386fd332f7c2415302101a65ac56cce6a6d7529

Comment 15

[Shilpa Suresh]

The issue does not seem to occur anymore on Leo V1.1 mozilla build.

Build ID: 20130801070210
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/aff662053ee8
Gaia: ddb922ed002e88d01f71199da32ff75911b455b2
Platform Version: 18.1
RIL Version: 01.01.00.019.172 

Verifying as Fixed in v1.1

Comment 17

[Arthur Chen [:arthurcc][inactive after 6/30]]

Nominate for hd? as this is a duplicate of bug 901775.

Comment 19

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: f386fd332f7c2415302101a65ac56cce6a6d7529

Comment 21

[milankragujevic]

This still occurs on Keon with the latest update (10th August)

Comment 22

[William Hsu [:whsu]]

Thanks for your help!
Verified on the V1.1.0 HD build with latest helix base image(0805).
Marked as "Verified"+"Fixed"

* Test build:(Mozilla-b2g18_v1_1_0_hd-helix/2013-08-15-04-22-01)
  + Mercurial-Information
    - Gecko revision="bd0864949c0f"
  + Git-information
    - Gaia revision="d04d2d3969e4366fabafe9659f9b2705b7879ac2"

Comment 23

[Wayne Chang [:wchang]]

It was leo+'ed after comment 9 and this already covers hd+ uplift. Correcting flag