94870 - Autocomplete ignores history entires starting with "www"

Status: VERIFIED FIXED

(SeaMonkey :: Location Bar, defect)

Description

[Ashley Bischoff (blog at handcoding.com)]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:0.9.3+)
Gecko/20010810
BuildID:    2001081003

Autocomplete seems to be ignoring history entries starting with "www".

Reproducible: Always
Steps to Reproduce:
1. Load "www.google.com" to ensure that it's in your history.
2. Goto URL Bar and type "www.goo"


Actual Results:  At this point, autocomplete drop-down should suggest
"http://www.google.com"

Expected Results:  No autocomplete suggestion.

Interestingly enough, after step 2, if you type just "goo", autocomplete
cooperates (but that's just bug 63421 working properly). 

I haven't found any dupes, though it looks like bug 94612 is close (though
separate, I think).

Comment 1

[Ashley Bischoff (blog at handcoding.com)]

*** Bug 94872 has been marked as a duplicate of this bug. ***

Comment 2

[R.K.Aa.]

And Linux. OS: All

Comment 3

[Jacek Piskozub]

Look to the duped bug 94872 for arguments why it is a bad behavior.

Comment 4

[R.K.Aa.]

Yes, it's very clearly bad behaviour. www.something.com, home.something.com and
something.com may be on different ports for that matter - or there may be no
server at all on something.com

Btw.. autocomplete doesn't trigger on http:// either:
It only triggers if i write slashdot.org (not when i write http://slashdot.org
or http://www.slashdot.org)

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 94946 has been marked as a duplicate of this bug. ***

Comment 6

[timeless]

it will be mostfreq shortly. flagging.

Comment 7

[Jacek Piskozub]

Changing severity to major. It *is* a major loss of autocomplete finctionality.

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 95064 has been marked as a duplicate of this bug. ***

Comment 9

[WD]

*** Bug 95222 has been marked as a duplicate of this bug. ***

Comment 10

[Joe Hewitt (gone)]

*** Bug 95438 has been marked as a duplicate of this bug. ***

Comment 11

[Ashley Bischoff (blog at handcoding.com)]

Propose target milestone -> mozilla0.9.4

Comment 12

[Jacek Piskozub]

Nominating for mozilla0.9.4 per request by Alex

Comment 13

[Paul Chen]

nav triage team:

Reassigning to Joe Hewitt since he owns auto-complete widget.

Comment 14

[Joe Hewitt (gone)]

working on this, will have a fix shortly

Comment 15

[Joe Hewitt (gone)]

The problem here is that the current autocomplete search slices off certain
prefixes (like "http://" and "www.") from both the url you type, and all urls in
the history, before it compares them.  What should really be done is to not cut
any prefixes from the typed url, and only cut prefixes from the history urls if
those prefixes are not on the typed url.  This way, if you type "www.moz", the
search will compare this to "http://mozilla.org" and fail, but it will compare
it to "http://www.mozilla.org" and match.

Comment 16

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 17

[Joe Hewitt (gone)]

*** Bug 94612 has been marked as a duplicate of this bug. ***

Comment 18

[Dan Mosedale (:dmosedale, :dmose)]

* AutoCompleteExcludeInfo doesn't look like it will work for strings
that start with something from both tables (eg "http://www."), since
both searches do "Substring(aURL, 0, ...".

and a couple of nits:

* instead of using "protocol" and "domain" in your variables, it would
be more obvious to the reader if names like "schemePrefix" and
"hostnamePrefix" were used.

* how about adding a comment at the decl of AutoCompleteExclude
explaining a bit about it?


 

Comment 19

[Joe Hewitt (gone)]

* AutoCompleteExcludeInfo does work for strings that start with items from both
tables, since it cuts the string between each loop

I'll address your other comments and post a new patch.

Comment 20

[Joe Hewitt (gone)]

Attachment: revised patch

Comment 21

[Joe Hewitt (gone)]

Attachment: patch, take 3

Comment 22

[Dan Mosedale (:dmosedale, :dmose)]

r=[e-mail]

Comment 23

[Chris Waterson]

Looks good. My only nit would be to create the AutoCompleteExclude struct on the
stack in OnStartLookup(), and then alter the signature of
AutoCompleteGetExcludeInfo() to _fill in_ the struct, rather than allocating one
from the heap and returning it.

Fix that, and sr=waterson

Comment 24

[Joe Hewitt (gone)]

fixed

Comment 25

[Christopher Aillon (sabbatical, not receiving bugmail)]

*** Bug 97420 has been marked as a duplicate of this bug. ***

Comment 26

[Claudius Gayle]

VERIFIED Fixed with 20010907 builds