984797 - You cannot peek at notifications in the notifications panel

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Chris Lord [:cwiiis]]

Because the notifications panel slides in as a whole, instead of revealing a fixed position panel, you cannot pull down on it to 'peek' at notifications and quickly slide it back up.

Comment 1

[Anthony Ricaud (:rik)]

I believe this will be fixed by bug 968930.

Michael: Is it a dupe?

Comment 2

[Michael Henretty [:mikehenrty][:mhenretty]]

Yup, this is definitely a valid concern/use case, and we will be addressing it with the notification rework done in bug 968930.

Comment 3

[Chris Lord [:cwiiis]]

I'm reopening this as the bottom-tray notifications aren't going to be implemented in 2.1 and this would still be nice.

Comment 4

[Chris Lord [:cwiiis]]

Attachment: Implementation of a fixed-position utility tray

I'm marking this for review now, as I think the method is sound and it works.

Unfortunately, a layout bug blocks this from landing as the performance once you have more than a couple of notifications is quite poor (see the blocking bug).

Comment 5

[Chris Lord [:cwiiis]]

Attachment: Implementation of a fixed-position utility tray v2

I've fixed the main layout bug that blocks this, so I think it's feasible to do this now. Here's an updated implementation based on UX feedback.

Comment 6

[Etienne Segonzac (:etienne)]

Comment on attachment 8456736 [details] [review]
Implementation of a fixed-position utility tray v2

Wow this is beautiful :)

r=me with the grippy/placeHolder's height cached (we probably want to update the placeholder's one on resize).
The reflows on touchstart are driving me crazy :)

You might also want to investigate calling .preventDedault() on the touchevents to prevent the reflows from BrowserElementPanning.js but this can be done in a follow up.

Great work! I'll show my phone to Rob to make the ui-review quicker.

Comment 7

[Chris Lord [:cwiiis]]

(In reply to Etienne Segonzac (:etienne) from comment #6)
> Comment on attachment 8456736 [details] [review]
> Implementation of a fixed-position utility tray v2
> 
> Wow this is beautiful :)
> 
> r=me with the grippy/placeHolder's height cached (we probably want to update
> the placeholder's one on resize).
> The reflows on touchstart are driving me crazy :)
> 
> You might also want to investigate calling .preventDedault() on the
> touchevents to prevent the reflows from BrowserElementPanning.js but this
> can be done in a follow up.
> 
> Great work! I'll show my phone to Rob to make the ui-review quicker.

Thanks :) I've made the suggested changes (good call!) and am attempting to fix the marionette breakage.

I'll leave the preventDefault changes because I'm afraid of breaking something, but follow-up is a good idea.

Comment 8

[Peter La]

Hi Chris,

Rob demoed this to me and the rest of the UX team this morning, and it looks great!  I approve. :)

Peter.

Comment 9

[Chris Lord [:cwiiis]]

Fixed tests, merged to master: https://github.com/mozilla-b2g/gaia/commit/92dd8cc758614123a62376a56458259f4fd77a23

Comment 10

[Chris Lord [:cwiiis]]

Comment on attachment 8456736 [details] [review]
Implementation of a fixed-position utility tray v2

Marking ui-review+ per comment #8.

Comment 11

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to revert this in https://github.com/mozilla-b2g/gaia/commit/0b2ff6ce18066c78bc0e5b850e61bf01f7a697e5 for breaking Gaia UI tests: https://tbpl.mozilla.org/php/getParsedLog.php?id=44127877&tree=B2g-Inbound

Comment 12

[Chris Lord [:cwiiis]]

Damn, this is due to a weird layout bug that causes visibility:hidden flexbox children to have a 0x0 size - I thought I'd worked around it, but obviously not well enough.

If I can't find a better work-around, I think I'll just have to not use flexbox (which is a shame because it makes the css much simpler, but not the end of the world).

I'll sort this out tomorrow.

Comment 13

[Chris Lord [:cwiiis]]

Attachment: Implementation of a fixed-position utility tray v3

Actually, I'm just a massive idiot - there's no layout bug here, I messed up the CSS. Carrying r+/ui-r+

Comment 14

[Chris Lord [:cwiiis]]

I'm confident the change would have fixed the issue, merged to master: https://github.com/mozilla-b2g/gaia/commit/35f68cec4d813182591f1a474b15f5f58b7dc146

If I'm wrong, that's the last time I'll ever do that without waiting for travis.

Comment 15

[William Dorffer [:Nildeala]]

Is this to land in v2.0 branch as well ?

Comment 16

[Chris Lord [:cwiiis]]

(In reply to William Dorffer [:schoewilliam] from comment #15)
> Is this to land in v2.0 branch as well ?

No, this is a 2.1 feature (there's also a notifications panel visual refresh, being worked on by gmarty)

Comment 18

[Alison Shiue]

https://moztrap.mozilla.org/manage/cases/?&pagenumber=1&pagesize=100&sortfield=created_on&sortdirection=desc&filter-tag=2990

Comment 19

[Alison Shiue]

Verified on
Gaia      de7235e41f36a23a31c5e47218473c0cc471b019
Gecko     https://hg.mozilla.org/mozilla-central/rev/149d3ce6e020
BuildID   20140819160208
Version   34.0a1