99363 - Compose windows opened from Navigator should use default identity/account even when Mail & News is open

Status: RESOLVED FIXED

(MailNews Core :: Composition, defect)

Description

[[e-mail]]

Using Build ID: 2001091003
Steps to reproduce problem:
1. Open Mail & Newsgroups
2. Change to a folder not in your current identity, preferably news
3. Open Navigator
4. ^M or File/New/Message

Expected results: New mail message using default identity as per 4.x

Actual results: Same as new message from mail and newsgroups

Comment 1

[Jean-Francois Ducarroz]

-->varada

Comment 2

[varada]

Following the footsteps of 4.x isnt necessarily the right way to do things.
Recently I checked in a fix that would do the following.
1-If only browser is open - mail compose would bring up default identity.
2-If mail was open -mail compose would bring up the current identity being used
in mail - regardless of whether it is the default or not.
The logic being that if we are using multiple accounts and have switched to
another account in the mail window - it would be wrong to bring up the default
identity when mailcompose is launched from the browser.
Marking as Wontfix.

Comment 3

[[e-mail]]

It's really annoying to get a new news message because I had forgotton that I
was in the middle of reading news in Messenger.

Exactly what do you do if there is more than one Messenger window open?

Is there any chance you could pref this behaviour (enhancement)?

Comment 4

[James Nord]

What about using the default identity if the MailNews window does not have focus?

Comment 5

[Jonas Jørgensen]

*** Bug 123244 has been marked as a duplicate of this bug. ***

Comment 6

[Jonas Jørgensen]

This behavior was implemented in bug 79053. Bug 103869 (which IMO should be
WONTFIXed) is about making it even worse.

I don't see why the state of my MailNews window should affect anything I do in
Navigator any more than it should affect what happens if I click a mailto: link
in another browser which opens Mozilla MailNews. It's confusing.

[changing summary since this is about all Compose windows opened from Navigator,
not just those opened by Ctrl+M]

Comment 7

[Peter Trudelle]

Having the behavior vary depending on selection in one of the background windows
would seem to appear inconsistent to users. I doubt most users could reliably
predict the results. This is mail/news behavior though, not Navigator, and could
include other scenarios not mentioned here, such as MAPI.  cc jglick for UE input.

Comment 8

[(not reading, please use [e-mail] instead)]

taking all of varada's bugs.

Comment 9

[jglick]

>Having the behavior vary depending on selection in one of the background windows
>would seem to appear inconsistent to users.

Agree. The default identity/account should be used for consistency.

Comment 10

[[e-mail]]

Attachment: Patch

Comment 11

[Samir Gehani]

Mail triage team: Unless we have a consensus with supporting data let's keep the
current behavior.  An informal poll indicates that the current behavior is
expected by some.

Comment 12

[(not reading, please use [e-mail] instead)]

neil's patch deserves some consideration.

on thing the current patch doesn't really take into account is if we are doing
file | new message from a mail window, or not.

(if from navigator, that should mean "use default account", from a mail window,
that should mean "use the selected account".)

I think we want to go with neil's patch.  I've asked the triage team to clarify.

in my book, this is a bug (not an RFE), as the current behaviour would appear
unpredictable to the user.

note, varada seems to have made a change for bug #105838 that fixes a problem
with file | new message when browser is open, and news is selected in the 3
pane, but is wrong for when we do file | new message from the 3 pane.  (unless
this code isn't hit in that case).

Comment 13

[(not reading, please use [e-mail] instead)]

I've confirmed, that doing ctrl-l from the 3 pane, when news is being read,
opens up a new compose window to the default acount, instead of a news post with
the current news identity, like it should.

and like it does if you do file | new message.

looking at neil's patch, his patch should fix that problem, too.

Comment 14

[(not reading, please use [e-mail] instead)]

I see, this is the anti-bug to #79053.

in addition to neil's fix, we'd also need to undo some of varada's changes for
send page, send link, etc.

I agree with jglick, trudelle (http://bugzilla.mozilla.org/show_bug.cgi?id=99363#c7)
Jonas Jørgensen, neil, and others.

we should change the behaviour.

Comment 15

[(not reading, please use [e-mail] instead)]

see http://bugzilla.mozilla.org/attachment.cgi?id=47396&action=view for the
other code we have to fix.

Comment 16

[(not reading, please use [e-mail] instead)]

if we undo #79053, we should mark #103869 wontfix.

Comment 17

[(not reading, please use [e-mail] instead)]

Attachment: neil's patch, plus a comment, plus a fix for how send page, send image, etc work.

Comment 18

[(not reading, please use [e-mail] instead)]

since jglick and I agree, and this fixes other issues, I'm going with this approach.

the patch has r/sr=bienvenu.  marking fixed.

I'll log a new bug on http://bugzilla.mozilla.org/show_bug.cgi?id=99363#c13 so
that QA can verify it seperately.

I'll also re-open #79053 and mark it wontfix.

Comment 19

[(not reading, please use [e-mail] instead)]

I logged bug #188387 on the ctrl-m / file | new message issue when news is selected.

I've marked the mailto: bug invalid.

Comment 20

[(not reading, please use [e-mail] instead)]

this caused a regression, see bug #196073.