Closed Bug 1033549 Opened 10 years ago Closed 10 years ago

[User Story] Data tracking on a per app basis

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

x86
macOS
defect
Not set
normal

Tracking

(feature-b2g:2.1, b2g-v2.1 verified)

VERIFIED FIXED
2.1 S3 (29aug)
feature-b2g 2.1
Tracking Status
b2g-v2.1 --- verified

People

(Reporter: pdol, Assigned: marshall)

References

Details

(Whiteboard: [tako][2.1-feature-qa+])

User Story

As a cost-conscious phone user, I want to be able to track individual app network data usage so that I can be more informed how my data is being used.

Acceptance Criteria:
1. Viewing data usage within the Usage app shows a breakdown of the overall data usage on a per app basis.
2. UX interaction and visual design matches UX spec.

Attachments

(4 files, 11 obsolete files)

19.18 KB, image/png
amylee
: feedback+
Details
46 bytes, text/x-github-pull-request
salva
: review+
Details | Review
50.75 KB, image/png
amylee
: ui-review+
Details
145 bytes, text/plain
Details
      No description provided.
User Story: (updated)
Blocks: 1035544
Assignee: nobody → marshall
Depends on: 1042149
feature-b2g: --- → 2.1
Whiteboard: [tako]
Hi, I've attached the VsD spec to the meta bug 1035544. Moving forward all VsD/IxD specs will be attached to the meta bug and will be updated with the latest version. This is an effort to keep all the latest VsD/IxD specs in one place for easier reference. Thanks!
QA Whiteboard: [2.1-feature-qa+]
QA Whiteboard: [2.1-feature-qa+] → [2.1-feature-qa+][COM=Gaia::Contacts]
QA Whiteboard: [2.1-feature-qa+][COM=Gaia::Contacts] → [2.1-feature-qa+]
Flags: in-moztrap?
QA Whiteboard: [2.1-feature-qa+]
Whiteboard: [tako] → [tako][2.1-feature-qa+]
Target Milestone: --- → 2.1 S2 (15aug)
Hi, 

I've updated the visual spec with Usage Settings screen and App Usage screen (pg 15-19). Please find the latest spec in meta bug 1035544. 

Thanks!
Attached file per app usage (obsolete) —
Initial implementation of per-app usage data in the Usage (costcontrol) app. This patch focuses on just reporting the amount of data in the app list and chart for the currently active data sim as called out by the visual design spec.

Follow up patches will add the ability to disable mobile data usage for specific apps.
Attachment #8476158 - Flags: review?(salva)
Attachment #8476158 - Flags: feedback?(jdarcangelo)
Attachment #8476158 - Flags: feedback?(dflanagan)
Comment on attachment 8476158 [details] [review]
per app usage

The patch is huge and it's addressing more than described in the bug. I think we should land changes progressively, first adding the breakdown of usage into the different apps, the changing the chart and so on. Each change with its own tests to ensure we don't loose functionality.

Currently, there are several UI problems with the implementation:

  * There are no labels for days in the week view as specified in bug 1035544.
  * If there is no data limit set, instead of a bar, UI should show a text indicating how much data have been spent during the period.
  * When reaching 70% the bar should be colored in orange (now displaying a little orange band).
  * The last day bar overflows the X axis.
  * When limit is disabled, the limit line overflows on the top of the chart.

Furthermore, we have lost some functionality. This is mainly due to bug 1035544 new UX is not considering the WiFi scenario and we should clarify the situation.

  * There is no way to display WiFi usage.
  * The chart does not change when changing the configuration in settings. You need to hide and show the application to force a redraw.

I recommend you to land here only the breakdown of data usage adding the needed modifications to costcontrol.js and the list and leave the original chart unchanged and use another distinct bug for that end.

Sorry.
Attachment #8476158 - Flags: review?(salva) → review-
Depends on: 1056894
Hi Marshall, 

Can you please flag me for all ui reviews related to visual design implementation. Since it's difficult to check all the data usage scenarios with live data, can you please provide screenshots? Thanks
Flags: needinfo?(marshall)
(In reply to Salvador de la Puente González [:salva] from comment #5)
> Comment on attachment 8476158 [details] [review]
> per app usage
> 
> The patch is huge and it's addressing more than described in the bug. I
> think we should land changes progressively, first adding the breakdown of
> usage into the different apps, the changing the chart and so on. Each change
> with its own tests to ensure we don't loose functionality.

Makes sense to me, I went ahead and filed Bug 1056894 for the Chart UX changes

> 
> Currently, there are several UI problems with the implementation:

I'll address these in a separate patch on the UX bug, thanks for noticing them!
 
> Furthermore, we have lost some functionality. This is mainly due to bug
> 1035544 new UX is not considering the WiFi scenario and we should clarify
> the situation.
> 
>   * There is no way to display WiFi usage.

Argh, yeah this hasn't been in the current UX or Visual Design Spec. A possible fix would seem to be add a "WiFi" tab, similar to multiple SIMs. Amy, Val, what do you think?

Thanks for the quick review! I'll have a new patch for just the per-app list up soon, and a follow up for the chart changes hopefully before the end of the day.
(In reply to Amy Lee [:amylee] from comment #6)
> Can you please flag me for all ui reviews related to visual design
> implementation. Since it's difficult to check all the data usage scenarios
> with live data, can you please provide screenshots? Thanks

Yup, will do! FYI I'm breaking this patch into two, so the first screenshots will only have the app list, and not the new Chart UX changes (those changes will be on the newly created Bug 1056894).

Also, see my questions in comment #7 about WiFi usage data
Flags: needinfo?(vtsatskin)
Flags: needinfo?(marshall)
Flags: needinfo?(amlee)
(In reply to Marshall Culpepper [:marshall_law] from comment #8)
> (In reply to Amy Lee [:amylee] from comment #6)
> > Can you please flag me for all ui reviews related to visual design
> > implementation. Since it's difficult to check all the data usage scenarios
> > with live data, can you please provide screenshots? Thanks
> 
> Yup, will do! FYI I'm breaking this patch into two, so the first screenshots
> will only have the app list, and not the new Chart UX changes (those changes
> will be on the newly created Bug 1056894).
> 
> Also, see my questions in comment #7 about WiFi usage data

The Wifi question is more related to the UX spec so I'll let Val answer this one.
Flags: needinfo?(amlee)
Blocks: 1056967
Marshal, Amy, Val, thank you all guys! So, we address all of this in two separated bugs.

 + This for landing the list of consuming apps.
 + Bug 1056894 for the visual refresh of the chart.

Val, in addition to the WiFi clarification, could you provide information about how the chart should be displayed when there is no period (not weekly, nor monthly) selected?
Attached file app usage list only (obsolete) —
As requested, this is just the app usage list as a standalone patch.

This patch also incorporates code to show app usage for both WiFi and Mobile networks (since they can be toggled)
Attachment #8476158 - Attachment is obsolete: true
Attachment #8476158 - Flags: feedback?(jdarcangelo)
Attachment #8476158 - Flags: feedback?(dflanagan)
Attachment #8476936 - Flags: review?(salva)
Comment on attachment 8476936 [details] [review]
app usage list only

Hi Marshal. Much better. Thank you for taking the patch.

Please, address the comments on GitHub and provide your opinion when needed and ping me again for review. I'm open to discussion and improvement proposals so feel free to say whatever you think is worthy.

Thank you again!
Attachment #8476936 - Flags: review?(salva)
Updated visual spec in meta bug bug 1035544. Minor edit: Removed extra hairline at the bottom of screen 1. Usage Settings (Multi Sim)(pg 19). Thanks
Given we're in sprint 3 now, can we update the target milestone? If we're comfortable to land this by this month, please change the target milestone to sprint 3. Otherwise, please highlight it, and we should come out some mitigation plans. Thank you.
Flags: needinfo?(marshall)
Flags: needinfo?(marshall)
Target Milestone: 2.1 S2 (15aug) → 2.1 S3 (29aug)
Attached image legend.png
Val and I are going to suggest that we just leave the app list as "mobile data" only for now, so the "App Usage" wording becomes "Mobile App Usage". We will address per-app WiFi usage in this UI in a follow-up, post-2.1 at this point.

Val also wanted to make a minor change to the existing checkbox legend (attached).
Attachment #8478362 - Flags: feedback?(amlee)
Flags: needinfo?(vtsatskin)
Comment on attachment 8478362 [details]
legend.png

Hi Marshall, 

Thanks for letting me know. I updated the VsD spec to reflect the header name change and uploaded the latest version to the meta bug 1035544.
Attachment #8478362 - Flags: feedback?(amlee) → feedback+
(In reply to Amy Lee [:amylee] from comment #13)
> Updated visual spec in meta bug bug 1035544. Minor edit: Removed extra
> hairline at the bottom of screen 1. Usage Settings (Multi Sim)(pg 19). Thanks

Just noticing it seems there are new options to be implemented (limit seems to behave in a different way and the "Alert when use above" is totally new).
(In reply to Salvador de la Puente González [:salva] from comment #17)
> (In reply to Amy Lee [:amylee] from comment #13)
> > Updated visual spec in meta bug bug 1035544. Minor edit: Removed extra
> > hairline at the bottom of screen 1. Usage Settings (Multi Sim)(pg 19). Thanks
> 
> Just noticing it seems there are new options to be implemented (limit seems
> to behave in a different way and the "Alert when use above" is totally new).

Hi Salvador, 

These screens are based on Valentin's IxD spec https://people.mozilla.org/~vtsatskin/specs/SmartData/images/specs/settings.png
(In reply to Amy Lee [:amylee] from comment #18)
> (In reply to Salvador de la Puente González [:salva] from comment #17)
> > (In reply to Amy Lee [:amylee] from comment #13)
> > > Updated visual spec in meta bug bug 1035544. Minor edit: Removed extra
> > > hairline at the bottom of screen 1. Usage Settings (Multi Sim)(pg 19). Thanks
> > 
> > Just noticing it seems there are new options to be implemented (limit seems
> > to behave in a different way and the "Alert when use above" is totally new).
> 
> Hi Salvador, 
> 
> These screens are based on Valentin's IxD spec
> https://people.mozilla.org/~vtsatskin/specs/SmartData/images/specs/settings.
> png

Thank you! I'm going to review it.
Address previous review comments, remove WiFi from app list, clean up legend, and use "Mobile App Usage" wording.
Attachment #8476936 - Attachment is obsolete: true
Attachment #8479367 - Flags: review?(salva)
Attached image Chart and Legend (obsolete) —
Old chart with new leged and beginning of the app usage list
Attachment #8479369 - Flags: ui-review?(amlee)
Attached image App Usage List (obsolete) —
Attachment #8479373 - Flags: ui-review?(amlee)
Comment on attachment 8479367 [details] [review]
app usage list only - v2

I found this but only once:

[JavaScript Error: "TypeError: Common.allApps.map is not a function" {file: "app://costcontrol.gaiamobile.org/js/views/datausage.js" line: 191}]

You have a couple of comments on GitHub. r+ once addressed.
Attachment #8479367 - Flags: review?(salva) → review+
Comment on attachment 8479369 [details]
Chart and Legend

Hi, 

Since the new chart will be implemented in another bug and this is using the old chart. What am I reviewing? Is it just the new Mobile App Usage title?
Flags: needinfo?(marshall)
Attached image Usage_Apps_Edits.png (obsolete) —
Attached is my UI review feedback for the app usage list. Thanks!
Comment on attachment 8479373 [details]
App Usage List

Hi Marshall,  

Here's my feedback and I've also attached a screenshot for reference:

1. Center “Usage” header.

2. Usage App Icons - There should be a 14px margin on the left side. Please move icons 2px to the right and 2px down.  

3. Please move app labels (Usage, Browser2, Homescreen, etc.) 2px left so it aligns with bar and numbers.

4. Usage app bar - Should have 0.8 rem spacing from top and bottom labels (currently too much spacing).

---------------------

Also, when I flashed the patch it doesn't seem to actually show my data being used. When I go into the Usage app it gives me the message "you have not used any mobile data..." even though in the notifications tray it says I used 64MB and I have been streaming video in the browser to test it.
Attachment #8479373 - Flags: ui-review?(amlee) → ui-review-
(In reply to Amy Lee [:amylee] from comment #26)
> Comment on attachment 8479373 [details]
> App Usage List
> 
> Hi Marshall,  
> 
> Here's my feedback and I've also attached a screenshot for reference:
> 
> 1. Center “Usage” header.
> 
> 2. Usage App Icons - There should be a 14px margin on the left side. Please
> move icons 2px to the right and 2px down.  
> 
> 3. Please move app labels (Usage, Browser2, Homescreen, etc.) 2px left so it
> aligns with bar and numbers.
> 
> 4. Usage app bar - Should have 0.8 rem spacing from top and bottom labels
> (currently too much spacing).
> 
> ---------------------
> 
> Also, when I flashed the patch it doesn't seem to actually show my data
> being used. When I go into the Usage app it gives me the message "you have
> not used any mobile data..." even though in the notifications tray it says I
> used 64MB and I have been streaming video in the browser to test it.

Amy: I ran into a similar issue. The updated app changes permissions and it doesn't go into effect unless you do a `make reset-gaia`.
(In reply to Justin D'Arcangelo [:justindarc] from comment #27)
> (In reply to Amy Lee [:amylee] from comment #26)
> > Comment on attachment 8479373 [details]
> > App Usage List
> > 
> > Hi Marshall,  
> > 
> > Here's my feedback and I've also attached a screenshot for reference:
> > 
> > 1. Center “Usage” header.
> > 
> > 2. Usage App Icons - There should be a 14px margin on the left side. Please
> > move icons 2px to the right and 2px down.  
> > 
> > 3. Please move app labels (Usage, Browser2, Homescreen, etc.) 2px left so it
> > aligns with bar and numbers.
> > 
> > 4. Usage app bar - Should have 0.8 rem spacing from top and bottom labels
> > (currently too much spacing).
> > 
> > ---------------------
> > 
> > Also, when I flashed the patch it doesn't seem to actually show my data
> > being used. When I go into the Usage app it gives me the message "you have
> > not used any mobile data..." even though in the notifications tray it says I
> > used 64MB and I have been streaming video in the browser to test it.
> 
> Amy: I ran into a similar issue. The updated app changes permissions and it
> doesn't go into effect unless you do a `make reset-gaia`.

Hi Justin, 

Thanks for the tip. It works now!
Attached image Usage-Icons.png (obsolete) —
Hi Marshall, 

Now that I am able to see the Usage app list on the device. I noticed that the circle icons appear to be slightly cut off instead of having a smooth circle shape. I've attached a screenshot for reference. 

Also, is there a way to have the blue tooth icon styled the same way as the default rock icon (i.e having it encased in a white circle)?

Thanks
(In reply to Amy Lee [:amylee] from comment #29)
> Created attachment 8479954 [details]
> Usage-Icons.png
> 
> Hi Marshall, 
> 
> Now that I am able to see the Usage app list on the device. I noticed that
> the circle icons appear to be slightly cut off instead of having a smooth
> circle shape. I've attached a screenshot for reference. 

Thanks for noticing!

> 
> Also, is there a way to have the blue tooth icon styled the same way as the
> default rock icon (i.e having it encased in a white circle)?
> 

The icons are simply pulled from the application manifest, so I'm not sure if it would make sense to have a special case for Bluetooth (we could possibly change the icon inside the manifest, but I'm not sure what ramification that would have)
Flags: needinfo?(marshall)
Attached image App Usage List - v2 (screenshot) (obsolete) —
Screenshot showing the latest changes and addressing Amy's review.

The "Usage" title is correctly centered in my local test (I think I might have a new checkout). Let me know if I missed anything else :)
Attachment #8479373 - Attachment is obsolete: true
Attachment #8479940 - Attachment is obsolete: true
Attachment #8479954 - Attachment is obsolete: true
Attachment #8480069 - Flags: ui-review?(amlee)
(In reply to Amy Lee [:amylee] from comment #24)
> Since the new chart will be implemented in another bug and this is using the
> old chart. What am I reviewing? Is it just the new Mobile App Usage title?

Can you also sanity check the new legend layout? I know we didn't get a chance to do Visual Spec for this, but it now matches Val's mockup at least.
Comment on attachment 8480069 [details]
App Usage List - v2 (screenshot)

Hi Marshall, 

The spacing between the usage bar and the title and numbers is still too wide and the spacing between the sections need to be smaller. I've attached a screenshot for reference.

1. Spacing between app listing should be 1.7rems (see screen)
2. Spacing for data bar between top and bottom text should be 0.8rems (see screen)

Thanks!


Thanks!
Attachment #8480069 - Flags: ui-review?(amlee) → ui-review-
Attached image App_Usage_Edits_v2.png (obsolete) —
Screen for UI review reference
Comment on attachment 8479369 [details]
Chart and Legend

Hi Marshall, 

I've attached a screenshot with my edits. 

Thanks!
Attachment #8479369 - Flags: ui-review?(amlee) → ui-review-
Attached image Usage_Legend.png (obsolete) —
My edits for the legend
(In reply to Amy Lee [:amylee] from comment #36)
> Created attachment 8480125 [details]
> Usage_Legend.png
> 
> My edits for the legend

Amy, as the toggles probably disappear when landing bug 1056894, I would recommend to not block on this. Event, I think it should be fixed in other bug as it is a legacy problem not related with the current implementation.

WDYT?
(In reply to Amy Lee [:amylee] from comment #36)
> Created attachment 8480125 [details]
> Usage_Legend.png
> 
> My edits for the legend

Amy, as the toggles probably disappear when landing bug 1056894, I would recommend to not block on this. Event, I think it should be fixed in other bug as it is a legacy problem not related with the current implementation.

WDYT?
Flags: needinfo?(amlee)
(In reply to Salvador de la Puente González [:salva] from comment #38)
> (In reply to Amy Lee [:amylee] from comment #36)
> > Created attachment 8480125 [details]
> > Usage_Legend.png
> > 
> > My edits for the legend
> 
> Amy, as the toggles probably disappear when landing bug 1056894, I would
> recommend to not block on this. Event, I think it should be fixed in other
> bug as it is a legacy problem not related with the current implementation.
> 
> WDYT?

Hi Salvador, 

Yes I'm okay with having this as a separate bug fix.
Flags: needinfo?(amlee)
Attached image App Usage List - v3 (screenshot) (obsolete) —
Amy, This is my latest attempt to get the spacings perfect. I'm using a Flame for most of my testing, so there is a 1.5 pixel ratio that is causing some rounding issues whenever I try to align things exactly to a pixel boundary (even when using rem).
Attachment #8480069 - Attachment is obsolete: true
Attachment #8480121 - Attachment is obsolete: true
Attachment #8480125 - Attachment is obsolete: true
Attachment #8480695 - Flags: ui-review?(amlee)
Comment on attachment 8480695 [details]
App Usage List - v3 (screenshot)

Hi Marshall, 

I had reviewed the VsD within the design team and there was a recommendation that we add in hairlines to the rows to be consistent with the settings app. 

I know it's a challenge to get the alignments right so thank you for your patience. I tried to mock up as best I could the revisions and played around in App Manager to figure out the rems for some of the elements (see attached). If the measurements are entered in the wrong element feel free to make adjustments. 

I also noticed that on the device it looks like the data bars for each app is 1px higher in every other bar. (See attached).
Attachment #8480695 - Flags: ui-review?(amlee) → ui-review-
Attached image Usage_Edits_v3.png (obsolete) —
Usage App List Edits
Amy and I talked offline and we are going to land the current patch with modification for spacing, and add the hairline changes and other polish as a follow up bug.
Latest screenshot for UI review
Attachment #8479369 - Attachment is obsolete: true
Attachment #8480695 - Attachment is obsolete: true
Attachment #8480849 - Attachment is obsolete: true
Attachment #8481509 - Flags: ui-review?(amlee)
Comment on attachment 8481509 [details]
App Usage List - v4 (screenshot)

Giving this a +. As discussed with Marshall, a follow-up visual polish bug will be filed for adding in hairlines and adjusting spacing.
Attachment #8481509 - Flags: ui-review?(amlee) → ui-review+
Depends on: 1060550
Blocks: 1060550
No longer depends on: 1060550
https://github.com/mozilla-b2g/gaia/commit/728132e3e6e438526b038e5a12f9014846d1c15a
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage?]
Flags: needinfo?(ktucker)
QA Whiteboard: [QAnalyst-Triage?] → [QAnalyst-Triage+]
Flags: needinfo?(ktucker)
Depends on: 1063834
Unable to verify due to bug 1063834
Status: VERIFIED → RESOLVED
Closed: 10 years ago10 years ago
Flags: needinfo?(ktucker)
Flags: needinfo?(ktucker)
No longer depends on: 1063834
(In reply to Seth Miko [:SethM] from comment #47)
> Unable to verify due to bug 1063834

According to Marshall, that was cut from the 2.1 release. We should verify this feature taking into account that bug 1063834 was cut from the 2.1 release.
QA Whiteboard: [QAnalyst-Triage+] → [QAnalyst-Triage+][needs-verification]
Since we are no longer blocked from bug 1063834, verifying this bug as fixed. All data can be tracked on a per app basis in the usage app
Status: RESOLVED → VERIFIED
QA Whiteboard: [QAnalyst-Triage+][needs-verification] → [QAnalyst-Triage+]
Flags: in-moztrap? → in-moztrap?(slyu)
QA Contact: slyu
While I am designing test cases, I found that the "You have not used any data..." message will disappear after a few seconds, replaced by a list of apps with 0.00B usage. 

I believe that if there were no usage, the "You ahve not used any data..." message should stay there until any mobile data is used. Is this in the spec or should I file a bug (and add a test case)?  Thank you.

This is the build I used:
  Gaia      855be6ade407c26e0596e7306a44deebc3f60933
  Gecko     https://hg.mozilla.org/mozilla-central/rev/02c3915bf742
  BuildID   20140915160203
  Version   35.0a1
  ro.build.version.incremental=eng.cltbld.20140915.191939
  ro.build.date=Mon Sep 15 19:19:49 EDT 2014
Flags: needinfo?(marshall)
Attached file Testcases on MozTrap
I added some testcases. 

Other potential testcases:
  - Verify the correct message is present if no mobile data is used.
  - Check the usage on each SIM is tracked separatly.
Flags: in-moztrap?(slyu) → in-moztrap+
Shing - I reviewed the two test cases you created. One fix needed - can you add these test cases to the cost control test suite? That will ensure that they are included as part of a test run.
Flags: needinfo?(slyu)
(In reply to Shing Lyu [:slyu] from comment #50)
> While I am designing test cases, I found that the "You have not used any
> data..." message will disappear after a few seconds, replaced by a list of
> apps with 0.00B usage. 
> 
> I believe that if there were no usage, the "You ahve not used any data..."
> message should stay there until any mobile data is used. Is this in the spec
> or should I file a bug (and add a test case)?  Thank you.

Go ahead and create a bug, the "You have not used any data.." message should stick around if no data has been used.
Flags: needinfo?(marshall)
Depends on: 1068454
(In reply to Jason Smith [:jsmith] from comment #52)
> Shing - I reviewed the two test cases you created. One fix needed - can you
> add these test cases to the cost control test suite? That will ensure that
> they are included as part of a test run.

Hi Jason, 
I've added them to the cost control suite (https://moztrap.mozilla.org/manage/cases/?filter-suite=430). Thank you.
Flags: needinfo?(slyu)
Depends on: 1064491
Blocks: 1072750
Hi Marshall, 
I have a few questions regarding the current status of this feature:

1. Does the data usage counts only download or download+upload?
2. Is the Dual-SIM UI ready?
3. I believe that most of the web browsing usage goes to the "System" app, is it right?
4. Do we have any technical spec for this feature? 

Thank you.
Flags: needinfo?(marshall)
(In reply to Shing Lyu [:slyu] from comment #55)
> Hi Marshall, 
> I have a few questions regarding the current status of this feature:
> 
> 1. Does the data usage counts only download or download+upload?

It should count both. We are pulling from the NetworkStatsDB API..

> 2. Is the Dual-SIM UI ready?

No, there will need to be significant changes to both CostControl app to accomplish that. Right now the UI shows data usage for the currently active Data SIM.

> 3. I believe that most of the web browsing usage goes to the "System" app,
> is it right?

That might be true if you're searching from the system / notification bar, I'll need to test to verify. I know it goes to 'Browser' when browsing through that app.

> 4. Do we have any technical spec for this feature? 
Not at the moment..
Flags: needinfo?(marshall)
Thank you Marshall, now I can have better confidence designing test cases.
Sorry, one more question:

Regarding the "Internet data report > Reset report" setting, does it only reset the date range on the plot, or does it also reset the numbers? 

Thank you!
Flags: needinfo?(marshall)
Clearing old ni
Flags: needinfo?(marshall)
You need to log in before you can comment on or make changes to this bug.