1336315 - (SM248-RELNOTE) Create/Update 2.48 Release Notes

Status: RESOLVED FIXED

(SeaMonkey :: Website, defect)

Description

[Edmund Wong (:ewong)]

+++ This bug was initially created as a clone of Bug #1302639 +++

+++ This bug was initially created as a clone of Bug #1294432 +++

SeaMonkey 2.48b1 release builds will be built soon.

These relnotes can be (begun to be) prepared ahead of the release date, but need to be out by our first beta release.

Comment 1

[Frank-Rainer Grahl (:frg)]

Not much new in 2.48 I think:

Switch to cache2
TLS 1.3 support
More add-on breakages...
help viewer and old Error Console now part of SeaMonkey (which probably not many even need to notice)
about:support has a more friendly layout

Comment 2

[Frank-Rainer Grahl (:frg)]

Just a reminder to put these into the release notes:

Bug 1347857 - Browser: Basic Authentication will not open auth. dialog (eventually error message instead) under particular Email Window related conditions

Bug 1308923 - Opening new e-mail compose window crashes [@ InvalidArrayIndex_CRASH | nsTArray_Impl<T>::ElementAt | nsCommandManager::CommandStatusChanged ]

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-website-update-WIP.patch

Not done yet. Release notes are not complete. 

I removed the downloads for ca fi gl lt nb-NO tr uk. Langpacks are still there but they are all missing hundreds of strings. We should not advertize them any longer. 

Filed bug 1356294 for this.


As ewong thought update does not work (yet?). Tried 2.39b1 with Win 7 x86.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-SM248B1-RELNOTE.patch

Not sure who wants to review them. Can't set mcsmurf.

Comment 6

[Edmund Wong (:ewong)]

Comment on attachment 8858318 [details] [diff] [review]
1336315-SM248B1-RELNOTE.patch

Review of attachment 8858318 [details] [diff] [review]:
-----------------------------------------------------------------

::: src/releases/2.46.en.html
@@ +1,5 @@
>  [%- PROCESS release.tmpl -%]
>  [%- smversion = '2.46' -%]
>  [%- prettyversion = '2.46' -%]
>  [%- relnoteversion = '2.46' -%]
> +[%- mirrorred = false -%]

2.46 shouldn't be removed right now.  need to wait for
2.48 release before we do this.

::: src/releases/2.48b1.en.html
@@ +92,5 @@
> +      <td class="curVersion">[% smversion %]</td>
> +      <td><a href="[% INCLUDE download_build platform='win' locale='zh-TW' %]" class="download-win">Download</a></td>
> +      <td><a href="[% INCLUDE download_build platform='osx' locale='zh-TW' %]" class="download-mac">Download</a></td>
> +      <td><a href="[% INCLUDE download_build platform='linux' locale='zh-TW' %]" class="download-linux">Download</a></td>
> +    </tr>

Not sure what the practice is, but I would believe zh-CN and zh-TW should be at the end.  and I think we're missing ca

@@ +251,5 @@
> +  <p>
> +    <a href="[% INCLUDE download_file path="langpack/seamonkey-${smversion}.zh-CN.langpack.xpi" %]">Chinese (Simplified)</a>,
> +    <a href="[% INCLUDE download_file path="langpack/seamonkey-${smversion}.zh-TW.langpack.xpi" %]">Chinese (Traditional)</a>,
> +    <a href="[% INCLUDE download_file path="langpack/seamonkey-${smversion}.cs.langpack.xpi" %]">Czech</a>,
> +    <a href="[% INCLUDE download_file path="langpack/seamonkey-${smversion}.nl.langpack.xpi" %]">Dutch</a>,

ditto here. I think zh-CN and zh-TW at the end. and add ca back.

::: src/releases/index.en.html
@@ -134,5 @@
> -      <td class="curVersion">[% smversion %]</td>
> -      <td><a href="[% INCLUDE download_build platform='win' locale='ca' %]" class="download-win">Download</a></td>
> -      <td><a href="[% INCLUDE download_build platform='osx' locale='ca' %]" class="download-mac">Download</a></td>
> -      <td><a href="[% INCLUDE download_build platform='linux' locale='ca' %]" class="download-linux">Download</a></td>
> -    </tr>

please re-add ca

Comment 7

[Robert Kaiser]

zh should not be at the end, we are usually sorting by the visible English name of the language, not by locale code.

Comment 8

[Ian Neal]

Comment on attachment 8858318 [details] [diff] [review]
1336315-SM248B1-RELNOTE.patch

>+++ b/src/news.en.xml

> <newsfeed title="SeaMonkey News" url="http://seamonkey-project.org/news">
>+  <entry id="2017-04-15" showfront="true">
>+    <headline>SeaMonkey 2.48 Beta 1 released</headline>
>+    <content type="html" xml:lang="en">
>+<![CDATA[<p>

>+++ b/src/releases/2.48b1.en.html
>@@ -0,0 +1,300 @@
>+[%- PROCESS release.tmpl -%]
>+[%- smversion = '2.48b1' -%]
>+[%- prettyversion = '2.48 Beta 1' -%]
>+[%- relnoteversion = '2.48' -%]
>+[%- mirrorred = true -%]
>+[%- uselongversion = false -%]
>+[%- releasedate = "April 13, 2017" -%]

These dates need to be consistent.

r=me with those fixed.

Comment 9

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/0f46cec236958ee2b7f6210bfc4ee48209d3b326

Comment 10

[Frank-Rainer Grahl (:frg)]

Frank,

could you update the website. I opted for April 17 as the date and removed the changes in src/releases/2.46.en.html per ewongs comment.

Comment 11

[rsx11m]

Linux requirements have changed, specifically for libstdc++ version (4.6+ as GLIBCXX_3.4.15 is now required). I've filed bug 1358316 to update the System Requirements page for this.

"On Linux, libstdc++ version 4.6.1 or higher is now required."

SeaMonkey 2.46 still worked with that library version.

Comment 12

[Frank-Rainer Grahl (:frg)]

>>
Linux requirements have changed, specifically for libstdc++ version (4.6+ as GLIBCXX_3.4.15 is now required). I've filed bug 1358316 to update the System Requirements page for this.

"On Linux, libstdc++ version 4.6.1 or higher is now required."

SeaMonkey 2.46 still worked with that library version.
<<

Then we should check this. SeaMonkey 2.48 is supposed to be build with --enable-gtk2 which doesn't need glibc 3.4. This would be right for 2.49 where we agreed to do gtk3.

Comment 13

[rsx11m]

I'll check the official 2.48 beta on a more current Linux box today, it should be easy to tell if it was built with GTK2 or GTK3.

Comment 14

[Frank-Rainer Grahl (:frg)]

>> should be easy to tell if it was built with GTK2 or GTK3.

Was built with gtk2 according to about:buildconfig. You can also see it because it actually redraws correctly compared to 2.52a1. Maybe we should reconsider wrt gtk3 in 2.49 :)

Comment 15

[rsx11m]

Yes, definitely GTK2, thus the library dependency must come from somewhere else.

Comment 16

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-SM248-release-RELNOTE.patch

2.48 release notes and website update.

Comment 17

[Edmund Wong (:ewong)]

Comment on attachment 8884363 [details] [diff] [review]
1336315-SM248-release-RELNOTE.patch

Review of attachment 8884363 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm

::: src/releases/2.48.en.html
@@ +3,5 @@
> +[%- prettyversion = '2.48' -%]
> +[%- relnoteversion = '2.48' -%]
> +[%- mirrorred = true -%]
> +[%- uselongversion = false -%]
> +[%- releasedate = "July 15, 2017" -%]

fwiw...  this is of course a tentative date.  Not sure how long this whole release process is going to take.

::: src/releases/seamonkey2.48/index.en.html
@@ +249,5 @@
> +  <li>A minority of our testers reported a crash when sending or replying to emails starting with SeaMonkey 2.48.
> +    This is tracked in <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1308923">bug 1308923</a> and was
> +    fixed in <a href="https://bugzilla.mozilla.org/show_bug.cgi?id=1364977">bug 1364977</a> for SeaMonkey.
> +    The original bug is still open but additional cases are likely caused by add-ons.</li>
> +  <li>A crash after archiving messages has been fixed in 

extra trailing space nit

Comment 18

[rsx11m]

Comment on attachment 8884363 [details] [diff] [review]
1336315-SM248-release-RELNOTE.patch

>+++ b/lib/config.tmpl
>@@ -7,31 +7,31 @@
>-[% betabaseversion = '2.50' %]
>+[% betabaseversion = '2.48' %]

Just wondering what this is about? There was no 2.50 beta, or is it supposed to mention which version is currently on comm-beta?


>+++ b/src/news.en.xml
>@@ -2,16 +2,46 @@
>+For a more complete list of major changes in SeaMonkey 2.48, see the What's New
>+in SeaMonkey 2.48 section of the <a href="http://www.seamonkey-project.org/releases/seamonkey2.48/">Release

"see the What's New page in the SeaMonkey 2.48 section..."


>+++ b/src/releases/2.48.en.html
>@@ -0,0 +1,314 @@
>+[%- releasedate = "July 15, 2017" -%]

This is July 12 elsewhere but may change anyway, as ewong pointed out.

>+  <br><font size="+2" color="#ff0000"><b>Automatic upgrades from previous versions are
>+  disabled for this release. Please download the full installer from the downloads section and
>+  install SeaMonkey 2.48 manually over the previous version.</b></font><br>

"disabled" sounds a bit like it was done on purpose - how about "not functional" here and in the News item?


>-  <li>SeaMonkey 2.48 will be the last version with gtk2 support on Linux.</li>
>+  <li>SeaMonkey 2.48 is the last version with gtk2 support on Linux.</li>
>   <li>SeaMonkey 2.49 will be the last version supporting Windows XP/Server 2003 and Vista/Server 2008.</li>
>   <li>SeaMonkey 2.51 will be the last version with ALSA support on Linux.</li>

When we go to ESR releases, there will be no 2.51 release (and we don't even have a beta planned from there).
So, technically the 2.49.x releases will be the last versions with ALSA support?


>+++ b/src/releases/seamonkey2.48/index.en.html
>@@ -15,16 +15,36 @@
>+disabled for this release. Please download the full installer from the downloads section and

See above.

>+<div class="key-point">
>+<p>The Mozilla backend code SeaMonkey is based on, now usually incorporates breaking changes in every release.

That's a fairly strong statement, which - though true - may discourage wary people from upgrading.

"The Mozilla backend code which SeaMonkey is based on contains substantial changes from releases to release."
>+This is especially true for changes in the Mozilla Gecko add-ons code and the JavaScript interpreter.
"changes in" probably can go here as you are talking about "changes" in the sentence before already.
>+The changes here and in other areas also mean that some older extensions might no longer function properly.
Shorter: "Consequently, some older extensions <em>may</em> no longer function properly."

Still sounds cautious enough to me, but I'll let IanN decide.

> SeaMonkey 2.48 uses the same backend as Firefox and contains the listed
>-<a href="https://www.mozilla.org/en-US/security/known-vulnerabilities/firefox/#firefox51">Firefox 51 security fixes"</a>.
>+<a href="https://www.mozilla.org/en-US/security/known-vulnerabilities/firefox/#firefox51.0.3">Firefox 51.0.3 security fixes"</a>.

Off-topic: We should update the SeaMonkey section of that page at some point, it's way behind... :-(
I've done it once, it's a bit tedious but mostly mechanical, and based on Github.

>   <li>The Errror Console is now a part of SeaMonkey. It was replaced by the Developer Tools Web
>     and Browser Console in Firefox which both are also available in SeaMonkey.

Typo in "Error"

This is confusing; from the end-users point of view, the Error Console has always been part of SeaMonkey. We just keep both around now and the code was moved to comm-* (same with the Help Viewer). Those details may be something for a "Developer Notes" section if you want to highlight it.

Comment 19

[Ian Neal]

Comment on attachment 8884363 [details] [diff] [review]
1336315-SM248-release-RELNOTE.patch

>+++ b/lib/config.tmpl

>-[% betabaseversion = '2.50' %]
>+[% betabaseversion = '2.48' %]
Shouldn't this be 2.52 now?

>-[% develbaseversion = '2.52' %]
>+[% develbaseversion = '2.53' %]

>new file mode 100644
>--- /dev/null
>+++ b/src/releases/2.48.en.html
Shouldn't this be copied from 2.46 rather than a new file?

>+[%- releasedate = "July 15, 2017" -%]
As noted, should match throughout.

>+  <br><font size="+2" color="#ff0000"><b>Automatic upgrades from previous versions are
>+  disabled for this release. Please download the full installer from the downloads section and
As mentioned by others, disabled is the wrong word, broken or not functional.

>+  install SeaMonkey 2.48 manually over the previous version.</b></font><br>

>+++ b/src/releases/seamonkey2.48/index.en.html

>+<font size="+2" color="#ff0000"><b>Automatic upgrades from previous versions are
>+disabled for this release. Please download the full installer from the downloads section and
broken/not functional

>+install SeaMonkey 2.48 manually over the previous version.</b></font>
>+
>+</p>
>+</div>
>+
>+<div class="key-point">
>+<p>The Mozilla backend code SeaMonkey is based on, now usually incorporates breaking changes in every release.

Something about code depreciation instead? See comments by others.

>+This is especially true for changes in the Mozilla Gecko add-ons code and the JavaScript interpreter.
>+The changes here and in other areas also mean that some older extensions might no longer function properly.
>+If you experience any problems please refer to the troubleshooting section first. Especially try to disable extensions
>+first and check if this makes a difference.

r=me with those addressed.

Comment 20

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-SM248-release-RELNOTE-V2.patch

New patch: r+ from IanN and f+ from rsx11m and ewong carried forward.

Used 2017-07-15 for all the dates for now. We might even make it if the final upload works. Candidates seem to be mostly complete :)

Beta should be current beta so 2.48 and not 2.50 or 2.52. Unfortunately I no longer have or can find the link which gave me a 404.

> "see the What's New page in the SeaMonkey 2.48 section..."

What's New in SeaMonkey 2.48 is correct. Didn't change it. It is the name of the section not a page. Was the same for previous versions. Maybe we should convert it to a link or use a different font/style?

> "disabled" sounds a bit like it was done on purpose

Replaced with not working. Should we add a note about Linux distributions? Doesn't affect them.

> now usually incorporates breaking changes in every release.

Rephrased the paragraph but let this one stay in for now. Deprecated is right but an end user might not know what it really means. The result is still a breaking change and I have seen many of them in 2.48 to 2.52. Classic add-ons are now treated if there is no tomorrow and if the past is irrelevant. No one seems to care about older add-ons any longer.
I am happy to change it again for the acutal release. But would be great if someone else does the final version of this paragraph then and let me know. I would probably come up with breaking change every time :)

Move some parts into a small developer notes sections.

> Shouldn't this be copied from 2.46 rather than a new file?

Does it matter? It is not a 1:1 copy.

Comment 21

[rsx11m]

(In reply to Frank-Rainer Grahl (:frg) from comment #20)
> > "see the What's New page in the SeaMonkey 2.48 section..."
> 
> What's New in SeaMonkey 2.48 is correct. Didn't change it. It is the name of
> the section not a page. Was the same for previous versions. Maybe we should
> convert it to a link or use a different font/style?

Oh, now I get it - yes, I'd make it "see the <a href=http://www.seamonkey-project.org/releases/seamonkey2.48/#new>What's New in SeaMonkey 2.48</a> section of the Release Note" (i.e., move the link from the general Release Notes page to that section), or put the title into &quot; to make it unambiguous. It's hard to distinguish now what's text and what's section heading.

> > Shouldn't this be copied from 2.46 rather than a new file?
> 
> Does it matter? It is not a 1:1 copy.

If you make an "hg cp ..." and then apply your text, it will be obvious from the history which parts have changed vs. 2.46 and which ones are new (also maybe saves a few bytes in the .hg directory).

Comment 22

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-SM248-release-RELNOTE-V3.patch

I do your bidding :)

But needs a new review because I forgot to include the mapi bug 1356902.

Comment 23

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-SM248-release-RELNOTE-interdiff.patch

Just what I added for bug 1356902

Comment 24

[Ian Neal]

Comment on attachment 8885748 [details] [diff] [review]
1336315-SM248-release-RELNOTE-V3.patch

LGTM r=me

Comment 25

[Frank-Rainer Grahl (:frg)]

Found a small NIT. Link is missing the >. Not sure if tomorrow will be the day but I will have it ready for push including the changed date in the three patch locations.
 
> <a href="https://go.microsoft.com/fwlink/?LinkId=746571"VS2017 x86 runtime>.

Comment 26

[rsx11m]

Nit #2: It's also missing the closing </a> and just has a '>' at the end of the link.

Comment 27

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/1cc4bdcbcf2c3da7908aca39653435f1b63a6203

Comment 28

[Frank-Rainer Grahl (:frg)]

One link was broken:

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/3e64c18ad8282db7d0b00460e68ff0b655e5da6e

Comment 29

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-release-notes-addendum.patch

Some things came up after the release which warrants an addendum. Let me know if you prefer a separate bug.

Comment 30

[Ian Neal]

Comment on attachment 8896579 [details] [diff] [review]
1336315-release-notes-addendum.patch

>+++ b/src/news.en.xml
>@@ -2,16 +2,34 @@
> 
> <!--
> non-ASCII characters must be DOUBLE-escaped;
> you can use Hixie's converter to get the entity codes
> http://www.damowmow.com/portal/ (use the "Indentify" field)
> -->
> 
> <newsfeed title="SeaMonkey News" url="http://seamonkey-project.org/news">
>+  <entry id="2017-08-12" showfront="true">
>+    <headline>Download problems with NoScript active</headline>
>+    <content type="html" xml:lang="en">
>+<![CDATA[<p>
>+If you are using NoScript you might encounter a certificate error when trying
>+to download SeaMonkey from this site. NoScript tries to force an https
>+connection for a http only site. It is not a NoScript problem but how the
Nit: should be "an http only site."
>+Mozilla server, from which downloads are delivered, is configured.
>+</p>

>+++ b/src/releases/2.48.en.html
>@@ -43,21 +43,28 @@
> </ul>
> 
> <div class="key-point">
> <ul>
>   <li><a href="seamonkey[% relnoteversion %]/">Release Notes</a> - The release notes describe
>   new changes, system requirements, installation instructions, and known issues
>   in this release - please read them carefully before using this version of
>   SeaMonkey!
>-  <br><font size="+2" color="#ff0000"><b>Automatic upgrades from previous versions are
>+  </li>
>+  <li>If you are using NoScript you might encounter a certificate error when trying
>+  to download SeaMonkey from this site. NoScript tries to force an https
>+  connection for a http only site. It is not a NoScript problem but how the
Nit: should be "an http only site."
>+  Mozilla server, from which downloads are delivered, is configured.<br>

>+++ b/src/releases/index.en.html
>@@ -86,16 +86,24 @@
> 
> <div class="key-point">
> <ul>
>   <li><a href="seamonkey[% relnoteversion %]/">Release Notes</a> - The release notes describe
>   new changes, system requirements, installation instructions, and known issues
>   in this release - please read them carefully before using this version of
>   SeaMonkey!
>   </li>
>+  <li>If you are using NoScript you might encounter a certificate error when trying
>+  to download SeaMonkey from this site. NoScript tries to force an https
>+  connection for a http only site. It is not a NoScript problem but how the
Nit: should be "an http only site."
>+  Mozilla server, from which downloads are delivered, is configured.<br>

>+++ b/src/releases/seamonkey2.48/index.en.html
>@@ -159,16 +159,22 @@ e.g. happens when you install the Add-on
>   a replacement.</p>
> </div>
> 
> <h2 id="issues">Known Issues</h2>
> <div class="section">
> This list covers some of the known problems with [% rnote.name %].
> Please read this before reporting any new bugs.
> <ul>
>+  <li>There is a known problem with SeaMonkey 2.48 crashing for some users on OS X 10.12 or greater.
>+    If you experience a crash when starting SeaMonkey or trying to use mail or news please go back to 2.46
>+    for now. For fixing the crash we would need to port some changes back from a later release still in
Nit: "To fix" rather than "For fixing"; then towards then end "from a later release, which is still in"
>+    internal testing. This might break other things so instead we are trying to get the next 2.49.1 release
Nit: should be "This might break other things so, instead, we are trying to get the next release (2.49.1)"
>+    out of the door as fast as we can.

r=me with those addressed.

Comment 31

[Frank-Rainer Grahl (:frg)]

 https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/cf15edd8523039dd949fd7e8fdd77f03544af9f2

Comment 32

[Frank-Rainer Grahl (:frg)]

Forgot to change the date and found a missing period in one sentence.

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/561de25e9ea22868e3693649073eb757b50c8de8

Comment 33

[Frank-Rainer Grahl (:frg)]

Attachment: 1336315-release-notes-revised.patch

Minor revision as per irc discussion. r+ from IanN over irc.

Comment 34

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/SeaMonkey/seamonkey-project-org/rev/542f544b720ce501bee0146c5681e2781ed828b7