1346488 - (photon-ui-refresh) [meta] Photon UI Refresh

Status: NEW

(Firefox :: General, enhancement)

Comment 1

[Po-chiang Chao [:bobchao]]

Is there any planning wiki stuff to help people know what this is?

Comment 2

[:Gijs (he/him)]

(In reply to Po-chiang Chao [:bobchao] from comment #1)
> Is there any planning wiki stuff to help people know what this is?

Dolske, is there a good place to point people to right now?

Marco: why are you adding Dão's bugs directly to this bug's dep fields when they're already in the dep tree via the photon-visuals bug? This bug is going to get very cluttered very quickly if every single photon bug is going to be blocking it, and I don't really understand why that would be necessary.

Comment 3

[Marco Mucci [:MarcoM]]

(In reply to :Gijs from comment #2)
> (In reply to Po-chiang Chao [:bobchao] from comment #1)
> > Is there any planning wiki stuff to help people know what this is?
> 
> Dolske, is there a good place to point people to right now?
> 
> Marco: why are you adding Dão's bugs directly to this bug's dep fields when
> they're already in the dep tree via the photon-visuals bug? This bug is
> going to get very cluttered very quickly if every single photon bug is going
> to be blocking it, and I don't really understand why that would be necessary.

No problem, the dependencies can just block their respective sub-projects. I'll revert the changes.  Was doing that to run searches off the main meta - easy to work around that.

Comment 4

[maxm]

Hi. I have question. Is any chance for making Main menu button movable or positionable to left side? I am left-handed and until now i was using Classic Theme Restorer to move it to left, but what i see on new screenshots of Photon UI, it will be stick to right side of  window with no posibility to move it. I think lots of left-handed persons would appreciate possibility like this. Regards.

Comment 5

[:Gijs (he/him)]

(In reply to maxm from comment #4)
> What i see on new screenshots
> of Photon UI, it will be stick to right side of  window with no posibility
> to move it.

This is also the current state. While I understand your reasoning, it's not obvious how this would be configured by users (making the button wholly movable is a no-go, and adding extra clutter in the form of checkboxes for a very-small-minority usecase seems equally problematic), and it would create extra challenges for testing the resulting panel, styling, fitts' law, etc. We're not interested in adding more hidden prefs with no UI that could potentially break the browser UI. I expect it's probably possible to get the customization you want with userChrome.css, on a "use at your own risk" basis (like any userChrome change). We don't ship features that way, though. As a result, we don't intend to change anything here as part of Photon.

Comment 6

[maxm]

Ok. but can you tell me (In reply to :Gijs from comment #5)
> (In reply to maxm from comment #4)
> > What i see on new screenshots
> > of Photon UI, it will be stick to right side of  window with no posibility
> > to move it.
> 
> This is also the current state. While I understand your reasoning, it's not
> obvious how this would be configured by users (making the button wholly
> movable is a no-go, and adding extra clutter in the form of checkboxes for a
> very-small-minority usecase seems equally problematic), and it would create
> extra challenges for testing the resulting panel, styling, fitts' law, etc.
> We're not interested in adding more hidden prefs with no UI that could
> potentially break the browser UI. I expect it's probably possible to get the
> customization you want with userChrome.css, on a "use at your own risk"
> basis (like any userChrome change). We don't ship features that way, though.
> As a result, we don't intend to change anything here as part of Photon.

So as I understand, there will be still such possibility but only by the addon or light theme css edition? 
By the way, there is a lot left-hand people, so we can't speak about very-small-minority.

Comment 7

[:Gijs (he/him)]

(In reply to maxm from comment #6)
This bug is really not a good place to have a detailed discussion about this issue given the subject of this bug (not specific to the issue of moving the hamburger panel button) and the number of people CC'd. If you still have questions, please use a more appropriate list/forum.

> (In reply to :Gijs from comment #5)
> > I expect it's probably possible to get the
> > customization you want with userChrome.css, on a "use at your own risk"
> > basis (like any userChrome change).
> So as I understand, there will be still such possibility but only by the
> addon or light theme css edition?

As long as we keep userChrome.css that will let you do it. I don't know about themes/add-ons.

Comment 8

[Sebastian Zartner [:sebo]]

(In reply to maxm from comment #6)
> Ok. but can you tell me (In reply to :Gijs from comment #5)
> > (In reply to maxm from comment #4)
> > > What i see on new screenshots
> > > of Photon UI, it will be stick to right side of  window with no posibility
> > > to move it.
> > 
> > This is also the current state. While I understand your reasoning, it's not
> > obvious how this would be configured by users (making the button wholly
> > movable is a no-go, and adding extra clutter in the form of checkboxes for a
> > very-small-minority usecase seems equally problematic), and it would create
> > extra challenges for testing the resulting panel, styling, fitts' law, etc.
> > We're not interested in adding more hidden prefs with no UI that could
> > potentially break the browser UI. I expect it's probably possible to get the
> > customization you want with userChrome.css, on a "use at your own risk"
> > basis (like any userChrome change). We don't ship features that way, though.
> > As a result, we don't intend to change anything here as part of Photon.
> 
> So as I understand, there will be still such possibility but only by the
> addon or light theme css edition? 
> By the way, there is a lot left-hand people, so we can't speak about
> very-small-minority.

Note that this feature isn't restricted to left-handed people. As most of the main actions like accessing the Awesomebar, going back and forth in page history and reloading happen on the left side, the way of the mouse cursor is probably most of the time shorter when the button is placed at the left side.
From a user point of view, I think it would be enough to allow to move the button like any other button, providing the biggest flexibility. Downside is, that if users place it somewhere else and they read some tutorial that says that the button is placed on the right upper side of the browser window, they may get confused.
From the programmer's view, I assume this would also make the code and tests a bit simpler, as you wouldn't have to handle the button special anymore in most cases. Challenges here are to handle the different styling and placement of the menu and to adjust/add/remove related unit tests.

Sebastian

Comment 9

[Justin Dolske [:Dolske]]

As Gijs noted, this is as project tracking meta-bug, and not the place for feature discussion. Restricting comments.

Comment 10

[Chris Lord [:cwiiis]]

Comment #9 didn't actually answer why the needinfo was added - is there a publicly accessible place where one can see designs/plans?

Comment 11

[Jared Wein [:jaws] (please needinfo? me)]

(In reply to Chris Lord [:cwiiis] from comment #10)
> Comment #9 didn't actually answer why the needinfo was added - is there a
> publicly accessible place where one can see designs/plans?

For designs,
https://mail.mozilla.org/pipermail/photon-dev/2017-April/000038.html points to https://mozilla.invisionapp.com/share/ENBBK0F9U

I don't know of a specific place to find plans. Each project is broken up in to meta bugs that are listed as blocking this bug. You may have to look at the full dependency tree and see what is assigned to know what bugs are in-progress.

Comment 12

[Tobias B. Besemer [:BesTo] (QA)]

What's about fixing bug 697359 with this UI refresh?