Status

enhancement
RESOLVED FIXED
2 years ago
5 months ago

People

(Reporter: shobson, Unassigned)

Tracking

({in-triage})

Details

Place to track all the beta bugs.
Depends on: 1375879
Depends on: 1375871
Depends on: 1375831
Depends on: 1375765
Depends on: 1375815
Depends on: 1375730
Depends on: 1375706
Depends on: 1375682
Depends on: 1375620
Depends on: 1375416
Depends on: 1375263
Depends on: 1374825
Depends on: 1375917
Depends on: 1375928
Depends on: 1375926
Depends on: 1375947
Depends on: 1375962
Depends on: 1376356
Summary: Beta meta bug tracker → Redesign beta [meta] [tracker]
Depends on: 1376358
Depends on: 1376770
Depends on: 1376980
See Also: → 1376817
Depends on: 1376817
Depends on: 1376699
Depends on: 1376270
Depends on: 1376072
Depends on: 1378199
Depends on: 1378202
Depends on: 1378453
Depends on: 1378428
Depends on: 1378337
Depends on: 1379104
Depends on: 1379259
No longer depends on: 1374825
Depends on: 1379737
Depends on: 1379418
Depends on: 1380657
Depends on: 1379903
Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/2fcf608a72b72929a26fd502d7036fac0ae018d4
Bug 1375892: Locale font fallbacks

The way the locale font fallbacks work is:
- The font stack includes made up keywords (`x-locale-body`,
  `x-locale-heading-primary`, `x-locale-heading-secondary`)
- When the browser doesn't recognize the keywords it falls back
  to the next font in the stack
- We can load CSS files specific to each locale. In those files we can
  include an `@font-face` declaration which defines the keywords. This
  causes the defined font to be loaded and displayed.
- Best practice for Asian character sets (ie Chinese) is to load a
  preferred display font and then specify a better fallback for the
  Chinese. This is because Chinese fonts have English characters but
  they look terrible.

Changes in this PR:
- Removed the @font-face declaration for Zilla from the main.css file.
- Added made up keyword x-locale-heading-primary to the front of the
  heading font stack.
- Added made up keywords `x-locale-heading-secondary`, and
  `x-locale-body` to the font stack as fallback fonts
- Added locale specific files for each locale which Zilla supports.
  These files each include the Zilla @font-face declaration which
  enables Zilla to load into its place in the font stack.
- Because font paths are relative the SCSS variables are complicated.
  To handle loading Zilla from the locale files I had to move the
  Zilla files into the locale folder and the _zilla.scss file in with
  the other locale style sheets.
- Copied locale specific fixes for Open Sans from bedrock to kuma
  using the x-locale-body keyword to load in better fallbacks.
    - Did not copy font-variant fixes since we don't use font variants.
- Declared new heading defaults for locales with Arabic alphabet by
  defining a font-face for x-locale-heading-primary in those locale
  specific files.

https://github.com/mozilla/kuma/commit/e8d406ef9f14e76682223fcfdcb0d2ac61e50245
Merge pull request #4317 from mozilla/1370594-locale-fonts

Bug 1375892: Locale font fallbacks
Depends on: 1382295
Depends on: 1383965
Depends on: 1384653
Summary: Redesign beta [meta] [tracker] → Redesign bugs [meta] [tracker]
Depends on: 1384425
Depends on: 1384384
Depends on: 1384287
Depends on: 1387252
Depends on: 1388090
Depends on: 1389117
Depends on: 1389278
No longer depends on: 1389117
Depends on: 1387166
No longer depends on: 1388090
Depends on: 1392452
Depends on: 1392451

Redesigned finished! :)

Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.