Closed Bug 1432725 Opened 4 years ago Closed 2 years ago

Make library window support dark mode

Categories

(Firefox :: Theme, defect, P5)

58 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 78
Tracking Status
firefox63 --- wontfix
firefox64 --- wontfix
firefox65 --- wontfix
firefox78 --- verified

People

(Reporter: combettaworld, Assigned: jf.dev)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Make library(Ctrl+Shift+B) window black when using preinstalled Dark Theme
Priority: -- → P5
Now that dark theme is much better supported throughout the application, it's weird that Library window is still light. Pretty inconsistent with the overall look and feel of FF.
Duplicate of this bug: 1512189
Status: UNCONFIRMED → NEW
Ever confirmed: true
Duplicate of this bug: 1522252
Duplicate of this bug: 1523971
Duplicate of this bug: 1615390
Assignee: nobody → jf.dev
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/40e834cc233c
Make library window black when using preinstalled Dark Theme. r=dao
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 78

This commit title says "... when using preinstalled Dark Theme", but the code uses prefers-color-scheme: dark. So unless Bug 1529323 is fixed, this will respect the OS dark theme or ui.systemUsesDarkTheme. (I understand preinstalled dark theme to mean to dark theme in Firefox)

Depends on: 1529323
Regressions: 1640403
Summary: Make library window black when using preinstalled Dark Theme → Make library window support dark mode
Blocks: 1641252

I'm sure you've noticed that the scrollbars and title bar aren't dark in Library window on Windows though. Are these already filed? I don't want to file duplicates

K just came across this on reddit, is this the one for the title bar? https://bugzilla.mozilla.org/show_bug.cgi?id=1607929

Still can't find anything for the scrollbars not respecting dark mode in Library window though

I just filed the scrollbar bug, apoligies if it's a duplicate https://bugzilla.mozilla.org/show_bug.cgi?id=1643453

Flags: qe-verify+
See Also: → 1607929
Depends on: 1643453

Is this something specific to Windows? I am not getting a dark themed Library in both Ubuntu 18.04 or macOS 10.15 using latest Nightly 79.0a1 with the dark theme activated.

Flags: needinfo?(jf.dev)

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #14)

Is this something specific to Windows? I am not getting a dark themed Library in both Ubuntu 18.04 or macOS 10.15 using latest Nightly 79.0a1 with the dark theme activated.

We support this on Windows and Linux right now. This is about system-level dark mode, not the dark Firefox theme.

Flags: needinfo?(jf.dev)

(In reply to Dão Gottwald [::dao] from comment #15)

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #14)

Is this something specific to Windows? I am not getting a dark themed Library in both Ubuntu 18.04 or macOS 10.15 using latest Nightly 79.0a1 with the dark theme activated.

We support this on Windows and Linux right now. This is about system-level dark mode, not the dark Firefox theme.

Thanks for the info. I verified that library does change to dark mode based on the dark mode enabled in the system for both Windows 10 64bit and Ubuntu 18.04 64bit using latest Firefox beta 78.0b9.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
Blocks: 1499293
Blocks: 1650417
See Also: → 1674566

Hi all,

I know this issue is a bit old, but I was wondering if there was any hope for the FireFox Library Window (for Bookmarks, History, etc) to be dark mode enabled. I'm running on macOS Big Sur (11.2.2) and using FireFox 86.0.

Thank you!

See Also: 1674566
You need to log in before you can comment on or make changes to this bug.