1432725 - Make library window support dark mode

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P5)

Description

[In]

Make library(Ctrl+Shift+B) window black when using preinstalled Dark Theme

Comment 1

[Yuriy Zakalyuzhnyy]

Attachment: Library window above the main app window

Comment 2

[Yuriy Zakalyuzhnyy]

Now that dark theme is much better supported throughout the application, it's weird that Library window is still light. Pretty inconsistent with the overall look and feel of FF.

Comment 7

[Jerome Fray]

Attachment: Bug 1432725 - Make library window black when using preinstalled Dark Theme. r?dao

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40e834cc233c
Make library window black when using preinstalled Dark Theme. r=dao

Comment 9

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/40e834cc233c

Comment 10

[Tom S [:evilpie]]

This commit title says "... when using preinstalled Dark Theme", but the code uses prefers-color-scheme: dark. So unless Bug 1529323 is fixed, this will respect the OS dark theme or ui.systemUsesDarkTheme. (I understand preinstalled dark theme to mean to dark theme in Firefox)

Comment 11

[Will]

I'm sure you've noticed that the scrollbars and title bar aren't dark in Library window on Windows though. Are these already filed? I don't want to file duplicates

Comment 12

[Will]

K just came across this on reddit, is this the one for the title bar? https://bugzilla.mozilla.org/show_bug.cgi?id=1607929

Still can't find anything for the scrollbars not respecting dark mode in Library window though

Comment 13

[Will]

I just filed the scrollbar bug, apoligies if it's a duplicate https://bugzilla.mozilla.org/show_bug.cgi?id=1643453

Comment 14

[Bogdan Maris, Desktop Test Engineering]

Is this something specific to Windows? I am not getting a dark themed Library in both Ubuntu 18.04 or macOS 10.15 using latest Nightly 79.0a1 with the dark theme activated.

Comment 15

[Dão Gottwald [:dao]]

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #14)

Is this something specific to Windows? I am not getting a dark themed Library in both Ubuntu 18.04 or macOS 10.15 using latest Nightly 79.0a1 with the dark theme activated.

We support this on Windows and Linux right now. This is about system-level dark mode, not the dark Firefox theme.

Comment 16

[Bogdan Maris, Desktop Test Engineering]

(In reply to Dão Gottwald [::dao] from comment #15)

(In reply to Bogdan Maris [:bogdan_maris], Release Desktop QA from comment #14)

Is this something specific to Windows? I am not getting a dark themed Library in both Ubuntu 18.04 or macOS 10.15 using latest Nightly 79.0a1 with the dark theme activated.

We support this on Windows and Linux right now. This is about system-level dark mode, not the dark Firefox theme.

Thanks for the info. I verified that library does change to dark mode based on the dark mode enabled in the system for both Windows 10 64bit and Ubuntu 18.04 64bit using latest Firefox beta 78.0b9.

Comment 17

[spetinga]

Hi all,

I know this issue is a bit old, but I was wondering if there was any hope for the FireFox Library Window (for Bookmarks, History, etc) to be dark mode enabled. I'm running on macOS Big Sur (11.2.2) and using FireFox 86.0.

Thank you!