1538043 - Remove $PATH-altering hacks from python configure

Status: RESOLVED FIXED

(Firefox Build System :: General, enhancement)

Description

[Mike Hommey [:glandium]]

Bug 1515579 removed some necessity for them, but kept a hack mentioning bug 1516228 and bug 1516253, but the former was fixed since then, and the latter is presumably fixed by bug 1524396.

However, we need to ensure that the change from bug 1537669 keeps working (cf. https://phabricator.services.mozilla.com/D24326#716073) and other things that might indirectly rely on $PATH containing the toolchain search path.

Comment 1

[Mike Hommey [:glandium]]

Bug 1537643 is another blocker.

Comment 2

[Mike Hommey [:glandium]]

And even though we do pass the full path for cl.exe to midl.exe, it still needs PATH alteration for mspdbcore.dll, so that makes bug 1537641 another blocker.

Comment 3

[Mike Hommey [:glandium]]

With the patches from bug 1537643 and bug 1537644, I was able to get successful win32 and win64 builds with the $PATH-altering hacks removed... but not for win64-aarch64, because armasm64.exe has a dependency on the x64 msvcdis140.dll.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Bug 1538043 - Remove Visual C++ toolchain search path from $PATH.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f70225b67b76
Remove Visual C++ toolchain search path from $PATH. r=firefox-build-system-reviewers,andi

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f70225b67b76

Comment 8

[Cosmin Sabou [:CosminS]]

Backed out for causing Bug 1829262.

Backout link: https://hg.mozilla.org/mozilla-central/rev/df954b717c6c614796661f019df2048f69d2faaa

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d92f2fcd1bac
Remove Visual C++ toolchain search path from $PATH. r=firefox-build-system-reviewers,andi

Comment 10

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/d92f2fcd1bac