1585958 - Megabar should not overlap adjacent toolbar items

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: bug - Address Bar active + MegaBar enabled.png

STR:

1. Start Mozilla Firefox with:

• disabled "Flexible Space" from both sides of Address Bar
• enabled "Compact" Density
• enabled "Bookmarks Toolbar"
  and see that most bookmarks in "Bookmarks Toolbar" and buttons in Address Bar are obscured and obstructed by MegaBar by default without address bar interaction, same thing happens on opening new windows and new tabs.

Each time I have to move focus away from Address Bar to use bookmarks in "Bookmarks Toolbar" and buttons in Address Bar when I'm starting Mozilla Firefox, opening new window and new tab.

It doesn't happen in competitive browsers.

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - Address Bar not active + MegaBar enabled.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: no bug - Address Bar active + MegaBar disabled.png

Comment 3

[Marco Bonardo [:mak]]

(In reply to Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.) from comment #0)

and see that most bookmarks in "Bookmarks Toolbar" and buttons in Address Bar are obscured and obstructed by MegaBar by default without address bar interaction, same thing happens on opening new windows and new tabs.

This is bug 1561904

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Will 10px top margin help also with visibility of buttons in Address Bar?

Comment 5

[Marco Bonardo [:mak]]

your should probably either morph this bug to only cover toolbar buttons covered by the side expansion, or file a specific bug for that, 2 bugs in one report is not trackable.

Comment 6

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

So I'm reopening this per Comment #5.

Comment 7

[Darkspirit]

Please don't change the framing of this topic. There is unexpected space to the left of the TP icon and to the right of the bookmarks icon. It should not cover tabs. The address bar should have the same size when focused. I haven't seen an input field behaving so unusual like this anywhere else. Megabar was copied from Chrome, but with this regression added.
(I assume you just want users to search using your ref links, but you don't offer some built-in warmness like a Doodle or a background image in exchange. Somewhat related to search experience: Months ago my Firefox regressed to contaminate browsing history plus suggestions with "google.com" instead of "google.de" entries. Since elementary school in 2002 my muscle memory is trained to open google.de.)

Comment 9

[Tooru Fujisawa [:arai]]

(In reply to Dão Gottwald [::dao] from bug 1561904 comment #1)

I propose we just don't expand the urlbar at all when the bookmarks toolbar is present.

This should be applied also here.
urlbar shouldn't be expanded when there's no flexible space placed on both side of it.

Comment 10

[Tooru Fujisawa [:arai]]

(In reply to Tooru Fujisawa [:arai] from comment #9)

urlbar shouldn't be expanded when there's no flexible space placed on both side of it.

also, urlbar shouldn't be expanded even when there's flexible spaces if it has not enough width, due to having many toolbar icons

Comment 11

[Danny Colin [:sdk]]

(In reply to Tooru Fujisawa [:arai] from comment #10)

(In reply to Tooru Fujisawa [:arai] from comment #9)

urlbar shouldn't be expanded when there's no flexible space placed on both side of it.
also, urlbar shouldn't be expanded even when there's flexible spaces if it has not enough width, due to having many toolbar icons

On a compact theme with no flexible space items it shouldn't expand on top, left and right side because
when the urlbar is focused it prevents the user to click on some elements in the UI. The user need
to first click somewhere where nothing is triggered by a click and after that they have access to the
hidden elements.

Comment 12

[Botond Ballo [:botond]]

Does this being a P5 mean this will not be fixed before shipping the megabar?

If so, some rationale for that would be appreciated. I think this is a significant usability issue.

Comment 13

[Marco Bonardo [:mak]]

Nope, we listen to feedback, we are working on solutions. It will require some changes and polish.
This is pretty much a meta bug at this point.

Comment 15

[Alice0775 White]

Attachment: Screencast durling drag & drop

drag a selected URL in Address Bar and move mouse over Bookmarks ToolBar,
The MegaBar covers Drop Indicator, so it is hard to see the Drop Indicator.

Comment 16

[Eddie Carswell]

I will admit that I initially came here with the righteous fury of a user that had their nice, familiar UI changed out from under them (https://xkcd.com/1172), but after reading through this and other related bugs (and also discovering browser.urlbar.megabar=False) I can look at this a bit more objectively now.

I would suggest that a separate preference to disable the expansion regardless of other UI state (bookmarks bar, flexible space, compact mode) would be very useful. Even in the "vanilla" layout a new profile gives, I don't think I'd want the urlbar expanding on me, as I detest unnecessary padding and whitespace that seems to be creeping into the UI of applications everywhere these days.

Other than that, I actually like that the new megabar results don't fill the whole window width unnecessarily, though until the expansion part is addressed, it will have to stay disabled on my profiles, unfortunately.

Comment 17

[Marco Bonardo [:mak]]

(In reply to Alice0775 White from comment #15)

drag a selected URL in Address Bar and move mouse over Bookmarks ToolBar,
The MegaBar covers Drop Indicator, so it is hard to see the Drop Indicator.

File a separate bug please.

Comment 18

[Alice0775 White]

(In reply to Marco Bonardo [::mak] from comment #17)

(In reply to Alice0775 White from comment #15)

drag a selected URL in Address Bar and move mouse over Bookmarks ToolBar,
The MegaBar covers Drop Indicator, so it is hard to see the Drop Indicator.

File a separate bug please.

Filed Bug 1586388 and Bug 1586392

Comment 23

[Dão Gottwald [:dao]]

Tabs were handled in bug 1561904.

Comment 24

[Dão Gottwald [:dao]]

Attachment: Bug 1585958 - Stop overlapping adjacent toolbar items with the megabar. r=harry

Comment 25

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/61f7d1cc144c
Stop overlapping adjacent toolbar items with the megabar. r=harry

Comment 26

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/61f7d1cc144c

Comment 27

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I can confirm this behavior is respected in the latest nightly (2020-02-07), I verified on macOS 10.15, Ubuntu 18.04 and Windows 10.
Updating the flags.

Comment 28

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

As OP, I'm also confirming that bug is fixed, starting in Mozilla Firefox Nightly 71.0a1 (2019-10-19).
Thank you very much! \o/