1616692 - (clang-10) [meta] Upgrade to clang 10.0.0

Status: RESOLVED WONTFIX

(Firefox Build System :: Toolchains, task, P3)

Description

[(Away)]

This is a meta bug tracking work related to using clang 10.0.0 in automation.

I am not proposing that we actually make the switch yet; this bug is just for tracking related work.

Comment 1

[(Away)]

Upstream bugs:
https://bugs.llvm.org/show_bug.cgi?id=44784 (fixed)
https://bugs.llvm.org/show_bug.cgi?id=44682 (fixed)
https://bugs.llvm.org/show_bug.cgi?id=44813

Comment 2

[Tom Ritter [:tjr]]

Hey glandium; if we bump to clang 10 we can start testing Control Flow Guard on Windows which would be some free mitigations. Is that okay with you?

Comment 3

[Mike Hommey [:glandium]]

Why would it not? If upgrading doesn't break anything...

Comment 4

[Sylvestre Ledru [:Sylvestre]]

it is the soft freeze, so, we should probably wait until it is over :)
(until may 4th)

Comment 5

[(Away)]

I can take this. Between testing and review time I expect this will go past soft freeze anyway.

Comment 6

[(Away)]

Attachment: Update to clang 10.0.0

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7340fb8c2297
Update to clang 10.0.0 r=froydnj

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/58cbc2929fb3
followup, fix sccache task bustage. CLOSED TREE

Comment 9

[Razvan Maries]

Backed out for reftests perma failures.

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=superseded%2Cusercancel%2Cretry%2Cpending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&searchStr=linux%2C18.04%2Cx64%2Casan%2Copt%2Creftests%2Ctest-linux1804-64-asan%2Fopt-jsreftest-e10s-1%2Cr%28j1%29&revision=7340fb8c2297c0ec7d79f8e74a49d45d56277e96

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=301960871&repo=autoland&lineNumber=12084

Backout: https://hg.mozilla.org/integration/autoland/rev/85e60f72d566366467c54c02f2c889de7c1220d1
https://hg.mozilla.org/integration/autoland/rev/82f9e4bad64592efb70ded65f86e566d3ca2c664

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80ba3f3cfaf9
Update to clang 10.0.0 r=froydnj

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/80ba3f3cfaf9

Comment 12

[Bogdan Tara[:bogdan_tara | bogdant]]

These changes seem to have turned bug 1414495 into a tier 2 perma fail on central:
https://treeherder.mozilla.org/#/jobs?repo=mozilla-central&selectedTaskRun=SseXXjjnQbSpOzd4Akv11g-0&fromchange=8af03d77567d3104c00efc5e6161e4910d835504&searchStr=windows%2C10%2Caarch64%2Copt%2Cmochitests%2Cwith%2Csocket%2Cprocess%2Ctest-windows10-aarch64%2Fopt-mochitest-media-spi-e10s%2Cm-spi%28mda%29

https://treeherder.mozilla.org/#/jobs?repo=autoland&searchStr=windows%2C10%2Caarch64%2Copt%2Cmochitests%2Cwith%2Csocket%2Cprocess%2Ctest-windows10-aarch64%2Fopt-mochitest-media-spi-e10s%2Cm-spi%28mda%29&tochange=80ba3f3cfaf9b31341bca28e2e6aea383cec8acc&fromchange=fb25c48f12af61b415c87b224e7408ce8579ce8f&selectedTaskRun=bTGy3uQcT1mm8aO6J34gMQ-0

Aryx, should we backout this?

Comment 13

[Sylvestre Ledru [:Sylvestre]]

As they are tier-2, I don't think we should.
David should be also involved in the potential backout (or not)

Comment 14

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Let's keep it in tree. Bug 1638409 tracks the regression.

Comment 15

[Eric Rahm [:erahm]]

David, can we back out for now. The regressions are piling up and it looks like Windows-on-ARM is completely broken. We don't have time or bandwidth to reasonably triage and fix all the issues before the next release, particularly given our reliance on upstream LLVM addressing all the issues.

Comment 16

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a79875b2cf6
Backed out changeset 80ba3f3cfaf9 at dev's request. CLOSED TREE

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c17af0632260
Update to clang 10.0.0 r=froydnj

Comment 18

[Dorel Luca [:dluca]]

Had to reland this one because it was causing perma leaks failures on WPT:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303020348&repo=autoland&lineNumber=7376

TH:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1a79875b2cf67e3539939f7002b3e5ba5ceccd79&selectedTaskRun=RhubQ4IbQ4mNixEzfRbsAw-0

dmajor: Please take a look at this ^

Comment 19

[Eric Rahm [:erahm]]

(In reply to Dorel Luca [:dluca] from comment #18)

Had to reland this one because it was causing perma leaks failures on WPT:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303020348&repo=autoland&lineNumber=7376

TH:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=1a79875b2cf67e3539939f7002b3e5ba5ceccd79&selectedTaskRun=RhubQ4IbQ4mNixEzfRbsAw-0

dmajor: Please take a look at this ^

Please back this out again, it fixes several issues that are more important than a leak on Linux (it is almost certainly not the cause of the leak). Aarch64-windows is completely broken right now.

Comment 20

[Razvan Maries]

Backout: https://hg.mozilla.org/integration/autoland/rev/005ef1c2599217538ed001683d210bd4f2776311

Comment 21

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #16)

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a79875b2cf6
Backed out changeset 80ba3f3cfaf9 at dev's request. CLOSED TREE

== Change summary for alert #25997 (as of Wed, 20 May 2020 00:21:28 GMT) ==

Regressions:

2% compiler_metrics num_static_constructors windows2012-64-shippable opt instrumented 128.00 -> 131.00
0.45% installer size osx-shippable opt instrumented 117,582,479.50 -> 118,112,308.25
0.26% installer size osx-shippable opt nightly 84,432,802.17 -> 84,655,979.50

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=25997

Comment 22

[Alexandru Ionescu (needinfo me) [:alexandrui]]

(In reply to Pulsebot from comment #17)

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c17af0632260
Update to clang 10.0.0 r=froydnj

== Change summary for alert #26000 (as of Wed, 20 May 2020 02:48:23 GMT) ==

Improvements:

1% compiler_metrics num_static_constructors windows2012-64-shippable opt instrumented 129.88 -> 128.00

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26000

Comment 23

[Atila Butkovits]

Backout merged: https://hg.mozilla.org/mozilla-central/rev/1a79875b2cf6

Comment 24

[Mike Hommey [:glandium]]

I have a bisect in progress on try to figure out where the leak comes from. But right now tests are not starting, so this will take more time.

Comment 25

[Alexandru Ionescu (needinfo me) [:alexandrui]]

Do you know about bisection guide?

Comment 26

[(Away)]

jgraham: We upgraded CI to clang 10 last week, but had to backout and restore clang 9 yesterday, and that uncovered a LeakSan failure in WPT.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=303020348&repo=autoland&lineNumber=7376

Could it be related to bug 1636118, which landed during the period of clang 10? I'm thinking the most likely explanation is that the inlining changed between clang 9 and 10, in such a way that something on the lsan-allowed list no longer matches.

Comment 27

[(Away)]

On second thought, now that the LSan failure has its own bug, let's move that discussion to bug 1639519.

Comment 28

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26016 (as of Wed, 20 May 2020 16:36:21 GMT) ==

Improvements:

8% about_newtab_with_snippets linux64-shippable opt e10s stylo 86.06 -> 79.01
8% perf_reftest_singletons id-getter-2.html windows10-64-shippable opt e10s stylo 750.89 -> 693.22
5% tsvgx windows7-32-shippable opt e10s stylo 130.05 -> 124.00
4% tsvgr_opacity linux64-shippable-qr opt e10s stylo 109.96 -> 105.35
3% tsvgr_opacity linux64-shippable opt e10s stylo 153.70 -> 148.56
3% tp5o_scroll linux64-shippable opt e10s stylo 1.28 -> 1.24

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26016

Comment 29

[Alexandru Ionescu (needinfo me) [:alexandrui]]

== Change summary for alert #26003 (as of Wed, 20 May 2020 04:36:26 GMT) ==

Improvements:

10% build times windows2012-aarch64 opt aarch64-no-eme nightly taskcluster-c5d.4xlarge 2,427.68 -> 2,187.97
9% build times linux64-shippable opt nightly taskcluster-c5.4xlarge 3,201.86 -> 2,910.93
9% build times windows2012-64-shippable opt nightly taskcluster-m5.4xlarge 2,609.49 -> 2,373.64
9% build times windows2012-32-shippable opt nightly taskcluster-c5d.4xlarge 2,472.63 -> 2,262.24
7% build times linux64-shippable opt nightly taskcluster-m5.4xlarge 3,194.27 -> 2,980.91
7% build times osx-shippable opt nightly taskcluster-c5d.4xlarge 3,133.88 -> 2,927.06
6% build times linux64-shippable opt nightly taskcluster-c5d.4xlarge 2,990.06 -> 2,804.88

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26003

Comment 30

[Florin Strugariu [:Bebe]]

== Change summary for alert #26020 (as of Wed, 20 May 2020 19:48:03 GMT) ==

Improvements:

33% raptor-tp6-outlook-firefox-cold replayed windows7-32-shippable opt 1,393.12 -> 1,852.92
4% raptor-tp6-facebook-firefox-cold not-replayed windows7-32-shippable opt 346.67 -> 331.17
3% raptor-tp6-wikipedia-firefox-cold loadtime windows7-32-shippable opt 1,511.79 -> 1,466.25
3% raptor-tp6-netflix-firefox-cold fcp linux64-shippable-qr opt 624.38 -> 606.92
3% raptor-tp6-wikipedia-firefox-cold fcp windows7-32-shippable opt 1,350.33 -> 1,314.33
3% raptor-tp6-outlook-firefox-cold loadtime linux64-shippable opt 843.04 -> 821.67
2% raptor-tp6-sheets-firefox-cold loadtime linux64-shippable-qr opt 1,650.50 -> 1,617.42

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=26020

Comment 31

[Julian Descottes [:jdescottes]]

While the patch was on autoland, it seems it also regressed most devtools performance tests: https://treeherder.mozilla.org/perf.html#/alerts?id=25964

Comment 32

[Intermittent Failures Robot]

1 failures in 4949 pushes (0.0 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 1

Platform breakdown:

• linux1804-64-asan: 1

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1616692&startday=2020-06-01&endday=2020-06-07&tree=all

Comment 33

[Arthur K. (he/him)]

It would seem that some of these issues are fixed in the upcoming CLANG 10.0.1 release. Is the intent to hold off until FF80?

Comment 34

[Arthur K. (he/him)]

10.0.1 has gone final: http://lists.llvm.org/pipermail/llvm-dev/2020-July/143572.html

Probably need to update this bug.

Comment 35

[mac198442]

the latest vs2019 16.7.0 requires clang 10.0.0 as a minimum requirement.

Comment 36

[mac198442]

see bug 1658122

Comment 37

[(Away)]

Because of the problems with this release, we plan to skip clang-10 and wait for clang-11 (bug 1660340).

Comment 38

[(Away)]

Chose the wrong 'W' option.