1691301 - Filter Log and Adaptive Junk Mail Log dialog size incorrectly persisted, log itself appears only after manual resizing.

Status: RESOLVED FIXED

(Thunderbird :: Filters, defect)

Description

[Dan Pernokis]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:85.0) Gecko/20100101 Firefox/85.0

Steps to reproduce:

View a few of the Filter Log files (under Message Filters), and view the Junk spam log (under Options). Resize the window to accommodate long lines and minimize lines per entry (ie - so you can see more at once AND visually align similar messages).

(I think this is a regression. I first noticed & documented it in October 2020 -- surprised, actually -- because I'm pretty sure the size used to persist.)

Actual results:

Each and every time I set the window size to something appropriate for me (very wide), the size reverts to the default small size when I choose the next log.

Expected results:

The resized window should maintain its settings for as long as I'm in the MESSAGE FILTERS area or in OPTIONS. My preference is for the window settings to persist long-term between sessions, but I can live with persisting within a given session.

Comment 1

[Wayne Mery (:wsmwk)]

I can confirm this is a regression - version 60 dialog size persists a least within the current session, both for filter long, and junk log (located in security options)

Comment 2

[Wayne Mery (:wsmwk)]

Does this still reproduce?

Comment 4

[Dan Pernokis]

(Sorry, my reply in my Comment 3 was for a different bug... I erased the comment but can't delete the slot.)

The log windows worked fine up until TB version 91.13.1 (32-bit) which I still run on my old Windows 7 desktop. I didn't realize the bug report was still open, as the log windows worked well again since shortly after I reported this bug.

I never checked it when I had version 102, but in 115.9.0 (64-bit), the window is wonky, as now reported in Bug 1715604. The dialogue box opens with no window visible (let's call it zero width, zero height). When I first saw it, I thought the window didn't work at all. Not true -- the content is there if you pull the sides or corner in the usual way.

However, when you close the session and re-open, the width is preserved but there is zero height -- and it has to be pulled down again for each session (and for each log being viewed in the case of messages).

Comment 6

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1691301 - Fix size of filter log and junk log dialogs. r=paenglab

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2eb5c928804c
Fix size of filter log and junk log dialogs. r=Paenglab

Comment 9

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9417976 [details]
Bug 1691301 - Fix size of filter log and junk log dialogs. r=paenglab

[Approval Request Comment]
User impact if declined: Filter Log and Adaptive Junk Mail Log dialog size incorrectly persisted, log itself appears only after manual resizing, so it may appear to be empty when it actually isn't.
Testing completed (on c-c, etc.): c-c and beta
Risk to taking this patch (and alternatives if risky): very low

Comment 10

[Corey Bryant]

Comment on attachment 9417976 [details]
Bug 1691301 - Fix size of filter log and junk log dialogs. r=paenglab

[Triage Comment]
Approved for esr128

Comment 11

[Daniel Darnell [:dandarnell]]

Thunderbird 128.2.1esr:
https://hg.mozilla.org/releases/comm-esr128/rev/05153f89bee7