Closed Bug 1693066 Opened 3 years ago Closed 3 years ago

Update tab audio indicator to latest Proton spec

Categories

(Firefox :: Theme, enhancement, P1)

Product:
Firefox
Component:
Theme
Version:
Firefox 87
Type:
enhancement
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox87 --- wontfix
firefox88 --- fixed

People

(Reporter: ke5trel, Assigned: ntim)

References

(Depends on 2 open bugs, Blocks 2 open bugs, Regressed 3 open bugs)

Details

(Keywords: helpwanted, Whiteboard: [proton-tabs-bar])

Attachments

(3 files)

Quantum vs Proton tab sound indicator when muted and unmuted
2.49 KB, image/png
Details
Bug 1693066 - Implement new proton tab audio indicator design.
48 bytes, text/x-phabricator-request
Details | Review
Bug 1693066 - Followup: use consistent end proton comment style. DONTBUILD
48 bytes, text/x-phabricator-request
Details | Review

When Proton-style tabs are minimum width, the active tab's sound indicator is faded and cropped making the difference between muted and unmuted barely distinguishable. Inactive tabs don't have this issue.

NIing Aaron here to help provide more details. Acknowledged this is an issue that needs fixing.

Flags: needinfo?(abenson)
Flags: needinfo?(abenson) → needinfo?(kcaldwell)

Provided a prototype to engineering (via Jared) in Figma. Clearing the NI for UX.

Flags: needinfo?(kcaldwell)
Severity: -- → S3
Priority: -- → P3
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [proton-tabs-bar]
Points: --- → 5
Assignee: jaws → ntim.bugs
Summary: Sound indicator for minimum-width active tab is much less visible with Proton → Update sound indicator to latest Proton spec
Summary: Update sound indicator to latest Proton spec → Update tab audio indicator to latest Proton spec
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9afd696ad2b4
Implement new proton tab audio indicator design. r=jaws,fluent-reviewers,flod
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/869c158fc1aa
Followup: use consistent end proton comment style. DONTBUILD

https://hg.mozilla.org/mozilla-central/rev/9afd696ad2b4
https://hg.mozilla.org/mozilla-central/rev/869c158fc1aa

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Type: defect → task
Type: task → enhancement
Depends on: 1698341
Depends on: 1698342
Regressions: 1699677
Regressions: 1701443
Regressions: 1701522
Depends on: 1701918
Regressions: 1702645
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: