Closed
Bug 1693066
Opened 4 years ago
Closed 4 years ago
Update tab audio indicator to latest Proton spec
Categories
(Firefox :: Theme, enhancement, P1)
Tracking
()
RESOLVED
FIXED
88 Branch
People
(Reporter: ke5trel, Assigned: ntim)
References
(Depends on 2 open bugs, Blocks 2 open bugs, Regressed 2 open bugs)
Details
(Keywords: helpwanted, Whiteboard: [proton-tabs-bar])
Attachments
(3 files)
When Proton-style tabs are minimum width, the active tab's sound indicator is faded and cropped making the difference between muted and unmuted barely distinguishable. Inactive tabs don't have this issue.
Comment 1•4 years ago
|
||
NIing Aaron here to help provide more details. Acknowledged this is an issue that needs fixing.
Flags: needinfo?(abenson)
Comment 2•4 years ago
|
||
Provided a prototype to engineering (via Jared) in Figma. Clearing the NI for UX.
Flags: needinfo?(kcaldwell)
Updated•4 years ago
|
Severity: -- → S3
Priority: -- → P3
Updated•4 years ago
|
Keywords: helpwanted
Updated•4 years ago
|
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Priority: P3 → P1
Updated•4 years ago
|
Whiteboard: [proton-tabs-bar]
Updated•4 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-447
Updated•4 years ago
|
Points: --- → 5
Updated•4 years ago
|
Assignee: jaws → ntim.bugs
Assignee | ||
Comment 4•4 years ago
|
||
Assignee | ||
Updated•4 years ago
|
Summary: Sound indicator for minimum-width active tab is much less visible with Proton → Update sound indicator to latest Proton spec
Assignee | ||
Updated•4 years ago
|
Summary: Update sound indicator to latest Proton spec → Update tab audio indicator to latest Proton spec
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/9afd696ad2b4
Implement new proton tab audio indicator design. r=jaws,fluent-reviewers,flod
Assignee | ||
Comment 6•4 years ago
|
||
Pushed by ntim.bugs@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/869c158fc1aa
Followup: use consistent end proton comment style. DONTBUILD
Comment 8•4 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/9afd696ad2b4
https://hg.mozilla.org/mozilla-central/rev/869c158fc1aa
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
Assignee | ||
Updated•4 years ago
|
Type: defect → task
Assignee | ||
Updated•4 years ago
|
Type: task → enhancement
Updated•4 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•