1792809 - Content area of Library doesn't fill the window

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[tgn-ff]

Attachment: Library_Bug.png

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:107.0) Gecko/20100101 Firefox/107.0

Steps to reproduce:

1. Open the Library.
2. Maximise the window.

Actual results:

The content area of the Library stays at the default size. See screenshot.

Expected results:

This is a regression from Bug 1665476.

https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=bb9421c2629c9d33c85ba257ad70507ef82aab89&tochange=37180b0bf14ad69cb4e0d952f2c88b26a5e99175

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:emilio, since you are the author of the regressor, bug 1665476, could you take a look? Also, could you set the severity field?

For more information, please visit auto_nag documentation.

Comment 3

[Alice0775 White]

I can also reproduce this on Windows10.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1792809 - Make library and other windows keep stretching after bug 1665476. r=Gijs

Much like the dialog changes in bug 1792730.

Comment 5

[Emilio Cobos Álvarez (:emilio)]

FYI, you probably need similar changes to thunderbird.

Comment 7

[alexf_ba124]

Attachment: Troubleshooting information

I am experiencing this issue -

Comment 8

[alexf_ba124]

I hope the troubleshooting info (provided above) is useful in narrowing this down to a specfic revision or patch.

Comment 13

[Geoff Lankow (:darktrojan)]

Thanks Emilio, looks like Richard is on the case. I'll CC him here anyway.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d08050f3ec2
Make library and other windows keep stretching after bug 1665476. r=eemeli

Comment 15

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0d08050f3ec2

Comment 17

[Dana Lucaci, Desktop QA]

Reproduced the issue with Firefox 107.0a1 (2022-09-29) using the steps from the description, on macOS 12. After maximise the "Library" window, content area stays unchanged, at its initial size.
The issue is verified fixed with Firefox 108.0a1 (20221020215126) on Windows 10x64, macOS 12, and Ubuntu 20.04. The window is correctly maximised along with the content area.

Comment 18

[jscher2000]

Changing width and height to min-width and min-height (in places.ftl) is causing complaints on SUMO among users who like to have a small Library window admidst various larger windows (for example, showing just the latest download):

• https://support.mozilla.org/questions/1396924
• https://support.mozilla.org/questions/1397089

We can mention userChrome.css as a workaround, but this is difficult for many users to implement. Were these changes essential or could those minimums be reduced (while also setting the initial width and height to the classic values)?