204248 - No maximize/minimize buttons in new Mailnews window, and raise & lower broken

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect)

Description

[Matthias Versen [:Matti]]

win2k build 20030502..

a) open Mailnews
b) select "open in new Mail Window" in the folder context menu (right click a
folder) or click on a "Click here to remove all expired articles" link in an
expired Newsgroup Post
c) see the new opened mailnews window without minimize/maximize button but you
can still resize the window

Comment 1

[Calum Mackay]

Confirmed: Linux/x86 20030503.

The problem is actually much worse than it appears at first glance. In this
second mozilla messenger window (using the branding names :), keyboard shortcuts
for minimise/maximise don't work either.

Worse, the window cannot be raised or lowered. Keyboard shortcuts for this are
ignored, and window manager "raise-on-focus" doesn't happen. This makes the app
suite practically unusable for anyone running 2 mozilla messenger windows, if
they're big enough overlap.

This all on metacity 2.4.34.

The regression ocurred between 2003043011 & 2003050105 (checkout hour times in GMT).

Comment 2

[Calum Mackay]

Note I'm using GTK2. I wonder if this is related to the fix for:

174471 [gtk2] need to port over the nsITheme interface code to gtk2

which seems to have landed at about the right time.

Comment 3

[Mitch]

I *can't* confirm this. Todays cvs (20030503) build is working fine for me
with gtk2 toolkit. However i am running windowmaker windowmanager.  Calum's
problem is probably metacity windowmanager as stacking is a function of the
windowmanager.

Comment 4

[Christopher Blizzard (:blizzard)]

Interesting.  I'll bet mail/news is opening the new window as a dialog.  I can
reproduce this here.  The stacking order is the big clue.

Comment 5

[Christopher Blizzard (:blizzard)]

It's more likely that bug 157438 caused this.  Is this happening on windows, by
any chance?

Comment 6

[Matthias Versen [:Matti]]

this happens on win2k (see my initial comment) and biesi saw it in an non gtk2
Linux build.

Comment 7

[Asa Dotzler [:asa]]

So this is or isn't a problem in the mozilla.org default builds (not GTK2)?

Comment 8

[Calum Mackay]

I've not tried a mozilla.org default build, but it is a problem in non-GTK2
builds. We build here from cvs, and I'm seeing the problem with a non-GTK2 build
of 20030506. I will try a mozilla.org build.

Comment 9

[Calum Mackay]

Yup, the problem is present in mozilla.org builds too. I've just downloaded the
nightly sparc 2.7 build:

http://ftp.mozilla.org/pub/mozilla/nightly/latest/mozilla-sparc-sun-solaris2.7.tar.gz

which is 2003050601, and the problem is still present.

Comment 10

[Ere Maijala (slow)]

My bad. Fix coming up soon.

Comment 11

[Ere Maijala (slow)]

Attachment: Patch to fix the params to OpenWindow()

I broke this when fixing bug 137661. We need to explicitly say this isn't a
dialog when there are arguments.

Comment 12

[Ere Maijala (slow)]

Comment on attachment 122691 [details] [diff] [review]
Patch to fix the params to OpenWindow()

Jag, r/sr for this follow-up for bug 137661?

Comment 13

[jag (Peter Annema)]

Comment on attachment 122691 [details] [diff] [review]
Patch to fix the params to OpenWindow()

r+sr=jag

Comment 14

[Matthias Versen [:Matti]]

*** Bug 204764 has been marked as a duplicate of this bug. ***

Comment 15

[Asa Dotzler [:asa]]

Comment on attachment 122691 [details] [diff] [review]
Patch to fix the params to OpenWindow()

a=asa (on behalf of drivers) for checkin to 1.4.

Comment 16

[Ere Maijala (slow)]

Fix checked in to trunk.

Comment 17

[Calum Mackay]

*** Bug 204995 has been marked as a duplicate of this bug. ***

Comment 18

[Matthias Versen [:Matti]]

*** Bug 205349 has been marked as a duplicate of this bug. ***

Comment 19

[Matthias Versen [:Matti]]

*** Bug 205414 has been marked as a duplicate of this bug. ***

Comment 20

[Matthias Versen [:Matti]]

*** Bug 205398 has been marked as a duplicate of this bug. ***

Comment 21

[Matthias Versen [:Matti]]

*** Bug 205500 has been marked as a duplicate of this bug. ***

Comment 22

[Matthias Versen [:Matti]]

*** Bug 205693 has been marked as a duplicate of this bug. ***

Comment 23

[Matthias Versen [:Matti]]

*** Bug 205722 has been marked as a duplicate of this bug. ***

Comment 24

[Karsten Düsterloh]

*** Bug 206423 has been marked as a duplicate of this bug. ***