236465 - Give the View Selection Source window a proper name

Status: RESOLVED FIXED

(Toolkit :: View Source, defect)

Description

[Christian Pernot]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.6) Gecko/20040207 Firefox/0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.6) Gecko/20040207 Firefox/0.8

special characters display in "view selection source" as in the browser (ex:
é displays as é in this mode). In "view source" there is no problem.
You can test this on www.granini.fr try with the word "Découvrez"

Reproducible: Always
Steps to Reproduce:

Comment 1

[Ali Ebrahim]

Moving over to Browser, I see this in Mozilla/5.0 (Windows; U; Windows NT 5.1;
en-US; rv:) Gecko/20040302.

Comment 2

[brewthatistrue]

*** This bug has been marked as a duplicate of 164906 ***

Comment 3

[rbs]

I just noted that, in their former ways, the Firefox UI folks removed "DOM
Source" from the title -- which was engineered bug 190947. It ought to be
re-instated. It is something that we thought hard on, and sweated on, before
coming up with a solution that has helped.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Reopening.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Over to firefox to fix their ui breakage.

Comment 6

[rbs]

Attachment: Put "DOM Source" in the title

See details in bug 190947.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 142967 [details] [diff] [review]
Put "DOM Source" in the title

Um... this needs review from one of the firefox peers (and doesn't need sr). It
looks like this just got forked before we made it better in SeaMonkey....  (not
sure _why_ it got forked, but....)

Comment 8

[José Jeria]

I think that "DOM Source" is not a good naming for the average user. I doubt
they even know what DOM is.

Comment 9

[Hungerburg]

I was asked to comment... there must be somebody with a similar email address, I
am not a firefox developer.

anyways my two cents: DOM source is a good name, as it behaves much like the DOM
inspector, eg. when debugging javascript generated content, or results of an xsl
transform.

Comment 10

[Ali Ebrahim]

In response to comment 8, by the same token, most users don't know/care what the
page source even is. If someone is saavy enough to want to view selection
source, it's likely that they'll know what DOM is.

Comment 11

[rbs]

And it isn't constructive either just to say "DOM Source" isn't good without
suggesting anything, as this invalidates the earlier discussion (e.g., bug
164906 comment 3, bug 190947).

Comment 12

[José Jeria]

(In reply to comment #11)
> And it isn't constructive either just to say "DOM Source" isn't good without
> suggesting anything

:-p

How about "View generated source"? At least that is comprehensive for average
users... (or maybe not, but more than dom source)

Comment 13

[rbs]

Was already discusseed.

Comment #10 is a good summary of why "DOM Source" is a winner so far. And since
living in Seamonkey, it hasn't got a negative feeback either.

Comment 14

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 142967 [details] [diff] [review]
Put "DOM Source" in the title

As a rule, when you have a menu item invoke a window or dialog, the dialog
should be called the same thing as the menu item (or something very close to
it).

Why not call the window "Selection Source" instead of "DOM Source"?

Comment 15

[rbs]

Dilemma: it doesn't quite say that it is from the DOM -- this is the dilemma
that we have had. People didn't relate it to the live DOM. We got so many dups
in Seamonkey (see bug 164906), newsgroups comments, blogs, etc, until compelled
to do something about it in bug 190947.

Note: we also use it for MathML. When somebody context-clicks on a MathML
expression, it shows the equivalent MathML markup. (In this case there is no
selection). Some old screenshots when the title was simply empty:
view-mathml-src: http://www.mozilla.org/projects/mathml/screenshots/viewsource.png
view-sel-src: http://bugzilla.mozilla.org/attachment.cgi?id=79770&action=view

Comment 16

[Ben Goodger (use ben at mozilla dot org for email)]

Comment on attachment 142967 [details] [diff] [review]
Put "DOM Source" in the title

Change the text to "Selection Source" and r=me.

Comment 17

[Ben Goodger (use ben at mozilla dot org for email)]

Oops, I assumed you were talking to someone called "Dilemma" (who knows, this is
Mozilla after all!) and didn't read your last comment. 

formulating a better response, one moment. 

Comment 18

[Ben Goodger (use ben at mozilla dot org for email)]

General UI principle - menu items invoking other windows/dialogs should have a
title that more or less matches the window they're invoking. 

This would imply that if the window is called "DOM Source" the context menu item
should read "View DOM Source". I don't like having the menus in a consumer
browser filled with techno acronyms like "DOM" etc that a large body of people
are unfamiliar with. If this is meant to imply a subtlety of the view source
window, why not express that subtlety explicitly there, e.g. put a panel at the
bottom of that window that says "this is generated from a live view of the
source DOM" (similar to the panel that appears at the top of .xml files rendered
in the browser content area) or something like that - I have less of a problem
explaining succinctly something in a window targeted at developers than I do
having the idiosyncracies of that window creeping into one targeted at consumers. 

While we're here, why is there a separate XUL file for viewing selection source?

Comment 19

[rbs]

Attachment: alternative patch

This is an alternative patch to produce the title as "DOM Source of Selection",
"DOM Source of MathML". The "DOM" term is important to differentiate from the
normal source, but could be droped if there is a sort of disclaimer message,
but as this is not really critical, I am not a big fan of that option and don't
have cylces for that. It was suggested in bug 190947 as well.

>While we're here, why is there a separate XUL file for viewing selection
source?

In my original code in SeaMonkey, it is a simple overlay (primarily aimed at
factoring some subtle differences in the JavaScript handlers and the default
menu items). However, in Firebird/Firefox, the .xul was split drastically. I am
not clear why it was split that way.

seamonkey:
http://lxr.mozilla.org/mozilla/source/xpfe/browser/resources/content/viewPartialSource.xul


firefox:
http://lxr.mozilla.org/mozilla/source/toolkit/components/viewsource/content/viewPartialSource.xul

Comment 20

[rbs]

Comment on attachment 146030 [details] [diff] [review]
alternative patch

-  +	    '
onload="document.getElementById(\'target\').scrollIntoView(true)">'
+  +	    '
onload="document.title=\''+title+'\';document.getElementById(\'target\').scroll
IntoView(true)">'

This is _not_ a mistake. Seems that the title has to be set after the document
has loaded. The title doesn't show up without that work-around.

Comment 21

[Mike Connor [:mconnor]]

maybe we should just make this part of the web developer tools extension? 
non-web-savvy users won't use a view partial source properly anyway.

Comment 22

[rbs]

That can be extreme too. Ordinary web autors would miss out too. For example,
view-selection-source is popular with bloggers. When they want to quote each
other (as they often do), view-selection-source preserves links (people feel
that the original message loses its tone without the original links). So it can
also be a great time-savings aid for such recurrent copy-paste operations.
@see http://kairosnews.org/node/view/3352

Comment 23

[Steffen Wilberg]

-> view source.

Comment 24

[waren]

is it only me, or does the view selection source window have no title at all
right now? (except "Mozilla Firefox")

I would expect it to have a title like "Selection source of:
http://whatever.com/bla.html" (and a info-panel as suggesten in #18)

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.2) Gecko/20040813
Firefox/0.9.1+

Comment 25

[Tuukka Tolvanen (sp3000)]

*** Bug 273739 has been marked as a duplicate of this bug. ***

Comment 26

[rbs]

Comment on attachment 146030 [details] [diff] [review]
alternative patch

ben, what do you think of this now? It gives a simple hint that it is not the
original source. And can be customized without further coding.

Comment 27

[Phil Ringnalda (:philor)]

*** Bug 275556 has been marked as a duplicate of this bug. ***

Comment 28

[Bill Mason]

*** Bug 276479 has been marked as a duplicate of this bug. ***

Comment 29

[Phil Ringnalda (:philor)]

*** Bug 277283 has been marked as a duplicate of this bug. ***

Comment 30

[:Gavin Sharp [email: [e-mail]]]

*** Bug 277699 has been marked as a duplicate of this bug. ***

Comment 31

[Nickolay_Ponomarev]

*** Bug 274853 has been marked as a duplicate of this bug. ***

Comment 32

[José Jeria]

*** Bug 281829 has been marked as a duplicate of this bug. ***

Comment 33

[José Jeria]

*** Bug 293886 has been marked as a duplicate of this bug. ***

Comment 34

[Mike Connor [:mconnor]]

Comment on attachment 146030 [details] [diff] [review]
alternative patch

>@@ -71,6 +71,7 @@
>   <script type="application/x-javascript" src="chrome://global/content/viewPartialSource.js"/>
> 
>   <stringbundle id="findBundle" src="chrome://global/locale/finddialog.properties"/>
>+  <stringbundle id="viewSourceBundle" src="chrome://global/locale/viewSource.properties"/>

This is probably okay, and a step in the direction of not having paired
viewSource xul files.

> <!-- LOCALIZATION NOTE (mainWindow.title) : DONT_TRANSLATE --> 
>-<!ENTITY mainWindow.title "&brandShortName;"> 
>+<!ENTITY mainWindow.title "&brandFullName;"> 
> <!-- LOCALIZATION NOTE (mainWindow.titlemodifier) : DONT_TRANSLATE --> 
>-<!ENTITY mainWindow.titlemodifier "&brandShortName;"> 
>+<!ENTITY mainWindow.titlemodifier "&brandFullName;"> 
> <!-- LOCALIZATION NOTE (mainWindow.titlemodifierseparator) : DONT_TRANSLATE -->
> <!ENTITY mainWindow.titlemodifierseparator " - ">
> <!ENTITY mainWindow.preface "Source of: ">

These changes are already in from somewhere else, it seems.

>Index: toolkit/components/viewsource/locale/viewSource.properties
>===================================================================
>RCS file: /cvsroot/mozilla/toolkit/components/viewsource/locale/viewSource.properties,v
>retrieving revision 1.1
>diff -u -r1.1 viewSource.properties
>--- toolkit/components/viewsource/locale/viewSource.properties	22 Oct 2003 14:54:11 -0000	1.1
>+++ toolkit/components/viewsource/locale/viewSource.properties	13 Apr 2004 19:28:24 -0000
>@@ -5,3 +5,5 @@
> outOfRangeTitle   = Line not found
> outOfRangeText    = The specified line was not found.
> statusBarLineCol  = Line %1$S, Col %2$S
>+viewSelectionSourceTitle = DOM Source of Selection
>+viewMathMLSourceTitle    = DOM Source of MathML

I'm not entirely happy with this, though I understand the idea of pushing the
live DOM aspect of this... 

r=me, we can revisit the alternate solution when we have cycles to spare.

Comment 35

[:Gavin Sharp [email: [e-mail]]]

*** Bug 299543 has been marked as a duplicate of this bug. ***

Comment 36

[rbs]

Comment on attachment 146030 [details] [diff] [review]
alternative patch

Asking a=1.8b4.

This a change that should have gone in a long time ago, had the firefox
reviewers cared to listen. It is a simple change, yet very helpful at cutting
some of the many dups that distract from more important things.

Comment 37

[Mike Connor [:mconnor]]

This isn't a blocker, but I'm ok with taking this soonish.

Comment 38

[rbs]

Checked in.

Comment 39

[William Bumgarner [:zsinj]]

*** Bug 300824 has been marked as a duplicate of this bug. ***

Comment 40

[:Gavin Sharp [email: [e-mail]]]

*** Bug 301601 has been marked as a duplicate of this bug. ***

Comment 41

[:Gavin Sharp [email: [e-mail]]]

*** Bug 335830 has been marked as a duplicate of this bug. ***