270474 - Firefox l10n: nl-NL

Status: VERIFIED FIXED

(Firefox :: General, defect)

Description

[Tim Maks van den Broek [:mad_maks]]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; nl-NL; rv:1.7.5) Gecko/20041113 Firefox/1.0
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; nl-NL; rv:1.7.5) Gecko/20041113 Firefox/1.0

A new bug voor patches to the nl-NL build of Firefox

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1

[Martijn Ras]

Attachment: fixed plugins.dtd

Comment 2

[Martijn Ras]

Attachment: Even better patch for plugins.

Comment 3

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 166261 [details] [diff] [review]
Even better patch for plugins.

committed

Comment 4

[Gert-Paul]

Attachment: Toolkit improvements to stay consitent (use

Improvements for toolkit to be consistent with the others terms in the
translation.

Comment 5

[Gert-Paul]

Attachment: Updated patch, including necko

Updated patch with improvements for necko. I noticed a lot untranslated
strings.

Comment 6

[Martijn (MozBrowser.nl)]

(In reply to comment #5)
> Created an attachment (id=166342)
> Updated patch, including necko
> 
> Updated patch with improvements for necko. I noticed a lot untranslated
> strings.

"De FTP server %1$S is momenteel niet ondersteund." => "wordt niet ondersteund"

"vercijferd" as well as "versleuteld" is being used. I do not think a user will
be very happy with "vercijferd", because it does not tell much. They just want
to know whether the transfer is secure, so "beveiligd" IMHO is a more suitable
translation.

"is over een niet versleutelde verbinding verstuurd" tells the data have already
been transmitted, while the original text says "is to be sent"

"verstuurd and kan makkelijker": untranslated and => en

"ge\u00EFdentificeert" => ge\u00EFdentificeerd

this isn't Dutch: "lage versleuteling graad" => use "laag beveiligingsniveau"
instead ?

"die wat niet versleutelde informatie bevat opgeropen": wat => enige ?
opgeropen misses 'e'.

"makkelijk" => consistency: gemakkelijk

"Mij waarschuwen als informatie verstuur die niet versleuteld is" => misses 'ik'

"door derden geleden worden" geleden => gelezen

"beveiliginscertificaat" has a typo.

Comment 7

[Gert-Paul]

Attachment: Updated patch

Updated patch with Martijn's comments. Also using beveiligd en versleuteld.

Comment 8

[Gert-Paul]

Attachment: Surfen instead of bladeren

Still one time bladeren in the privacy panel. This patch fixes this for
'surfen'

Comment 9

[Martijn Ras]

Comment on attachment 166372 [details] [diff] [review]
Surfen instead of bladeren

if we do not want 'bladeren' we need to choose between "navigeren" and
"surfen". I noticed patches i checked in or reviewed today using "navigeren"
consistently. I prefer "navigeren".

Comment 10

[u81239]

Martijn: me too, see bug 270699.

On a related note, I filed bug 270702 about the translation for 'decrypt'.


~Grauw

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 166367 [details] [diff] [review]
Updated patch

on behalf of bsmedberg

Comment 12

[Martijn Ras]

Comment on attachment 166367 [details] [diff] [review]
Updated patch

committed

Comment 13

[Martijn (MozBrowser.nl)]

(In reply to comment #9)
> (From update of attachment 166372 [details] [diff] [review])
> I prefer "navigeren".

I prefer 'surfen' as this is more commonly used in The Netherlands. Otherwise
one still has to explain what is meant by 'navigeren'. A translation should make
it easier for ordinary users to use the software, so we should use words they
are already familiar with. 

Comment 14

[Martijn Ras]

Attachment: small improvements

Gert-Paul found some untranslated sentences and incorrect shortcuts and words.
This patch fixes those problems.

Comment 15

[u81239]

I'm spent tonight, so I'll give some attention to the remainder of the Help
reviewing tomorrow, ok? ^_^

Comment 16

[Gert-Paul]

Attachment: More small improvements

Updated patch (makes Martin's patch obsolete) with more comments from
http://www.mozbrowser.nl/forum/viewtopic.php?p=11345#11345.

One question, is it 'Help-inhoud' and 'Voor Internet Explorer-gebruikers' or
'Help inhoud' and 'Voor Internet Explorer gebruikers'?
On IRC we were not sure..

Comment 17

[harmhilvers]

(In reply to comment #16)
> One question, is it 'Help-inhoud' and 'Voor Internet Explorer-gebruikers' or
> 'Help inhoud' and 'Voor Internet Explorer gebruikers'?
> On IRC we were not sure..

Helpinhoud and Internet Explorer-gebruiker. These words are both
'samenstellingen' (can't remember the correct English word right now ;) ) and
therefor have to be put together. If that's not possible you can use a hyphen.

Comment 18

[Gert-Paul]

Attachment: More small improvements

Updated patch with Helpinhoud en Voor Internet Explorer-gebruikers.

Comment 19

[Gert-Paul]

Attachment: Change width JavaScript Options dialog

Changed the width of the Options dialog, in the same way as the German
translation .

Comment 20

[Martijn Ras]

Comment on attachment 166514 [details] [diff] [review]
small improvements

Gert-Paul imcorporated all of these in his update.

Comment 21

[Benjamin Smedberg]

Comment on attachment 166554 [details] [diff] [review]
More small improvements

-EndFTPTransaction=FTP transactie beindigd
+EndFTPTransaction=FTP-transactie be�indigd

What's that?

Comment 22

[Benjamin Smedberg]

Comment on attachment 166556 [details] [diff] [review]
Change width JavaScript Options dialog

Please add a newline to the end of this file.

Comment 23

[Martijn Ras]

(In reply to comment #21)
> (From update of attachment 166554 [details] [diff] [review])
> -EndFTPTransaction=FTP transactie beindigd
> +EndFTPTransaction=FTP-transactie be�indigd
> 
> What's that?
> 

That's an error, will fix it by inserting the proper UNICODE escape sequence

Comment 24

[Benjamin Smedberg]

Comment on attachment 166554 [details] [diff] [review]
More small improvements

ok, a=me with the unicode escape sequence fixed

Comment 25

[Martijn Ras]

Comment on attachment 166554 [details] [diff] [review]
More small improvements

committed

Comment 26

[Martijn Ras]

Comment on attachment 166556 [details] [diff] [review]
Change width JavaScript Options dialog

committed

Comment 27

[u81239]

Attachment: Some harmless changes

A few nits.

Comment 28

[Martijn Ras]

Comment on attachment 166588 [details] [diff] [review]
Some harmless changes

The browser.dtd changes the  accesskeys to non-standard values. The
browser.properties change is invalid. What remains is a good change in
pref-advancedscripts.dtd. Obsoleting this and adding an update to this patch to
bug 270938 as these are not showstoppers.

Comment 29

[Gert-Paul]

Attachment: Patch to fix the error on Mac OS X

This fixes the error mentioned in
http://www.mozbrowser.nl/forum/viewtopic.php?p=11426

Comment 30

[u81239]

Martijn: the patch was *especially* to address the issue of Firefox currently
having non-standard access keys. They are exactly like this (K&nippen, &Plakken,
&Kopiëren) in (Dutch) Internet Explorer and Notepad too, so I definitely would
not call them 'non-standard'. Quite the opposite.

About the browser.properties file... I'd say Gereed is a good word (less
informal than the current 'klaar'), and IE uses it as well.


~Grauw

Comment 31

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 166598 [details] [diff] [review]
Patch to fix the error on Mac OS X

approving on behalf of bsmedberg

Comment 32

[Martijn Ras]

Comment on attachment 166598 [details] [diff] [review]
Patch to fix the error on Mac OS X

committed

Comment 33

[Martijn Ras]

Attachment: Fixed accesskeys as correctly noted in Lauren's comment (#30)

In short is this what this enforces:

				 Accesskey
Command       Translation	 | Commandkey
Copy:	      Kopiëren 	  K C
Cut:	      Knippen		 N X
Delete:       Verwijderen	 D D
Print:	      Afdrukken 	 D P
Printpreview: Afdrukvoorbeeld	 V
Redo:	      Opnieuw uitvoeren  U Y
Reload:       Herladen		 R R
Save page:    Pagina opslaan als O S

Comment 34

[Tim Maks van den Broek [:mad_maks]]

forget the comment: there is a type error in the commandkey in editMenuOverlay.dtd

Comment 35

[u81239]

yay! ^_^

Comment 36

[u81239]

Attachment: Fixed accesskeys (updated)

This fixes the typing error in the patch.

Comment 37

[Martijn Ras]

Attachment: Updated for "Fixed accesskeys" with consistent use of vernieuwen

Comment 38

[Martijn Ras]

Attachment: Fixed conflicts ...

Comment 39

[Martijn Ras]

Comment on attachment 166699 [details] [diff] [review]
Fixed conflicts ...

as requested by [e-mail]

Comment 40

[Gert-Paul]

Attachment: 2 Updated images

Updates for the helpimages. cookie_ask.png was too old and showed the TBP-icon
and cookie_manager.png was too big compared to the other images (still 100%).

Comment 41

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 166700 [details]
2 Updated images

approving on behalf of bsdmedberg

Comment 42

[Zibi Braniecki [:zbraniecki][:gandalf]]

Comment on attachment 166699 [details] [diff] [review]
Fixed conflicts ...

approving on behalf of bsmedberg

Comment 43

[Martijn Ras]

Comment on attachment 166699 [details] [diff] [review]
Fixed conflicts ...

committed

Comment 44

[Martijn Ras]

Comment on attachment 166700 [details]
2 Updated images

committed

Comment 45

[Gert-Paul]

Attachment: Fixes image size in help

The size of the helpimages in the xhtml-files was not right. This patch fixes
the width/height of the helpimages so that they appear correctly.
Also changing the location to the popup-image to the right location. It can be
found in chrome://.. and not in ./images/..

Comment 46

[u81239]

Attachment: Fix problems with Help index

One item was improperly nested, and I removed the empty 'r' reference just like
the other nonexistant parts.

Comment 47

[u81239]

Attachment: Final minor nits

Fixes a duplicate access key in the 'Beeld' menu, and changes the "Kleine
pictogrammen gebruiken" from the 'Werkbalk wijzigen' window into "Kleine
pictogrammen" (which makes the windo fit its width and yet is still clear
enough).

~Grauw

Comment 48

[Martijn Ras]

Comment on attachment 166707 [details] [diff] [review]
Final minor nits

This change in customizeToolbar.dtd is ok, the findAgainCmd has to be sorted
out, this inserts a third key ... 
I'll open a bug to create a reference for accesskeys and commandkeys. We can
not just change one here or there, we need to make sure it's consistent
throughout the translation.

Comment 49

[Martijn Ras]

Attachment: Patch to make customizeToolbar.dtd fit window

Comment 50

[Tim Maks van den Broek [:mad_maks]]

We have a test failed:
Entities in ./chrome/global/editMenuOverlay.dtd don't match:
  In
/builds/tinderbox/firefox-aviarybranch-l10n/Darwin_7.6.0_Clobber/mozilla/toolkit/locales/en-US:
    cutCmd.accesskey

in https://bugzilla.mozilla.org/attachment.cgi?id=166699&action=view is missing a > 
RCS file:
/l10n/mozilla/toolkit/locales/nl-NL/chrome/global/Attic/editMenuOverlay.dtd,v
retrieving revision 1.1.2.1
diff -u -r1.1.2.1 editMenuOverlay.dtd
--- mozilla/toolkit/locales/nl-NL/chrome/global/editMenuOverlay.dtd	21 Oct 2004
21:09:20 -0000	1.1.2.1
+++ mozilla/toolkit/locales/nl-NL/chrome/global/editMenuOverlay.dtd	21 Nov 2004
20:01:43 -0000
@@ -1,13 +1,13 @@
-<!ENTITY copyCmd.accesskey "I">
+<!ENTITY copyCmd.accesskey "K">
 <!ENTITY copyCmd.key "C">
-<!ENTITY copyCmd.label "Kopiëren">
-<!ENTITY cutCmd.accesskey "K">
+<!ENTITY copyCmd.label "Kopi&#xEB;ren">
+<!ENTITY cutCmd.accesskey "N"

Comment 51

[Tim Maks van den Broek [:mad_maks]]

Attachment: fix the buildbustage

(In reply to comment #50)

Comment 52

[Gert-Paul]

Attachment: Fix Beeld acceskeys and downloadmanager shortcut for Linux

We have to use L as acceskey for Beeld, because it interferes with the Alt + D
shortcut for selecting the locationbar. In the bookmarks D as acceskey is OK,
but we have to be consistent.
Also using Y again as download shortcut for Linux. In all documentation Ctrl +
Y is used for Linux and Ctrl + J for websearch.

Comment 53

[Martijn Ras]

Comment on attachment 166753 [details] [diff] [review]
Fix Beeld acceskeys and downloadmanager shortcut for Linux

See my previous comment https://bugzilla.mozilla.org/show_bug.cgi?id=270474#c48

Comment 54

[Martijn Ras]

Problems with shortcuts will be handled separately from now on in the following bug:
https://bugzilla.mozilla.org/show_bug.cgi?id=271202

Result of which should be consistently used shortcuts and a reference guide
listing all values used.

Comment 55

[Martijn Ras]

Comment on attachment 166753 [details] [diff] [review]
Fix Beeld acceskeys and downloadmanager shortcut for Linux

working on a update for this patch and 166707

Comment 56

[Martijn Ras]

Attachment: Updated 166753

Comment 57

[Tim Maks van den Broek [:mad_maks]]

Comment on attachment 166735 [details] [diff] [review]
fix the buildbustage

committed

Comment 58

[Martijn Ras]

Comment on attachment 166703 [details] [diff] [review]
Fixes image size in help

committed

Comment 59

[Martijn Ras]

Comment on attachment 166704 [details] [diff] [review]
Fix problems with Help index

committed

Comment 60

[Martijn Ras]

Comment on attachment 166756 [details] [diff] [review]
Updated 166753

committed

Comment 61

[Martijn Ras]

Comment on attachment 166734 [details] [diff] [review]
Patch to make customizeToolbar.dtd fit window

committed

Comment 62

[Anne (:annevk)]

I think we can resolve this as fixed.