343901 - [tbird] cannot install dictionaries in thunderbird since bug 216382 landed

Status: RESOLVED WORKSFORME

(Thunderbird :: General, defect)

Description

[Magnus Melin [:mkmelin]]

Using a thunderbird branch build, if you try to install a dictionary it says install was successful, but the dictionary does not show up under preferences > composition > spelling. (And seems not to work either...)

This broke 2006062903 -> 2006063003, so caused by bug 216382.

I tried swedish, but it probably affects all.
http://forums.mozillazine.org/viewtopic.php?t=436549&sid=807ae0c3ee6fc8d97bfca9838439e6ea

Comment 1

[Scott MacGregor]

This would block our 2.0 release if we can't install our dictionaries anymore.

Comment 2

[Benjamin Smedberg]

The location in which to install dictionaries has changed. Dictionaries should now be installed as extensions into <extension>/dictionaries. See http://developer.mozilla.org/en/docs/Bundles#Application-specific_Extension_Files

Comment 3

[Benjamin Smedberg]

See also bug 343076, which is about adding new-style dictionary extensions to AMO.

Comment 4

[Ian Neal]

-> All/All

Comment 5

[Benjamin Smedberg]

*** Bug 345859 has been marked as a duplicate of this bug. ***

Comment 6

[Adam Guthrie]

*** Bug 346601 has been marked as a duplicate of this bug. ***

Comment 7

[Magnus Melin [:mkmelin]]

*** Bug 358874 has been marked as a duplicate of this bug. ***

Comment 8

[Magnus Melin [:mkmelin]]

Currently trying to install an old style dictionaries will say "install successful", but do nothing useful at all. That needs to get fixed. (New style dictionaries install just fine.)

I think there should also be a note about the dictionary format change on 
http://www.mozilla.com/en-US/thunderbird/dictionaries.html

Comment 9

[Magnus Melin [:mkmelin]]

*** Bug 360508 has been marked as a duplicate of this bug. ***

Comment 11

[Adam Guthrie]

So it sounds like we'd have to implement some sort of hack to get old dictionaries to work; e.g. copy the installed files into /dictionaries. Does Firefox do this? (I don't think it does...)

If older dictionaries aren't going to work, we shouldn't make them available. It sounds like in bug 343076 the dictionaries in the link mentioned in comment 8 were converted to the new format and added to AMO. So don't we just need to update that page to link to Add-ons (rather than to mozdev) and let the owner of the mozdev dictionaries project know about this, and suggest they make a note of it on their website?

Comment 12

[Steffen Wilberg]

Right, we need to update the url.
Firefox uses this code to get to the dictionaries add-ons page:
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/base/content/nsContextMenu.js&rev=1.10&mark=1069-1092#1069
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/browser/app/profile/firefox.js&rev=1.170&mark=78#77

So the url should be:
https://%locale%.add-ons.mozilla.com/%LOCALE%/thunderbird/%VERSION%/dictionaries

Working url with working dictionaries:
https://en-US.add-ons.mozilla.com/en-US/thunderbird/2/dictionaries
It redirects to: https://addons.mozilla.org/thunderbird/dictionaries/?lang=en-US
Remora preview:
https://remora.stage.mozilla.com/en-US/thunderbird/browse/type:3

Comment 13

[Steffen Wilberg]

Looks like the proper server redirects have been set up. So when clicking on the Download More Dictionaries link in Thunderbird Options->Composition->Spelling, it takes me to https://addons.mozilla.org/en-US/thunderbird/browse/type:3, which is the correct page. Thunderbird also uses the correct url: http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/mail/app/profile/all-thunderbird.js&rev=1.44.2.45#349

The old page was at http://www.mozilla.com/en-US/thunderbird/dictionaries.html.

I guess this can be considered WFM.

Comment 14

[Magnus Melin [:mkmelin]]

Unfortunately the old dictionaries don't have (at least the ones i checked) any install.rdf or similar, so if you try to install an old type dictionary in 2.0 it will "install" - with all files getting copied and installation success confirmation. Only they go to the old place so and won't work. 

I suppose its expected, and I don't know if there's much to do about it, but http://www.mozilla.com/en-US/thunderbird/dictionaries.html need a BIG notice that the dictionaries listed there will only work in <= 1.5. 

Comment 15

[Chris Ilias [:cilias]]

(In reply to comment #14)
> I suppose its expected, and I don't know if there's much to do about it, but
> http://www.mozilla.com/en-US/thunderbird/dictionaries.html need a BIG notice
> that the dictionaries listed there will only work in <= 1.5. 

Bug 376458 [dictionaries.html should state compatibility] created. :)