345887 - Thunderbird Theme Update for Qute

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Scott MacGregor]

Arvid has been hard at work on a theme refresh for Thunderbird 2 to the qute theme. This is a tracking bug for those changes.

Comment 1

[Scott MacGregor]

In addition to the theme update, we'll need a few more new icons for new Thunderbird 2 features:

1) Toolbar button icon for the new 'Tags' Features. Both a small and a large toolbar icon.

2) saved search folder icon that indicates new mail (similar to http://lxr.mozilla.org/seamonkey/source/mail/themes/qute/mail/icons/folder-search.png but with the new mail indicator on top of it)

3) Replace the existing flag icons with 'star' (like gmail). In particular:
http://lxr.mozilla.org/seamonkey/source/mail/themes/qute/mail/icons/flag-col.png
and
http://lxr.mozilla.org/seamonkey/source/mail/themes/qute/mail/icons/flag.png

4) We're adding a new feature that lets you navigate backwards and forwards through previously viewed messages. Kind of like a browser back/forward page cache but for e-mail. We need main toolbar buttons for going forward and another one for going backward. 

Comment 2

[Scott MacGregor]

Attachment: theme refresh against the trunk

In addition to the first cut at a theme refresh from Arvid I moved the starred column in the thread pane to a more prominent position, to the left of the subject like it is in gmail.

screen shots coming up.

Comment 3

[Scott MacGregor]

Attachment: screen shot

screen shot of some of the new artwork.

Comment 4

[Scott MacGregor]

Attachment: options dialog

Comment 5

[Frederic Bezies]

Looks great ! A new icon theme at least. Let's hope you can check it in very soon. I am hardly waiting for it.

Comment 6

[Golyc - André Villar]

What about the RSS icon ???

We should use the standard icon

Comment 7

[Scott MacGregor]

Comment on attachment 233651 [details] [diff] [review]
theme refresh against the trunk

There might be some problems with us overriding all of the toolbar button padding CSS rules in messenger.css....

In either case, I want to get some feedback on the new theme so I'm going to land this on the trunk today.

Comment 8

[Chris Ilias [:cilias]]

Is there a specific place you want feedback to go, before this gets checked in (based on the screenshots)? This bug? The MozillaZine thread? Someplace else?

Comment 9

[David Miller]

Looks very nice.  I especially enjoy the new options menu you guys rock! :-)

Comment 10

[Frederic Bezies]

It is great version, but option menu doesn't play very well with gnome :(

It is strange to see what I can see with my ubuntu dapper drake. Composition icon is not completely filled for example. Will attach screenshot asap.

Comment 11

[Frederic Bezies]

Attachment: Composition icon is not fully colored fill (gnome 2.14 / Ubuntu 6.06.1)

This "bug" is also present for attachments.

Comment 12

[Adam Guthrie]

Frederic, I think it would be best if you filed follow-up bugs for the issues with GNOME and made them block this one. Thanks!

Comment 13

[Frederic Bezies]

filled bug 348829. Thanks for your idea.

Comment 14

[Mike Cowperthwaite]

With 3a1-0816, Win2K, I'm not seeing icons for items in the thread pane unless they've been replied or forwarded, which causes the list of items to appear staggered.

I'm not enthused about a flame icon for Junk -- that could just as easily be interpreted as "of burning importance" -- but it's not like the previous icon was any better.  The star icon looks fine, altho I do personally prefer the "flag" technology -- "flag" works better as a verb, to my ear.

On the Options dialog, the Composition and Attachments tabs have a pale border on the right and left edges (only shows on hover or select) that the other tabs don't.  What's up with that?

All of these icons lack the vibrancy of the earlier ones.  The one icon that looks better than the previous incarnation is the shield on the Options | Privacy tab.

Comment 15

[Scott MacGregor]

(In reply to comment #14)
> With 3a1-0816, Win2K, I'm not seeing icons for items in the thread pane unless
> they've been replied or forwarded, which causes the list of items to appear
> staggered.

This is part of the new design. Originally there was enough blank space to the left of the subject text for entries without an icon, so things weren't staggered, but I didn't like the wasted space horizontal space this gave most messages, and tweaked it to experiment with the staggered view.

> On the Options dialog, the Composition and Attachments tabs have a pale border
> on the right and left edges (only shows on hover or select) that the other tabs
> don't.  What's up with that?

related to the gtk bug that depends on this one?

Comment 16

[Frederic Bezies]

Or it could be another way to see this display bug. Anyway, I don't like junk icon, it makes me think of a trash can more than a junk filter.

Comment 17

[Scott MacGregor]

Attachment: additional patch

some more tweaks from arvid.

Comment 18

[Scott MacGregor]

These changes have landed on the branch now too. We'll continue to land changes based on feedback into both places.

Comment 19

[Peter Lairo]

Most e-mails don't have attachments. Thus, the attachments column wastes valuable horizontal space. How about just putting an attachment icon in the subject column in front the the subject?

I posted other suggestions to news://news.mozilla.org:119/mozilla.dev.apps.thunderbird
Subject: New Theme - Why are Folders Sideways? Why is Dig Sig Seal a Ribbon?

Comment 20

[Scott MacGregor]

FYI, I just landed some new toolbar icons from Arvid tonight on the branch and trunk, some minor polish changes.

Comment 21

[Scott MacGregor]

Attachment: more changes from arvid including a new stop button

this patch also fixes the toolbar button padding issue in Bug #349565.

Comment 22

[Scott MacGregor]

Attachment: [fixed branch and trunk] update from arvid

fixes icons for the select folders for offline use dialog.

removes the icons in the autocomplete pop down.

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Scott, dunno if that only happens for me but there is no junk icon visible inside the thread pane. If it's valid I'll file a new bug for that issue.

Comment 24

[Scott MacGregor]

That's strange Henrik. I'm definetly seeing the flame junk icon in the thread pane in the Windows release builds off ftp. Any chance of some userChrome.css or an extension that's keeping you from seeing it?

So the junk column is blank?

Comment 25

[Henrik Skupin [:whimboo][⌚️UTC+1]]

> That's strange Henrik. I'm definetly seeing the flame junk icon in the thread
> pane in the Windows release builds off ftp. Any chance of some userChrome.css
> or an extension that's keeping you from seeing it?

Good catch. Running Thunderbird in Safe Mode shows me the icon. I deactivated my only extension mnenhy and it's working now. I will file a bug report for that extension. Sorry for bugspam.

Comment 26

[Scott MacGregor]

New art for the clear quick search icon has been checked in.

Also the thread pane background row image has been changed.

Branch and trunk. 

Comment 27

[Scott MacGregor]

Attachment: [fixed branch and trunk] update from arvid

This latest patch fixes the close button and adds some spacing to the signed icon in the message header envelope.

Comment 28

[Tim Maks van den Broek [:mad_maks]]

The text under the icons in the NL build are too big (old problem) and so you don't see the last icon in a clean profile. in tb 1.5 the searchbar moved under the iconbar if this was happened but in tb 2preb1 is this not the case. New users will not now there is a searchbar present.