Closed Bug 375485 Opened 14 years ago Closed 14 years ago
Remove some unused toolkit strings
This time, with bad-tempered annotations! toolkit/locales/en-US/chrome/cookie/cookieAcceptDialog.dtd props.box.label - unused since bug 163350, 2003-02-22 toolkit/locales/en-US/chrome/cookie/cookieAcceptDialog.properties permissionToAcceptImage - unused since bug 191380, 2003-03-21 rememberThisDecision - unused since bug 191380, 2003-03-21 toolkit/locales/en-US/chrome/global/console.properties typeException - added unused by bug 67647, 2001-02-28 toolkit/locales/en-US/chrome/global/contentAreaCommands.properties searchText - thanks, Aviary Landing SavePageTitle - added unused by bug 11632, 2001-12-11 saveLinkErrorMsg, and saveLinkErrorTitle, and unknownDescriptionFilesFilter, and unknownDescriptionFilesPluralFilter - unused since bug 294759, 2005-06-28 toolkit/locales/en-US/chrome/global/downloadProgress.properties close, unknown, error - if these aren't the reason we require review, they should be FilePickerTitle - for the suite's filepicker, when this was for downloads instead of plugins toolkit/locales/en-US/chrome/global/filepicker.dtd permissions.label - unused since rev=1.17 of the xpfe filepicker.xul, 2000-08-31 toolkit/locales/en-US/chrome/global/filepicker.properties noButtonLabel - for the 2nd of 4 alternate patches on bug 77474 - never used, 2001-05-07 errorDirNotReadableMessage - removed by bug 142482, 2005-03-11 toolkit/locales/en-US/chrome/global/finddialog.dtd findDialogFrame.title - added unused in bug 52727, which was wontfixed 2000-12-18 backwardsCheckbox.label, backwardsCheckbox.accesskey - whenever we switched to direction radiobuttons, maybe one of the four empty log messages? findField.tooltip - added 2000-05-13 claiming to be bug 23103, never used toolkit/locales/en-US/chrome/global/printPageSetup.dtd hfTitle.code, hfURL.code, hfDateAndTime.code, hfPage.code, hfPageAndTotal.code - added unused, inconsistent, unusable, unlocalizable, and uncommented in bug 113727 toolkit/locales/en-US/chrome/global/printPreview.dtd percent.label - went unused in bug 127857, during the Mozilla 1.0 string freeze toolkit/locales/en-US/chrome/global/printPreviewProgress.dtd spaces - randomly added between the first and second patch in bug 154135 toolkit/locales/en-US/chrome/global/tabbrowser.dtd newTabButton.tooltip - adds to the humor of bug 186865 and friends, that we've been carrying the string all along
Attachment #259752 - Flags: first-review?(gavin.sharp)
Comment on attachment 259752 [details] [diff] [review] Fix v.1 r=mano.
Attachment #259752 - Flags: first-review?(gavin.sharp) → first-review+
toolkit/locales/en-US/chrome/cookie/cookieAcceptDialog.dtd: 1.8 toolkit/locales/en-US/chrome/cookie/cookieAcceptDialog.properties: 1.6 toolkit/locales/en-US/chrome/global/console.properties: 1.4 toolkit/locales/en-US/chrome/global/contentAreaCommands.properties: 1.5 toolkit/locales/en-US/chrome/global/downloadProgress.properties: 1.4 toolkit/locales/en-US/chrome/global/filepicker.dtd: 1.4 toolkit/locales/en-US/chrome/global/filepicker.properties: 1.5 toolkit/locales/en-US/chrome/global/finddialog.dtd: 1.4 toolkit/locales/en-US/chrome/global/printPageSetup.dtd: 1.4 toolkit/locales/en-US/chrome/global/printPreview.dtd: 1.5 toolkit/locales/en-US/chrome/global/printPreviewProgress.dtd: 1.3 toolkit/locales/en-US/chrome/global/tabbrowser.dtd: 1.4
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Phil, did you find those strings by manual labour or do you have some magic procedure to find those?
Brute force. You could probably write a script to cut down the number you look at, but since properties can be used as "foo"+bar+"baz", and an entity used in a different part of the tree could be unused in something we don't build (like xpfe) or used in something we do build (like xpfe), I don't think we could have a test script running on a tinderbox to spot them as they happen without having hundreds of special-cased exceptions. I'd love to be proved wrong, though.
You need to log in before you can comment on or make changes to this bug.