396417 - [Mac] Datepicker freezes after changing month/year

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Daniel Boelzle [:dbo]]

On Mac branch builds, the datepicker freezes after selecting a month or year via dropdown. This occurs on all instances of the datepicker; the problem does not
occur on Windows or Linux.

Comment 2

[Shinya Kuribayashi]

[trolling] This bug is still alive on Tb2.0.0.9 + Lg0.8pre(2008012320).

When year changed, the datepicker freezes. OTOH when month changed, the datepicker just exits instead of update its contents. And make matters worse, the right/left arrows on the datepicker does NOT work. This means we couldn't create events for next month or later.

IMO this bug is worth Major or higher for Mac users.

Comment 3

[Stefan Sitter [:ssitter]]

Bug 416161 reports the same issue for Windows but only for the Agendas datepicker.

Comment 4

[Bas van den Bosch]

bug 416161 isn't the same problem but similar. The arrows do work in windows but the month freezes the window as does the year.

Comment 5

[Simon Paquet [:sipaq]]

Not going to happen for 0.8.

Comment 6

[Stefan Sitter [:ssitter]]

This bug was added as a follow up for Bug 367159 that added a hack to make the datepicker usable on Mac OS X branch builds. This hack still exists in comm-central builds: <http://mxr.mozilla.org/comm-central/search?string=mUseReshowHack&find=/calendar/>

The corresponding |#ifndef MOZ_SUNBIRD| workaround in /widget/src/mac/nsMacWindow.cpp doesn't exist in mozilla-central anymore.

Is the hack in datetimepickers.xml still required in 1.0pre builds?

Does this issues still exists in 1.0pre builds?

Comment 7

[Daniel Boelzle [:dbo]]

(In reply to comment #6)
> Is the hack in datetimepickers.xml still required in 1.0pre builds?
needs investigation

> Does this issues still exists in 1.0pre builds?
No, the datepicker currently works well on Mac (trunk).

WFM? Or WFM after investigation resp. potential cleanup?

Comment 11

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Remove reshow hack - v1

It seems we can remove the reshow hack. This patch is tested on mac, will test windows/linux soon (therefore not requesting review yet)

Comment 12

[Felix Möller]

Is this a duplicate of bug #278877 ?

Comment 13

[Felix Möller]

Sorry I meant bug #286747 in comment #12

Comment 15

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Patch works on windows

Comment 16

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Attachment: Remove reshow hack - v2

Tested on Linux, debitrotted and comment removed

Comment 17

[Stefan Sitter [:ssitter]]

Comment on attachment 581566 [details] [diff] [review]
Remove reshow hack - v2

r=ssitter (I don't have access to Mac OS X and therefore cannot test if this patch fixes or breaks anything on this system)

Comment 18

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Pushed to comm-central changeset 298e996a1267

Comment 19

[Stefan Sitter [:ssitter]]

Any particular reason why the removing of the obsolete comment that was part of the patch I reviewed didn't make it into the final patch that was pushed to comm-central?

Comment 20

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Oh, sorry about that. I had this patch locally on my mac and assumed it was the same one as on the bug. Will fix.

Comment 21

[Philipp Preißer-Kewisch [:Fallen][☁️📆]]

Fixed this in comm-central changeset 069ae74f83d9