Closed Bug 403137 Opened 12 years ago Closed 12 years ago

Bookmarks organizer toolbar use media-toolbox on Vista

Categories

(Firefox :: Bookmarks & History, defect)

x86
Windows Vista
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 3

People

(Reporter: faaborg, Unassigned)

References

Details

(Keywords: polish, Whiteboard: [vistatheme][Fixed by bug 403147])

Attachments

(2 files)

The toolbar in the bookmarks organizer should be black on Vista to visually integrate with similar organizers for media objects, like Windows Media Player, and Windows Photo Gallery.  I'm not sure if we will be able to get this styling through nsiTheme or not, otherwise I guess we will need to ship with an image of the toolbar.

See bug# 393514 for a mockup.
Flags: blocking-firefox3?
flags added in bug 397073 could be used to pull different CSS for different windows os versions.
Flags: blocking-firefox3? → blocking-firefox3-
Whiteboard: [vistatheme]
This is the black background for Vista, without the shiny bottom, with extended height so that it'll work on toolbars of any height.
The shiny bottom part of the Vista toolbar background
Using the images, the code should be like this:

#placesToolbox{
	-moz-appearance: none !important;
	background: #0f0f14 url(vista-black-bar.png) repeat-x center !important;
	border: 0 !important;
}

#placesToolbar{
	-moz-appearance: none !important;
	background: transparent url(vista-black-bar-bottom.png) repeat-x bottom !important;
	border: 0 !important;
}
Now that bug 419383 is fixed, we don't need to do this with images. The following code should do it:

#placesToolbox {
  color: white ! important;
  -moz-appearance: media-toolbox ! important;
}
oops, and:

#placesMenu > menu {
  color: white ! important;
}
Summary: Bookmarks organizer toolbar should be black on Vista → Bookmarks organizer toolbar use media-toolbox on Vista
Blocks: 423491
Depends on: 423498
Blocks: 425598
No longer blocks: 425598
Depends on: 425598
Blocks: 425582
Bug 427045 is related. It could solve accessibility as well, dependency?
Blocks: 405605
Depends on: 427045
No longer depends on: 425598
Whiteboard: [vistatheme] → [vistatheme][possible patch in bug 403147]
see bug 403147 for a possible impl
No longer depends on: 423498
Blocks: 430903
FIXED by checkin for bug 403147
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
Verified with Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9pre) Gecko/2008050806 Minefield/3.0pre ID:2008050806
Status: RESOLVED → VERIFIED
Depends on: 403147
Whiteboard: [vistatheme][possible patch in bug 403147] → [vistatheme][Fixed by bug 403147]
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.