Closed Bug 403412 Opened 13 years ago Closed 13 years ago

Download Manager window title fails to clear/update upon download completion

Categories

(Toolkit :: Downloads API, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.9beta5

People

(Reporter: rathel, Assigned: Mardak)

References

Details

Attachments

(2 files)

2.00 KB, application/octet-stream
Details
v1
775 bytes, patch
sdwilsh
: review+
beltzner
: approval1.9+
Details | Diff | Splinter Review
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007111104 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007111104 Minefield/3.0b2pre

After download completion download manager still shows % of file and the # of files that you were downloading.

Reproducible: Always

Steps to Reproduce:
1. Download anything
2.
3.
Actual Results:  
Incorrectly shows % and # of files. in title bar.

Expected Results:  
Display no % or # of files when all downloads are complete.
would you be willing to attach your downloads.sqlite file?
Hrmm.. if this was Windows, I would have guessed that it was because of the scanning state and we don't update the title until the download is done scanning and considered completed. Not so much sure about linux though..
Attached file downloads.sqlite
Rather, what's the value of your 'browser.download.manager.retention' preference in about:config?
Confirming, based on my own duplicate and bug 404756.
Status: UNCONFIRMED → NEW
Ever confirmed: true
https://litmus.mozilla.org/show_test.cgi?id=5027

in-litmus+
OS: Linux → All
Hardware: PC → All
Version: unspecified → Trunk
Tweaking summary from "Download Manager fails to update upon download completion" to "Download Manager window title fails to clear/update upon download completion", in hopes of being easier to find.
Summary: Download Manager fails to update upon download completion → Download Manager window title fails to clear/update upon download completion
Attached patch v1Splinter Review
Update the title right when we get state changes instead of only on progress. We don't always get the last progress update. This will also have us update the title when new downloads are added yet before they progress.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #309731 - Flags: review?(sdwilsh)
Please change the string from "1 file - Downloads" to "1
file – Downloads" and from "%d files – Downloads" to "%d file – Downloads".

In case you can't see or haven't noticed, the strings have an en dash and not a hyphen! An en dash is a little longer than a hyphen
and a little smaller than an em dash.

En dash: U+2013 (0x96)
Keystroke: Alt+0150 (on Windows)

Please change that hyphen into an en dash.
Also... Please make the number and the % (percent sign) separated with a space for the Download Manager's window title when a file or files is/are downloading.
Example 1: 14 % of 1 file – Downloads
Example 2: 25 % of 2 files – Downloads

Please note that in those examples there's an EN DASH before the words 'Downloads' and also a SPACE between the numbers of percents (14 and 25) and the percent sign (%). This is how the Download Manager's window title should be when a file or files is/are downloading.

Please make it so. Thank you.
This build has the latest patch applied and should fix this issue:

https://build.mozilla.org/tryserver-builds/2008-03-16_18:52-edward.lee@engineering.uiuc.edu-sleepPause.clearSearch.syncTime.keyIcon/

Bug 403412 - Download Manager window title fails to clear/update upon download completion
Bug 335418 - Pause downloads when computer is about to go to sleep
Bug 414850 - "Clear List" in download manager should only remove visible downloads
Bug 420482 - Big discrepancy in ETA between Downloads Manager & Downloads status bar panel
Bug 414326 - Use DownloadUtils for software update downloads

Bug 393678 - location bar autocomplete should take word boundaries in account
Bug 407946 - emphasize all matching text in title and url, not just the first match in title and url
Bug 415403 - Show matches for all search words for location bar autocomplete
Bug 418257 - Show what part of which tags match for urlbar autocomplete
Bug 392143 - show keywords as url bar autocomplete choices
Bug 249468 - Add all bookmark keywords to location bar autocomplete drop-down list
Bug 395161 - make it possible to restrict the url bar autocomplete results to bookmarks, tags, or history entries
Bug 407204 - adjust the title and url text sizes
Bug 406257 - reduce the number of rows in url bar autocomplete from 10 to 6
Bug 420437 - Search and emphasize quoted strings with spaces
Bug 422491 - Optimize AwesomeBar if it finished searching and found fewer than maxResults
Comment on attachment 309731 [details] [diff] [review]
v1

aye, this is the right fix.

Drivers - this is a fairly low risk patch fixing a UI inconsistency.

r=sdwilsh
Attachment #309731 - Flags: review?(sdwilsh)
Attachment #309731 - Flags: review+
Attachment #309731 - Flags: approval1.9?
Comment on attachment 309731 [details] [diff] [review]
v1

a1.9=beltzner
Attachment #309731 - Flags: approval1.9? → approval1.9+
Checking in toolkit/mozapps/downloads/content/DownloadProgressListener.js;
/cvsroot/mozilla/toolkit/mozapps/downloads/content/DownloadProgressListener.js,v  <--  DownloadProgressListener.js
new revision: 1.38; previous revision: 1.37
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
Verified FIXED using:

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008031904 Minefield/3.0b5pre

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031904 Minefield/3.0b5pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008031905 Minefield/3.0b5pre
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.