Last Comment Bug 564656 - "Warning: package error or possible missing or unnecessary file: ....app/Contents/Plug-Ins/ (package-manifest, ...)."
: "Warning: package error or possible missing or unnecessary file: ....app/Cont...
Status: VERIFIED FIXED
:
Product: MailNews Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: Thunderbird 12.0
Assigned To: Serge Gautherie (:sgautherie)
:
:
Mentors:
http://mxr.mozilla.org/comm-central/s...
Depends on: 353841 463605 530503 533891 713418 714042
Blocks: 385205 713134
  Show dependency treegraph
 
Reported: 2010-05-08 19:15 PDT by Serge Gautherie (:sgautherie)
Modified: 2012-01-01 06:43 PST (History)
8 users (show)
bugzillamozillaorg_serge_20140323: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
-


Attachments
fix v1.0 [This is (FF) part of bug 533891] (792 bytes, patch)
2010-05-10 21:50 PDT, Josh Aas
no flags Details | Diff | Splinter Review
(Av1 [SM]) Port bug 533891 [Checkin: See comment 18] (3.25 KB, patch)
2010-05-20 22:06 PDT, Serge Gautherie (:sgautherie)
kairo: review+
Details | Diff | Splinter Review
(Bv1) Package 'isp/dotmac.rdf' (773 bytes, patch)
2010-05-20 22:35 PDT, Serge Gautherie (:sgautherie)
kairo: review-
Details | Diff | Splinter Review
(Bv2) Stop uselessly building 'isp/dotmac.rdf' (907 bytes, patch)
2010-05-21 18:01 PDT, Serge Gautherie (:sgautherie)
no flags Details | Diff | Splinter Review
(Bv3) Get rid of obsolete 'dotmac.rdf' and 'googlemail.rdf' [Checkin: Comment 20] (8.97 KB, patch)
2010-05-22 09:39 PDT, Serge Gautherie (:sgautherie)
mnyromyr: review+
standard8: superreview+
Details | Diff | Splinter Review
(Cv1 [SM]) Remove existing 'dotmac.rdf' file too [Checkin: Comment 22] (780 bytes, patch)
2010-06-06 12:34 PDT, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Splinter Review
(Dv1-SM) Port bug 713418 (Stop packaging dead [XP_MACOSX] '/Contents/Plug-Ins/') [Checked in: Comment 28] (709 bytes, patch)
2011-12-30 05:57 PST, Serge Gautherie (:sgautherie)
bugspam.Callek: review+
Details | Diff | Splinter Review

Description Serge Gautherie (:sgautherie) 2010-05-08 19:15:59 PDT
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1273303800.1273311351.14500.gz&fulltext=1
OS X 10.5 comm-central-trunk nightly on 2010/05/08 00:30:00
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1273367846.1273370115.1970.gz&fulltext=1
OS X 10.5 comm-central-trunk build on 2010/05/08 18:17:26
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1273367846.1273368939.30689.gz&fulltext=1
OS X 10.5 comm-central-trunk leak test build on 2010/05/08 18:17:26
{
Warning: package error or possible missing or unnecessary file: SeaMonkey.app/Contents/Plug-Ins/ (package-manifest, 16).
}

Hopefully, the fix should be trivial.
I think this should be investigated/fixed asap, as it affects nightlies too.
Comment 1 Robert Kaiser 2010-05-10 06:06:55 PDT
As long as we don't know what's breaking without this being fixed (if anything), there's no criteria for making this block anything.
Comment 2 Serge Gautherie (:sgautherie) 2010-05-10 19:23:48 PDT
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273537541.1273540006.10470.gz&fulltext=1
OS X 10.5.2 mozilla-central build on 2010/05/10 17:25:41
{
Warning: package error or possible missing or unnecessary file: Minefield.app/Contents/Plug-Ins/ (package-manifest, 15).
}

It looks like FF, SM and TB are affected.
Comment 3 Josh Aas 2010-05-10 21:49:50 PDT
This is fallout from bug 533891. Need to remove the default plugin lines from "package-manifest.in".
Comment 4 Josh Aas 2010-05-10 21:50:30 PDT
Created attachment 444592 [details] [diff] [review]
fix v1.0
[This is (FF) part of bug 533891]

This will probably work.
Comment 5 Josh Aas 2010-05-10 22:09:24 PDT
The patch that caused this was backed out.
Comment 6 Serge Gautherie (:sgautherie) 2010-05-11 08:40:03 PDT
(In reply to comment #5)
> The patch that caused this was backed out.

Was it?

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1273571545.1273573676.5046.gz&fulltext=1
OS X 10.5.2 mozilla-central build on 2010/05/11 02:52:25
still reports this warning.
Comment 7 Serge Gautherie (:sgautherie) 2010-05-20 22:06:46 PDT
Created attachment 446659 [details] [diff] [review]
(Av1 [SM]) Port bug 533891
[Checkin: See comment 18]

removed-files.in:
I removed |#ifndef WINCE| because I'm not sure WINCE is defined, etc.
I (assume but) wonder if '.../DefaultPlugin' is enough to remove DefaultPlugin~.ppc and DefaultPlugin~.86 which this "directory" contains.
Comment 8 Serge Gautherie (:sgautherie) 2010-05-20 22:15:21 PDT
Comment on attachment 446659 [details] [diff] [review]
(Av1 [SM]) Port bug 533891
[Checkin: See comment 18]


Note that this patch is not trying to solve comment 0 warning...
Comment 9 Serge Gautherie (:sgautherie) 2010-05-20 22:35:41 PDT
Created attachment 446664 [details] [diff] [review]
(Bv1) Package 'isp/dotmac.rdf'

To fix package-compare
{
+SeaMonkey.app/Contents/MacOS/isp/dotmac.rdf
}
Comment 10 Robert Kaiser 2010-05-20 23:29:17 PDT
Comment on attachment 446664 [details] [diff] [review]
(Bv1) Package 'isp/dotmac.rdf'

From all I know, Mnyromyr and others explicitely vetoed packaging that and other such vendor-specific files being packaged and shipped in SeaMonkey. If you want to revert that decision, please ask Mnyromyr for it.
Comment 11 Serge Gautherie (:sgautherie) 2010-05-21 18:01:54 PDT
Created attachment 446854 [details] [diff] [review]
(Bv2) Stop uselessly building 'isp/dotmac.rdf'

Bv1, with comment 10 suggestion(s).
Comment 12 Mark Banner (:standard8, afk until Dec) 2010-05-22 00:47:45 PDT
(In reply to comment #11)
> Created an attachment (id=446854) [details]
> (Bv2) Stop uselessly building 'isp/dotmac.rdf'

!suite, !thunderbird.... c'mon it must be time for that to die completely :-)
Comment 13 Robert Kaiser 2010-05-22 06:38:36 PDT
Comment on attachment 446854 [details] [diff] [review]
(Bv2) Stop uselessly building 'isp/dotmac.rdf'

I really want Karsten to review this as the SeaMonkey mailnews owner.
Comment 14 Serge Gautherie (:sgautherie) 2010-05-22 09:39:56 PDT
Created attachment 446895 [details] [diff] [review]
(Bv3) Get rid of obsolete 'dotmac.rdf' and 'googlemail.rdf'
[Checkin: Comment 20]

Bv2, with comment 12 suggestion(s).
Comment 15 Robert Kaiser 2010-05-24 06:10:26 PDT
Comment on attachment 446659 [details] [diff] [review]
(Av1 [SM]) Port bug 533891
[Checkin: See comment 18]

>+#elifdef XP_MACOSX
>+plugins/DefaultPlugin.plugin/Contents/Resources/English.lproj/InfoPlist.strings
>+plugins/DefaultPlugin.plugin/Contents/Resources/English.lproj/
>+plugins/DefaultPlugin.plugin/Contents/Resources/plugin.png
>+plugins/DefaultPlugin.plugin/Contents/Resources/
>+plugins/DefaultPlugin.plugin/Contents/MacOS/DefaultPlugin
>+plugins/DefaultPlugin.plugin/Contents/MacOS/
>+plugins/DefaultPlugin.plugin/Contents/Info.plist
>+plugins/DefaultPlugin.plugin/Contents/
>+plugins/DefaultPlugin.plugin/

Please turn around the order of those to be alphabetical and from the less deep to the deeper paths, just like in http://hg.mozilla.org/mozilla-central/file/tip/browser/installer/removed-files.in#l712

With that, r=me.
Comment 16 Serge Gautherie (:sgautherie) 2010-05-24 08:59:54 PDT
(In reply to comment #15)
> Please turn around the order of those to be alphabetical and from the less deep
> to the deeper paths, just like in
> http://hg.mozilla.org/mozilla-central/file/tip/browser/installer/removed-files.in#l712

I saw what FF did, but isn't it "better" to list (= remove) the deepest files and directories first ? Or does it work the same anyway ?
Comment 17 Robert Kaiser 2010-05-24 09:59:58 PDT
(In reply to comment #16)
> I saw what FF did, but isn't it "better" to list (= remove) the deepest files
> and directories first ? Or does it work the same anyway ?

I have no idea how the algorithm actually works, and we've been doing things this way all the time, so let's stick to it. If the order does matter in the way you imply, we'd have a number of real bugs around, I guess...
Comment 18 Serge Gautherie (:sgautherie) 2010-05-25 05:15:17 PDT
Comment on attachment 446659 [details] [diff] [review]
(Av1 [SM]) Port bug 533891
[Checkin: See comment 18]


http://hg.mozilla.org/comm-central/rev/c5bd60ab7eac
Av1, with comment 15 suggestion(s).
Comment 19 Karsten Düsterloh 2010-06-06 07:35:09 PDT
Comment on attachment 446895 [details] [diff] [review]
(Bv3) Get rid of obsolete 'dotmac.rdf' and 'googlemail.rdf'
[Checkin: Comment 20]

Yeah, .Mac is dead since mid 2008 (or rather has been replaced by MobileMe).
We shipped .Mac in recent years only because "we always did".
Comment 20 Serge Gautherie (:sgautherie) 2010-06-06 12:10:57 PDT
Comment on attachment 446895 [details] [diff] [review]
(Bv3) Get rid of obsolete 'dotmac.rdf' and 'googlemail.rdf'
[Checkin: Comment 20]


http://hg.mozilla.org/comm-central/rev/c6c096edf0bf
Comment 21 Serge Gautherie (:sgautherie) 2010-06-06 12:34:55 PDT
Created attachment 449540 [details] [diff] [review]
(Cv1 [SM]) Remove existing 'dotmac.rdf' file too
[Checkin: Comment 22]

Remove file packaged before SeaMonkey had a MacOSX manifest.
Comment 22 Serge Gautherie (:sgautherie) 2010-06-06 21:15:52 PDT
Comment on attachment 449540 [details] [diff] [review]
(Cv1 [SM]) Remove existing 'dotmac.rdf' file too
[Checkin: Comment 22]


http://hg.mozilla.org/comm-central/rev/dde58b518386
Comment 23 Serge Gautherie (:sgautherie) 2010-08-08 09:23:23 PDT
(In reply to comment #8)
> Note that this patch is not trying to solve comment 0 warning...

(In reply to comment #3)
> This is fallout from bug 533891. Need to remove the default plugin lines from
> "package-manifest.in".

Fwiw, this remains to be fixed.
Comment 24 jag (Peter Annema) 2011-03-10 11:08:08 PST
Is there anything more to do than to remove http://hg.mozilla.org/mozilla-central/annotate/6a898157f842/browser/installer/package-manifest.in#l17 ? The only other file that references that directory is browser/installer/removed-files.in, with those lines added there for bug 520494 where the PrintPDE plugin was removed.
Comment 25 Serge Gautherie (:sgautherie) 2011-12-30 05:55:06 PST
(In reply to jag (Peter Annema) from comment #24)
> Is there anything more to do than to remove
> http://hg.mozilla.org/mozilla-central/annotate/6a898157f842/browser/
> installer/package-manifest.in#l17 ?

FF bug 713418 removed it.
TB bug 714042 removed it.
Comment 26 Serge Gautherie (:sgautherie) 2011-12-30 05:57:41 PST
Created attachment 584953 [details] [diff] [review]
(Dv1-SM) Port bug 713418 (Stop packaging dead [XP_MACOSX] '/Contents/Plug-Ins/')
[Checked in: Comment 28]
Comment 27 Justin Wood (:Callek) 2011-12-30 10:23:47 PST
Comment on attachment 584953 [details] [diff] [review]
(Dv1-SM) Port bug 713418 (Stop packaging dead [XP_MACOSX] '/Contents/Plug-Ins/')
[Checked in: Comment 28]

Review of attachment 584953 [details] [diff] [review]:
-----------------------------------------------------------------

Lets (finally) close this bug
Comment 28 Serge Gautherie (:sgautherie) 2011-12-30 11:04:34 PST
Comment on attachment 584953 [details] [diff] [review]
(Dv1-SM) Port bug 713418 (Stop packaging dead [XP_MACOSX] '/Contents/Plug-Ins/')
[Checked in: Comment 28]

http://hg.mozilla.org/comm-central/rev/48f14d18ad22
Comment 29 Serge Gautherie (:sgautherie) 2012-01-01 06:39:38 PST
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1325277552.1325281890.18814.gz&fulltext=1
OS X 10.5 comm-central-trunk leak test build on 2011/12/30 12:39:12
http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1325301669.1325311691.15226.gz&fulltext=1
OS X 10.6 comm-central-trunk build on 2011/12/30 19:21:09

V.Fixed

Note You need to log in before you can comment on or make changes to this bug.