We need to update Orion to use the newer code from Eclipse.
Created attachment 566218 [details] [diff] [review] proposed patch This is the proposed patch. Changes: - fixed bug 678995 and bug 680375 by adding padding to the line gutter. - fixed bug 680509 - now Orion highlights the current line by default. - partial fix for bug 680465: Orion now recognizes /* comments */ in CSS. Some properties are still unrecognized and // comments are still highlighted, which is wrong and confusing. - see bug 681360 comment 1. - fixes for bug 684862, bug 685925, bug 687565, bug 687850, bug 687855 and bug 689559. This patch doesn't fix: bug 687573, bug 687577, bug 687580, bug 687861. Before we can enable Orion by default I would suggest we fix: bug 687573, bug 687577 and 687580. Thoughts? Looking forward for your review!
Comment on attachment 566218 [details] [diff] [review] proposed patch oh noe! tabs! r+ with a successful run through try.
Created attachment 566503 [details] [diff] [review] updated patch - test fixes Rob, thank you for the r+! Updated the patch to include more test fixes, this time for the textarea fallback. The cut/copy/paste event handling became async in Orion. In the previous patch I did address those changes, but it looks like I broke the testing for the textarea fallback. Fixed this now, in this patch. Patch also pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=600398ece62a
looks good! Thanks!
Comment on attachment 566503 [details] [diff] [review] updated patch - test fixes >--- /dev/null >+++ b/browser/devtools/sourceeditor/orion/mozilla.css >@@ -0,0 +1,11 @@ >+/* Any copyright is dedicated to the Public Domain. >+ http://creativecommons.org/publicdomain/zero/1.0/ */ Mozilla code is supposed to use the MPL.
(In reply to Dão Gottwald [:dao] from comment #7) > Comment on attachment 566503 [details] [diff] [review] [diff] [details] [review] > updated patch - test fixes > > >--- /dev/null > >+++ b/browser/devtools/sourceeditor/orion/mozilla.css > >@@ -0,0 +1,11 @@ > >+/* Any copyright is dedicated to the Public Domain. > >+ http://creativecommons.org/publicdomain/zero/1.0/ */ > > Mozilla code is supposed to use the MPL. True. I thought the code is minimal enough to not need the whole MPL boilerplate. Much bigger than the CSS itself. Shall I make a patch to switch to MPL? (thanks for checking out the patch!)