Closed
Bug 692807
Opened 13 years ago
Closed 13 years ago
Update the code from Orion upstream
Categories
(DevTools :: General, defect)
DevTools
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 10
People
(Reporter: msucan, Assigned: msucan)
References
Details
(Whiteboard: [sourceeditor][orion][fixed-in-fx-team])
Attachments
(1 file, 1 obsolete file)
216.10 KB,
patch
|
Details | Diff | Splinter Review |
We need to update Orion to use the newer code from Eclipse.
Assignee | ||
Updated•13 years ago
|
Whiteboard: [sourceeditor][orion]
Assignee | ||
Comment 1•13 years ago
|
||
This is the proposed patch. Changes: - fixed bug 678995 and bug 680375 by adding padding to the line gutter. - fixed bug 680509 - now Orion highlights the current line by default. - partial fix for bug 680465: Orion now recognizes /* comments */ in CSS. Some properties are still unrecognized and // comments are still highlighted, which is wrong and confusing. - see bug 681360 comment 1. - fixes for bug 684862, bug 685925, bug 687565, bug 687850, bug 687855 and bug 689559. This patch doesn't fix: bug 687573, bug 687577, bug 687580, bug 687861. Before we can enable Orion by default I would suggest we fix: bug 687573, bug 687577 and 687580. Thoughts? Looking forward for your review!
Comment 2•13 years ago
|
||
Comment on attachment 566218 [details] [diff] [review] proposed patch oh noe! tabs! r+ with a successful run through try.
Attachment #566218 -
Flags: review?(rcampbell) → review+
Assignee | ||
Comment 3•13 years ago
|
||
Rob, thank you for the r+! Updated the patch to include more test fixes, this time for the textarea fallback. The cut/copy/paste event handling became async in Orion. In the previous patch I did address those changes, but it looks like I broke the testing for the textarea fallback. Fixed this now, in this patch. Patch also pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=600398ece62a
Attachment #566218 -
Attachment is obsolete: true
Comment 4•13 years ago
|
||
looks good! Thanks!
Whiteboard: [sourceeditor][orion] → [sourceeditor][orion][land-in-fx-team]
Comment 5•13 years ago
|
||
https://hg.mozilla.org/integration/fx-team/rev/a67b2587a4cc
Whiteboard: [sourceeditor][orion][land-in-fx-team] → [sourceeditor][orion][fixed-in-fx-team]
Comment 6•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a67b2587a4cc
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 10
Comment 7•13 years ago
|
||
Comment on attachment 566503 [details] [diff] [review] updated patch - test fixes >--- /dev/null >+++ b/browser/devtools/sourceeditor/orion/mozilla.css >@@ -0,0 +1,11 @@ >+/* Any copyright is dedicated to the Public Domain. >+ http://creativecommons.org/publicdomain/zero/1.0/ */ Mozilla code is supposed to use the MPL.
Assignee | ||
Comment 8•13 years ago
|
||
(In reply to Dão Gottwald [:dao] from comment #7) > Comment on attachment 566503 [details] [diff] [review] [diff] [details] [review] > updated patch - test fixes > > >--- /dev/null > >+++ b/browser/devtools/sourceeditor/orion/mozilla.css > >@@ -0,0 +1,11 @@ > >+/* Any copyright is dedicated to the Public Domain. > >+ http://creativecommons.org/publicdomain/zero/1.0/ */ > > Mozilla code is supposed to use the MPL. True. I thought the code is minimal enough to not need the whole MPL boilerplate. Much bigger than the CSS itself. Shall I make a patch to switch to MPL? (thanks for checking out the patch!)
Updated•6 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•