Last Comment Bug 793781 - In-product MooTools 1.2.x fix
: In-product MooTools 1.2.x fix
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Trunk
: All All
-- normal (vote)
: ---
Assigned To: :Benjamin Peterson
: Jason Orendorff [:jorendorff]
Depends on: 789036
Blocks: harmony:stringextras
  Show dependency treegraph
Reported: 2012-09-24 11:08 PDT by Alex Keybl [:akeybl]
Modified: 2013-03-02 11:31 PST (History)
18 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

disable (8.17 KB, patch)
2012-10-02 14:55 PDT, :Benjamin Peterson
luke: review+
akeybl: approval‑mozilla‑aurora+
Details | Diff | Splinter Review

Description User image Alex Keybl [:akeybl] 2012-09-24 11:08:33 PDT
Perform the necessary disable of bug 772733 until the effect of TE outreach in bug 789036 rolls out across the web.

+++ This bug was initially created as a clone of Bug #789036 +++

This is a meta bug for breakage caused by bug 772733's addition of String.prototype.contains. MooTools defines a incompatible version of String.prototype.contains. Versions of MooTools greater than 1.2 override the builtin implementation, but 1.2.x assumes it is a compatible implementation. Upgrading to any later version of MooTools fixes the problem.

A MooTools bug has been filed:
Comment 1 User image Luke Wagner [:luke] 2012-10-01 16:53:38 PDT
Benjamin: I haven't really been following this MooTools stuff; would you like to land the disabling patch?  I can do it if you're busy.
Comment 2 User image Luke Wagner [:luke] 2012-10-01 16:59:52 PDT
n/m, I might as well do it.
Comment 3 User image :Benjamin Peterson 2012-10-01 17:07:52 PDT
I can do it; it's trivial, though, so I had put it on backburner.
Comment 4 User image Luke Wagner [:luke] 2012-10-01 17:14:02 PDT
It wasn't clear in bug 789036: what version(s) should 'contains' be disabled on?
Comment 5 User image :Benjamin Peterson 2012-10-01 17:15:25 PDT
Comment 6 User image Luke Wagner [:luke] 2012-10-01 17:19:39 PDT
If there are any FF chrome JS uses, were you planning to keep a prefixed 'mozContains' or something else?
Comment 7 User image :Benjamin Peterson 2012-10-01 17:39:43 PDT
I don't think there are any in 17 (running Try now to find out).
Comment 8 User image David Mandelin [:dmandelin] 2012-10-02 11:27:21 PDT
FYI - we should really do this before it hits Beta, which means landing this week. So please let me know if something comes up and you're not going to be able to get it in that time.
Comment 9 User image :Benjamin Peterson 2012-10-02 14:55:10 PDT
Created attachment 667187 [details] [diff] [review]
Comment 10 User image Luke Wagner [:luke] 2012-10-02 15:08:35 PDT
Comment on attachment 667187 [details] [diff] [review]

Thanks!  (I wish the wild wild webz were more appreciative of your hard work :)
Comment 11 User image Alex Keybl [:akeybl] 2012-10-03 15:19:38 PDT
Comment on attachment 667187 [details] [diff] [review]

Thanks for pulling this together - there's a good chance we'll also disable again for FF18 (and up) unless a TE effort works out.
Comment 13 User image Alex Keybl [:akeybl] 2012-11-12 15:59:07 PST
Let's land this fix on central/aurora. There's little chance that 6 weeks will change the situation here, since many sites won't have upgraded. I'd rather not revisit each release.
Comment 14 User image :Benjamin Peterson 2012-11-12 21:33:41 PST
It's not quite that easy, since usage of .contains() in the browser has been growing like weeds.
Comment 15 User image Alex Keybl [:akeybl] 2012-12-10 17:00:12 PST
Spoke with Ben, we'll try to do as much outreach as possible, and be on the lookout for web regressions with support here.
Comment 16 User image David Weir (satdav) 2013-02-10 10:02:40 PST
Firefox 20 added to the list
Comment 17 User image :Benjamin Peterson 2013-03-02 11:27:31 PST
Don't need this bug anymore.
Comment 18 User image Tom Schuster [:evilpie] 2013-03-02 11:31:38 PST
Can we also remove this from the release notes?

Note You need to log in before you can comment on or make changes to this bug.