793781 - In-product MooTools 1.2.x fix

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Alex Keybl [:akeybl]]

Perform the necessary disable of bug 772733 until the effect of TE outreach in bug 789036 rolls out across the web.

+++ This bug was initially created as a clone of Bug #789036 +++

This is a meta bug for breakage caused by bug 772733's addition of String.prototype.contains. MooTools defines a incompatible version of String.prototype.contains. Versions of MooTools greater than 1.2 override the builtin implementation, but 1.2.x assumes it is a compatible implementation. Upgrading to any later version of MooTools fixes the problem.

A MooTools bug has been filed:
https://github.com/mootools/mootools-core/issues/2402

Comment 1

[Luke Wagner [:luke]]

Benjamin: I haven't really been following this MooTools stuff; would you like to land the disabling patch?  I can do it if you're busy.

Comment 2

[Luke Wagner [:luke]]

n/m, I might as well do it.

Comment 3

[:Benjamin Peterson]

I can do it; it's trivial, though, so I had put it on backburner.

Comment 4

[Luke Wagner [:luke]]

It wasn't clear in bug 789036: what version(s) should 'contains' be disabled on?

Comment 5

[:Benjamin Peterson]

17

Comment 6

[Luke Wagner [:luke]]

If there are any FF chrome JS uses, were you planning to keep a prefixed 'mozContains' or something else?

Comment 7

[:Benjamin Peterson]

I don't think there are any in 17 (running Try now to find out).

Comment 8

[David Mandelin [:dmandelin]]

FYI - we should really do this before it hits Beta, which means landing this week. So please let me know if something comes up and you're not going to be able to get it in that time.

Comment 9

[:Benjamin Peterson]

Attachment: disable

Comment 10

[Luke Wagner [:luke]]

Comment on attachment 667187 [details] [diff] [review]
disable

Thanks!  (I wish the wild wild webz were more appreciative of your hard work :)

Comment 11

[Alex Keybl [:akeybl]]

Comment on attachment 667187 [details] [diff] [review]
disable

Thanks for pulling this together - there's a good chance we'll also disable again for FF18 (and up) unless a TE effort works out.

Comment 12

[:Benjamin Peterson]

https://hg.mozilla.org/releases/mozilla-aurora/rev/086db97198a8

Comment 13

[Alex Keybl [:akeybl]]

Let's land this fix on central/aurora. There's little chance that 6 weeks will change the situation here, since many sites won't have upgraded. I'd rather not revisit each release.

Comment 14

[:Benjamin Peterson]

It's not quite that easy, since usage of .contains() in the browser has been growing like weeds.

Comment 15

[Alex Keybl [:akeybl]]

Spoke with Ben, we'll try to do as much outreach as possible, and be on the lookout for web regressions with support here.

Comment 16

[David Weir (satdav)]

Firefox 20 added to the list

Comment 17

[:Benjamin Peterson]

Don't need this bug anymore.

Comment 18

[Tom S]

Can we also remove this from the release notes?
https://www.mozilla.org/en-US/firefox/21.0a2/auroranotes/