Closed Bug 793781 Opened 8 years ago Closed 7 years ago

In-product MooTools 1.2.x fix

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Tracking Status
firefox17 + fixed
firefox18 + wontfix
firefox19 + wontfix
firefox20 --- affected

People

(Reporter: akeybl, Assigned: Benjamin)

References

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Perform the necessary disable of bug 772733 until the effect of TE outreach in bug 789036 rolls out across the web.

+++ This bug was initially created as a clone of Bug #789036 +++

This is a meta bug for breakage caused by bug 772733's addition of String.prototype.contains. MooTools defines a incompatible version of String.prototype.contains. Versions of MooTools greater than 1.2 override the builtin implementation, but 1.2.x assumes it is a compatible implementation. Upgrading to any later version of MooTools fixes the problem.

A MooTools bug has been filed:
https://github.com/mootools/mootools-core/issues/2402
Benjamin: I haven't really been following this MooTools stuff; would you like to land the disabling patch?  I can do it if you're busy.
n/m, I might as well do it.
I can do it; it's trivial, though, so I had put it on backburner.
It wasn't clear in bug 789036: what version(s) should 'contains' be disabled on?
17
If there are any FF chrome JS uses, were you planning to keep a prefixed 'mozContains' or something else?
I don't think there are any in 17 (running Try now to find out).
No longer depends on: 781796, 786584, 788483, 790462, 791980, 784280, 789093
Assignee: luke → benjamin
FYI - we should really do this before it hits Beta, which means landing this week. So please let me know if something comes up and you're not going to be able to get it in that time.
Attached patch disableSplinter Review
Attachment #667187 - Flags: review?(luke)
Attachment #667187 - Flags: approval-mozilla-aurora?
Comment on attachment 667187 [details] [diff] [review]
disable

Thanks!  (I wish the wild wild webz were more appreciative of your hard work :)
Attachment #667187 - Flags: review?(luke) → review+
Comment on attachment 667187 [details] [diff] [review]
disable

Thanks for pulling this together - there's a good chance we'll also disable again for FF18 (and up) unless a TE effort works out.
Attachment #667187 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
https://hg.mozilla.org/releases/mozilla-aurora/rev/086db97198a8
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → NEW
Whiteboard: [js:t]
Let's land this fix on central/aurora. There's little chance that 6 weeks will change the situation here, since many sites won't have upgraded. I'd rather not revisit each release.
It's not quite that easy, since usage of .contains() in the browser has been growing like weeds.
Spoke with Ben, we'll try to do as much outreach as possible, and be on the lookout for web regressions with support here.
Firefox 20 added to the list
Don't need this bug anymore.
Status: NEW → RESOLVED
Closed: 8 years ago7 years ago
Resolution: --- → FIXED
Can we also remove this from the release notes?
https://www.mozilla.org/en-US/firefox/21.0a2/auroranotes/
You need to log in before you can comment on or make changes to this bug.