947261 - Regression: Gap above the first row of icons in the menu

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Attachment: Nightly (12/06) - Screenshot

See screenshot.

--
Nightly (12/06), LG Nexus 4 (Android 4.4)

Comment 1

[Wesley Johnston (:wesj)]

Just a wild guess, but this is probably from bug 936756.

Comment 2

[Richard Newman [:rnewman]]

Looks like the sharing bar disappeared. Sriram, Lucas?

The l10n switching code shouldn't be involved unless you've changed a locale.

Comment 3

[Richard Newman [:rnewman]]

Works in 2013-12-05 Nightly.

Broken in 2013-12-06 Nightly.

My screenshot: https://dl.dropboxusercontent.com/u/3911373/Fennec/Screenshot_2013-12-06-10-19-25.png

Comment 4

[Richard Newman [:rnewman]]

Candidates:

changeset:   159141:8bba470af6ef
parent:      159140:861db7473c26
parent:      159032:2831368a5e05
user:        Ryan VanderMeulen <[e-mail]>
date:        Thu Dec 05 17:55:47 2013 -0500
summary:     Merge m-c to b2g-inbound.

changeset:   159135:871fab42fa64
user:        Mark Finkle <[e-mail]>
date:        Fri Dec 06 01:41:50 2013 -0500
summary:     Backout f118b840cabe, 8f90c8059733, d440fa8a1568 because bug 946074 breaks a test

changeset:   159134:2c42e70b08c2
user:        Wes Johnston <[e-mail]>
date:        Thu Dec 05 22:32:11 2013 -0800
summary:     Bug 943513 - Lazy load animation time. r=lucasr

changeset:   159131:d440fa8a1568
user:        Mark Finkle <[e-mail]>
date:        Thu Dec 05 23:50:23 2013 -0500
summary:     Bug 943475 - Predictive lookup for awesomebar entries r=rnewman

changeset:   159130:8f90c8059733
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 23:50:13 2013 -0500
summary:     Bug 933739 - Use given search term in handleAutocomplete, not mSearchTerm (r=bnicholson)

changeset:   159129:f118b840cabe
user:        Richard Newman <[e-mail]>
date:        Tue Dec 03 22:02:28 2013 -0800
summary:     Bug 946074 - Awesomebar cursor processing is inefficient. r=mfinkle

changeset:   159077:2b398758366c
parent:      159076:fbc0b4c30fd0
parent:      159032:2831368a5e05
user:        Ryan VanderMeulen <[e-mail]>
date:        Thu Dec 05 17:56:44 2013 -0500
summary:     Merge m-c to inbound.

changeset:   159034:258bb2ea7c1a
user:        Mike Hommey <[e-mail]>
date:        Fri Dec 06 08:45:29 2013 +0900
summary:     Bug 946576 - Disable unified builds on b2g and xulrunner builds, and android debug builds. r=ehsan

changeset:   158991:fb87b500de16
user:        Margaret Leibovic <[e-mail]>
date:        Thu Dec 05 12:43:22 2013 -0800
summary:     Bug 946486 - Don't cache "browser.snippets.enabled" value. r=bnicholson

changeset:   158990:1810169dc57f
user:        Margaret Leibovic <[e-mail]>
date:        Thu Dec 05 11:13:42 2013 -0800
summary:     Bug 946802 - Update bing icon to new triangular icon. r=mfinkle

changeset:   158984:2ae327cecde6
user:        Mark Finkle <[e-mail]>
date:        Thu Dec 05 12:08:55 2013 -0500
summary:     Bug 946779 - Disable history in the hidden reader <browser> element r=lucasr

changeset:   158983:fbc58d273b9c
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 16:26:36 2013 +0000
summary:     Bug 935473 - Change animateForwardButton() to take an animation argument (r=wesj)

changeset:   158982:1353c0a6159a
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 16:26:35 2013 +0000
summary:     Bug 935473 - Add comment explaining animateForwardButton's behaviour (r=wesj)

changeset:   158981:a2e2a341e543
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 16:26:35 2013 +0000
summary:     Bug 935473 - Change updateBackButton/updateForwardButton to take a Tab argument (r=wesj)

changeset:   158980:dfe673e83ebc
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 16:26:35 2013 +0000
summary:     Bug 935473 - Update forward button visibility when exiting editing mode (r=wesj)

changeset:   158979:2c343bc88009
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 16:26:35 2013 +0000
summary:     Bug 935473 - Factor out method to animate forward button's visibility (r=wesj)

changeset:   158978:8e6348162cc2
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 16:26:35 2013 +0000
summary:     Bug 935473 - Avoid unnecessary animations in forward button (r=wesj)

changeset:   158977:b3128b3dc02d
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 16:26:34 2013 +0000
summary:     Bug 935473 - Replace ViewGroup.MarginLayoutParams with MarginLayoutParams (r=sriram)

changeset:   158971:2bd207736d7b
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 11:16:45 2013 +0000
summary:     Bug 945375 - Unconditionally return mSubmenu in GeckoMenuItem.getSubMenu() (r=rnewman)

changeset:   158878:632ee65fb67f
parent:      158859:056164bcce96
parent:      158877:9473d7b659e9
user:        Carsten "Tomcat" Book <[e-mail]>
date:        Thu Dec 05 12:56:11 2013 +0100
summary:     merge fx-team to m-c

changeset:   158874:4d64a37dac18
user:        Wes Johnston <[e-mail]>
date:        Wed Dec 04 21:20:19 2013 -0800
summary:     Bug 942680 - Place search pane below actionbar. r=lucasr

changeset:   158873:d379a9103c5b
user:        Wes Johnston <[e-mail]>
date:        Wed Dec 04 08:35:58 2013 -0800
summary:     Bug 943513 - Update visual style of action modes. r=lucasr

changeset:   158869:a7c9340f5a34
user:        Michael Comella <[e-mail]>
date:        Wed Dec 04 18:32:53 2013 -0800
summary:     Bug 910859 - Part 4: Add Proguard annotations. r=ckitching

changeset:   158868:cedb942aa081
user:        Michael Comella <[e-mail]>
date:        Wed Dec 04 18:32:53 2013 -0800
summary:     Bug 910859 - Part 3: Add missing go button work around. r=lucasr

changeset:   158867:db9eae6662a0
user:        Michael Comella <[e-mail]>
date:        Wed Dec 04 18:32:53 2013 -0800
summary:     Bug 910859 - Part 2: Wait for DOMTitleChanged event in waitForPageLoad. r=lucasr

changeset:   158866:b3096c58816b
user:        Michael Comella <[e-mail]>
date:        Wed Dec 04 18:32:53 2013 -0800
summary:     Bug 910859 - Bootstrap new API for UI testing in Fennec. r=lucasr,gbrown

Comment 5

[Richard Newman [:rnewman]]

Bisecting now.

Comment 6

[Kevin Brosnan [Ex-Mozilla]]

Inbound builds exist ftp://ftp.mozilla.org/pub/mobile/tinderbox-builds/mozilla-inbound-android/ this will get to a specific checkin in most cases.

Comment 7

[Richard Newman [:rnewman]]

I can't reproduce this on current fx-team, and bisection led nowhere (a gaia pushbot commit).

Comment 8

[Richard Newman [:rnewman]]

I'm no longer able to reproduce this with any local build. Still shows up on my default Nightly with full profile, though.

Can someone else bisect this?

There are only two commits that touch /m/a/b/menu:

changeset:   158971:2bd207736d7b
user:        Lucas Rocha <[e-mail]>
date:        Thu Dec 05 11:16:45 2013 +0000
summary:     Bug 945375 - Unconditionally return mSubmenu in GeckoMenuItem.getSubMenu() (r=rnewman)

changeset:   158873:d379a9103c5b
user:        Wes Johnston <[e-mail]>
date:        Wed Dec 04 08:35:58 2013 -0800
summary:     Bug 943513 - Update visual style of action modes. r=lucasr

Comment 9

[u421692]

regression window mozilla-inbound:
1386008090 - good build 
1386009805 - bad build
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=5dc0d8f19d26&tochange=ca4c295c9454

Comment 10

[u421692]

The regression window from comment 9 may not be a valid regression window, since the issue not consistently reproducing. I will look further into this.

Comment 11

[Aaron Train [:aaronmt]]

You can try using fx-team builds. I also see this on latest-holly-android.

Comment 12

[u421692]

INBOUND:
1385997226 - GOOD
1385998492 - BAD
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=70fde224f3d1&tochange=2be8f1640e21
FXTEAM:
1385963806 - GOOD
1385998848 - BAD
http://hg.mozilla.org/integration/fx-team/pushloghtml?fromchange=9cbe6533c480&tochange=2581b84e0ca1

Unfortunately, no luck, the regression range window is to big.
On holly-android, I don't think we can create a pushlog.

Comment 13

[Lucas Rocha (:lucasr)]

I can have a look at this if no one else does it before I'm back from holidays. Sriram, feel free to pick this up if you want.

Comment 14

[Richard Newman [:rnewman]]

Really? None of those changes seem relevant.

Comment 15

[Aaron Train [:aaronmt]]

Also reproducible on the Galaxy Note II (Android 4.1)

Comment 16

[Richard Newman [:rnewman]]

I can only reproduce this with my locale-switcher add-on installed. Looks like the share/actionbar stuff doesn't interact nicely with when I rebuild the menu on locale change: it adds a row each time.

Comment 17

[Richard Newman [:rnewman]]

I have a fix for this. GeckoMenu.clear() needs the same removal code for mActionItemBarPresenter as has removeItem().

Comment 18

[Richard Newman [:rnewman]]

Attachment: Ensure that mActionItemBarPresenter is removed from the menu when cleared. v1

This seems to work for me. Please test!

Comment 19

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/fx-team/rev/fb2697d854d0

Let's verify this, then request uplift.

Flagging Aaron to take a look when this hits Nightly

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fb2697d854d0

Comment 21

[Aaron Train [:aaronmt]]

Aurora plz.

Comment 22

[Richard Newman [:rnewman]]

Comment on attachment 8348581 [details] [diff] [review]
Ensure that mActionItemBarPresenter is removed from the menu when cleared. v1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
  Recent action bar work.

User impact if declined: 
  Gap at the top of the menu, possibly only in certain add-on/locale situations (unclear whether this repros without locale switching installed).

Testing completed (on m-c, etc.): 
  Verified on m-c.

Risk to taking this patch (and alternatives if risky): 
  Low.

String or IDL/UUID changes made by this patch:
  None.

Comment 23

[Richard Newman [:rnewman]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/1be80da4f90d

Comment 24

[Ioana Chiorean]

Removing the tag as per Comment #12