Closed Bug 947916 Opened 12 years ago Closed 12 years ago

"Couldn't load XPCOM" & missing pgort100.dll after updating Nightly (2013-12-9)

Categories

(Firefox Build System :: General, defect)

All
Windows 7
defect
Not set
blocker

Tracking

(firefox28 verified)

VERIFIED FIXED
mozilla28
Tracking Status
firefox28 --- verified

People

(Reporter: gcp, Assigned: glandium)

References

Details

I was prompted to do the normal Nightly update. After clicking apply, Firefox errored out on restart with a "Couldn't load XPCOM" error, followed by a "couldn't find pgort100.dll" error. The installation appeared to be completely busted with no way of recovering. I downloaded a fresh Nightly off mozilla.org. I zipped up the broken Nightly dir in program files. Some reading suggests the XPCOM error is due to not finding xul.dll, however that file is present.
>I downloaded a fresh Nightly off mozilla.org. That should've said "I downloaded a fresh Nightly with Chrome and installed that to recover".
The problem is reproducible. Allowing the 8-12 Nightly to update always busts. If other people hit this we should disable updates?
Severity: critical → blocker
Respins are going with bug 945042 backed out. Should fix this.
Assignee: nobody → mh+mozilla
Blocks: 945042
Target Milestone: --- → mozilla28
Depending bug points to it being actual Firefox bustage, switching component.
Component: Application Update → Build Config
Product: Toolkit → Core
Hardware: x86_64 → All
Summary: "Couldn't load XPCOM" after updating Nightly (2013-12-9) → "Couldn't load XPCOM" & missing pgort100.dll after updating Nightly (2013-12-9)
We also hit this but without updating anything, I managed to reproduce it simply by installing the latest nightly from FTP. Here is the pushlog responsible: http://hg.mozilla.org/mozilla-central/pushloghtml?changeset=0204febd3146 Also here is the last good tinderbox build: ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win32/1386578102/ And the first bad tindebox build: ftp://ftp.mozilla.org/pub/firefox/tinderbox-builds/mozilla-central-win32/1386586922/
The Nightly itself is busted, see comment 4. The cause is a bad commit from bug 945042.
Posted the following in 947932 Same happening here, except system is XP SP3, fully updated. Used Help > About Firefox to update Firefox (Australis) 28.0a1 this morning. Message on Firefox restart (note: did not get ref to XPCOM though I heard 2 distinct audible signals): The application has failed to start because pgort100.dll was not found. Reinstalling the application may fix the problem. What I tried: 1 Uninstalled 12-09-2013 update to Firefox 28.0a1 leaving profile 2 Download and reinstalled 12-09-2013 full installer 3 Same problem. 4 Downloaded 12-08-2013 full installer, installed over the top of 12-09-2013 5 Started Firefox and 12-08-2013 update worked 6 Ran update (to 12-09-2013) using Help > About Firefox and same error message on startup of Firefox 7 Ran full installer of 12-08-2013 over the top of 12-09-2013 and restart worked. Problem appears to be with something in 12-09-2013 update/installer for Firefox (Australis) 28.0a1.
Today Firefox Nightly is broken On Windows 8.1 Pro x64 too
Flags: a11y-review+
Fixed in the respun Nightly, by this backout: https://hg.mozilla.org/mozilla-central/rev/9f12a9fab080 According to bug 947965 updates are now reenabled.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
I'm curious as to why this happened. Should bug 945042 have landed on inbound and/or pushed to try prior to landing on central? Would doing so have caught this in automated testing prior to getting into Nightlies or is there not currently an automated way to test and catch build breakage like this from changes like this? (I'm not all too familiar with this stuff so please do tell me if I've horribly confused something in this comment; this just made me curious about the procedures here)
The problem was indeed that that bug shouldn't have landed on mozilla-central. The tests caught it correctly.
Arguably, nightlies shouldn't be created on changesets without pgo runs.
(In reply to comment #15) > Arguably, nightlies shouldn't be created on changesets without pgo runs. Please propose that somewhere? That's not how our Nightlies are currently built as far as I understand.
(In reply to :Ehsan Akhgari (needinfo? me!) from comment #17) > (In reply to comment #15) > > Arguably, nightlies shouldn't be created on changesets without pgo runs. > > Please propose that somewhere? That's not how our Nightlies are currently > built as far as I understand. I thought it was the case. Or at least in the past.
Gian-Carlo, please confirm this is now fixed for you.
Flags: needinfo?(gpascutto)
The respun Nightly fixed it for me.
Flags: needinfo?(gpascutto)
Thank you, Gian-Carlo.
Status: RESOLVED → VERIFIED
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.