985024 - Show all bookmarks should not scroll with the bookmarks menu contents (so that we can finally stop showing "show all bookmarks" / "manage bookmarks" twice in the same menu)

Status: NEW

(Firefox :: Bookmarks & History, defect, P3)

Description

[Marco Bonardo [:mak]]

The issue here is that users think we removed:
- the Library
- the backups
- the possibility to export html
- undo / redo
cause now Show all bookmarks is at the bottom of the Bookmarks panel, and on commonly long menus, it's out of the view. These users are unlikely to know about an exotic arrowscrollbox.

We need to change the places popup implementation to have static content out of the scrollable part, and likely stop using arrowscrollbox in favor of a normal box with a scrollbar.

Comment 1

[Justin Dolske [:Dolske]]

Same issue as bug 980038. I suspect this remains WONTFIX for the current implementation, but if we think it's realistic to reimplement things (post-Australis!) to make this fixable, maybe we should reopen that as a followup fix?

Comment 2

[Marco Bonardo [:mak]]

I don't think this is wontfix, as well as bug 980038 was not wontfix. We need to reimplement things to make this work as expected, Australis or not, doesn't matter.

Comment 4

[Matthew N. [:MattN]]

See bug 986866 comment 4 for some thoughts by Gijs.

Comment 5

[:Gijs (he/him)]

We should fix this properly, but we won't manage for 29. We'll probably end up adding an item at the top of the menu for now. We'll deal with that in bug 986866. I'm lowering the priority here to indicate we're not going to be fixing it for 29.

Comment 6

[:Gijs (he/him)]

Marco, can we fix this in a way that doesn't involve switching away from using a menu as the base?

Comment 7

[Marco Bonardo [:mak]]

it's a tricky question, off-hand I'd say yes (for example we could move stuff outside the arrowscrollbox), but until we try that's just a guess.

Comment 16

[Shane Hughes [:aminomancer]]

Can we hide/show the menuitems on overflow/underflow or dimensions? It makes sense to show only the bottom menuitem when the popup is small, and show only the top menuitem when the popup is very long. Otherwise maybe just get rid of the bottom menuitem altogether.

Edit: I did a bit of investigation into that avenue and it doesn't look like a great idea. Never mind

Comment 18

[Avlasenko Vitaliy]

Is that such a problem to remove excess lower button in bookmarks menu? One year and still nothing done.

Comment 19

[:Gijs (he/him)]

(In reply to Avlasenko Vitaliy from comment #18)

Is that such a problem to remove excess lower button in bookmarks menu? One year and still nothing done.

Because of the abstractions being used, yes, it's "such a problem" - it isn't a trivial fix.

Comment 20

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 9 duplicates.
:mak, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 21

[BugBot (nomail) [:suhaib / :marco/ :calixte]]

The last needinfo from me was triggered in error by recent activity on the bug. I'm clearing the needinfo since this is a very old bug and I don't know if it's still relevant.

Comment 22

[joshas]

The part of the bug where "Manage bookmarks" is displayed twice in "Show your bookmarks" dropdown (Bookmarks menu button added to toolbar), is still relevant.

Comment 25

[Chris Bellini (:cbellini)]

This can be updated to include useful scroll behaviour, but due to a high regression risk, this will also require additional validation of existing functionality as part of it (e.g. sub-menus, drag and drop, basic menu functionality).