Linux: Animated panels (security doorhanger, history panel, bookmarks panel, downloads panel, ...) are invisible/hidden/flash briefly/do not open

VERIFIED FIXED in mozilla32

Status

()

Toolkit
XUL Widgets
--
major
VERIFIED FIXED
3 years ago
3 years ago

People

(Reporter: Magnus P, Assigned: Neil Deakin)

Tracking

({regression})

Trunk
mozilla32
x86_64
Linux
regression
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox31+ unaffected, firefox32+ unaffected)

Details

(Whiteboard: [qa-])

Attachments

(3 attachments, 4 obsolete attachments)

(Reporter)

Description

3 years ago
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Firefox/31.0 (Beta/Release)
Build ID: 20140409030203

Steps to reproduce:

I click on the download panel button on the UI as usual.


Actual results:

Sometimes it's unresponsive, other times it flashes briefly before closing again.


Expected results:

The download panel should open.
(Reporter)

Updated

3 years ago
Component: Untriaged → Downloads Panel

Updated

3 years ago
Blocks: 610545
Keywords: regression

Comment 1

3 years ago
Happens for me also on Ubuntu, no problem on Windows 7.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 2

3 years ago
I can reproduce on ubuntu12.04 GNOME Classic(No effects)

Regression window
Good:
https://hg.mozilla.org/integration/mozilla-inbound/rev/878193cac6b7
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140408052319
Bad:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c2c661f15fcd
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140408054720
Pushlog:
http://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=878193cac6b7&tochange=c2c661f15fcd

Regressed by: Bug 610545
(Reporter)

Comment 3

3 years ago
Bug appears to be on all panels like ssl certificate panel and bookmark panel. Customization panel and menu panel seem fine to me.
(Reporter)

Updated

3 years ago
Summary: Download Panel does not open on Nightly → Download Panel, SSL Panel and Bookmark Panel do not open on Nightly

Updated

3 years ago
Duplicate of this bug: 994434

Comment 5

3 years ago
This also prevents the activation of plugins. On support.addthis.com/customer/portal/articles/381276-flash-examples I can't start flash either by clicking on the plugin or via the spot in the URL bar, the menu doesn't come up.

Comment 6

3 years ago
Bug 980220 fixed similar issue by tuning Linux theme to degrade better without X compositor.

Comment 7

3 years ago
(In reply to Jan Beich from comment #6)
> Bug 980220 fixed similar issue by tuning Linux theme to degrade better
> without X compositor.

Unfortunately, Bug 980220 did not fix this problem on Ubuntu12.04 GNOME Classic(No effects).
https://hg.mozilla.org/integration/fx-team/rev/6d956b7f8f6e
Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Firefox/31.0 ID:20140413112937

Comment 8

3 years ago
(In reply to Jan Beich from comment #6)
> Bug 980220 fixed similar issue by tuning Linux theme to degrade better without X compositor.

The situation is improved for the bookmarks menu today. It now appears about one in ten clicks. I've never seen the download panel or the panel for approving add-ons since this issue started.

I've also noticed that when the bookmarks menu doesn't appear it is (at least often) still active.

This stealth mode has allowed me to activate my commonly used bookmarks from the keyboard and has kept me from switching browsers so far. (I don't know if this invisible but active state also applies to other panels. I don't have practice using those from the keyboard.)

Comment 9

3 years ago
Created attachment 8405993 [details] [diff] [review]
workaround

Comment 10

3 years ago
Created attachment 8406236 [details] [diff] [review]
workaround, v0.1

regression fix for either transparent or black-tinted Menu popup in previous patch
Attachment #8405993 - Attachment is obsolete: true

Comment 11

3 years ago
Also the animation looks cheesy. If I wanted animated menus I would adjust my windowmanager.
Please revert.

Updated

3 years ago
Flags: firefox-backlog+
Whiteboard: p=0
Duplicate of this bug: 995902
(Assignee)

Comment 13

3 years ago
I'm assuming that this is a issue on Linux only with/without a compositor or something like that. So we can likely either something like the patch above, (although I haven't tested it myself), or just disable the animation on Linux for now.

For the patch in comment 10, the changes need to be made in xul.css instead of the Linux-specific popup.css so that it works on other themes. Conditionals can be used here to make it Linux specific.

For disabling the transition, this would involve putting the arrow panel related styles in xul.css inside a not Linux conditional block. You could also or instead add a default animate="false" on Linux to the arrow panel's binding.

For all of the above, the same applies to the bookmarks menu which uses different styles related to #BMB_bookmarksPopup.

Updated

3 years ago
Duplicate of this bug: 996567

Comment 15

3 years ago
(In reply to Neil Deakin from comment #13)
> I'm assuming that this is a issue on Linux only with/without a compositor or
> something like that. So we can likely either something like the patch above,
> (although I haven't tested it myself), or just disable the animation on
> Linux for now.
> 
> For the patch in comment 10, the changes need to be made in xul.css instead
> of the Linux-specific popup.css so that it works on other themes.
> Conditionals can be used here to make it Linux specific.
> 
> For disabling the transition, this would involve putting the arrow panel
> related styles in xul.css inside a not Linux conditional block. You could
> also or instead add a default animate="false" on Linux to the arrow panel's
> binding.
> 
> For all of the above, the same applies to the bookmarks menu which uses
> different styles related to #BMB_bookmarksPopup.

My bug was marked as duplicated of this bug, see the screencast that I recorded about this please.
I use CentOS 6.5 with NO composition or similar, and the bug appear un 2014-04-08 31, is present too in bookmarks mini-window after add a new site.

Comment 16

3 years ago
screencast of the bug, CentOS 6.5 i686 gnome 2.28 no composition enabled:

https://bugzilla.mozilla.org/show_bug.cgi?id=996567

Comment 17

3 years ago
(In reply to Neil Deakin from comment #13)
> I'm assuming that this is a issue on Linux only with/without a compositor or
> something like that. So we can likely either something like the patch above,
> (although I haven't tested it myself), or just disable the animation on
> Linux for now.
> 
> For the patch in comment 10, the changes need to be made in xul.css instead
> of the Linux-specific popup.css so that it works on other themes.
> Conditionals can be used here to make it Linux specific.
> 
> For disabling the transition, this would involve putting the arrow panel
> related styles in xul.css inside a not Linux conditional block. You could
> also or instead add a default animate="false" on Linux to the arrow panel's
> binding.
> 
> For all of the above, the same applies to the bookmarks menu which uses
> different styles related to #BMB_bookmarksPopup.

I Agree.
tracking-firefox31: --- → ?

Comment 18

3 years ago
Created attachment 8408940 [details] [diff] [review]
workaround, limited opacity transition

Only |opacity| transition becomes broken without X compositor, |transform| still looks fine. No need for |animate="false"| unless it looks better than without.

ifdefs used aren't limited to Linux per bug 948946
Attachment #8406236 - Attachment is obsolete: true

Comment 19

3 years ago
Created attachment 8408944 [details] [diff] [review]
workaround, no opacity transition

May or may not look better without X compositor than if transition uses black color in place of translucency.

Comment 20

3 years ago
Created attachment 8408949 [details] [diff] [review]
workaround, limited opacity transition

Oops, limit to X11 as compositing on non-X11 (e.g. Wayland) may behave differently.
Attachment #8408940 - Attachment is obsolete: true

Updated

3 years ago
Attachment #8408949 - Flags: review?(enndeakin)

Comment 21

3 years ago
Created attachment 8408972 [details]
screencast (120fps), limited opacity transition patch, no X compositor

Black tint, visible black background and choppy animation are transition artifacts without X compositor.

Comment 22

3 years ago
Created attachment 8408975 [details]
screencast (120fps), limited opacity transition patch, with X compositor
Tracking this due to user impact and regression.
tracking-firefox31: ? → +

Comment 24

3 years ago
It is time to backed out Bug 610545 for next ESR31.
Duplicate of this bug: 998542
Depends on: 1001234

Updated

3 years ago
Component: Downloads Panel → XUL Widgets
Product: Firefox → Toolkit

Comment 26

3 years ago
The situation is much worse with today's build. I've been getting by with typing characters to an invisible bookmarks menu, but that has stopped working. (An I still can't enable plugins.)

As Alice said: It is time to back out Bug 610545 for next ESR31.

Updated

3 years ago
Duplicate of this bug: 1002871
(Assignee)

Updated

3 years ago
Attachment #8408949 - Flags: review?(enndeakin) → review+
Hi,

experimented this one first time today with Mozilla/5.0 (X11; Linux x86_64; rv:32.0) Gecko/20100101 Firefox/32.0 ID:20140429030201 CSet: d7c07694f339 (Debian Sid). Happens in Safe Mode and with a clean profile also, with the default theme.
The Download menu is affected as well.

Let me know if you need more info.

Cheers,
Francesca

Updated

3 years ago
Attachment #8408944 - Attachment is obsolete: true

Comment 29

3 years ago
Comment on attachment 8408949 [details] [diff] [review]
workaround, limited opacity transition

This patch tries to follow bug 980220 example where X compositor look doesn't degrade much. If you do not agree, attachment 8408944 [details] [diff] [review] has less animation, still with artifacts, but provides more consistent look between with/without X compositor (no screencast yet).
Attachment #8408949 - Flags: ui-review?(philipp)

Updated

3 years ago
Duplicate of this bug: 1003130

Comment 31

3 years ago
I'm another Linux user affected by this issue. If it helps, I'm using
FVWM with an ATI card and the open-source drivers on Fedora 20 (exact
details available if they're helpful). For me, the problem is that
various panels are invisible or do not open.

I used Mercurial bisection to identify the exact changeset that introduces
the problem for me and it is e4f3408af361, 'Bug 610545, arrow panels
should animate when opening and when cancelling, r=neil,dao'.

The patch from comment 29 works but the result doesn't look particularly
good on my system; the animation feels slow and obtrusive. I personally
would prefer no animation and the panels to just appear and disappear
promptly (as they did before this issue showed up, which I believe means
before bug 610545 landed).
(Assignee)

Comment 32

3 years ago
Chris, or others, does this patch in this bug fix the problem for you?
Flags: needinfo?(cks+mozilla)

Comment 33

3 years ago
The patch attachment from comment 29 'works' in that panels appear.
The appearance and disappearance animation looks ugly and jerky,
especially the disappearance animation (where large black sections
visibly blink into existence for large panels). The screencast from
comment 22 is a mild but representative example; watch the sections
of black tear into and out of existence.

(It's mild because the panels are small.)

If there is another patch that I should try, let me know which one
it is. I'm a bit lost in all of the versions of things in this bug
(many of them marked as superseded).

Based on the patch attachment from comment 29, I believe that the entire
transition animations should be backed out on Linux and things reverted
to the pre Bug 610545 state. There are clearly a noticeable number of
Linux users affected by this and the 'fixed' version here is slow and
brutally ugly.

(As one anecdotal data point, I've stopped updating my 'tip of tree'
build version because I can't stand the new animation.)
Flags: needinfo?(cks+mozilla)

Updated

3 years ago
Duplicate of this bug: 1003807

Updated

3 years ago
Summary: Download Panel, SSL Panel and Bookmark Panel do not open on Nightly → Download Panel, SSL Panel and Bookmark Panel invisible ("do not open") on Nightly

Updated

3 years ago
Severity: normal → major
QA Whiteboard: [bugday-20140505]

Updated

3 years ago
Duplicate of this bug: 1006083

Updated

3 years ago
Duplicate of this bug: 1005714

Updated

3 years ago
Summary: Download Panel, SSL Panel and Bookmark Panel invisible ("do not open") on Nightly → Linux: Animated panels (security doorhanger, history panel, bookmarks panel, downloads panel, ...) are invisible/hidden/flash briefly/do not open

Updated

3 years ago
Duplicate of this bug: 1002813

Comment 38

3 years ago
For the record: I like the patch in bug 1001234 significantly more than
the patch in comment 29. The former patch avoids the visible 'tearing'
and black chunks that appear with the comment 29 patch. (This may be
unnecessary to mention, since it looks like the patch from bug 1001234
is being integrated, but I'm throwing it in for the record.)

Updated

3 years ago
Duplicate of this bug: 1006865
(Assignee)

Updated

3 years ago
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
Assignee: nobody → enndeakin
Target Milestone: --- → mozilla32

Comment 40

3 years ago
This bug of nighttly was landed in Aurora 31a02. What version was patched actually?.
Actually Firefox Aurora Latest i686 have the bug working on CentOS 6.5 i686.

Comment 41

3 years ago
The bug is fixed in firefox-32.0a1.es-AR.linux-i686.tar.bz2.
Landed the same bug in Aurora 310a2 too, is a good idea a new tarball with the patch in Aurora branch.

Updated

3 years ago
Duplicate of this bug: 1007669
Despite being resolved it still affects users of aurora on linux. A lot of features are close to be unusable for a lot of people. Would it make sense to request an uplift?

Updated

3 years ago
Duplicate of this bug: 1015398

Comment 45

3 years ago
FWIW, bug #1015398 is in that alpha branch that comment #43 points out is lacking the backport.  So, I guess properly duped, but unfixed for people on the alpha.  Does that mean it'll eventually hit beta and stable too?

Comment 46

3 years ago
Eh. n/m. I fail at reading comments. Sorry.  It *was* backported.
"Version 31.0a2: Bug 1015398 and bug 994562 not reproducible (presumably fixed)."

Sorry, was just a tad worried since allll my machines over here are linux and didn't want to have to support a bunch of confused relatives.
Comment on attachment 8408949 [details] [diff] [review]
workaround, limited opacity transition

This seems to be fixed, so I'm cancelling ui-review.
Sorry for not acting on it, somehow this flew by me without myself noticing.
Attachment #8408949 - Flags: ui-review?(philipp)
Neil, can we have an uplift request for beta? Thanks
status-firefox31: --- → affected
status-firefox32: --- → fixed
tracking-firefox32: --- → +
Flags: needinfo?(enndeakin)
Hi,

reproduced on Firefox/31.0 ID:20140414030203 and verified the fix on latest Aurora (32.0a2 2014-06-23) on Debian (Linux) x86_64.

Thanks for fixing it: it was really irritating :)

Cheers,
Francesca
Status: RESOLVED → VERIFIED
status-firefox32: fixed → verified
Hi Neil, can you provide a point value and if the bug should be marked as [qa+] or [qa-].
Flags: needinfo?(enndeakin)
Whiteboard: p=0 → p=0 s=33.1 [qa?]
(Assignee)

Comment 51

3 years ago
The animation is disabled on Linux, so this patch doesn't do anything currently and hasn't been checked in anywhere.
Flags: needinfo?(enndeakin)
Whiteboard: p=0 s=33.1 [qa?] → p=0 s=33.1 [qa-]
(In reply to Neil Deakin from comment #51)
> The animation is disabled on Linux, so this patch doesn't do anything
> currently and hasn't been checked in anywhere.

Ops, so that's why it seemed fixed during verification. :)
Should I change it back from Verified to Resolved?

Cheers,
Francesca
I would say Unaffected
status-firefox31: affected → unaffected
status-firefox32: verified → unaffected
Removing from Backlog - Neil stated that Bug 994562 was fixed by Bug 1001234 which was in iteration 32.1
Flags: firefox-backlog+
Whiteboard: p=0 s=33.1 [qa-] → [qa-]
You need to log in before you can comment on or make changes to this bug.