Closed Bug 1518547 (bmo-release-20190108.1) Opened 5 years ago Closed 5 years ago

push updated bugzilla.mozilla.org live: mozillabteam/bmo:release-20190108.1

Categories

(bugzilla.mozilla.org :: Infrastructure, defect)

Product:
bugzilla.mozilla.org
Component:
Infrastructure
Version:
Production
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
bmo-push accept production

People

(Reporter: dylan, Assigned: bobm)

Details

bug 1514765 : New bug comment preview broken when use_markdown is disabled
bug 1515144 : Prevent Google Analytics script from being loaded when DNT:1 so that Tracking Protection doesn't have to block it
bug 1515405 : Add rate limiting for comments and attachment accesses
bug 1514848 : Add utility to revoke API keys
bug 1506725 : Update form.doc to direct reporters to GitHub
bug 1493253 : Embed crash count table to bug pages
bug 1514446 : Disabled users don't have 'strikethrough' in group owners report
bug 1508389 : Change links for WebCompat reporting
bug 1516021 : Rename all references in the code and file tree from Quantum to App
bug 1514411 : NSS, DevTools and other products don't have "Has STR" and "Has Regression Range" fields
bug 1516188 : Alignment of "Bugs Filed" section in profile page is not same as of rest of rows below it.
bug 1517606 : Infinite loop in Bugzilla::Extension::BMO::_inject_headers_into_body()
bug 1518381 : lightbox is no longer used when clicking on an attachment's link in markdown comments
bug 1512526 : Revisions table: mouse over anywhere in the reviewer name should pop up the review status
bug 1509122 : Need additional space between status icon and status text in the revision panel in show_bug
bug 1518264 : New non-monospace comments styled with way too small a font size
bug 1518380 : reduce the margins of blockquotes in html comments
bug 1518350 : Allow literal html tags to stand for themselves
bug 1518303 : Comments on splinter patches are misformatted with markdown styling
bug 1518218 : The attachment icon is misplaced
bug 1518268 : Preview cuts off bottoms of things using ```
bug 1518266 : Font of comment emails is rendered too large since markdown has been enabled

{
   "build" : "https://circleci.com/gh/mozilla-bteam/bmo/18150",
   "commit" : "5ed8720b5278827a33d3625a0f674d4f51807f76",
   "source" : "https://github.com/mozilla-bteam/bmo",
   "version" : "20190108.1"
}

Deployed to stage.

status-bmo-push: --- → staging
tracking-bmo-push: --- → verify?

bugzilla-staging doesn't want to load attachments for me anymore :'(. I was able to load a couple when starting off, but, now the connection times out when i click on an attachment (bugs/pages load fine). Might be due to https://bugzilla.mozilla.org/show_bug.cgi?id=1515405?

Flags: needinfo?(dylan)
Flags: needinfo?(dkl)

Here's a list of each change and my verification of it. Don't think we can deploy this to prod as it is.

  • bug 1514765 : New bug comment preview broken when use_markdown is disabled
    • VERIFIED
  • bug 1515144 : Prevent Google Analytics script from being loaded when DNT:1 so that Tracking Protection doesn't have to block it
    • Not able to verify
  • bug 1515405 : Add rate limiting for comments and attachment accesses
    • ❗ Broken? - Not able to load image or github attachments (since it talks to bmo first) anymore on staging. See comment above.
  • bug 1514848 : Add utility to revoke API keys
    • Not able to verify
  • bug 1506725 : Update form.doc to direct reporters to GitHub
    • Likey Ok, but, I'm not sure where this page is to verify
  • bug 1493253 : Embed crash count table to bug pages
  • bug 1514446 : Disabled users don't have 'strikethrough' in group owners report
    • VERIFIED
  • bug 1508389 : Change links for WebCompat reporting
    • VERIFIED
  • bug 1516021 : Rename all references in the code and file tree from Quantum to App
    • VERIFIED
  • bug 1514411 : NSS, DevTools and other products don't have "Has STR" and "Has Regression Range" fields
    • VERIFIED
  • bug 1516188 : Alignment of "Bugs Filed" section in profile page is not same as of rest of rows below it.
    • VERFIED
  • bug 1517606 : Infinite loop in Bugzilla::Extension::BMO::_inject_headers_into_body()
    • Not able to verify
  • bug 1518381 : lightbox is no longer used when clicking on an attachment's link in markdown comments
    • VERIFIED
  • bug 1512526 : Revisions table: mouse over anywhere in the reviewer name should pop up the review status
  • bug 1509122 : Need additional space between status icon and status text in the revision panel in show_bug
    • Not able to verify (bugzilla-staging has no connected phabricator instance)
  • bug 1518264 : New non-monospace comments styled with way too small a font size
    • VERIFIED (someone else might want to check that it looks good on their screen too)
  • bug 1518380 : reduce the margins of blockquotes in html comments
    • VERIFIED
  • bug 1518350 : Allow literal html tags to stand for themselves
    • VERIFIED
  • bug 1518303 : Comments on splinter patches are misformatted with markdown styling
    • VERIFIED
  • bug 1518218 : The attachment icon is misplaced
    • VERIFIED (it was removed, the patch to align it will be in next deploy!)
  • bug 1518268 : Preview cuts off bottoms of things using ```
    • VERIFIED
  • bug 1518266 : Font of comment emails is rendered too large since markdown has been enabled
    • Not able to verify
tracking-bmo-push: verify? → reject

The problem is the BMO_attachment_base is wrong.

However this isn't new, so I approve it.

tracking-bmo-push: reject → accept
Flags: needinfo?(dylan)
Flags: needinfo?(dkl)
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
tracking-bmo-push: verify? → accept
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.