17476 - Move/Copy menus should sort

Status: VERIFIED DUPLICATE of bug 112301

(MailNews Core :: Backend, defect, P2)

Description

[fenella]

Linux (1999-10-27-15 M11)
Win32 (1999-10-27-09 M11)

Summary: When doing a Move/Copy message, Drop-down list's sort order in server
should match sort order of the folder pane.

Steps:
1. Launch Messenger, select an account (qatest01)
2. From the Inbox, select a message
3. Select Message|Move Message (or Copy Message) to qatest01.

Actual result: Notice that the sort order of the drop-down list from the server
does not match with those in the folder pane.

Expected result: I expect it to be sorted the same order like the folder pane,
meaning that non-special folders are listed below special folders and that they
are sorted like the Subject field in the thread pane.

folder pane folder's order ( win32)
---------------------------------
INBOX
Drafts
Sent
Trash
123folder
234folder
afolder
attachfolder
bugfolder
imagefolder
replyfolder
testfolder
xyz

folder's  order in the Move/Copy message drop-down list
----------------------------------------------------------
123folder
234folder
afolder
bugfolder
Drafts
INBOX
Replyfolder
Sent
testfolder
Trash
xyz

Comment 1

[Phil Peterson]

Reassign to putterman for M13, cc alecf

Comment 2

[scottputterman]

changing summary.  cc'ing rjc and hyatt.  I think we had this discussion on a
newsgroup once, but is there anyway to apply a sort to a menu?

Comment 3

[Alec Flett]

don't we just change the arc that's being followed?

Comment 4

[scottputterman]

Alec, can you explain what you mean.  The problem as I understood it, is that
the RDF Sort Service only sorts trees.  At least it did the last I was involved
in the discussion.  We probably either want it to sort content in general, or
we'll need another way to do our sorting.

Comment 5

[Alec Flett]

oh...I guess I was thinking that it just fiddled with the template, changing the
arc that was followed, not the tree itself.

Comment 6

[Robert John Churchill]

I'll try and code up what you need to make this work. Give me a few days to
massage the XULSortService.

Comment 7

[Robert John Churchill]

You can now sort any content by slapping a "sortResource" and "sortDirection" on

the root node of the generated content.  [Yes, if you need a second level sort,

you can also use a "sortResource2" attribute].



Note: you can also specify a "template" attribute on the root node so that the

template can be defined OUTSIDE of the generated content subtree.  You might want

to do this with <html:select> for example so that default select will work as

expected, for example.

Comment 8

[scottputterman]

Great. Thanks for getting this in.

Comment 9

[Phil Peterson]

Wouldn't hold beta for this, but I'd love to have it especially since some of
the work is apparently done.

Comment 10

[Phil Peterson]

*** Bug 26558 has been marked as a duplicate of this bug. ***

Comment 11

[Phil Peterson]

*** Bug 26827 has been marked as a duplicate of this bug. ***

Comment 12

[scottputterman]

*** Bug 23854 has been marked as a duplicate of this bug. ***

Comment 13

[selmer (gone)]

Mass moving to M16 to get these off the M15 radar.  Please let me know if this
is really an M15 stopper.

Comment 14

[selmer (gone)]

Mail Review hopes this is post-beta2, easy, polish work.  Marking M18.

Comment 15

[scottputterman]

marking nsbeta3 polish for the moment.

Comment 16

[lchiang]

+ per mail triage

Comment 17

[lchiang]

second pass: - per mail triage

Comment 18

[scottputterman]

sorry for the extra email. Removing mail2 keyword.

Comment 19

[laurel]

*** Bug 57926 has been marked as a duplicate of this bug. ***

Comment 20

[laurel]

*** Bug 58484 has been marked as a duplicate of this bug. ***

Comment 21

[laurel]

*** Bug 59308 has been marked as a duplicate of this bug. ***

Comment 22

[scottputterman]

nominating for mail3. Based on all of the dups I get I think this is a highly
requested bug to fix.

Comment 23

[scottputterman]

reassigning to sspitzer

Comment 24

[laurel]

*** Bug 60484 has been marked as a duplicate of this bug. ***

Comment 25

[Henrik Gemal]

Please remember that this is not only for foldernames, but also accounts.

Comment 26

[scottputterman]

this should include all of our menu lists including new folder dialog and copies
and folders menu lists.  marking nsbeta1+ and moving to mozilla0.9 milestone.

Comment 27

[scottputterman]

moving to mozilla0.8 milestone.

Comment 28

[(not reading, please use [e-mail] instead)]

accepting.

Comment 29

[scottputterman]

reassigning to chuang

Comment 30

[scottputterman]

moving to mozilla0.9

Comment 31

[scottputterman]

marking nsbeta1- and moving to future milestone.

Comment 32

[laurel]

*** Bug 69602 has been marked as a duplicate of this bug. ***

Comment 33

[laurel]

*** Bug 70703 has been marked as a duplicate of this bug. ***

Comment 34

[laurel]

*** Bug 74364 has been marked as a duplicate of this bug. ***

Comment 35

[Peter Lairo]

My suggestion is to use the sort order of the folders pane (standard folders
first, *then* user created folders). The folders should be sorted alphabetically
within their group (standard folders, user created folders), *regardles* of
whether they contain subfolders or not.

Target Milestone: Mozilla0.91? Status: assigned ???

Comment 36

[laurel]

*** Bug 77768 has been marked as a duplicate of this bug. ***

Comment 37

[laurel]

*** Bug 81101 has been marked as a duplicate of this bug. ***

Comment 38

[Keyser Sose]

*** Bug 81633 has been marked as a duplicate of this bug. ***

Comment 39

[Jacek Piskozub]

13 dups. Marking mostfreq and 4xp as this is a Netscape 4.* parity issue.

I would mark it mostannoy as well if there were such a keyword :-(

Comment 40

[Jacek Piskozub]

Can really 4xp bugs be targetted to Future. I believe mozilla1.0 is more
appropriate.

Bug 68725 is on similar problem with Get Message dropdown sorting

Comment 41

[laurel]

*** Bug 89969 has been marked as a duplicate of this bug. ***

Comment 42

[Jacek Piskozub]

*** Bug 90180 has been marked as a duplicate of this bug. ***

Comment 43

[[e-mail]]

Attachment: Proposed Patch

Comment 44

[laurel]

*** Bug 91944 has been marked as a duplicate of this bug. ***

Comment 45

[[e-mail]]

Can someone update this bug to add the patch, review and/or ui keywords?

Comment 46

[chuang]

I'll do the review today.

Comment 47

[chuang]

r=chuang.  I applied the patch and tested on Move/Copy msg menu, File button,
New Folder, Message Filter and search dialog.  All folder lists appeared the
same order as in folder pane.

Comment 48

[Scott MacGregor]

sr=mscott. Although this might break when the outliner branch lands for the
folder pane. 

Comment 49

[(not reading, please use [e-mail] instead)]

this looks good.  (and I think I've got dups of this in my bug list.)

this shouldn't cause a conflicts with the folder outliner branch.  (see bug 
#73865)

setting target to 0.9.4

Comment 50

[(not reading, please use [e-mail] instead)]

there might be two other places to check.

the picker in messengercompose.xul and the picker in SearchDialog.xul

Comment 51

[chuang]

Picker in Search dialog is fine.  I'll attach the patch for the compose window 
menu Options|File Sent Message.

Comment 52

[chuang]

Attachment: Patch for picker in mail compose window

Comment 53

[chuang]

The file button in Search dialog is not covered.  I'll attach a final patch 
including the file button in search dialog.

Comment 54

[chuang]

Attachment: Final patch including compose window and file button in search dialog

Comment 55

[(not reading, please use [e-mail] instead)]

why the change from <menu> to <menulist> in the patch?

Comment 56

[chuang]

I'm not sure about that one,  [e-mail] did the fix for
mailWindowOverlay.xul and msgFolderPickerOverlay.xul.  I can find out what
happen if using menu.

Comment 57

[chuang]

Attachment: New patch using <menu>

Comment 58

[chuang]

Using <menu> works fine. The new patch doesn't use <menulist>.

Comment 59

[chuang]

Forgot to mention,  those are the pickers in Account Setting|Copies and Folders.

Comment 60

[(not reading, please use [e-mail] instead)]

r/sr=sspitzer on http://bugzilla.mozilla.org/showattachment.cgi?attach_id=44474

Comment 61

[laurel]

*** Bug 94595 has been marked as a duplicate of this bug. ***

Comment 62

[[e-mail]]

*** Bug 94071 has been marked as a duplicate of this bug. ***

Comment 63

[[e-mail]]

So when is this fix going in?
I only ask because 93061 and 93011 have gone in.
P.S. menu to menulist is covered by another bug which should go in anyway.

Comment 64

[Scott MacGregor]

Candice, can you try to get this patch checked into the tree soon? If you can't
get to it then we should push this off to .9.5 per the mailnews triage meeting
today. Feel free to do so if you aren't going to have time to check this in.

Comment 65

[chuang]

Attachment: Most updated patch with <menulist>, same as first patch

Comment 66

[chuang]

Fix checked in.  The patch just posted is the same patch combined first three 
patches using <menulist>.

Comment 67

[fenella]

I am reopening this bug because the sort order in the folder pane is 

Upper case  letters sort  followed by small letters sort
INBOX
Trash
Business
Confirm
Drafts
Mail-to-read
Sent
Template
bugstatus
fen_to_read
fenella
imapfolder
mail issue
mail _news
sarah
skin

But in the MOVE/COPY sort, it is sorting by alphabetical orders with small
letters preceding upper  case characters  (except for INBOX and Trash). Eg
INBOX
Trash
bugstatus
Business
Confirm
Drafts
fen_to_read
fenella
imapfolder
mail issue mtg
Mail-to-read
mail_news
sarah
sentskin
Templates

Comment 68

[(not reading, please use [e-mail] instead)]

that's another bug.

http://bugzilla.mozilla.org/show_bug.cgi?id=95358

(fix in hand for that one.)

Comment 69

[fenella]

Thanks. Seth.
I'll verify this one.

Comment 70

[Paulo Vilela]

I am testing this with build 2001090908.
The sorting looks OK, but there is a problem: If while focused on a message
header I click on the right button I do see an alphabetically sorted list of
folders. If then I move the mouse down the list , if I position the mouse over a
folder with subfolders, sometime the subfolder list is shown , some other times
it is not shown. The behaviour is not consistent.

Comment 71

[mozbug1]

This worked for me as of 0.9.6 but in 0.9.7 it is broken again.  Specifically
I'm trying to do a move to on linux and the sort order appears to be random.  In
0.9.6 it was alphabetical.

Comment 72

[Peter Lairo]

It's *not* sorted alphabetically on win98, build 2002-01-03 also. This needs to
be reopened.

I also really like the idea that it should be sorted as in the folder pane
(special folders first). I would further suggest to put a horizontal line
between the special and the user-created folders - I think that would help
visually demonstrate why there is no straight alphabetical sorting.

Comment 73

[Calum Mackay]

Also now broken again on 0.9.7 Solaris 8 SPARC.

Comment 74

[[e-mail]]

naving, this wasn't broken by the sortKey code, was it?

Comment 75

[Navin Gupta]

This bug is really old. I didn't know such a bug existed. However I have
a fix to make it sort just as they appear in folder pane.

*** This bug has been marked as a duplicate of 112301 ***

Comment 76

[[e-mail]]

Verifying Dup.