1807063 - State of collapsed/expanded thread is not maintained

Status: RESOLVED FIXED

(Thunderbird :: Folder and Message Lists, defect, P2)

Description

[Alessandro Castellani [:aleca] PTO Until Oct 5th]

The state of collapsed threads is not maintained upon restart if single threads are opened or closed.
If all threads are opened or closed with the specific command, the state is remembered.
The issue happens only if threads are opened manually by clicking on the chevron.

This started happening recently, but I'm not sure about the correct regression window.

Comment 1

[Francesco]

There seems to be some confusion what the desired and established behaviour should be, here and also in bug 1849960. Both show up with this search: https://mzl.la/3Lt7gSz.

In 102 the bahaviour is this:

For a folder, threads can be collapsed or expanded (\ or *). This is persisted when the folder is left and revisited and also across restart.

Collapsed/expanded states for individual threads were never persisted. However, if a message was selected in a manually expanded thread in a generally collapsed folder, then that one thread was expanded again on leaving the folder and returning to be able to show the selection again. This does no longer work in Supernova, amongst other things reported in bug 1851320.

Comment 4

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 1807063 - Restore thread state when selecting folder. r=darktrojan

Restore the collapsed or expanded state of threaded or grouped by sort views when selecting
a folder. Threads or groups containing previously selected messages are opened in any case if
possible.

Comment 5

[betterbird.project+10]

restoreSelection() is called twice when a folder is entered:

restoreSelection chrome://messenger/content/about3Pane.js:4955
_onSelect chrome://messenger/content/about3Pane.js:2540

and

restoreSelection chrome://messenger/content/about3Pane.js:4955
onMessagesLoaded chrome://messenger/content/mailCommon.js:963

Can you please clarify why restoreSelection() is called twice.

Comment 6

[betterbird.project+10]

The issue we mentioned in comment #5 is really the root of the problem why Hartmut's patch only works sometimes. Adding some debugging to restoreSelection() shows that this function is called twice or three times on entering a folder. That doesn't appear to be correct. Blocking those excessive calls with a 100 ms gate makes the patch work. Quite a hack, but we believe the overall architecture should be straightened out here to just restore the selection once together with the thread state (bug 1851320).
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1807063-restore-thread-state.patch

Comment 7

[betterbird.project+10]

We toned down the hack a bit, now the calls are bundled and run in a setTimeout().

Comment 8

[betterbird.project+10]

Thanks for attributing our investigation re. "grouped by sort" views. Please consider also taking the following patch. Currently "collapse all threads" and "collapse single thread" gives different results when restoring the selection after leaving and returning to a folder. This is also due to the behaviour of getting DB keys for dummy rows, which returns the key of the first group member.
https://github.com/Betterbird/thunderbird-patches/blob/main/115/bugs/1807063-fix-saving-selection.patch

Comment 12

[Nicola Soranzo]

Not sure if related, but in Supernova the following annoying behaviour started:

1. Search in a folder using the Quick Filter
2. Reset the filter
3. All threads are expanded, even if they were all/most collapsed before the search.

Comment 13

[Hartmut Welpmann [:welpy-cw]]

(In reply to Nicola Soranzo from comment #12)

Not sure if related, but in Supernova the following annoying behaviour started:

1. Search in a folder using the Quick Filter
2. Reset the filter
3. All threads are expanded, even if they were all/most collapsed before the search.

Yes, I am aware of that. This will be fixed as well.

Comment 14

[Nicola Soranzo]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #13)

Yes, I am aware of that. This will be fixed as well.

That's great, thank you for confirming!

Comment 15

[max]

Another reason why new interface is confusing: when all thread are expanded new ones appear collapsed.

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/a1f852ae5b9a
Restore thread state when selecting folder. r=darktrojan

Comment 21

[Wayne Mery (:wsmwk)]

Comment on attachment 9356746 [details]
Bug 1807063 - Restore thread state when selecting folder. r=darktrojan

[Triage Comment]
Approved for beta

Comment 22

[Daniel Darnell [:dandarnell]]

Thunderbird 120.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/787c1b2cb76a

Comment 23

[Wayne Mery (:wsmwk)]

good for 115?

Comment 24

[Hartmut Welpmann [:welpy-cw]]

Yes, I think this fixes a lot of things that have been reported recently. By disabling selection persistence in multi-folder views such as unified folders, this also mitigates the problem of selecting the wrong messages as reported in bug 1857766. This functionality should be implemented in another patch soon.

Comment 25

[Wayne Mery (:wsmwk)]

Comment on attachment 9356746 [details]
Bug 1807063 - Restore thread state when selecting folder. r=darktrojan

[Triage Comment]
Approved for esr115

Comment 26

[Rob Lemley [:rjl]]

Thunderbird 115.4.3:
https://hg.mozilla.org/releases/comm-esr115/rev/2beb000990b8