Closed Bug 227241 Opened 17 years ago Closed 16 years ago
Open new windows only upon explicit instruction (Single Window Mode) (open new-window links in tabs instead)
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.5) Gecko/20031007 Firebird/0.7 Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.5) Gecko/20031007 Firebird/0.7 Firebird should have the option of a single window mode (à la TBE) built in. Firebird version of bug 103843 (?) Reproducible: Always Steps to Reproduce:
I've heard "single window mode" mean two features: A) Windows that the web page opens open in a new tab. B) A, plus Ctrl+N opens a new tab instead of a new window, and all "Open ... in New Window" commands are removed. I am in favor of adding (A), but I am against adding (B) as a single checkbox.
TBE implements Single Window mode in one of two ways (configurable by the user): 1. only ever use one window (A & B) 2. open new windows only upon explicit instruction (A) My original suggestion was for Only ever use one window. However, I think the other option would be better, assuming it's do-able, and not as buggy as TBE's implementation.
related to bug 189313?
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: RFE: Single Window Mode for Firebird → Single Window Mode for Firebird
Summary: Single Window Mode for Firebird → Open new windows only upon explicit instruction (Single Window Mode)
this has to be somewhere already, I know this is planned...
I don't recall seeing anything in the roadmap nor a confirmation from any of the devs. This is the most requested TBE feature, though.
Re comment 6: Dave Hyatt, the Firebird module owner, has said in http://forums.mozillazine.org/viewtopic.php?p=144580#144580 : As for TBE, there are some features that we'd like to implement, but in some cases TBE has implementations that aren't desirable, e.g., the way it forces open windows into new tabs. My understanding is that it actually lets the window open and then it shoves it into a tab and closes the window (this also severs the window.opener connection that is supposed to exist between the two windows). We want to fix that at the C++ level and really make the initial window open right in a new tab. Some tab features that we would like to see incorporated into Firebird (patches welcome): (1) Ability to drag/drop to reorder tabs (2) Ability to force windows into new tabs always (hard, anything that just hacks JS is inadequate) (3) Ability to drag a tab out of the tab strip and drop it into another tab strip or to drop it on the desktop and have a new window get made Features that we will not accept: Tons of prefs for tabs just because you don't like our defaults (e.g., where tabs open, where tabs close, close boxes on tabs, etc. etc.). Adding a bunch of geeky configurability options is perfect for an extension.
http://forums.mozillazine.org/viewtopic.php?t=37895 This is the thread where a signficiant portion of the MozillaZine populace voted for the features that they wanted to have in the core from TBE. Single window mode topped the list. What milestone is this targeted for? Is it just a matter of writing a diff that adds single window mode to the core, or will it take longer?
QA Contact: mconnor
There are three options in TBE and they're probably there for a reason. I prefer option 3, always only use one window. Crazy Browser, the first tabbed browser that I used, offered the option for everything in one window or the ability to use more than one window.
*** Bug 232955 has been marked as a duplicate of this bug. ***
At the moment, TBE option #3, everything in tabs stretches things out but I've been using that mode for a long time and it seems fine to me. I suppose that there may be problems for some popups that rely on the screen size instead of fixed pixel positions but I've never run into one of those. Of course I normally see very few popups except the ones that I want.
Actually it would be extremely nice if there was a Closebutton in every tab, instead of having to move your mouse to the right corner which, since most people use mousescroll, is annoying. There are also more positive things with having a Closebutton in each tab, for example, you may want to close alot of tabs in one instance. Without having a Closebutton in each tab you would have to first select the tab, then move your mouse to the right side of the windows and close, which is quite annoying, especially for me working with many sites on the same time.
That's bug 108938 (wontfix).
(In reply to comment #21) > That's bug 108938 (wontfix). Why not let people decide for themselves whether this is a good or bad feature, I think there are alot of people out there who wants this, and if it's a setting you could always deactivate it if you don't like it?
Because there's an extension that already offers that functionality. It's in TBE and also there's a standalone extension for that single purpose only.
(In reply to comment #21) > That's bug 108938 (wontfix). Why not let people decide for themselves whether this is a good or bad feature, I think there are alot of people out there who wants this, and if it's a setting you could always deactivate it if you don't like it?(In reply to comment #23) > Because there's an extension that already offers that functionality. It's in TBE > and also there's a standalone extension for that single purpose only. The advantages of having the function in the core is, possible speed advantage/better integration?, no risk of extention colliding with another extension and you wouldn't have to worry about extension not working with new builds/slow updating.
Sorry to spam this bug some more, but that idea of using CSS in userChrome.css to put a closebox in tabs sounds interesting. Do you know the code that will do this?
Seems I was wrong about userChrome.css, but there's an extension which does more or less what you want here: http://downloads.us-east3.mozdev.org/clav/tabx/tabx.xpi It could be better, but it has the functionality you desire.
Just a note - some people on netscape.public.mozilla.wishlist are asking for this to be "fixed", i.e. it's currently broken. I suggest upgrading severity to minor.
severity != priority, so that's invalid. Just because someone thinks there is such a function doesn't mean its broken.
(In reply to comment #29) > severity != priority, so that's invalid. Just because someone thinks there is > such a function doesn't mean its broken. It does mean that advertising Firefox as a "tabbed browser" might be misleading... but that's a different issue.
why? it is a tabbed browser, just because it doesn't have as much control as it might have doesn't mean its not a tabbed browser.
I doubt this will block 1.0 - more pressing matters (such as decent Bookmarks Manager UI) are "OUT for 1.0" (http://www.mozilla.org/projects/firefox/roadmap.html) It's a shame we can't target this for 1.1 (bug 234461)...
Well, this problem will be partially alleviated if the Extension Bundles portion of the new Firefox Installer comes to be. Then the appropriate extensions, such as Tabbrowser Preferences, Focus Last Tab Selected and/or Undo Close Tab could be installed upon request, thus providing the functionality needed while the other issues are worked out.
Extension Bundles is unlikely to happen with the advent of update.mozilla.org. There's also a number of potential security issues with some (i.e. TBE)
17 years ago
Flags: blocking1.0? → blocking1.0-
*** Bug 248180 has been marked as a duplicate of this bug. ***
Summary: Open new windows only upon explicit instruction (Single Window Mode) → Open new windows only upon explicit instruction (Single Window Mode) (open new-window links in tabs instead)
*** Bug 250653 has been marked as a duplicate of this bug. ***
*** Bug 251693 has been marked as a duplicate of this bug. ***
Links can be forced to be opened in new tab/window by holding down CTRL/SHIFT while clicking them, or with the "Open Link in new tab" / "Open Link in new window" items of the context menu of links. I think it would be consequent to introduce also a special key and a menu item "Open Link in current tab" to force links to open in the current tab.
maybe as an extension. Keep in mind that the user has no way of knowing where a link is going to open, so that would be of limited use, unless you indicated new window links differently, which we don't want to do.
to Mike Connor: (In reply to comment #40) > Keep in mind that the user has no way of knowing where a > link is going to open If the user browses through a link list where he already found one link openinge in a new tab, I knows that the other links of this list in all probability also open in new windows! > so that would be of limited use, unless you indicated new > window links differently, which we don't want to do. I think you mean the style of the links itself. But what about any indication in the status-bar? There alraedy the URL of links is shown on mouse over. What about to also show the target there? Perhaps with a small icon.... What do you mean? Further on, introducing a menu item anf key to force opening of links in current tab would allow to fix bug 36867 without loosing features! So please re-consider this.
point 1: that's guessing at best. point 2: we have enough stuff going on in the status bar. For those cases where you really want the current window (not a new tab) its an edge case and more apt to cause confusion, IMO. point 3: that's a really obscure bug, not anywhere near worth justifying what you're asking for. Maybe as an extension it'd be useful, but anything beyond a pref is really not going to happen in the core. I think you'll notice after a while that I won't get worn down by arguments that I don't find validity in, so please don't repeat the process you've gone through on other bugs.
to Mike Connor: (In reply to comment #40) > Keep in mind that the user has no way of knowing where a > link is going to open That's incorrect. A way to get this info; maybe a bit circumstantial, is to right-click "Properties": "Will open in:". > so that would be of limited use, unless you indicated new > window links differently, which we don't want to do. So I think this is a bit inconsequent: You also can say: non-new-window links are not indicated... I think new-window links should not be seen as special links... (In reply to comment #42) >I think you'll notice after a while that I won't >get worn down by arguments that I don't find validity in, so please don't repeat >the process you've gone through on other bugs. Do you want to say users should stop to post suggestions here? Nevertheless, this is my last comment about this issue...
*** Bug 255575 has been marked as a duplicate of this bug. ***
TBE's single-window mode is good, but for links launched from flash, java and firefox itself, it's a bodge. you'll get new windows appearing, before they are made into tabs. single-window mode should really be an option integrated into the heart of firefox. having multiple tabs in multiple windows, is even more confusing than having just multiple windows (as in IE).
The fix for bug 172962 takes care of this too, is there any reason for this to be a separate bug?
This is now covered by bug 172962. It provides options (in Options-Advanced-Tabbed Browsing) to open links from external applications in the current or a new tab. It also lets you force links that open new windows to open in a new tab. Get a build from here to test it: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-0.9/ It's currently Windows-only, but Mac and Linux implementations are on the way in bug 172962. Please open new bugs if you find any problems. Component: Tabbed Browser. *** This bug has been marked as a duplicate of 172962 ***
Status: NEW → RESOLVED
Closed: 16 years ago
Component: General → Tabbed Browser
No longer depends on: 172962
Resolution: --- → DUPLICATE
Status: RESOLVED → REOPENED
Resolution: DUPLICATE → ---
You haven't even checked, Greg. It's now an option in the adavanced tab (tabbed browsing->Force Links...). *** This bug has been marked as a duplicate of 172962 ***
Status: REOPENED → RESOLVED
Closed: 16 years ago → 16 years ago
Resolution: --- → DUPLICATE
Status: RESOLVED → VERIFIED
Asaf, except for drivers, who can do whatever they want, it is not the place of a resolver to be also a verifier. Please read the bug QA rules.
it shouldn't have been reopened, so Asaf's action was to restore the correct resolution, and then verify as if the reporter had not acted incorrectly. Also, please don't nit on bugzilla etiquette in the bug, its public flaming, whereas private email is far more conducive to getting an appropriate response.
(In reply to comment #51) > You haven't even checked, Greg. It's now an option in the adavanced tab (tabbed > browsing->Force Links...). I did check. With that enabled, window.open() links still open in windows, not tabs, for me anyway. Steps to reproduce: 1. Enable "Force links that open new windows to open in a new tab" 2. Visit http://radiotimes.com 3. Click the tab "Today's TV" 4. Click any programme's name Actual results: Link opens in a new popup window Expected results: Link opens in a new tab - no explicit instruction to open a new window was given
> I did check. With that enabled, window.open() links still open in windows, not > tabs, for me anyway. That's true. Only target="_blank" is fixed right now. But also note that bug 172962 contains a patch for window.open, which is reviewed, but not checked in yet. Bug 172962 covers window.open, and has a patch, so this is a dupe of that.
Given the new pref, browser.link.open_newwindow.restriction, which Jesse mentions at http://www.squarefree.com/burningedge/archives/000590.html , I now believe this is fixed.
*** Bug 264089 has been marked as a duplicate of this bug. ***
*** Bug 264454 has been marked as a duplicate of this bug. ***
*** Bug 269711 has been marked as a duplicate of this bug. ***
*** Bug 269960 has been marked as a duplicate of this bug. ***
*** Bug 279299 has been marked as a duplicate of this bug. ***
You need to log in before you can comment on or make changes to this bug.