Closed Bug 260981 Opened 20 years ago Closed 20 years ago

Empty trash fails to clear trash folder

Categories

(Thunderbird :: General, defect)

Product:
Thunderbird
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: rmay, Assigned: Bienvenu)

References

Details

(Keywords: fixed-aviary1.0)

Attachments

(1 file)

proposed fix
822 bytes, patch
sspitzer
: superreview+
Details | Diff | Splinter Review
User-Agent: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040915 Firefox/0.10 Build Identifier: Mozilla/5.0 (X11; U; Linux i686; rv:1.7.3) Gecko/20040915 Firefox/0.10 After deleting __more than one__ message, and right clicking on the trash folder and saying "empty trash", I can still see the deleted messages in the trash folder. If I visit the trash folder, and then tell it to "empty trash", the messages will be deleted. Looking at the actual mail files, it appears that after deleting the first message, and subsequent message deletions causes my trash folder index file (trash.msf) to be deleted, and thus thunderbird is not able to clear trash. Opening the trash folder causes trash.msf to be regenerated and thus I can then empty the trash folder. This problem does not occur if I only delete one message and then empty trash. Reproducible: Always Steps to Reproduce: 1.Delete more than one message. 2.Right click on trash and select empty trash. 3.Open trash folder and see messages still present. Actual Results: I had messages remaining in my trash folder. Expected Results: I should have nothing left in my trash folder after telling it to empty trash. Compiled from source on Gentoo.
When I said the trash.msf file was deleted, I misspoke. This file is reset -- trash.msf is still present, but it is completely empty (0 size).
Trash.msf is set to 0 size after you delete the second message, but not the first message? Does this happen every time you delete two messages? You're deleting the messages one at a time, right? Are you deleting them from the 3-pane ui (as opposed to the stand-alone message window)?
Assignee: mscott → bienvenu
Status: UNCONFIRMED → NEW
Ever confirmed: true
Well, when the bug happens, trash.msf is set to 0 after the second message (and subsequent messages), not the first. I noticed this because I clear trash pretty regularly, yet I noticed at times I had a lot more trash than I expected. This is using the 3 pane ui (all I ever use), and my testing so far has only involved deleting messages one at a time. There have been a few times when this bug hasn't occured given the circumstances I specified. For instance, I deleted some messages (into the trash can) and then moved them back out (I'm running out of messages to delete). When I moved these messages back out, the trash folder looked empty, but the Trash file did not have 0 size. At this point, the bug would not reproduce. Deleting another message and emptying the trash finally reset the Trash file to 0, at which point I could get the bug to reproduce.
can you get this bug to happen without ever opening the trash folder itself? Do you have any filters or junk mail controls that move messages into the trash folder?
Attached patch proposed fix — — Splinter Review
need to mark db valid after emptying trash...
Attachment #159783 - Flags: superreview?(mscott)
Comment on attachment 159783 [details] [diff] [review] proposed fix a=sspitzer for approval1.8a4
Attachment #159783 - Flags: superreview?(mscott) → superreview?(sspitzer)
Attachment #159783 - Flags: superreview?(sspitzer) → superreview+
fixed on trunk and aviary branch
Status: NEW → RESOLVED
Closed: 20 years ago
Keywords: fixed-aviary1.0
Resolution: --- → FIXED
Just spun a build with the fix in and it's fixed it. Thanks David :-)
Duh, Replied to wrong bug (should have been bug 260266).
*** Bug 260226 has been marked as a duplicate of this bug. ***
I'm adding this here and also sending it to the writer of the double click extension mentioned below. I don't know if it is related to this bug, or if it involves the next and prev buttons. I am still running with the version of tbird I installed a few days ago.(20040913). Yesterday I installed the then and prev buttons that come with it (not the extension ones). This morning I installed the extension that stops folders from spawning off a copy of the folder if I double click. I have no other extensions installed. A short time ago, my inbox had a bunch of messages in it, with the two most recent (or the 2nd and 3rd most recent, I don't remember exactly) being unread messages. They were messages I sent myself to remind me to do things, so the reminders were in the subject field and the messages contained no text. When I started tbird, or when I did a getmail, I forget which, a few new messages appeared. I forget what I did with one or two of these, I am 99% sure I deleted them after reading them. Then I came to two copies of a newsletter (these appear to be two genuine copies, as both are on the server with a slightly different date; I suspect I am in the newsletter list twice). I used the next button when reading the newsletters, and from the second newsletter (I had not deleted either newsletter) it went backwards to the first reminder message. I clicked on next a couple of times, but then when I looked at the list of messages, the two reminder messages were no longer listed. I couldn't find them in the trash or junk. So I exited tbird, went to the file area and deleted the junk msf and trash msf files, because I remembered the discussion of the bug about one or more of those possibly being corrupted. Then I restarted tbird, but the reminder messages are still no where to be found, either in the inbox or trash or junk. My guess is that the next and maybe prev buttons that come with tbird might somehow be remembering the delete function for the previous messages read, is that possible? Or that the double click extension is messing this up somehow.
Somehow exiting tbird again and restarting and who knows what else, now the reminder messages are back.
*** Bug 261377 has been marked as a duplicate of this bug. ***
*** Bug 261407 has been marked as a duplicate of this bug. ***
*** Bug 259185 has been marked as a duplicate of this bug. ***
*** Bug 251343 has been marked as a duplicate of this bug. ***
*** Bug 251343 has been marked as a duplicate of this bug. ***
*** Bug 261670 has been marked as a duplicate of this bug. ***
*** Bug 258731 has been marked as a duplicate of this bug. ***
*** Bug 262856 has been marked as a duplicate of this bug. ***
*** Bug 262903 has been marked as a duplicate of this bug. ***
*** Bug 263866 has been marked as a duplicate of this bug. ***
*** Bug 264035 has been marked as a duplicate of this bug. ***
*** Bug 259784 has been marked as a duplicate of this bug. ***
*** Bug 264886 has been marked as a duplicate of this bug. ***
*** Bug 259925 has been marked as a duplicate of this bug. ***
this is working for me using 2004112311-0.9 bits on linux fc2, so marking verified.
Status: RESOLVED → VERIFIED
1. Bug 258731 which is for Windows, has been duped to this one, so I move the platform be changed to PC/All or All/All. 2. I'm seeing junk status lost on compact (which is bug 258731) but not failure to clear trash (which is supposed to be this; however the two are currently duped to each other) on "Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.2pre) Gecko/20070129 Thunderbird/2.0pre" (Build ID: 2007012904). I hope the fix will be propagated to the branch. Or maybe the dupe should be removed and that other bug reopened.
Was this fix trunk only? If so, has it "baked" enough where it could go to branch? Thanks.
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: