Closed Bug 267378 Opened 20 years ago Closed 20 years ago

open link from Mail&News in new tab doesn't work (XPCNativeWrapper is not defined)

Categories

(SeaMonkey :: Tabbed Browser, defect)

Product:
SeaMonkey
Component:
Tabbed Browser
Version:
1.7 Branch
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: aha, Assigned: jon)

References

Details

(Keywords: fixed1.7.6, regression, Whiteboard: [sg:nse])

Attachments

(1 file)

proposed fix
4.31 KB, patch
neil
: review+
Bienvenu
: superreview+
mkaply
: approval1.7.6+
Details | Diff | Splinter Review 
20041101/M 1.7.4/W2K

Repro:
1. middle click on link in e-mail body to open link in new Tab

Actual:
Tab isn't opened, error in JS console will appear:

  Error: XPCNativeWrapper is not defined
  Source File: chrome://communicator/content/contentAreaClick.js
  Line: 153

Same situation with links in AddressBook.

Link to source:
http://lxr.mozilla.org/mozilla1.7/source/xpfe/communicator/resources/content/contentAreaClick.js#153

It looks like regression (my M 1.7.3 is able to do it correctly), probably from
bug 249332. If anybody could confirm this, please ask for 1.7.x blocking.

Because bug 249332 is confidential, I'm setting this too - Dan, feel free to
public it, if security bit is not nessesary.
Good call -- yes, this looks like fallout from bug 249332. On the Suite side
contentAreaClick.js is included many places and now they'll need to make sure to
include XPCWrappedNative.js as well

Dang, is there any good way to catch these js dependencies earlier? It all comes
down to testing in all the right places. Maybe start a push to have debug-only
startup code that tests for the existence of required objects, so more failures
are caught sooner rather than waiting for someone to go down just the right path
later.

Looks like Thunderbird on the aviary branch could be affected theoretically,
although I don't know if they're able to do much with a middle-click.

http://lxr.mozilla.org/mozilla1.7/search?string=contentAreaClick.js
 vs.
http://lxr.mozilla.org/mozilla1.7/search?string=XPCNativewrapper.js
not a security exploit
Group: security
Flags: blocking1.7.x+
Whiteboard: [sg:nse]
we don't do anything with middle clicks Dan. 
So, looks like 1.7 (and trunk?) mailnews and addressbook are the places to fix.

The P3Psummary page is too broken to test so I guess we don't need to worry
about that one. I don't know where middle clicks would come up in editor.
Attached patch proposed fix — — Splinter Review 
Fix messenger, messageWindow, mail3PaneWindowVertLayout, and p3pSummary by
including XPCNativeWrapper.js from each.

Editor gets XPCNativeWrapper.js from editorOverlay.xul.  Addressbook book
doesn't appear to do anything with middle clicks (or right clicks) on links.

(Trunk only seemed broken in p3pSummary..)
Attachment #168737 - Flags: review?(neil.parkwaycc.co.uk)
Comment on attachment 168737 [details] [diff] [review]
proposed fix

This is basically the relevant sections from the 1.4 branch patch but applied
to the 1.7 branch instead, right?
Attachment #168737 - Flags: review?(neil.parkwaycc.co.uk) → review+
Attachment #168737 - Flags: superreview+
Flags: blocking1.7.6+
Flags: blocking1.7.5-
Flags: blocking1.7.5+
*** Bug 275518 has been marked as a duplicate of this bug. ***
*** Bug 275204 has been marked as a duplicate of this bug. ***
Comment on attachment 168737 [details] [diff] [review]
proposed fix

(In reply to comment #6)
Right.
Attachment #168737 - Flags: approval1.7.6?
*** Bug 275733 has been marked as a duplicate of this bug. ***
*** Bug 275844 has been marked as a duplicate of this bug. ***
*** Bug 276001 has been marked as a duplicate of this bug. ***
This bug also may be causing cookies to not be sent to sites if a page is opened
from an email.

(Could someone with privilege add the word "XPCNativeWrapper" to the Summary?
Right now it's a bit hard to find this bug, and XPCNativeWrapper is an excellent
keyword for it.)
Summary: open link from Mail&News in new tab doesn't work → open link from Mail&News in new tab doesn't work (XPCNativeWrapper is not defined)
*** Bug 276252 has been marked as a duplicate of this bug. ***
Comment on attachment 168737 [details] [diff] [review]
proposed fix

a=mkaply

ARGH2
Attachment #168737 - Flags: approval1.7.6? → approval1.7.6+
Keywords: fixed1.7.6
*** Bug 275546 has been marked as a duplicate of this bug. ***
*** Bug 276653 has been marked as a duplicate of this bug. ***
*** Bug 276841 has been marked as a duplicate of this bug. ***
*** Bug 276885 has been marked as a duplicate of this bug. ***
*** Bug 276989 has been marked as a duplicate of this bug. ***
*** Bug 276995 has been marked as a duplicate of this bug. ***
(In reply to comment #1)
> Good call -- yes, this looks like fallout from bug 249332. On the Suite side
> contentAreaClick.js is included many places and now they'll need to make sure to
> include XPCWrappedNative.js as well
> 
> Dang, is there any good way to catch these js dependencies earlier? It all comes
> down to testing in all the right places. Maybe start a push to have debug-only
> startup code that tests for the existence of required objects, so more failures
> are caught sooner rather than waiting for someone to go down just the right path
> later.
...

Did you ever "start a push"? Sounded like a good idea.



*** Bug 277091 has been marked as a duplicate of this bug. ***
Is there a reason to left this bug open? Open or not, most people will not find
this bug because it is Core.
OS: Windows 2000 → All
Hardware: PC → All
Comment on attachment 168737 [details] [diff] [review]
proposed fix

nah, no particular reason to leave this bug open, other than perhaps the fact
that it doesn't seem to be fixed on trunk.
Attachment #168737 - Flags: approval1.8a6?
Timeless: IMHO this is as reported okay on trunk, it was just regression on 1.7
branch.

Jon: Mark it as FIXED, if all is done.
Assignee: tabbed-browser → jon
Comment on attachment 168737 [details] [diff] [review]
proposed fix

a=asa (on behalf of drivers) for checkin to 1.8a6.
Attachment #168737 - Flags: approval1.8a6? → approval1.8a6+
(In reply to comment #26)
It's FIXED.
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attachment #168737 - Flags: approval1.8a6+
*** Bug 277538 has been marked as a duplicate of this bug. ***
*** Bug 277719 has been marked as a duplicate of this bug. ***
*** Bug 277936 has been marked as a duplicate of this bug. ***
*** Bug 277975 has been marked as a duplicate of this bug. ***
*** Bug 278070 has been marked as a duplicate of this bug. ***
*** Bug 276276 has been marked as a duplicate of this bug. ***
Blocks: 276000
I tested this with 2005031011-1.7 mozilla bits on linux fc3:

when I middle-click a link in an email from the mail 3pane or mail standalone
window, the link does open in the mozilla browser in a new tab (success).

however, when I middle-click a webpage link in an address book card (from the AB
3-pane window), nothing is loaded in the browser window. is this expected, or
still buggy? if I just left-mouse click the link, it does load the page in the
mozilla browser.
*** Bug 286105 has been marked as a duplicate of this bug. ***
*** Bug 276000 has been marked as a duplicate of this bug. ***
Product: Core → SeaMonkey
Comment 35 lead to reopening of bug 116114 "Links from Address Cards must have same behaviour as links from MailNews"

VERIFIED
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: