27529 - Border-drawing glitches on tinderbox tables

Status: VERIFIED FIXED

(Core :: Layout: Tables, defect, P2)

Description

[David Hyatt]

Platform: Win98

(1) Load tinderbox.
(2) Examine the vertical borders of the cells (i.e., borders between columns).
 
This is also visible in the mailnews thread pane.  Sometimes the vertical 
borders between two cells in different columns seem to overlap by one pixel 
(even though border-collapse ain't set).

Comment 1

[David Hyatt]

Oops. Meant to give that to karnaze.

Comment 2

[Christian Mattar]

I am seeing this too. However, the cell borders which overlap each other change 
after each incremental reflow.

Comment 3

[Martin Horwath]

*** Bug 32998 has been marked as a duplicate of this bug. ***

Comment 4

[Jesse Ruderman]

*** Bug 39167 has been marked as a duplicate of this bug. ***

Comment 5

[karnaze (gone)]

*** Bug 32770 has been marked as a duplicate of this bug. ***

Comment 6

[karnaze (gone)]

*** Bug 42288 has been marked as a duplicate of this bug. ***

Comment 7

[karnaze (gone)]

Attachment: patch to fix the bug

Comment 8

[karnaze (gone)]

The patch ensures that table column balancing places columns on even pixel 
boundaries, something that should have been done a long time ago. There are 
probably a lot of pages affected (for the better) by this change

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

*** Bug 44982 has been marked as a duplicate of this bug. ***

Comment 10

[Mats Palmgren (inactive)]

*** Bug 47062 has been marked as a duplicate of this bug. ***

Comment 11

[Marc Attinasi]

Approving for beta3

Comment 12

[Rann Bar-On]

*** Bug 46357 has been marked as a duplicate of this bug. ***

Comment 13

[Rann Bar-On]

*** Bug 46357 has been marked as a duplicate of this bug. ***

Comment 14

[Mats Palmgren (inactive)]

*** Bug 47745 has been marked as a duplicate of this bug. ***

Comment 15

[Simon Fraser [no longer active]]

Can someone check this patch in?

Comment 16

[Mats Palmgren (inactive)]

*** Bug 49617 has been marked as a duplicate of this bug. ***

Comment 17

[Mats Palmgren (inactive)]

*** Bug 49162 has been marked as a duplicate of this bug. ***

Comment 18

[Mats Palmgren (inactive)]

This bug can be seen at http://slashdot.org and numerous other sites.
Can someone check in the patch? please, please, please.

Comment 19

[Asa Dotzler [:asa]]

adding mostfreq keyword.

Comment 20

[buster]

I will review the patch and if it's ok, I will check it in.

Comment 21

[buster]

I think the patch is only a partial solution.  Judging by how tinderbox lays out 
with the patch, and how other bugs that are marked as duplicates still render 
poorly, I have to leave this one open.  Reassigning back to Chris.

Comment 22

[karnaze (gone)]

The patch fixes the original bug and some of the ones marked as duplicates. I'll 
check in the patch and leave it up to chrisD to find out which bugs marked as 
duplicates are really not duplicates.

Comment 23

[leger]

PDT moving to P2. Adding [PDTP2]

Comment 24

[karnaze (gone)]

Fixed. The patch needed some rework. ChrisD, please look at the dups and 
determine which ones really aren't.

Comment 25

[gabriel]

Bug 47745 (slashdot.org) is still there.

Comment 26

[Christine Hoffman]

Verified bug fixed across platform. Checked every dup and all are fixed except 
#44745 which is an open bug.