315057 - Display - Fonts tab: The pull-down menu of Character Encodings doesn't work.

Status: VERIFIED FIXED

(Thunderbird :: Preferences, defect)

Description

[Hiro]

The pull-down menu of �hCharacter encodings" doesn't work when Option is displayed with "Display - Fonts" displayed with last Option and the font button is pushed. 

Reproducible: Always

Steps to Reproduce:
1.Create new profile.
   (Migration is not done. and the mail account need not be made.)
2. Open Tool --> Options
3. Select "Display" tab and "Fonts" tab
4. Close Option window
5. Re-open Option window
6. Push "Fonts" button
7. Close Font setting window
8. Click pull-down menu of "Character encodings"
   (Both Outgoing and Incoming)

Windows XP SP1
trunk and 1.8 branch build
version 1.5 (20051103)
version 1.6a1 (20051103)

Comment 1

[Hiro]

The Mac version reproduced. 
1.8branch build version 1.5 (20051103)

Comment 2

[Mike Cowperthwaite]

xref bug 285302, duped to bug 285076 (XUL Template Builder bug).

In bug 285076 comment 53, Scott said:
> this [fix] has been backed out due to Bug #310833.
> no longer a blocker as I've worked around it for 1.5

Comment 3

[Scott MacGregor]

the character encoding menu still works the first time you open the options dialog. That can be the work around for 1.5.

It's too late in the 1.5 cycle to respin for this. This isn't a show stopper anymore. putting in the 2.0 bucket so we don't lose track of this.

Comment 4

[Adam Guthrie]

*** Bug 301858 has been marked as a duplicate of this bug. ***

Comment 5

[Mike Cowperthwaite]

*** Bug 307810 has been marked as a duplicate of this bug. ***

Comment 6

[Mike Cowperthwaite]

Bug 313987 is a similar problem with a different dropdown.

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+2]]

(In reply to comment #6)
> Bug 313987 is a similar problem with a different dropdown.
 
Mike, I don't think that's a similar problem. This bug hides the complete charset list when clicking on it. But on bug 313987 there is no initialisation of the list. Or I'm wrong?

Comment 8

[Dirkjan Ochtman (:djc)]

This won't even get fixed for the 1.5.1 release?

Comment 9

[Mike Cowperthwaite]

(In reply to comment #7)
> (In reply to comment #6)
> > Bug 313987 is a similar problem with a different dropdown.
> 
> Mike, I don't think that's a similar problem. This bug hides the complete
> charset list when clicking on it. But on bug 313987 there is no initialisation
> of the list. Or I'm wrong?

I think you're right, actually.  Sorry for the noise.

Comment 10

[Mike Cowperthwaite]

*** Bug 323506 has been marked as a duplicate of this bug. ***

Comment 11

[Hiro]

*** Bug 323751 has been marked as a duplicate of this bug. ***

Comment 12

[Scott MacGregor]

Attachment: the fix

don't use the xul template builder in the font pref  panel because the template builder doesn't work with dynamic overlays. Build the menus by hand like we did for the address book list boxes in the privacy and composition dialogs for 1.5.

Comment 13

[David :Bienvenu]

Comment on attachment 209898 [details] [diff] [review]
the fix

+    if (n)
+      return n.QueryInterface(Components.interfaces.nsIRDFLiteral).Value;
+    else
+      return "";


can use return (n) ? n.QI... : ""; here if you want

Comment 14

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Works fine with TB version 1.6a1 (20060128) now.

Comment 15

[Adam Guthrie]

*** Bug 325044 has been marked as a duplicate of this bug. ***

Comment 16

[Scott MacGregor]

Comment on attachment 209898 [details] [diff] [review]
the fix

this has baked long enough.

Comment 17

[Marcia Knous [:marcia]]

verified fixed on the 1.8.0 branch using version 1.5.0.2 (20060308. I was not able to reproduce following the reporter's STR. Adding keyword.

Comment 19

[Bob Clary [:bc] (inactive)]

verified fixed thunderbird 2.0.0.0 rc2 windows/linux. If you can reproduce this please download a build from <http://ftp.mozilla.org/pub/mozilla.org/thunderbird/nightly/2.0.0.0-candidates/rc2/> and report back here if you can reproduce it with that.