418961 - "Save Page As" "Text Files" saves file but Downloads window doesn't show completion

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect, P2)

Description

[Allen Stenger]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022104 Minefield/3.0b4pre
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b4pre) Gecko/2008022104 Minefield/3.0b4pre

When commanding the "Text Files" option of "Save Page As", a correct text file is created, but the Downloads window shows the item as "Starting..." with no progress in the progress bar.

Reproducible: Always

Steps to Reproduce:
1. go to http://mozilla.org
2. command File> Save Page As, select "Text Files" in the popup menu in the dialog, use the default file name.
3. in the Downloads window, observe that this item appears with status "Starting..." and never progresses (bad).
4. open the saved file in a text editor (for example TextEdit). You will see that it has a representation of the page as a text file, with no obvious missing data.

Actual Results:  
see above

Expected Results:  
see above

Not sure why this feature is called the plural "Text Files" - under what conditions would there be more than one file?

Comment 1

[Shawn Wilsher :sdwilsh]

*ug*

confirming :(

No download file appears to be downloading either...

Comment 2

[Ed Lee :Mardak]

Attachment: v1

Similar to what we needed to do for exthandler.. set the NETWORK bit. All places in webbrowserpersist that have a STATE_START or STATE_STOP are able to send STATE_IS_NETWORK bit if necessary with this patch.

Comment 3

[Ed Lee :Mardak]

Here's a build with patch v1 applied:

https://build.mozilla.org/tryserver-builds/2008-02-25_01:[e-mail]/

Bug 416446 - Make PluralForm more useful for extensions and delay importing strings for perf
Bug 415460 - searching in places queries does not decode urls
Bug 418961 - "Save Page As" "Text Files" saves file but Downloads window doesn't show completion
Bug 401660 - when showing autocomplete result, show tags that partially match
Bug 416211 - Tagged results don't show bookmark title when matching the tag
Bug 405320 - support "out of order" multiple word tag search in the url bar and in the places organizer
Bug 418920 - Allow multiple word search with tags in addition to title and url
Bug 419068 - Allow tagged pages to mingle with non-tagged autocomplete results
Bug 407946 - emphasize all matching text in title and url, not just the first match in title and url
Bug 415403 - Show matches for all search words for location bar autocomplete
Bug 395735 - Instrument the location bar auto-complete to report accuracy
Bug 395739 - adaptive learning (match entered text to selected item) in url bar autocomplete
Bug 392143 - show keywords as url bar autocomplete choices
Bug 407204 - adjust the title and url text sizes
Bug 406257 - reduce the number of rows in url bar autocomplete from 10 to 6
Bug 419324 - Edit bookmarks dialog doesn't unescape URLs
Bug 419403 - Pimp My Download Manager Search! (multi word, match any text)

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

The tryserver build in comment 3 fixes this nicely.

Comment 5

[Shawn Wilsher :sdwilsh]

biesi - any chance you'll get to this soon?

Comment 6

[Ed Lee :Mardak]

Checking in embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp;
/cvsroot/mozilla/embedding/components/webbrowserpersist/src/nsWebBrowserPersist.cpp,v  <--  nsWebBrowserPersist.cpp
new revision: 1.136; previous revision: 1.135
done

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008030904 Minefield/3.0b5pre

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008030904 Minefield/3.0b5pre

-and-

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008030904 Minefield/3.0b5pre

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+

https://litmus.mozilla.org/show_test.cgi?id=5205