429302 - Select changes width when option has padding: 0px

Status: RESOLVED WORKSFORME

(Core :: Layout: Form Controls, defect)

Description

[Martijn Wargers (dead)]

Attachment: testcase

See testcase, I would think that both select elements would have the same widths, but they don't.

This regressed between 2007-05-03 and 2007-05-05:
http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2007-05-03+04&maxdate=2007-05-05+07&cvsroot=%2Fcvsroot
Regression from bug 364510?

Comment 1

[Martijn Wargers (dead)]

Attachment: reftest

Comment 2

[Martijn Wargers (dead)]

Attachment: reference

Comment 3

[Boris Zbarsky [:bzbarsky]]

Hmm.  So by default, options have 8px of padding.  The display area has 4px of padding.  So normally, the display area can't be wider than an option with the same text (unless the author does some careful font styling, of course, in which case all bets are off).

In this case, though, the display area is 4px + text length, so it can be wider than the widest option.  What we used to do was cut off part of the text, basically.  We no longer do that, with the change from bug 364510.

I bet you could get a similar effect with negative margins on <option> without changing the padding.

The obvious options here (no pun intended) are to leave things as-is, to disallow changing <option> padding, to introduce 4px of spacing in <option>s that can't be turned off, or to somehow change the intrinsic width algorithm to take each option text, add the display frame padding, and max over those, not just the current text of the display frame.  That still wouldn't solve the font-size thing, of course.

My gut instinct here is to do nothing, to be honest.

Comment 4

[Martijn Wargers (dead)]

Just a fyi, I found this bug on some site where it was causing a widening of a table column, so this doesn't come completely out of the blue.

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is relatively low, S3. However, the bug has 3 duplicates and 6 See Also bugs.
:emilio, could you consider increasing the bug severity?

For more information, please visit auto_nag documentation.

Comment 9

[Emilio Cobos Álvarez (:emilio)]

This no longer happens. I reworked combo box layout a while ago.