Edit Message Filter window is scrolling slowly, bad performance for large multi-criteria filters
Categories
(Thunderbird :: Filters, defect)
Tracking
(Not tracked)
People
(Reporter: mcow, Unassigned)
References
(Blocks 1 open bug, )
Details
(Keywords: perf, testcase, Whiteboard: [needs profile][filter-mgmt])
Attachments
(3 files, 2 obsolete files)
Comment 1•16 years ago
|
||
Reporter | ||
Comment 2•16 years ago
|
||
Assignee | ||
Updated•16 years ago
|
Comment 4•16 years ago
|
||
Comment 6•15 years ago
|
||
Comment 8•14 years ago
|
||
Comment 9•14 years ago
|
||
Comment 10•14 years ago
|
||
Comment 11•14 years ago
|
||
Comment 12•14 years ago
|
||
Comment 13•14 years ago
|
||
Updated•14 years ago
|
Comment 14•14 years ago
|
||
Comment 15•14 years ago
|
||
Comment 16•14 years ago
|
||
Comment 17•14 years ago
|
||
Comment 18•14 years ago
|
||
Comment 19•14 years ago
|
||
Comment 20•14 years ago
|
||
Comment 21•14 years ago
|
||
Comment 22•14 years ago
|
||
Comment 23•14 years ago
|
||
Comment 24•14 years ago
|
||
Comment 25•13 years ago
|
||
Updated•13 years ago
|
Comment 26•13 years ago
|
||
Comment 27•12 years ago
|
||
Updated•12 years ago
|
Comment 28•12 years ago
|
||
Comment 29•12 years ago
|
||
Comment 30•12 years ago
|
||
Comment 31•12 years ago
|
||
Comment 32•12 years ago
|
||
Comment 33•12 years ago
|
||
Comment 34•11 years ago
|
||
Comment 35•11 years ago
|
||
Comment 36•11 years ago
|
||
Comment 37•11 years ago
|
||
Comment 38•11 years ago
|
||
Comment 39•10 years ago
|
||
Comment 40•10 years ago
|
||
Comment 41•10 years ago
|
||
Comment 42•10 years ago
|
||
Comment 43•10 years ago
|
||
Comment 44•10 years ago
|
||
Comment 45•10 years ago
|
||
Comment 46•10 years ago
|
||
Comment 47•10 years ago
|
||
Comment 48•10 years ago
|
||
Comment 49•10 years ago
|
||
Comment 50•10 years ago
|
||
Comment 51•7 years ago
|
||
Comment 52•7 years ago
|
||
Comment 53•5 years ago
|
||
(In reply to BlueHorizon from comment #52)
I'm not going have access to the PC with the filters on until the spring
next year, so can't comment on this right now. Will try to remember to do so
in due course.
possible to test now?
Comment 54•5 years ago
•
|
||
(In reply to Wayne Mery (:wsmwk) from comment #53)
possible to test now?
Unfortunately that PC is still inaccessible. That will change - I hope before the year end.
Updated•5 years ago
|
Comment 55•5 years ago
|
||
Using 68.1.2 I don't see a scrolling problem. Opening/clicking edit uses signficant time and memory. Cutting BlueHorizon's testcase by 2/3 for an 11k filter file:
- memory grows 2gb
- 28% of time spent in filterEditorOnLoad of which 18% is initializeDialog
- 24% doing I think disk IO - which makes me wonder if bug 571419 did enough
- 4% in cycle collector
Profile at https://perfht.ml/35st0HH
Comment 56•5 years ago
|
||
Yes, I can also see the slow opening of Edit filter dialog, with just 100 filter rules.
(In reply to Wayne Mery (:wsmwk) from comment #55)
Using 68.1.2 I don't see a scrolling problem. Opening/clicking edit uses signficant time and memory. Cutting BlueHorizon's testcase by 2/3 for an 11k filter file:
- memory grows 2gb
- 28% of time spent in filterEditorOnLoad of which 18% is initializeDialog
But the times in the profile seem to be displayed accumulated, so these functions didn't actually take any time. It seems to me all that time is spent in the call stack below CustomElementRegistry.upgrade, which looks like building the elements for the rule rows.
- 24% doing I think disk IO - which makes me wonder if bug 571419 did enough
When did you start the profiling? Reading the filter file should happen when showing the Filter list dialog, not at editing a particular filter. And also when the Filter list dialog is closed.
Comment 57•5 years ago
|
||
I would have started the profiler after opening filters and just before clicking edit.
Comment 59•4 years ago
|
||
I have always had this issue. If a filter only contained a few line items, it will open within a second or two for edit. However, if I have 20 "match any of these" items (triggers), with a few action line items, it may take 5-10 seconds for the window to open for edit. It drives me nuts at times. When the filter does pop up for editing, the length of the list of triggers determines if scrolling around in that window is slow or not as well (20+ triggers means it might lag for a second or two before you can scroll to the bottom to add another). To this day it does that, and my systems are built to be a beast (the current one, i7-6700k, 64GB RAM, NVMe, etc).
I've always wondered why this was.
Comment 60•4 years ago
|
||
TB 78.3.3 32-bit on Windows 10 and this problem is still occurring. The dialog to edit filters of non-trivial size is nearly useless. Surprised that this problem has been lingering for 12+ years.
Comment 61•3 years ago
|
||
This is definitely still happening and very frustrating.
Comment 62•3 years ago
|
||
Wow, this is 13 years old?
I have 14 filters. One of them has about 100 in the list. It is VERY slow to open, almost impossible to scroll, I can barely add new items to it without thunderbird locking up entirely.
This is retarded that a simple listing of text should run so slowly.
Comment 63•3 years ago
|
||
Hi,
Thought I'd add something to help with this discussion. I too am finding the same problem, and yes I do have some filters with a lot (>100) of rules.
I've monitored task manager as I use thunderbird so I'll first say how my memory/CPU usage changes:
- When TB starts the computer uses 300MB RAM and 0% CPU usage
- Opening the "Message Filters" dialog doesn't change usage
- When opening "Edit" dialog on one of the filters with >100 rules, RAM usage spikes to ~4000MB and 10% CPU usage. This stays like that for ~5 minutes before stabilising
- After stabilising RAM usage rests at 1800 MB and CPU to 0, the filter edit dialog also is opened and looks like it is ready for me to use it.
- Bus as soon as I tried to do anything (scroll, close, minimize the window) CPU usage spikes to 10 % (RAM stays the same) and the application freezes.
I've got screenshots for the above if anyone would like to see them. I've now given up trying to edit filter rules using TB, and looking into how to edit the raw .dat files using python.....
I've also used the TB profiler to investigate the reason for this behaviour and I think the profiler did not record any events during the slow period? I have a .json file, but I'm not sure how to "publish" it or share it for others to see? Should I just attach it to this bug?
I'm not a developer but know enough to sound smart, so if there are other things I can try to investigate further let me know and I'll be happy to try it when I get a free moment. Thunderbird is a great software and it is quite disappointing to have to deal with this odd slowness.
Re: environment, I'm running Windows 10, TB 78.13.0 (64-bit) and my machine is built with high specifications.
Updated•2 years ago
|
Comment 64•8 months ago
|
||
Problem w slow work of message filter still exist. My env: Win7 x64, TB 115.9.0(64bit), i7 6700K, 64GB RAM. Obviously such config you'll barely blame for "slow".
What I do/experience:
- Select menu Tools->Message Filters (quite inconvenient, I need BUTTON ON TOOLBAR!).
- "Message Filters" dialog appears - OK, fast enough (I have literally 40 rules just to dispatch emails to different folders).
- But there is one rule (last one) to block all spam from specific IP. That one rule opened enormously slow!! First, you quickly see dialog w settings of the rule("Filter Rules"), but... you simply cannot interact with it!! This window doesn't respond to anything (including movement) and periodically it's hidden by.... PARENT WINDOW!!! ("Message Filters") This enormous behaviour happen around 1 minute after what you CAN move window. But even this action is not happen immediately - you click on the header, move mouse, NOTHING moves on the screen and only after 5 sec delay window moves to place of mouse. What the hell is that window?? Why it's unresponsive? WHAT so heavy computed inside? Is it real window or just mozilla imitation?
- Even after some BG work finished, you CANNOT work properly w window - it still does some computations, which are so heavy that you wait SECONDS until mouse become "resize cursor" to adjust controls.
- Some "smartie" removed restoring of size/position for "Filter Rules" dialog - WHY? I'm forced EVERY TIME to expand the window and extend "rules" listbox.
- Scrolling of the rules list also WORKS SLOW. You click on the scrollbar, move mouse, but nothing scrolls! And only after 3 sec of "thinking" scrollbar moves. It's unacceptable level of code! So dilettantish that even SIMPLISTIC actions (standard to Windows) take enormous time.
- And finally when you press [OK], "Filter Rules" freezes (not closes!), switches back and forth to "Message Filters" dialog, then closes (after SECOND press of [OK]), but "Message Filters" still not responsive - again some BG work happen so slow, that SECONDS past until you can interact with it.
People, I understand that not all code is quality, but you have YEARS(!!!!!!) to polish it! Which are enormous computations you do to show plain dialog with filters???? It's ridiculously SIMPLE task which must not take so much efforts and PC resources. We used mail even on 80386, but never experience so HORRIBLE QUALITY of code! Looks like somebody in a rush to make "multiplatform code" made WORST code on ALL platforms!
Comment 65•3 months ago
|
||
I've got a message filter that's 953 entries long. Needless to say, attempting to open it in Thunderbird's filter editor causes the UI to be completely unresponsive. CPU will spike to 100% on a single core, and I've given up ever editing this thing again with Thunderbird's UI until this bug is fixed.
The interesting thing, though, is that this giant filter was usable on Thunderbird 115. It took several seconds to initially open, but it was in a perfectly workable state before I upgraded to Thunderbird 128esr. Performance on the new version is significantly worse.
I'm running up-to-date Arch Linux on a ThinkPad with an AMD Ryzen 7 5825U, 22GB RAM, and 1TB NVME storage.
Last working version of Thunderbird for my filters: 115.14.0
Broken version of Thunderbird I'm currently running: 128.2.0
Description
•