Closed Bug 516586 Opened 10 years ago Closed 10 years ago

Account Settings dialog cuts off buttons, needs to be wider

Categories

(Thunderbird :: Account Manager, defect)

x86
All
defect
Not set

Tracking

(blocking-thunderbird3.0 needed, thunderbird3.0 .1-fixed)

RESOLVED FIXED
Thunderbird 3.1a1
Tracking Status
blocking-thunderbird3.0 --- needed
thunderbird3.0 --- .1-fixed

People

(Reporter: brandt24, Assigned: andreasn)

References

Details

Attachments

(13 files, 1 obsolete file)

User-Agent:       Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; SLCC1; .NET CLR 2.0.50727; .NET CLR 3.0.30729; .NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1.4pre) Gecko/20090914 Shredder/3.0b4pre

Some of the buttons in the Account Settings dialogue are simply cut off by default.

Reproducible: Always

Steps to Reproduce:
1. Start TB.
2. Go to Tools / Account Settings.
3. Look at the Server Settings, for instance.
Actual Results:  
One may see that some of the buttons and text does not fit into the window.
Version: unspecified → 3.0
What panes get cuts off? There is already Bug 416263 and 516472 about similar issues with the account settings dialog.
Attached image screenshot 1
Attached image screenshot 2
Attached image screenshot 3
I clearly see this on Windows 7 when running beta 3. bug 516472 could actually solve this problem.
Attached image server settings cutoff
I've see problem like shown in comment #2
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090915 Shredder/3.0b4pre
Status: UNCONFIRMED → NEW
Ever confirmed: true
Duplicate of this bug: 512056
Duplicate of this bug: 514834
OS: Windows Vista → All
confirmed on Win7
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.4pre) Gecko/20091002 Shredder/3.0pre
And this does not blocks the TB3?
It works here, seems like 3.0 only issue.
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.3a1pre) Gecko/20091020 Shredder/3.1a1pre
Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.5pre) Gecko/20091022 Shredder/3.0pre
see bug #524893 comment #5: workaround fix your issue?
Component: Preferences → Account Manager
QA Contact: preferences → account-manager
Duplicate of this bug: 378617
Depends on: 529245
Also confirmed with TB3 RC1 running on Vista. Added screenshots (accountsettingsvista.zip). Suggest to mark it a blocking.
Confirmed using TB 3.0 RC1 in Windows 7. 

*Note*: More importantly, this problem does not show up in Ubuntu Linux (version 9.10). Not only are the buttons not cut off (room to spare actually) but the dialog box is re-sizable in Linux but not in Windows. I agree, this should be blocking TB 3.0 final. Even though this problem doesn't affect functionality at all, it does look rather shoddy and unfinished. Considering users have a habit of judging things by their looks plus the fact that Windows has the largest market share, shouldn't this be blocking the final release?
Flags: blocking-thunderbird3?
While this is ugly, it doesn't actually inhibit any functionality, and most people will end up using the autoconfig dialog most of the time anyway. We won't hold 3.0 for it, but we'll need to do _something_ here for 3.0.1.  Setting flags appropriately.
blocking-thunderbird3.0: --- → .1
Flags: blocking-thunderbird3? → blocking-thunderbird3-
Duplicate of this bug: 532651
Assignee: nobody → nisses.mail
Duplicate of this bug: 533730
Attached patch possible fix (obsolete) — Splinter Review
This makes the buttons not getting cut off on my system by increasing the width from 97 to 107 of accountManager.size in AccountManager.dtd

I'm not 100% certain that this is the correct place to fix it, based on the paragraph above in that file, but as this is a issue in the en-US locale it might be the right place and I haven't found any other place to fix it.
Attachment #416887 - Flags: ui-review?(clarkbw)
Comment on attachment 416887 [details] [diff] [review]
possible fix

asking for a code review from Neil as well, since he wrote the initial code and should know the details on what is correct and not.
Attachment #416887 - Flags: review?(neil)
Going from 97 to 107ch does seem like a big jump. Does 105ch not suffice?
indeed, 105 ch seems to be just enough
Attachment #416887 - Attachment is obsolete: true
Attachment #417084 - Flags: ui-review?(clarkbw)
Attachment #417084 - Flags: review?(neil)
Attachment #416887 - Flags: ui-review?(clarkbw)
Attachment #416887 - Flags: review?(neil)
Comment on attachment 417084 [details] [diff] [review]
updated patch (105ch wide)

seems good to me
Attachment #417084 - Flags: ui-review?(clarkbw) → ui-review+
Duplicate of this bug: 530502
Andreas, I set bug #530502 as dupe of this because has similar\dupe symptom: the Account Settings "Manage Identities"  button is hidden because height minor than is necessary... your patch can fix also this? :-D
Keywords: polish
Aureliano: I think I want to do that one as a separate patch, so I'll attach a patch to the other bug report for that one if it's ok.
Whiteboard: [needs review neil]
I found this bug on my machine too. It's the same with those ones on the screnshots. Buttons are cut off. I'm running windows XP sp3. I also have an Ubuntu 9.10 with thunderbird3, and I'll check that too.
Attachment #417084 - Flags: review?(neil) → review+
Keywords: polishcheckin-needed
Whiteboard: [needs review neil]
Checked in as http://hg.mozilla.org/comm-central/rev/c44f8b55f777
Status: NEW → RESOLVED
Closed: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.1a1
Comment on attachment 417084 [details] [diff] [review]
updated patch (105ch wide)

Setting approval request, I just need to check something first.
Attachment #417084 - Flags: approval-thunderbird3.0.1?
blocking-thunderbird3.0: .1+ → needed
Attachment #417084 - Flags: approval-thunderbird3.0.1? → approval-thunderbird3.0.1+
Flags: blocking1.8.0.next?
Flags: blocking1.8.0.next?
Duplicate of this bug: 528057
As of Thunderbird 3.0.2, this problem still exists.
(In reply to comment #41)
> As of Thunderbird 3.0.2, this problem still exists.

Even when you nuke the locastore.rdf file in your profile ? if so please file a new bug.
This problem also exists for me in 3.0.2 (Linux GTK) even after removing locastore.rdf
This bug is manifesting for me in Thunderbird 3.0.4 over Windows Vista Service Pack 2 32-bit.

Even after:

Shutting down Thunderbird.
Removing the file "localstore.rdf" in "the profile" (AppData/Roaming/Thunderbird/profiles/{...}".
Re-startinging Thunderbird.
This "bug zilla" or whatever it is appears to be a technical tool for use by product engineers.

I don't really know what I am looking at here.

We appear to have status "Resolved Fixed". But manifestly that is not the case because I am still seeing the problem here. I've clicked "Check for updates", but it says there aren't any updates, and I'm still getting the problem.

Can someone explain, in straightforward language, how and when that "Resolved Fixed" status might translate into my getting a working version in my hands?
If you still see a problem, please file a new bug, attach a screen shot to the bug, and comment here.

Note this bug addressed dialog width. Bug 416263 / bug 507640 are more specific to addressing vertical size
No longer depends on: 529245
See Also: → 529245
Summary: Account Settings dialog cuts off buttons → Account Settings dialog cuts off buttons, needs to be wider
You need to log in before you can comment on or make changes to this bug.