Closed
Bug 54911
Opened 24 years ago
Closed 21 years ago
News article gets sent [posted] to the right news group but on the wrong [first] server [account]
Categories
(MailNews Core :: Networking: NNTP, defect, P3)
MailNews Core
Networking: NNTP
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: adamlock, Assigned: ch.ey)
References
(Blocks 1 open bug)
Details
Attachments
(4 files)
2.98 KB,
patch
|
Details | Diff | Splinter Review | |
737 bytes,
text/plain
|
Details | |
12.14 KB,
text/plain
|
Details | |
10.54 KB,
patch
|
Bienvenu
:
review+
mscott
:
superreview+
|
Details | Diff | Splinter Review |
If you have two news servers with the same newsgroup, articles are posted to the first server even when you are looking at the newsgroup on the second server. Steps to reproduce: 1. Subscribe to the same newsgroup on two servers, e.g. netscape.public.mozilla.embedding on news.netscape.com & news.mozilla.org 2. Select the second listed news server and open the newsgroup. 3. Select an article and reply to it from the toolbar or popup menu. 4. Submit the reply. Result: The reply is submitted to the first news server and not the one you are looking at. This can be shown by examining the delivery path in the message's header.
I think this is a duplicate...will look for the original bug...
QA Contact: esther → suresh
Well, the bug I was thinking of was verified some time ago, could be we have a regression since then. see bug 35678
There may be a regression here. It seems to occur when I reply to a message that I'm reading on the second server. I select the message, read it, right mouse click on it to "Reply to Newsgroup" from the popup, write my reply and hit send. The message gets sent to the first server. I'm subscribed to the same news group on both servers. If I post a new message (not a reply), it does go to the correct server.
Comment 4•24 years ago
|
||
clearly the code that picks which server to post to needs some work. accepting, marking mozilla 1.0
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.0
Comment 5•24 years ago
|
||
You don't need a duplicate newsgroup for this. My guess is that Mozilla contacts news.sci.fi when replying to news.mozilla.org just because my e-mail address is fuerte@sci.fi. The error I get is: "NEWS ERROR: An authorization error occurred. Please try entering your name and/or password again. Could not get your access name. Goodbye."
Mass moving all NEWS bugs from esther to myself.
QA Contact: suresh → stephend
Comment 7•24 years ago
|
||
changing milestone to unknown. It will get changed back when we figure out what milestone to put this bug in.
Target Milestone: mozilla1.0 → ---
Comment 8•24 years ago
|
||
In my case the newsgoup server Mozilla tries to use to submit messages is not even the first one, and unfortunately one where I have no right to submit anything :-( It happens in newsgroups I used to read with Netscape 4*, and not freshly subcribed (but this conclusion is derived from a very limited sample). Therefore, it may be a migration problem.
Comment 9•24 years ago
|
||
Workaround: change the newsgroup name (in my example let it be: alt.test) to full URL news://news.foo.com/alt.test, where news.foo.com is the news server you want to se for submitting the posting. Tiresome, but workable. PS. unsubscribng and then subscribing again to the newsgroup does not help.
Comment 10•24 years ago
|
||
yes, there is a problem with how I determine which host to post to. I think this is a duplicate of a bug I already have.
*** Bug 57834 has been marked as a duplicate of this bug. ***
Comment 12•23 years ago
|
||
Bug 74679 is probably a dup of this one
*** Bug 74679 has been marked as a duplicate of this bug. ***
Comment 14•23 years ago
|
||
Bug 64142 discusses a server selection dialog.
*** Bug 95895 has been marked as a duplicate of this bug. ***
Hardware: PC → All
*** Bug 97823 has been marked as a duplicate of this bug. ***
Comment 17•23 years ago
|
||
This patch might fix it. I don't know how to verify whether it does, because news.mozilla.org doesn't support the Delivery-Path: header. Note that I can do some further clean up and simplifying, so it is not done - but I appreciate testing.
Comment 18•23 years ago
|
||
Compare (probably dup) bug 94962, which has a patch.
Comment 19•23 years ago
|
||
H
Comment 20•23 years ago
|
||
Hakan, How does your patch work? I mean, what algorithm, with which Mozilla determines which news server is the appropriate one, is used in your patch? Anyway, I use the 0114 nighty built but it doesn't work for me. The simplest solution would be to give users the possibility to choose the news server. Actually, I've given this suggestion in my bug filed here: http://bugzilla.mozilla.org/show_bug.cgi?id=111636 but unluckily it was marked as a dup of this bug and it didn't get any attention.
Comment 21•23 years ago
|
||
under similar circumstances, I see similar problems. With just my ISPs server in the list, the sending of messages works. If I add news.mozilla.org to the list, then sending to my isp's list reports the nntp error 437 - "unwanted newsgroup a.b.c". The workaround to specify the newsgroup with full url doesn't work either. Interestingly, I've had these plus other severs in the list in the past without these problems, and do this successfully from home.
Comment 22•23 years ago
|
||
Looking in Message Source, I can see that Mozilla has put a mark about news server: X-Mozilla-News-Host: news.xxxxxxx.com What is this exactly? Anyway, I still think that the simplest solution is to provide a popup menu letting user choose the appropriate server.
Comment 23•23 years ago
|
||
I think that it would be better if Mozilla remembered the news server in which the reply is composed.
Comment 24•23 years ago
|
||
No, I totally disagree. Please see my bug (http://bugzilla.mozilla.org/show_bug.cgi?id=111636) But I can add some more words: when someone subscribes to the same newsgroup from two different news servers, there should be a reson to do so and certainly it's not for fun. My home ISP and work ISP aren't the same, so the news servers aren't the same either. It isn't rare that I write or reply to a post for a newsgroup at work, but I finish it at home. So you see, it would be annoying and meaningless if *Mozilla remembered the news server in which the reply is composed*. Annoying because I have to unsubscribe the newsgroup from the ISP of work and resubscribe it again the next day when I get back to work. Well, maybe you would say, "It isn't a big deal to wait for 12 hours to get back to work and send the message". Yeah, but how about if it's in the weekend? How about if I'm too busy in work to remember to sent the post? Etc, etc ......
Comment 25•23 years ago
|
||
My fix is an attempt to make Mozilla remember which newsgroup the reply was composed in, like we do with all other types of accounts. This is a fix for this bug (see the description). Seak, if you want more customization, file that request for enhancement under another bug.
Comment 26•22 years ago
|
||
2002021016 OS/2 I've not had this problem before. See bug 115205, where I had no problem posting as long as it wasn't a crosspost. Now on a fresh migrate, two servers are created from Netscape Communicator, 127.0.0.1 (Changi), and news.atlantic.net. With Mozilla I have aways used only news.atlantic.net to read and post. I went a few minutes ago to group netscape.public.mozilla.os2, read a post, composed a reply (to only the one group), and tried to send. The post could not be sent due to Changi not being open, which means 127.0.0.1 is an unavailable server. I went into prefs and designated news.atlantic.net the default news server, but I still could not send.
Comment 27•22 years ago
|
||
My bug (111636) isn't a dup of this bug then. Could someone unmark it as a dup, please?
Comment 28•22 years ago
|
||
To mrmazda@atlantic.net: Your problem seems to be related to my bug (111636). If you could, please vote for it so that it can be implemented soon. Its target milestone is Mozilla 1.2, too far ! :(
*** Bug 138450 has been marked as a duplicate of this bug. ***
Comment 30•22 years ago
|
||
*** Bug 142154 has been marked as a duplicate of this bug. ***
*** Bug 150434 has been marked as a duplicate of this bug. ***
*** Bug 148628 has been marked as a duplicate of this bug. ***
Comment 33•22 years ago
|
||
Compare bug 80542
Comment 34•22 years ago
|
||
*** Bug 132477 has been marked as a duplicate of this bug. ***
Comment 35•22 years ago
|
||
Please up severity to major. For me this is a virtual blocker for Mozilla as a newsreader. Also this should have keyword 4xp, which I have no power to add.
Severity: normal → major
Keywords: 4xp
Comment 36•22 years ago
|
||
I guess duping 4xp major bug 132477 must have automatically changed the severity and added the keyword here?
No, I'm just quick on the draw.
Comment 38•22 years ago
|
||
Quick no doubt, but also makes me think mid-air collisions are broken in Bugzilla 2.17?
*** Bug 155335 has been marked as a duplicate of this bug. ***
Comment 40•22 years ago
|
||
Mozilla 2002061603 on Mac OSX: The first news server I added was news.mozilla.org Then I added Netscape's server and my own ISP's server. I set my ISP server in the account setting to be the default. However, when I click on an nntp link in the browser, I get a message telling me that the group can not be found on the mozilla org server. It seems that mozilla just uses the first server I added as the default nntp server, ignoring what I told him. Is this the same bug as here, or should I open another bug?
*** Bug 157431 has been marked as a duplicate of this bug. ***
Comment 42•22 years ago
|
||
*** Bug 162470 has been marked as a duplicate of this bug. ***
Comment 43•22 years ago
|
||
*** Bug 162632 has been marked as a duplicate of this bug. ***
Comment 44•22 years ago
|
||
I cannot use mozilla for posting because nearly all posts go to the wrong server. Is there a trick or workaround to make it work?
Comment 45•22 years ago
|
||
Jens, comment #9 in this bug details a workaround.
Comment 46•22 years ago
|
||
Stuart, thanks for your hint. But what does it mean "change the newsgroup name to full URL" Where shall I change it?
Comment 47•22 years ago
|
||
Answered Jens' question offline to avoid noise in this bug.
Comment 48•22 years ago
|
||
hmmm... I can't even get the full format (news://<server>/<ng>) working in Moz1.2a. Still reports the same error about the non existent group... :( sTu.
Comment 49•22 years ago
|
||
The workaround of using a full NNTP URL no longer works. Here is the version I am using... Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1) Gecko/20020913 Debian/1.1-1 This is a big time bug for me. I have several different news servers I visit now, and posting to any but the first one doesn't work. Since most of the servers are private ones with unique groups, I can't post to the first one and get it to propogate to the others.
*** Bug 172115 has been marked as a duplicate of this bug. ***
Blocks: 172730
Comment 51•22 years ago
|
||
encountered this problem, too, and tracked it down to the |servername| vs. |realservername| setting in the preferences (for the account I wish to send to). It seems that when |servername| is not the complete host name (e.g. "cis.dfn.de"), but the |realservername| is (e.g. "news.cis.dfn.de"), then the code in nsNntpService::GetProtocolForUri does not find the server to post to (as it checks for the |servername| only). It then defaults to the first nntp server found (there is a line in the code explicitly saying "the first known server"). The attached changes hook into nsNntpService::GetProtocolForUri, and in case the lookup for |severname| fails (means nsIMsgAccountManager::FindServer does not return a server), it looks up |realservername|, too. If this fails, too, it proceedes as before. Unfortunately nsNntpService::GetProtocolForUri is used for many other cases, so I do not yet know if this changes do have any side effect - I don't know this code good enough to judge this. Additionally, I applied Håkan's patch, too - I do not know if it's necessary for my change to work, did not try this, yet.
Comment 52•22 years ago
|
||
update - Håkan's patch does not seem to be necessary. Without it, loking up the |realservername| as described seems sufficient. Which leads me to suggesting a workaround for the people affected by this: go to the prefs.js, and change the |servername| setting for the respective server to the value of |realservername| (assuming they're different. If they aren't, then what I encountered is not what you encountered :).
Comment 53•22 years ago
|
||
> go to the prefs.js, and change the |servername| setting for the respective
> server to the value of |realservername|
Forry for the dumb question, but I have neither a servername nor a
realservername in my prefs (using 1.0.1). I only have
mail.server.<serverid>.name and mail.server.<serverid>.hostname, while name is
the human readable account name I typed in the Account Manager. name is
something like "Usenet" and "Netscape News" in my case - trying that as hostname
will of course fail and would be an obvious programming bug.
Comment 54•22 years ago
|
||
Arghh. Sorry, Ben, 1am in the morning was obviously too late for me :). Of course I mean |hostname| instead of |servername| and |realhostname| instead of |realservername|. Please think of these as globally replaced in my previous comments :).
Comment 55•22 years ago
|
||
<http://lxr.mozilla.org/seamonkey/source/mailnews/news/src/nsNntpService.cpp> 1083 // xxx todo what if we have two servers on the same host, but different ports? 1084 // or no port, but isSecure (snews:// vs news://) is different? 1085 rv = accountManager->FindServer(userPass.get(),
Comment 56•22 years ago
|
||
Well, I tried the hostname/realhostname fix... the server I've been having problems with did actually have different entries for these two params, but unfortunately, syncing them up didn't fix the problem. Is it the case that the realhostname param is only added if the user changes the serer name (hostname) sometime? My other two servers (that I never get the name wrong for) don't even have the realhostname param. Perhaps removal of it, and setting the hostname properly would work better? sTu.
*** Bug 178465 has been marked as a duplicate of this bug. ***
Comment 58•22 years ago
|
||
For some reason, the wrong newsgroup server is being used when posting to my Adelphia account. I have checked and rechecked my Adelphia newsgrouop account settings and the are correct. I can download messages no problem. But I can't send new messages or replies on this account. Steps to reproduce: A) Highlight a forum within my Adelphia newsgroup account Click compose a new message Compose message Click send Send eventually times out, stating that connection was refused 2nd error message states that AT&T's news-server did not accept connection (naturally, since I am not currently connected to their network) B) Highlight a forum within my Adelphia newsgroup account Highlight a message Click reply Compose message Click send Send eventually times out, stating that connection was refused 2nd error message states that AT&T's news-server did not accept connection (naturally, since I am not currently connected to their network)
Comment 59•22 years ago
|
||
Checked both pref.js files I found: neither had a [realhostname] entry, but I did find an error in one of the hostname settings. Fixed it, exited Mozilla, and restarted. There is no change in the reported problem behavior.
Comment 60•22 years ago
|
||
This bug still noticeable in my cvs build, 20021128. I notice slightly different results. Mozilla will post to the *second* server, the last one set up. Not the *first* server. I would also like to add that if both servers require user/pass then the problem still exists. Also, if the accounts on the servers are set up to use the same user/pass (that's how it is in my case) then mozilla will post to the wrong server using the user/pass from the other server even *before* it knows it is supposed to use the user/pass. (that probably sounds confusing, sorry) ie: I subscribed to a group that requires user/pass but did not open the group. Hence mozilla doesn't know the group requires user/pass, only that the server does. When I replied to the group on the other (first) server mozilla posted to the wrong (new - second) server without even asking for user/pass. Then when I opened the new group for the *first* time moz asked for the user/pass. But that was *after* it had already posted without asking. Please note I am *not* using password manager for the second server, but I do for the first. Moz always asks for user/pass when it opens a group for the *first* time, even if using password manager. But somehow the posts are getting out *with* a user/pass, without moz asking AND it is a previously unopened group for moz.
Comment 61•22 years ago
|
||
Saw this bug today and ended up removing the news servers which it was trying to send to (but which weren't applicable for this network location). I specifically selected the correct news server in the 'From' field of the compose window, but it still tried to post to the wrong one. Why does this have to be complicated? I don't see why it can't just send it to where you tell it to send it...I have a 'From' for each server (mail and news) on which I have an account. Build:2002112808 OS:Mac OS X 10.2.2 Max.
Comment 62•22 years ago
|
||
*** Bug 185025 has been marked as a duplicate of this bug. ***
Comment 63•22 years ago
|
||
I can confirm this bug too, using Mozilla 1.2.1 on linux .... I had 4 newsgroups. The first one in the left pane was the newsserver of my ISP ( port 119 ), the second is secnews.netscape.com ( encrypted - port 563 ). I was trying to post a question in secnews.netscape.com, when mozilla popped-up with a message saying "No valid newsgroups in netscape.mozilla.user.unix". That newsgroup is of course only available in Netsacpe's servers, not on my ISP ... and doing a sniff of the traffic that using ethereal, mozilla was trying to post the message, in non-encrypted NNTP ( port 119 ), to my ISP.
Comment 64•22 years ago
|
||
How long does it take to fix this bug??? I switched from Mozilla to OE partly because of this, and I can't believe that this can't be fixed. Just save the original news server address with the new message...
Comment 65•22 years ago
|
||
The fact that messages that should be sent securely, but are not makes this a privacy/secirity issue in my opinion. There is a reason you sent it secure.
*** Bug 187489 has been marked as a duplicate of this bug. ***
Comment 67•22 years ago
|
||
Does this bug's priority need shifting? (this is possibly not the correct place for this question). It's severity is down as Major (although, to me and presumably anyone else forced to use >1 news server, it's a blocker), and it's older than my toddler, who's learning to use a mouse. tc
Comment 68•22 years ago
|
||
This is a major bug in Mozilla 1.2.1. Here is the exact version I'm running: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.2.1) Gecko/20021130 I have 2 news servers that I use (both are private so I can't give their addresses). Both have a newsgroups named "timeout". When I try posting to the second server (either composing or replying), my posts are put onto the first server. These are 2 totally different newsgroups on 2 totally different servers. The workaround for specifying the full path does not work either. The message just never posts, anywhere and I don't get any error messages. The only way for me to be able to post from Mozilla to the "timeout" newsgroup on the second server is unsubscribe from the "timeout" newsgroup on the first server. Why is it so hard to fix this bug? How hard is it to route the messages to the correct server?
Comment 69•22 years ago
|
||
Bug 188391 reports what sounds like this problem, but the newsgroup does NOT exist on both servers. This bug makes it impossible for some users to post to newsgroups without first unsubscribing from other servers. Marking "1.3b blocking ?" to get some attention.
Blocks: 188391
Flags: blocking1.3b?
Comment 70•22 years ago
|
||
My original bug 162632 which was marked as a dup of this one didn't require that the newsgroup exist on both servers either, just as in bug 188391. Without knowing much about the Mozilla internals I'd suggest marking bug 188391 as a dup as well.
Comment 71•22 years ago
|
||
*** Bug 188391 has been marked as a duplicate of this bug. ***
Comment 72•22 years ago
|
||
May I add that the same problem exists in Netscape 7.01 ? Perhaps some Netscape guys can take a look at it ????
Updated•22 years ago
|
Flags: blocking1.3b? → blocking1.3b+
Comment 73•22 years ago
|
||
only drivers are supposed to + the blocking1.3b flag. if you don't know how something works in bugzilla then please don't fiddle with it. if you want to learn how it works you are welcome to visit #mozillazine on irc.mozilla.org and politely ask about it.
Flags: blocking1.3b+ → blocking1.3b?
Comment 74•22 years ago
|
||
To clarify it: it is not necessary for this bug that a newsgroup exists on both servers.
Updated•22 years ago
|
Flags: blocking1.3b? → blocking1.3b-
Comment 75•22 years ago
|
||
This log file logs all activity of one small session. Mozilla is started, the news/mail window is opened, the two news servers are requested for an update of the message counts, the comp.os.vms news group of @home benelux is opened, a message is opened, with the reply button a composer screen is opened, some text is added, the message is posted, a rejection follows, and I quit Mozilla. Before I do so I have to answer a few popup windows etc.
Comment 76•22 years ago
|
||
Since the same problem exists in Netscape 7.01 as well, I have filed a bug report using Netscape's feedback pages, refering to this bug report. Maybe now this bug will get the attention it needs.
Comment 77•22 years ago
|
||
#76 That owuld be fine, it took 2 hrs of my life to find out this reason for my problmes
Comment 78•21 years ago
|
||
changing summary to make this easier to find
Summary: News article gets sent to the right news group but on the wrong server → News article gets sent [posted] to the right news group but on the wrong [first] server [account]
Comment 79•21 years ago
|
||
*** Bug 197600 has been marked as a duplicate of this bug. ***
Comment 80•21 years ago
|
||
I just downloaded and installed Netscape 7.02 on Windows. Needless to say the problems still exists. Perhaps we should all give 5 votes for this bug. That just might give a higher priority ?
Comment 81•21 years ago
|
||
I am experiencing similar behaviors with v1.3 (Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312). Difference is i have two news accounts established with different forums on each. One is a private news server at work and the other is giganews. When posting to the work server the reader attempts to post it to giganews instead. I have performed a network trace of the event and verified the behavior. Trace data: Network News Transfer Protocol Date: Fri, 25 Apr 2003 20:41:22 -0400\r\n From: Steve Currie <curries@workaddress>\r\n User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.3) Gecko/20030312\r\n X-Accept-Language: en,pdf\r\n MIME-Version: 1.0\r\n Newsgroups: forums.tester.myself\r\n Subject: mozilla test\r\n Content-Type: text/plain; charset=us-ascii; format=flowed\r\n Content-Transfer-Encoding: 7bit\r\n \r\n \r\n .\r\n forums.tester.myself is on the private news server. Steve
Assignee | ||
Comment 82•21 years ago
|
||
Here's my approach to this problem. One way was using Hakans not done patch and adding code in nsNntpService::SetUpNntpUrlForPosting to use the parameter newspostingUrl filled in Hakans patch. But some situations withstood this variant: opening an editor window using a link, composing a message when no newsgroup but the servers name in the folder pane is selected and last but not least changing the senders identity (and with this the server used) while composing the message. So I decided to get the server to be used and generate the uri not until the mail is really going to be send. So instead feeding a maybe good, maybe bad or maybe even empty uri to PostMessage() now the users identity is fed and used for setting up a NNTP Url in SetUpNntpUrlForPosting(). Included is Franks workaround which is really necessary. I know, that the identity has actually no unique POP3/NNTP server (accounts can have multiple identities and a identity can be assigned to more than one account) but at least for NNTP it seems ok to me to take the identity as reference. So I hope you'll find this a reasonable approach too.
Comment 83•21 years ago
|
||
*** Bug 207026 has been marked as a duplicate of this bug. ***
Assignee | ||
Updated•21 years ago
|
Attachment #122964 -
Flags: review?(bienvenu)
Comment 84•21 years ago
|
||
JF is more familiar with this code - can you review this, JF? Or should I?
Comment 85•21 years ago
|
||
I can confirm this bug on Netscape 7.0 and 7.01. Has this bug really been around since October 2000?
Comment 86•21 years ago
|
||
Mozilla/5.0 (OS/2; U; Warp 4.5; de-AT; rv:1.3; MultiZilla v1.4.0.3J) Gecko/20030313 After luckily finally being pointed to this bug, this eventually explains most of the weirdness -besides the neverending nightmare of user account informations not being stored for news server access, but that is another well known bug and neverending story, too- that I'm experiencing as well since some 10 days and culdn't come up with an explanation or solution yet, when I try to post NG messages to CIS.DFN.DE after recently having subscribed there. Most of the NGs now subscribed there, had been subscribed already since a couple of months on another server, now having replication problems with the internet since a couple of weeks and a second, read-only one for monitoring purposes. Since my outgoing messages didn't show up at DFN.DE, but on this other first server, I renamed all server names for it in prefs.js, localstore.rdf and in the News directory structure for the used Mozilla user into something invalid and additionally removed panacea.dat, while leaving all records for the read-only server untouched. But instead of now finally asking for the account information and placing the messages to the right server DFN.DE, Mozilla now complains about not being able to connect to the server (which one of the three?) at all. So what the hell is this stupid thing still searching for? Where does it pick up the wrong NG/server information and which of the 3 servers is it using? If this bug already is over 2 1/2 years old, then this *IS* a valid reason for a blocker, since this is a major issue, turning the whole thing quite useless, until this nasty bug finally is solved. The previously used server still is set as ("mail.accountmanager.defaultaccount", "account6"), while DFN.DE is ("mail.account.account19.server", "server19") and the read-only server is ("mail.account.account16.server", "server16"). So what is the the quick&dirty workaround to fix this problem, until a final solution eventually finds its way into the code base?
Comment 87•21 years ago
|
||
does anyone that codes mozilla even know about this bug?
Comment 88•21 years ago
|
||
You bet. Please don't post comments unless you can *contribute* something, Bugzilla is here to *help* development, not for users to *ask* something.
Comment 89•21 years ago
|
||
*** Bug 210865 has been marked as a duplicate of this bug. ***
Comment 90•21 years ago
|
||
*** Bug 216774 has been marked as a duplicate of this bug. ***
Comment 91•21 years ago
|
||
no word from JF - I'll try to figure out if this is reasonable. It's a nasty bug.
Assignee | ||
Comment 92•21 years ago
|
||
It's nasty, yes. And because of this I've choosen a quite different approach. I hope I didn't make a mistake in my considerations. If my description or code is incomprehensible, I'll try to give you a thought of what I meant.
Comment 93•21 years ago
|
||
*** Bug 220936 has been marked as a duplicate of this bug. ***
Comment 94•21 years ago
|
||
*** Bug 220936 has been marked as a duplicate of this bug. ***
Comment 95•21 years ago
|
||
*** Bug 221605 has been marked as a duplicate of this bug. ***
Comment 96•21 years ago
|
||
I just got bitten by this bug in 1.5rc2 on Windows XP. It is an ugly bug because my postings got lost. Nominating as a blocker for 1.5
Flags: blocking1.5?
Comment 97•21 years ago
|
||
Two additional reasons for making this a blocker: The workaround of adding "realhostname" entries to prefs.js did not work, so it appears impossible to post to a news server that is not the first one in the list. With a slightly different order of News servers in my MailNews window, the bug could have cause internal company information (intended for a company news server) to be leaked to a public news server. This is perhaps the most important reason to make this a blocker, as the bug can cause articles to be sent to inappropriate places.
Comment 98•21 years ago
|
||
Seems I have been too late with my blocking 1.5 request, but this bug is so bad that no release must go out with it -> request blocking1.4.2 status
Flags: blocking1.4.2?
Updated•21 years ago
|
Flags: blocking1.5?
Comment 99•21 years ago
|
||
Scott, Seth, David, can you all take a look at the patch here and see if we can get this in for 1.6a?
Comment 100•21 years ago
|
||
Comment on attachment 122964 [details] [diff] [review] proposed patch this seems OK to me - r=bienvenu. I'd need to test it some, however.
Attachment #122964 -
Flags: review?(bienvenu) → review+
Comment 101•21 years ago
|
||
The workaround in Comment #9 works, but it is cumbersome and easy to forget (resulting in a post to the wrong server). Since it would be good to be able to test the fix before 1.6, I nominate this as an 1.6b stopper.
Flags: blocking1.6b?
Assignee | ||
Updated•21 years ago
|
Attachment #122964 -
Flags: superreview?(mscott)
Updated•21 years ago
|
Attachment #122964 -
Flags: superreview?(mscott) → superreview+
Comment 103•21 years ago
|
||
fix checked in.
Status: NEW → RESOLVED
Closed: 21 years ago
Resolution: --- → FIXED
Comment 104•21 years ago
|
||
Comment on attachment 122964 [details] [diff] [review] proposed patch > nsCAutoString host; >+ nsXPIDLCString temphost; >+ PRInt32 port; > >+ nsCOMPtr<nsIMsgIncomingServer> nntpServer; >+ rv = GetNntpServerByIdentity(aSenderIdentity, getter_AddRefs(nntpServer)); >+ if (NS_SUCCEEDED(rv) && nntpServer) >+ { >+ nntpServer->GetRealHostName(getter_Copies(temphost)); >+ host = temphost; >+ nntpServer->GetPort(&port); > } > > // if we *still* don't have a hostname, use "news" >+ if (host.IsEmpty()) > host = "news"; > >- *newsUrlSpec = PR_smprintf("%s/%s",kNewsRootURI,host.get()); >+ *newsUrlSpec = PR_smprintf("%s/%s:%d",kNewsRootURI, host.get(), port); String fu: nsXPIDLCString host; nntpServer->GetRealHostName(getter_Copies(host)); then use host.IsEmpty() ? "news" : host.get() >+nsresult >+nsNntpService::GetNntpServerByIdentity(nsIMsgIdentity *aSenderIdentity, nsIMsgIncomingServer **aNntpServer) If you make this an nsINntpIncomingServer, then you don't have to do the extra check for the server type...
Assignee | ||
Comment 105•21 years ago
|
||
Hm, thanks - but a little late, no?
>>+nsresult
>>+nsNntpService::GetNntpServerByIdentity(nsIMsgIdentity *aSenderIdentity,
>> nsIMsgIncomingServer **aNntpServer)
>If you make this an nsINntpIncomingServer, then you don't have to do the extra
>check for the server type...
Er, what check? If
+ if(serverType.Equals("nntp"))
I can't see why.
Comment 106•21 years ago
|
||
I think this fix caused a crash when quitting the app after posting a news message: http://bugzilla.mozilla.org/show_bug.cgi?id=225188
Comment 107•21 years ago
|
||
I should have caught this during the review. I think we are missing an addref here: + *aNntpServer = inServer; + break; I'll see if that fixes the crash.
Updated•21 years ago
|
Flags: blocking1.6b?
Comment 108•21 years ago
|
||
I found the reason why I was experiencing that bug: mozilla takes the server from the identity. It does not use the server that was selected when clicking "create new". In my user.js, I have assigned the same identity to multiple accounts, in fact all news accounts point to the same identity. Since mozilla does not look for the selected server but always tries to find the server by the identity, it will fail in my case. I think it is a very bad design to get the server from the identity. It is a good design to split account, identity and server. So it is legal to make GetServerByAccount and GetIdentitybyAccount, but GetServerbyIdentity is against all design rules because identity is not connected to server!
Assignee | ||
Comment 109•21 years ago
|
||
Jens, you're right that the identity is not unique connected to one server. I noted that in the last paragraph of my comment #82. The problem is, that AFAIK Mozilla doesn't know the account the user uses when composing. See the second paragraph in the mentioned comment for this. If you've a better approach, just post it.
Comment 110•21 years ago
|
||
How can it not know? If you are viewing a newsgroup, it necessarilly knows which server's copy of the newsgroup you are viewing.
Comment 111•21 years ago
|
||
I still see this bug after using "edit draft" on a news message. I cant post posting to any newsservers anymore if I change the identity. should I open a new bug or reopen
Assignee | ||
Comment 112•21 years ago
|
||
John, that's viewing a newsgroup. I'm talking about sending a message. I'm currently trying to find another way to get around this problem. What I wrote is my knowledge from doing the patch over half a year ago.
Assignee | ||
Comment 113•21 years ago
|
||
Henrik, if filing a new or reopen this depends on what's your problem. You wrote "I cant post posting to any newsservers anymore". The problem of this bug is that every mail was sent (and still is if you share identities between accounts manually) through the first server. What error message do you get when posting the message. A step-by-step description what you did would be useful.
Comment 114•21 years ago
|
||
This is not fixed in the current trunk. When I try to reply to an existing post in news://news.mozilla.org/netscape.public.mozilla.os2, and add the group news://news.mozilla.org/netscape.public.mozilla.style, when I try to send, I get the following: Sending of message failed. You can only send a message to one news server at a time. news.mozilla.org is not my #1 news server. I have 4 servers configured. Should I reopen this, or open a new bug?
Assignee | ||
Comment 115•21 years ago
|
||
Felix, I can reproduce the problem. Though it only occurs if one you're subscribed to one of the groups you add on another server too, it's still a bug. But since this bug is already quite messed up and with bug 228597 another one exists, I'd don't reopen it. I'll try to find out what's happening and maybe fix it in bug 228597 or file a new if it's to different.
Assignee | ||
Comment 116•21 years ago
|
||
I just opened bug 230899 for this issue.
Updated•20 years ago
|
Flags: blocking1.4.2? → blocking1.4.2-
Comment 117•20 years ago
|
||
*** Bug 209170 has been marked as a duplicate of this bug. ***
Comment 118•20 years ago
|
||
Can somebody please check if bug 199276 can also be marked FIXED (see bug 199276 comment 9)?
Comment 119•20 years ago
|
||
This bug still exists for me in 1.8a. This may be the case because I have manually set multiple accounts to the same id: user_pref("mail.account.account1.identities", "id20"); user_pref("mail.account.account2.identities", "id20"); user_pref("mail.account.account3.identities", "id20");
Assignee | ||
Comment 120•20 years ago
|
||
After closing this one, bug 228597 has been filed to fix exactly this problem (shared identities). I guess you ran into bug 228593 - not the wrong server is used but the wrong drop-down entry is preselected. In your case the first account using id20, that is account1. If account 1 isn't an account with a newsserver, the first one with a newsserver is taken. To work around the problem, you've to make sure the right entry is selected before sending the message.
Updated•20 years ago
|
Product: MailNews → Core
Updated•15 years ago
|
Product: Core → MailNews Core
You need to log in
before you can comment on or make changes to this bug.
Description
•