646168 - crash (shift-del) deleting/moving mail in normal or Unified Folders view? [@ nsMsgXFViewThread::RemoveChildHdr] via nsMsgSearchDBView::OnHdrDelete - m_view is already destroyed or invalid

Status: RESOLVED FIXED

(MailNews Core :: Backend, defect, P1)

Description

[Wayne Mery (:wsmwk)]

crash [@ @0x0 | nsMsgXFViewThread::RemoveChildHdr(nsIMsgDBHdr*, nsIDBChangeAnnouncer*)]

from crash-stats. 

nsMsgXFViewThread::RemoveChildHdr(nsIMsgDBHdr*, nsIDBChangeAnnouncer*) has the same stack

this module has many crashes sigs (at least 4) per https://bugzilla.mozilla.org/buglist.cgi?type1-0-0=anywordssubstr&field0-0-0=short_desc&bug_severity=critical&bug_severity=major&bug_severity=normal&type0-0-1=substring&field0-0-1=keywords&type1-0-1=substring&value1-0-1=backend&resolution=---&classification=Client%20Software&classification=Components&query_format=advanced&value1-0-0=virtual%20saved%20XFView&longdesc=virtual%20XFView&value0-0-1=crash&type0-0-0=anywordssubstr&value0-0-0=crash%20segfault&field1-0-0=short_desc&product=MailNews%20Core&product=Thunderbird&longdesc_type=anywordssubstr&field1-0-1=component

262af427-7dde-4bf6-9846-c45d62110329
EXCEPTION_ACCESS_VIOLATION_READ
0x0
0		@0x0	
1	thunderbird.exe	nsMsgXFViewThread::RemoveChildHdr	mailnews/base/src/nsMsgXFViewThread.cpp:346
2	thunderbird.exe	nsMsgSearchDBView::OnHdrDeleted	mailnews/base/src/nsMsgSearchDBView.cpp:266
3	thunderbird.exe	nsMsgDatabase::NotifyHdrDeletedAll	mailnews/db/msgdb/src/nsMsgDatabase.cpp:724
4	thunderbird.exe	nsMsgDatabase::DeleteHeader	mailnews/db/msgdb/src/nsMsgDatabase.cpp:1810
5	thunderbird.exe	nsMsgDatabase::DeleteMessages	mailnews/db/msgdb/src/nsMsgDatabase.cpp:1753
6	thunderbird.exe	nsImapMailFolder::CopyMessagesOffline	mailnews/imap/src/nsImapMailFolder.cpp:7178
7	thunderbird.exe	nsImapMailFolder::CopyMessages	mailnews/imap/src/nsImapMailFolder.cpp:7336
8	thunderbird.exe	nsMsgCopyService::DoNextCopy	mailnews/base/src/nsMsgCopyService.cpp:321
9	thunderbird.exe	nsMsgCopyService::DoCopy	mailnews/base/src/nsMsgCopyService.cpp:263
10	thunderbird.exe	nsMsgCopyService::CopyMessages	mailnews/base/src/nsMsgCopyService.cpp:531
11	thunderbird.exe	nsImapMailFolder::DeleteMessages	mailnews/imap/src/nsImapMailFolder.cpp:2405
12	thunderbird.exe	nsMsgSearchDBView::ProcessRequestsInOneFolder	mailnews/base/src/nsMsgSearchDBView.cpp:1097
13	thunderbird.exe	nsMsgSearchDBView::DeleteMessages	mailnews/base/src/nsMsgSearchDBView.cpp:908
14	thunderbird.exe	nsMsgDBView::ApplyCommandToIndices	mailnews/base/src/nsMsgDBView.cpp:2726
15	thunderbird.exe	nsMsgDBView::DoCommand	mailnews/base/src/nsMsgDBView.cpp:2393
16	thunderbird.exe	nsMsgSearchDBView::DoCommand	mailnews/base/src/nsMsgSearchDBView.cpp:807 

nsMsgXFViewThread::RemoveChildHdr(nsIMsgDBHdr*, nsIDBChangeAnnouncer*)
bpf913b143-3f4f-490c-9441-2746d2110329
EXCEPTION_ACCESS_VIOLATION_EXEC
0x206f6f74
0 		@0x206f6f74 	
1 	thunderbird.exe 	nsMsgXFViewThread::RemoveChildHdr 	mailnews/base/src/nsMsgXFViewThread.cpp:346
2 	thunderbird.exe 	nsMsgSearchDBView::OnHdrDeleted 	mailnews/base/src/nsMsgSearchDBView.cpp:266
3 	thunderbird.exe 	nsMsgDatabase::NotifyHdrDeletedAll 	mailnews/db/msgdb/src/nsMsgDatabase.cpp:724
4 	thunderbird.exe 	nsMsgDatabase::DeleteHeader 	mailnews/db/msgdb/src/nsMsgDatabase.cpp:1810
5 	thunderbird.exe 	nsMsgDatabase::DeleteMessages 	mailnews/db/msgdb/src/nsMsgDatabase.cpp:1753
6 	thunderbird.exe 	nsImapMailFolder::CopyMessagesOffline 	mailnews/imap/src/nsImapMailFolder.cpp:7178
7 	thunderbird.exe 	nsImapMailFolder::CopyMessages 	mailnews/imap/src/nsImapMailFolder.cpp:7336
8 	thunderbird.exe 	nsMsgCopyService::DoNextCopy 	mailnews/base/src/nsMsgCopyService.cpp:321
9 	thunderbird.exe 	nsMsgCopyService::DoCopy 	mailnews/base/src/nsMsgCopyService.cpp:263
10 	thunderbird.exe 	nsMsgCopyService::CopyMessages 	mailnews/base/src/nsMsgCopyService.cpp:531
11 	thunderbird.exe 	nsImapMailFolder::DeleteMessages 	mailnews/imap/src/nsImapMailFolder.cpp:2405
12 	thunderbird.exe 	nsMsgSearchDBView::ProcessRequestsInOneFolder 	mailnews/base/src/nsMsgSearchDBView.cpp:1097
13 	thunderbird.exe 	nsMsgSearchDBView::DeleteMessages 	mailnews/base/src/nsMsgSearchDBView.cpp:908
14 	thunderbird.exe 	nsMsgDBView::ApplyCommandToIndices 	mailnews/base/src/nsMsgDBView.cpp:2726
15 	thunderbird.exe 	nsMsgDBView::DoCommand 	mailnews/base/src/nsMsgDBView.cpp:2393
16 	thunderbird.exe 	nsMsgSearchDBView::DoCommand 	mailnews/base/src/nsMsgSearchDBView.cpp:807

Comment 1

[David :Bienvenu]

hmm, I guess m_view is null - not sure how that can happen.

Comment 2

[Wayne Mery (:wsmwk)]

(In reply to comment #1)
> hmm, I guess m_view is null - not sure how that can happen.

is bug 526935 the same issue?


(no significant crash reporter emails available to work with)

Comment 3

[Jonathan Lewis]

Wayne,

In response to your request for the information to be entered here instead of just E-mails:

The first instance I selected four E-mails to move, the only other time it has happened it was a single message. I am using "Unified Folders".

Jon

Comment 4

[Wayne Mery (:wsmwk)]

bp-e1ec7cfb-291b-47f7-8bcc-354a72121212
bp-9d06e466-1e17-4d3f-b137-5624f2121205

Comment 5

[Wayne Mery (:wsmwk)]

(In reply to David :Bienvenu from comment #1)
> hmm, I guess m_view is null - not sure how that can happen.

the reporter of bp-98c884ff-a16e-4194-b669-9d07e2130701  says "Just deactivated Thunderbird-Conversations Add-On some minutes ago, then moved some Inbox-Mails into local folders. Since then no such problems".

Thunderbird-Conversations does not however correlate in the other crashes looked at. For example bp-01f14752-3a2f-4c56-948f-618a62130714 and bp-1482632b-3749-4f15-b56c-6b2352130701

Comment 6

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #5)
> (In reply to David :Bienvenu from comment #1)
> > hmm, I guess m_view is null - not sure how that can happen.
> 
> the reporter of bp-98c884ff-a16e-4194-b669-9d07e2130701 (humbug) says "Just
> deactivated Thunderbird-Conversations Add-On some minutes ago, then moved
> some Inbox-Mails into local folders. Since then no such problems".

Comment 7

[Wayne Mery (:wsmwk)]

topcrash in TB24

bp-f05dcaff-1383-436a-b0f1-ca74f2140312
0	xul.dll	nsMsgXFViewThread::RemoveChildHdr(nsIMsgDBHdr *,nsIDBChangeAnnouncer *)	mailnews/base/src/nsMsgXFViewThread.cpp
1	xul.dll	nsMsgSearchDBView::OnHdrDeleted(nsIMsgDBHdr *,unsigned int,int,nsIDBChangeListener *)	mailnews/base/src/nsMsgSearchDBView.cpp
2	xul.dll	nsMsgDatabase::NotifyHdrDeletedAll(nsIMsgDBHdr *,unsigned int,int,nsIDBChangeListener *)	mailnews/db/msgdb/src/nsMsgDatabase.cpp
3	xul.dll	nsMsgDatabase::DeleteHeader(nsIMsgDBHdr *,nsIDBChangeListener *,bool,bool)	mailnews/db/msgdb/src/nsMsgDatabase.cpp
4	xul.dll	nsMsgDatabase::DeleteMessages(unsigned int,unsigned int *,nsIDBChangeListener *)	mailnews/db/msgdb/src/nsMsgDatabase.cpp
5	xul.dll	nsImapMailFolder::CopyMessagesOffline(nsIMsgFolder *,nsIArray *,bool,nsIMsgWindow *,nsIMsgCopyServiceListener *)	mailnews/imap/src/nsImapMailFolder.cpp
6	xul.dll	nsImapMailFolder::CopyMessages(nsIMsgFolder *,nsIArray *,bool,nsIMsgWindow *,nsIMsgCopyServiceListener *,bool,bool)	mailnews/imap/src/nsImapMailFolder.cpp
7	xul.dll	nsMsgCopyService::DoNextCopy()	mailnews/base/src/nsMsgCopyService.cpp 

ehsan@13324  303 for (uint32_t childIndex = 0; childIndex < m_keys.Length(); childIndex++)
bienvenu@774 304 {
bienvenu@774 305 if (m_keys[childIndex] == msgKey && m_folders[childIndex] == msgFolder)
bienvenu@774 306 {
ehsan@13324  307 uint8_t levelRemoved = m_keys[childIndex];
bienvenu@774 308 // Adjust the levels of all the children of this header
bienvenu@774 309 nsMsgViewIndex i;
bienvenu@774 310 for (i = childIndex + 1;
bienvenu@774 311 i < m_keys.Length() && m_levels[i] > levelRemoved; i++)
bienvenu@774 312 m_levels[i] = m_levels[i] - 1;
bienvenu@774 313
bienvenu@774 314 m_view->NoteChange(childIndex + 1, i - childIndex + 1,
bienvenu@774 315 nsMsgViewNotificationCode::changed);

Comment 8

[ISHIKAWA, Chiaki]

I just noticed that this happens with imap(?)
I am using TB for POP3, and do not use unified view, so I did not notice this problem on my PCs.
But investigating imap angle may be a way to go IMHO.

Comment 9

[Adam Roach [:abr]]

bp-4c06d1f5-1c95-412f-8780-a17472140814

FWIW, I was moving messages from a unified inbox view to a folder. The only accounts I have are IMAP.

Comment 11

[Wayne Mery (:wsmwk)]

(In reply to Adam Roach [:abr] from comment #9)
> bp-4c06d1f5-1c95-412f-8780-a17472140814
> 
> FWIW, I was moving messages from a unified inbox view to a folder. The only
> accounts I have are IMAP.

abr's stack 
 0 	XUL	nsMsgXFViewThread::RemoveChildHdr(nsIMsgDBHdr*, nsIDBChangeAnnouncer*)	mailnews/base/src/nsMsgXFViewThread.cpp
1 	XUL	nsMsgSearchDBView::OnHdrDeleted(nsIMsgDBHdr*, unsigned int, int, nsIDBChangeListener*)	mailnews/base/src/nsMsgSearchDBView.cpp
2 	XUL	nsMsgDatabase::NotifyHdrDeletedAll(nsIMsgDBHdr*, unsigned int, int, nsIDBChangeListener*)	mailnews/db/msgdb/src/nsMsgDatabase.cpp
3 	XUL	nsMsgDatabase::DeleteHeader(nsIMsgDBHdr*, nsIDBChangeListener*, bool, bool)	mailnews/db/msgdb/src/nsMsgDatabase.cpp
4 	XUL	nsMsgDatabase::DeleteMessages(unsigned int, unsigned int*, nsIDBChangeListener*)	mailnews/db/msgdb/src/nsMsgDatabase.cpp
5 	XUL	nsImapMailFolder::CopyMessagesOffline(nsIMsgFolder*, nsIArray*, bool, nsIMsgWindow*, nsIMsgCopyServiceListener*)	mailnews/imap/src/nsImapMailFolder.cpp
6 	XUL	nsImapMailFolder::CopyMessages(nsIMsgFolder*, nsIArray*, bool, nsIMsgWindow*, nsIMsgCopyServiceListener*, bool, bool)	mailnews/imap/src/nsImapMailFolder.cpp
7 	XUL	_ZThn56_N16nsImapMailFolder12CopyMessagesEP12nsIMsgFolderP8nsIArraybP12nsIMsgWindowP25nsIMsgCopyServiceListenerbb	mailnews/imap/src/nsImapMailFolder.cpp
8 	XUL	nsMsgCopyService::DoNextCopy()	mailnews/base/src/nsMsgCopyService.cpp
9 	XUL	nsMsgCopyService::CopyMessages(nsIMsgFolder*, nsIArray*, nsIMsgFolder*, bool, nsIMsgCopyServiceListener*, nsIMsgWindow*, bool)	mailnews/base/src/nsMsgCopyService.cpp
10 	XUL	nsMsgSearchDBView::ProcessRequestsInOneFolder(nsIMsgWindow*)	mailnews/base/src/nsMsgSearchDBView.cpp

Comment 12

[Adam Roach [:abr]]

bp-0ebbee16-f8da-4d20-bf8f-ca9262160512

Comment 13

[Adam Roach [:abr]]

bp-eb652f7b-e9ed-47d4-b802-bc6f12161101

Comment 14

[Adam Roach [:abr]]

bp-af811eb8-357f-4821-bcea-e44e72170413

Comment 15

[Wayne Mery (:wsmwk)]

(In reply to Adam Roach [:abr] from comment #14)
> bp-af811eb8-357f-4821-bcea-e44e72170413

Adam are you still crashing?


I crashed two times in the last day:
bp-40a25557-2a37-49f4-9d7f-a46920180323  60.0a1 clicking a merssage in vseerror inbox after deleting a message in wayne.mery@g
bp-2e82a8fc-8c19-4b4d-88f3-84d280180323  52.7.0 during compose typing an email

This started after creating two new virtual folders both of which watch 60+ folders (even though I already have 10 virtual folders defined, but not actively using).  Perhaps related to Bug 775472 - Saved Search virtual folder (collecting mails marked "Unread") doesn't update automatically when incoming new mail is filtered into folders other than inbox - which I've  been seeing examples of.

Makoto, what do you make of this, or bug 1136498, or bug 1344036?

Comment 16

[Adam Roach [:abr]]

> Adam are you still crashing?

I haven't seen *this* crash in a while now. I have a recent GC/CC crash, but I don't have reason to believe it is related.

On the other hand, the telemetry graph does not show that the incidence of this crash is going down at all, so it would appear to be coincidence that I haven't hit it recently, rather than any actual improvement.

Comment 17

[Makoto Kato [:m_kato]]

(In reply to Wayne Mery (:wsmwk) from comment #15)
> (In reply to Adam Roach [:abr] from comment #14)
> > bp-af811eb8-357f-4821-bcea-e44e72170413
> 
> Adam are you still crashing?
> 
> 
> I crashed two times in the last day:
> bp-40a25557-2a37-49f4-9d7f-a46920180323  60.0a1 clicking a merssage in
> vseerror inbox after deleting a message in wayne.mery@g
> bp-2e82a8fc-8c19-4b4d-88f3-84d280180323  52.7.0 during compose typing an
> email
> 
> This started after creating two new virtual folders both of which watch 60+
> folders (even though I already have 10 virtual folders defined, but not
> actively using).  Perhaps related to Bug 775472 - Saved Search virtual
> folder (collecting mails marked "Unread") doesn't update automatically when
> incoming new mail is filtered into folders other than inbox - which I've 
> been seeing examples of.
> 
> Makoto, what do you make of this, or bug 1136498, or bug 1344036?

Bug 1136498 is related issue.  But I don't know whether it is same issue.

This bug's crash may be that nsMsgSearchDBView (m_view) is already destroyed or invalid.  I don't know root cause.

Comment 18

[Wayne Mery (:wsmwk)]

I don't recall if it was Ben or Geoff I saw recently lamenting the state of xfolder/virtual folder code.  Was that in a bug report?

It would be nice if we could make gradual progress / any progress so we can chip away at this topcrash area, because ...

per https://mzl.la/2C23P2a little has been fixed in the last 6 years, not since Bug 629487 crash [@ nsMsgDBView::RemoveRows] - except for a minor foray in bug 1385573, which doesn't look like it helped and so needs a followup bug.  

I just crashed bp-34da6ca5-0410-4f0b-9e26-2ec810181005 nsMsgXFViewThread::RemoveChildHdr 
But I rarely crash, so I don't have testcase

It looks like the average user/installation crashes 3 times, based on https://crash-stats.mozilla.com/signature/?signature=nsMsgXFViewThread%3A%3ARemoveChildHdr&date=%3E%3D2018-07-05T13%3A14%3A17.000Z&date=%3C2018-10-05T13%3A14%3A17.000Z#summary

Comment 19

[Geoff Lankow (:darktrojan)]

(In reply to Wayne Mery (:wsmwk) from comment #18)
> I don't recall if it was Ben or Geoff I saw recently lamenting the state of
> xfolder/virtual folder code.  Was that in a bug report?

I do complain a lot about the state of the code but I really doubt this was me.

Comment 20

[Ben Campbell]

(In reply to Wayne Mery (:wsmwk) from comment #18)
> I don't recall if it was Ben or Geoff I saw recently lamenting the state of
> xfolder/virtual folder code.  Was that in a bug report?

If it was me, it probably wasn't about virtual folders specifically, more just the accumulated complexity around folders in general. eg:

bug 1317117 comment 30
bug 92165 comment 141

Definitely a lot of scope for simplification and refactoring. It'd definitely help robustness, but it's really hard - there are so many legitimate corner cases and trickiness that's easy to overlook, so it's so easy to break things. Just a case of slowly and methodically chipping away and improving things I think.
(and it's not a complaint - it's all just the result of a complex app being exposed to real world use for a long period)

Comment 21

[Wayne Mery (:wsmwk)]

straight up delete from imap Inbox - message is not part of thread, and a virtual folder is not currently in display (but this Inbox is in some virtual folders)
bp-0d1b5a72-e151-4fa8-a13f-e453d0190507 60.6.1

Comment 22

[Paul Hatton]

The following shows a similar problem:

Remove any installations of Thunderbird including the profile folder
Install Thunderbird from download site https://www.thunderbird.net/en-GB/ taking default options - at the time of writing this installs 68.2.2 (32 bit)
Set up initial account - in my case hosted on chimail.uk2.net using IMAP on port 993 and SMTP on port 465
In Settings, specify Tools/Options and select 'Open messages in:An existing message window' and 'Close message window/tab on move or delete'
Add a second account
Select Unified folders from View/Folders/Unified
Select the unified Inbox
Open a mail - this opens in a new message window, as expected
Delete the mail - it closes the window, as expected

** but:

Select View/Sort By/Descending/Threaded and repeat - the window stays open after deleting a message. The mail itself does not need to be threaded to show this.

Comment 23

[Anje]

https://support.mozilla.org/en-US/questions/1272097 (Paul)
Testing another user claiming a bug where window does not close on delete.
Agreed there was a bug, but also managed to get a crash on last test.

Windows 10
Thunderbird 68.2.1
Set Unified view
The following all performed in the 'Unified Inbox'
Set Sort by to include threaded
Set options: Open messages in: 'An existing message window' and 'Close message window/tab on move or delete'

Double click to open any message - not necessarilly a threaded email.
email opens in new window.
Click on 'Delete' button
Window with deleted messages remains open, but note the 'Delete' button has been removed.
Close 'deleted email' window - top right X

Set options: Open messages in: 'An new message window' and 'Close message window/tab on move or delete'
Open email, email opens in new window, click on 'Delete'. Same result as above.
Close 'deleted email' window - top right X

Set options: Open messages in: 'A new tab' and 'Close message window/tab on move or delete'
Open email, email shows in tab. Click on Delete
Thunderbird program closed immediately - crashed.
Crash reporter:
bp-bc481bac-c68c-4828-a422-b32a70191108

Trying to reproduce crash is proving illusive.

Comment 24

[Wayne Mery (:wsmwk)]

Matt, can you reproduce using comment 23?

(No longer a topcrash)

Comment 25

[Matt]

Can not even see Comment 10 Wayne. If you can tell me how or what perhaps.

Comment 26

[Wayne Mery (:wsmwk)]

(In reply to Matt from comment #25)

Can not even see Comment 10 Wayne. If you can tell me how or what perhaps.

I meant comment 23 - my bad

Comment 27

[Matt]

Ok I can reproduce until it get to the close the tab. It just closes as expected without a crash. The windows functionality is obviously broken, the button disappears, but the content nor the windows does. I assume the code is hitting the button instead of the window context when the close is executed. But it should have it's own Bug I think. I can't find anything current. But my Bugzilla fu is not good.

Test done with 68.3.1. EN_US 64Bit
One obvious difference is I use ESET anti virus and Anje uses Norton. Or she did.

Comment 28

[Wayne Mery (:wsmwk)]

bp-16b405bb-0ff5-401c-824b-966120200212
I had just opened a message in a tab, closed 3 search tabs, filtered on Inbox two or three times.
Clicked on non-Inbox folder and crashed.
(no message deletes in these steps)

Comment 29

[Wayne Mery (:wsmwk)]

Paul, can you still reproduce, or have any crashes?

Comment 30

[Paul Hatton]

I can still reproduce the error with the window staying open; I have never had a crash.
Out of interest, shouldn't this be listed in the Known Problems in the Release Notes for each version as they are released?
Thanks

Comment 31

[Wayne Mery (:wsmwk)]

(In reply to Paul Hatton from comment #30)

...
Out of interest, shouldn't this be listed in the Known Problems in the Release Notes for each version as they are released?

If it were an extremely common problem, and the user could take some action to avoid it. Neither is the case here.

Comment 32

[Adam Roach [:abr]]

(In reply to Adam Roach [:abr] from comment #16)

Adam are you still crashing?

I haven't seen this crash in a while now.

Okay, I'm seeing it again. This time, I had just hit "delete" on a message in a unified folder view. This is on Windows (where my other crashes were on Macs), so it's definitely not platform-specific:

bp-67ea1c3d-f1e8-4647-84cb-702f90201116

Comment 33

[Wayne Mery (:wsmwk)]

Matt can you still reproduce?

Comment 34

[Wayne Mery (:wsmwk)]

related to Bug 1318751 - thread lost from view after deleting top message of thread - or any of https://mzl.la/2M8PRTI ? (unfortunately a long list)

Comment 35

[Wayne Mery (:wsmwk)]

(In reply to Adam Roach [:abr] from comment #32)

(In reply to Adam Roach [:abr] from comment #16)

Adam are you still crashing?

I haven't seen this crash in a while now.

Okay, I'm seeing it again. This time, I had just hit "delete" on a message in a unified folder view. This is on Windows (where my other crashes were on Macs), so it's definitely not platform-specific:

bp-67ea1c3d-f1e8-4647-84cb-702f90201116

but that was version 68. Have you had any crashes, of any signature, when using version 78?

Comment 36

[Wayne Mery (:wsmwk)]

Still needs reproducible steps.

Comment 37

[Wayne Mery (:wsmwk)]

Version 78.14.0 and 91.2.1 both rank ~#50.

Adam indicates he's stuck on version 68 because of a couple add-ons.

Comment 39

[Wayne Mery (:wsmwk)]

_tailMerge_d3dcompiler_47.dll | nsMsgXFViewThread::RemoveChildHdr bp-865eba7a-ec88-4d93-981f-bf6560220616
nsMsgMailNewsUrl::Clone bp-46a8fc15-619e-4fe3-a32c-2051b0220617
nsImapUrl::QueryInterface bp-0856c010-be13-48e2-a4ae-741090220614

Comment 40

[Rachel Martin]

More "modern" crashes in 91 and 102
https://crash-stats.mozilla.org/signature/?product=Thunderbird&signature=nsMsgXFViewThread%3A%3ARemoveChildHdr&date=%3E%3D2022-06-15T19%3A42%3A00.000Z&date=%3C2022-06-22T19%3A42%3A00.000Z&_columns=date&_columns=product&_columns=version&_columns=build_id&_columns=platform&_columns=reason&_columns=address&_columns=install_time&_columns=startup_crash&_sort=-date&page=1#reports
all point to this line:
https://searchfox.org/comm-central/rev/70eb022d47a9f70631a8db6a3f63575dcf05e21d/mailnews/base/src/nsMsgXFViewThread.cpp#291

Comment 41

[Rachel Martin]

As for the steps, we got this report:
In a unified view for some IMAP accounts which is threaded and sorted by date (nsMsgXFViewThread, XF = cross folder), delete a message.

Comment 42

[Wayne Mery (:wsmwk)]

TCW, does some combination of comment 23 and comment 41 crash for you?

Comment 43

[Arthur K. (he/him)]

So I can't repro using comment 23 since I can't find where "Open messages in: 'An existing message window' and 'Close message window/tab on move or delete" is anymore.

And using the STR in comment 41, TB did not crash for me (using 103.0b6).

Comment 44

[Arthur K. (he/him)]

(In reply to Rachel Martin from comment #41)

As for the steps, we got this report:
In a unified view for some IMAP accounts which is threaded and sorted by date (nsMsgXFViewThread, XF = cross folder), delete a message.

Did the report say which TB the were using to repro?

Comment 45

[b1]

The user was using 91, but 102 crashes as well, likely also later betas, see link in comment #40. A threaded unified view is perhaps not so common. Apparently it crashes a few times a day, so just a few tries won't reproduce the issue.

Comment 46

[Arthur K. (he/him)]

(In reply to b1 from comment #45)

The user was using 91, but 102 crashes as well, likely also later betas, see link in comment #40. A threaded unified view is perhaps not so common. Apparently it crashes a few times a day, so just a few tries won't reproduce the issue.

Hmm, so I must be doing something wrong in trying to repro the crash.

Comment 47

[sternmarc]

I still have the problem with 91.11. It indeed happens only sometimes, it's not systematic. I understand it's difficult to troubleshoot when it cannot be reproduced; if I can provide more info, tell me.

Comment 48

[sternmarc]

Additional note: the problem seems to be more frequent when using shift-del (permanent delete) than using normal delete

Comment 49

[Wayne Mery (:wsmwk)]

(In reply to sternmarc from comment #48)

Additional note: the problem seems to be more frequent when using shift-del (permanent delete) than using normal delete

stermarc, is this still true for you?

Comment 50

[Wayne Mery (:wsmwk)]

nsImapUrl::IsUrlType bp-eaef4ec9-260d-45dc-8eb2-e00960221122

Comment 51

[sternmarc]

Yes, still true

Comment 52

[ISHIKAWA, Chiaki]

So this should be tested

• unified view
• threaded display
• (IMAP?)

correct?

Comment 53

[sternmarc]

Correct (with IMAP)

Comment 55

[Wayne Mery (:wsmwk)]

bp-5da79fca-77d4-4dd5-be76-5ef7c0221124 from bug 1804141 is @ nsNSSSocketInfo::GetProviderTlsFlags

Comment 56

[kgbstrat]

I opened a bug that was closed, saying this is a duplicate. It is happening nearly every day to me. Below are a list of crash id's. This one was opened 12 years ago!!!! Doesn't sound like a fix is imminent. Thunderbird is almost unusable due to the frustration of constantly crashing

bp-482798df-c673-4030-a921-510500221203 12/3/2022, 3:18 PM
View
bp-846ff96a-db27-4e38-99b0-ca6030221201 12/1/2022, 10:27 AM
View
bp-42c1b796-a2e4-4135-af97-5ce020221128 11/28/2022, 6:52 PM
View
bp-563e844a-d0f8-499d-b779-775370221125 11/25/2022, 4:21 PM
View
bp-5da79fca-77d4-4dd5-be76-5ef7c0221124 11/24/2022, 11:24 AM
View
bp-6a2a1412-3bd0-47b8-be82-ffc040221122 11/21/2022, 10:19 PM
View
bp-b833b64d-3528-47c7-a6c7-58b920221121 11/21/2022, 4:27 PM
View
bp-3b68a6c3-69af-4fc5-9226-c467b0221117 11/17/2022, 3:38 PM
View
bp-72c1a04b-dbfa-48a9-85ac-62e7a0221113 11/13/2022, 5:18 PM
View
bp-994d7513-65d5-41d0-babe-5d8690221112 11/12/2022, 9:24 AM
View
bp-ab98ed4d-baa7-4132-b63c-e56820221111 11/11/2022, 5:03 PM
View
bp-de39303d-57dd-4fc7-9475-e8d770221028 10/28/2022, 2:28 PM
View
bp-cb996caf-f0d6-409f-a597-596e60221027 10/27/2022, 10:43 AM
View
bp-1ef3b234-a839-4cf1-9005-49d0b0221021 10/21/2022, 10:37 AM
View
bp-afc8f434-27eb-4276-8bf3-167270221020 10/20/2022, 12:53 PM
View
bp-3ddf0d66-f38b-49e8-b24e-32e180221018 10/18/2022, 5:11 PM
View
bp-4d878578-3f24-43ed-b21f-cbb030221017 10/17/2022, 7:58 PM
View
bp-39bc09ea-44c6-4db4-a47e-bf5d30221015 10/15/2022, 9:38 AM
View
bp-0afc69c7-a8cd-46cc-aaaf-8abd00221008 10/8/2022, 2:00 PM
View
bp-431a21ed-c3b2-4e87-b0dd-edb2d0220929 9/29/2022, 7:43 PM
View
bp-4701b3d3-29a6-4a7b-aef3-e1b920220923 9/23/2022, 2:32 PM
View

Comment 57

[Arthur K. (he/him)]

(In reply to kgbstrat from comment #56)

I opened a bug that was closed, saying this is a duplicate. It is happening nearly every day to me. Below are a list of crash id's. This one was opened 12 years ago!!!! Doesn't sound like a fix is imminent. Thunderbird is almost unusable due to the frustration of constantly crashing

This could be a Windows 11 specific issue or potentially an NVidia issue. GT 730 is quite long in the tooth. Are you by chance running that critical security release update for your NVidia card (https://www.nvidia.com/en-us/drivers/results/196634/)? Your CPU is a Coffee Lake, yes? Your profile is locally stored, yes?

102.6.0 is coming out next week as is the December Win 11 patch Tuesday update. Maybe one or the other will help?

Comment 58

[Arthur K. (he/him)]

(In reply to Arthur K. (he/him) from comment #43)

So I can't repro using comment 23 since I can't find where "Open messages in: 'An existing message window' and 'Close message window/tab on move or delete" is anymore.

And using the STR in comment 41, TB did not crash for me (using 103.0b6).

So I want to amend this a bit. I found the "Open messages in: 'An existing message window' and 'Close message window/tab on move or delete" settings and tried to repro again using 108.0b3.

Double click to open any message - not necessarilly a threaded email.
email opens in new window.
Click on 'Delete' button
Window with deleted messages remains open, but note the 'Delete' button has been removed.
Close 'deleted email' window - top right X

This did repro somewhat. On the first repro try, the Delete button doesn't disappear but it just greys out after being clicked. Nothing in Error Console. On second try, clicking the Delete button does close the open window. Same after a third repro try. Seems like it semi-repros on the first try only. Oddly, a ctrl-z action does not perform an undo-delete action and move the deleted message back to the Inbox from where it was deleted.

Set options: Open messages in: 'A new tab' and 'Close message window/tab on move or delete'
Open email, email shows in tab. Click on Delete
Thunderbird program closed immediately - crashed.

No crash for me here. The message opened in a tab closes normally. Here, a ctrl-z action does perform an undo-delete action and moves the deleted message back to the Inbox from where it was deleted.

Comment 59

[Arthur K. (he/him)]

I'm WFH today but on my work PC I have a copy of TB portable 102.5.0. I'll try to repro using that version tomorrow.

Comment 60

[Arthur K. (he/him)]

(In reply to Arthur K. (he/him) from comment #58)

(In reply to Arthur K. (he/him) from comment #43)

So I can't repro using comment 23 since I can't find where "Open messages in: 'An existing message window' and 'Close message window/tab on move or delete" is anymore.

And using the STR in comment 41, TB did not crash for me (using 103.0b6).

So I want to amend this a bit. I found the "Open messages in: 'An existing message window' and 'Close message window/tab on move or delete" settings and tried to repro again using 108.0b3.

Double click to open any message - not necessarilly a threaded email.
email opens in new window.
Click on 'Delete' button
Window with deleted messages remains open, but note the 'Delete' button has been removed.
Close 'deleted email' window - top right X

This did repro somewhat. On the first repro try, the Delete button doesn't disappear but it just greys out after being clicked. Nothing in Error Console. On second try, clicking the Delete button does close the open window. Same after a third repro try. Seems like it semi-repros on the first try only. Oddly, a ctrl-z action does not perform an undo-delete action and move the deleted message back to the Inbox from where it was deleted.

I tested with TB Portable 102.5.1 and was not able to repro. Also, the ctrl-z action did not perform an undo-delete action as I observed on my home PC with 108.0b3.

Set options: Open messages in: 'A new tab' and 'Close message window/tab on move or delete'
Open email, email shows in tab. Click on Delete
Thunderbird program closed immediately - crashed.

No crash for me here. The message opened in a tab closes normally. Here, a ctrl-z action does perform an undo-delete action and moves the deleted message back to the Inbox from where it was deleted.

Unable to repro and no crash for me using 102.5.1 as well. A ctrl-z action does perform an undo-delete action here.

Nothing weird in Error Console either.

Comment 61

[Arthur K. (he/him)]

Does it repro in Safe Mode?

Comment 62

[Wayne Mery (:wsmwk)]

Wonder why this more likely to crash with immediate delete (shift+delete). (I rarely use it)

Also, the version 102 crash rate is rought 2.5x higher than version 91.

https://searchfox.org/comm-central/rev/70eb022d47a9f70631a8db6a3f63575dcf05e21d/mailnews/base/src/nsMsgXFViewThread.cpp#291

bp-ef732c5a-e7e2-41db-b014-c5fbd0230115 windows Crash Address 0xe5e5e5e5e5e5e80d
bp-491db693-949b-435f-8579-14d4e0230114 linux Crash Address 0xe5e5e5e5e5e5e80d
bp-d34897d6-75c4-47b8-9188-9c8460230111 Mac Crash Address 0xe5e5e5e5e5e5e80d

m_view->NoteChange(childIndex + 1, i - childIndex + 1, is noted in comment 7.

Comment 63

[Wayne Mery (:wsmwk)]

sternmarc,

You mention this only happens sometimes. What percentage of deletes would you say? One in ten? One in fifty?
Unified folder view ? Or saved search?

kgbstrat seems to be gone. frustrated perhaps.

Comment 64

[kgbstrat]

Frustrated yes. Happens now with much less frequency. No idea what triggers it. I could delete many emails (one at a time with the delete key) with no issue. Then occasionally, same action will crash Thunderbird. The fact that this thread is 12 years old does not give me much hope. If it starts again more frequently, I'll just give up and switch to Outlook (which I really don't want to do).

Comment 65

[Arthur K. (he/him)]

(In reply to kgbstrat from comment #64)

Frustrated yes. Happens now with much less frequency. No idea what triggers it. I could delete many emails (one at a time with the delete key) with no issue. Then occasionally, same action will crash Thunderbird. The fact that this thread is 12 years old does not give me much hope. If it starts again more frequently, I'll just give up and switch to Outlook (which I really don't want to do).

Just ensure if it does happen that you submit a crash report. The last one from 3 years ago doesn't give much to go on since it doesn't seem to exist anymore. =\

Comment 66

[Arthur K. (he/him)]

(In reply to kgbstrat from comment #64)

Frustrated yes. Happens now with much less frequency. No idea what triggers it. I could delete many emails (one at a time with the delete key) with no issue. Then occasionally, same action will crash Thunderbird. The fact that this thread is 12 years old does not give me much hope. If it starts again more frequently, I'll just give up and switch to Outlook (which I really don't want to do).

There should be a 102.7.2 coming soon but would you kindly retest with 102.8.0 next week? If it crashes again, it'll give us a more current look at what's going on. 12 years is a long time for this to still exist but it's tough to say why it's not happened with greater frequency to a greater TB population to merit more resources being put towards finding the cause and fixing it.

Comment 67

[kgbstrat]

Most recent crash report (v102.6.1 - updating to 102.7.2 now)

bp-f06f3e0b-64c1-44f9-a808-9db0b0230209 2/9/2023, 4:27 PM View

https://crash-stats.mozilla.org/report/index/f06f3e0b-64c1-44f9-a808-9db0b0230209

Comment 68

[Arthur K. (he/him)]

(In reply to kgbstrat from comment #67)

Most recent crash report (v102.6.1 - updating to 102.7.2 now)

Release notes for 102.7.2 state "Various crash fixes" but no specific details. Thanks for being willing to test.

Comment 69

[kgbstrat]

Still an issue. Crashes multiple times per day. Beyond frustrating.

Comment 70

[Arthur K. (he/him)]

(In reply to kgbstrat from comment #69)

Still an issue. Crashes multiple times per day. Beyond frustrating.

And this is with 102.11.0, yes? Do you happen to have a link to one of your latest crash reports you can share?

Comment 71

[kgbstrat]

Yes, 102.11.0

most recent crash report: https://crash-stats.mozilla.org/report/index/67fe46c8-2556-42a7-8cb7-d6d550230512

here's more:

bp-67fe46c8-2556-42a7-8cb7-d6d550230512 5/12/2023, 11:13 AM
View
bp-f5e4ac6a-c39d-4b7b-b785-053e20230510 5/10/2023, 12:13 PM
View
bp-f5529915-d26d-4ba5-9bea-b57b20230509 5/9/2023, 5:27 PM
View
bp-36bf4acd-4745-4ef1-8228-58bea0230502 5/2/2023, 10:29 AM
View
bp-a263af2c-951b-4a4b-b985-02d6f0230427 4/27/2023, 12:56 PM
View
bp-bd4ba890-0625-4277-81c8-de8900230414 4/14/2023, 7:40 PM
View
bp-587337eb-d45b-423a-9f79-df4700230407 4/6/2023, 8:32 PM
View
bp-735e4a47-d356-448c-b4eb-c7ec60230406 4/6/2023, 1:08 PM
View
bp-b740a2e7-3698-44bb-aa53-7ef5c0230406 4/5/2023, 9:02 PM
View
bp-3f0d8322-1e81-4919-a7bc-147cc0230401 4/1/2023, 3:20 PM
View
bp-abec901b-86b9-4842-a222-c8b0b0230331 3/31/2023, 4:11 PM
View
bp-582db7fe-570f-4e5f-8e9c-e7ae20230331 3/30/2023, 9:58 PM
View
bp-4fbfa882-19ad-4532-8364-fcd860230328 3/28/2023, 4:53 PM
View

Comment 72

[Wayne Mery (:wsmwk)]

Unified is a hornet's nest. I don't seeing it getting attention in the next few months.
I can only suggest trying beta - might be better, same, or worse.

Comment 73

[sternmarc]

It crashes so often that I'm really envisonning to switch to another program ...

Comment 74

[Arthur K. (he/him)]

(In reply to sternmarc from comment #73)

It crashes so often that I'm really envisonning to switch to another program ...

Understandable. Not seeing anything in the 102.11.0 relnotes that seems like a fix either. I know 115 is not too far away (July-ish).

Comment 75

[Wayne Mery (:wsmwk)]

(In reply to sternmarc from comment #73)

It crashes so often that I'm really envisonning to switch to another program ...

Understood but that's not helpful to this bug report - it doesn't change the crystal ball or help us move forward.

Comment 76

[sternmarc]

(In reply to Wayne Mery (:wsmwk) from comment #75)

(In reply to sternmarc from comment #73)

It crashes so often that I'm really envisonning to switch to another program ...

Understood but that's not helpful to this bug report - it doesn't change the crystal ball or help us move forward.

I didn't want to be rude, just to to sure everyone understands the order of magnitude of the crashes.
I'm ready to help obviously (test some pre-releases or specific fixes for instance).

Comment 77

[kgbstrat]

(In reply to Wayne Mery (:wsmwk) from comment #72)

Unified is a hornet's nest. I don't seeing it getting attention in the next few months.
I can only suggest trying beta - might be better, same, or worse.

This might be a clue. I changed from unified to favorites view and have yet to have it crash when deleting emails. More of a pain to use, but beats constant crashes.

Comment 78

[Wayne Mery (:wsmwk)]

#2 crash for 115.3.1 at ~900/week. ~1000 with bug 1344036.

Comment 79

[Wayne Mery (:wsmwk)]

@0x0 | nsMsgSearchDBView::OnHdrDeleted bp-a6eb63df-8b39-4df5-990f-e9ab50231023
nsMsgSearchDBView::OnHdrDeleted bp-34e9be06-90db-47a8-a37f-f2fee0231010

Comment 80

[Wayne Mery (:wsmwk)]

kgbstrat, can you still reproduce?

Comment 81

[kgbstrat]

(In reply to Wayne Mery (:wsmwk) from comment #80)

kgbstrat, can you still reproduce?

Stopped using Unified folders last time I posted. Recently upgraded to 115.4.1 (64-bit) and use Unified view, but only delete emails within each individual folder under the Unified view. SuperNova messed up the way I used Favorites, so need to use Unified again to somewhat organize in a way I like. Have had no crashes in quite a while. Just tried deleting emails in the Unified folder and was not able to reproduce. I'll try every so often, but assuming my issue has cleared up.

Comment 82

[kgbstrat]

Attachment: Crash popup

Spoke too soon

Comment 83

[Arthur K. (he/him)]

(In reply to kgbstrat from comment #82)

Spoke too soon

If you go to Help > Troubleshooting Information > scroll down to Crash Reports > is there a crash report shown there? If yes, can you copy the link and post it here?

Comment 84

[kgbstrat]

Spoke too soon:

AdapterDeviceID: 0x1287
AdapterDriverVersion: 30.0.14.7444
AdapterSubsysID: 37333842
AdapterVendorID: 0x10de
Add-ons: google%40search.mozilla.org:1.0,amazondotcom%40search.mozilla.org:1.1,bing%40search.mozilla.org:1.0,ddg%40search.mozilla.org:1.0,wikipedia%40search.mozilla.org:1.0,thunderbird-compact-light%40mozilla.org:1.3
AvailablePageFile: 7064997888
AvailablePhysicalMemory: 7701549056
AvailableVirtualMemory: 138505096015872
BackgroundTaskMode: 0
BlockedDllList:
BuildID: 20231024181440
CPUMicrocodeVersion: 0xde
ContentSandboxCapable: 1
ContentSandboxLevel: 1
ContentSandboxWin32kState: Win32k Lockdown enabled -- default value is true
CrashTime: 1698671813
DOMFissionEnabled: 1
DOMIPCEnabled: 1
EMCheckCompatibility: true
EventLoopNestingLevel: 1
GPUProcessLaunchCount: 1
GPUProcessStatus: Running
GpuSandboxLevel: 1
HeadlessMode: 0
InstallTime: 1698489070
LastStartupWasCrash: 0
LauncherProcessState: 0
ModuleSignatureInfo: {"Avast Software s.r.o.":["aswJsFlt.dll","snxhk.dll","aswhook.dll"],"Microsoft Corporation":["msvcp140.dll","VCRUNTIME140.dll","VCRUNTIME140_1.dll"],"Microsoft Windows":["TaskFlowDataEngine.dll","Windows.Security.Integrity.dll","edputil.dll","mlang.dll","wdmaud.drv","explorerframe.dll","dataexchange.dll","pcacli.dll","twinapi.dll","ntshrui.dll","Windows.FileExplorer.Common.dll","midimap.dll","usp10.dll","linkinfo.dll","ondemandconnroutehelper.dll","msacm32.drv","ksuser.dll","ktmw32.dll","sfc_os.dll","winmmbase.dll","msacm32.dll","AudioSes.dll","nlansp_c.dll","winrnr.dll","pnrpnsp.dll","NapiNSP.dll","wscapi.dll","cscapi.dll","wininet.dll","mpr.dll","wsock32.dll","webauthn.dll","comctl32.dll","directmanipulation.dll","msimg32.dll","Windows.Globalization.dll","textinputframework.dll","Windows.UI.Immersive.dll","Windows.UI.dll","Bcp47Langs.dll","srvcli.dll","iertutil.dll","urlmon.dll","MMDevAPI.dll","Windows.System.Launcher.dll","rasadhlp.dll","dbgcore.dll","dbghelp.dll","npmproxy.dll","mscms.dll","OneCoreUAPCommonProxyStub.dll","FWPUCLNT.DLL","twinapi.appcore.dll","wshbth.dll","windows.staterepositorycore.dll","version.dll","dhcpcsvc.dll","dhcpcsvc6.DLL","winmm.dll","CoreUIComponents.dll","avrt.dll","directxdatabasehelper.dll","netprofm.dll","winhttp.dll","propsys.dll","msvcp110_win.dll","policymanager.dll","DWrite.dll","dcomp.dll","CoreMessaging.dll","winnsi.dll","uxtheme.dll","DXCore.dll","dxgi.dll","dwmapi.dll","resourcepolicyclient.dll","WinTypes.dll","windows.storage.dll","slc.dll","netutils.dll","IPHLPAPI.DLL","dnsapi.dll","wtsapi32.dll","secur32.dll","kernel.appcore.dll","ntmarta.dll","sspicli.dll","mswsock.dll","winsta.dll","CRYPTBASE.DLL","umpdc.dll","powrprof.dll","bcrypt.dll","msasn1.dll","devobj.dll","cfgmgr32.dll","ServicingCommon.dll","profapi.dll","KERNELBASE.dll","gdi32full.dll","ucrtbase.dll","crypt32.dll","win32u.dll","bcryptPrimitives.dll","wintrust.dll","msvcp_win.dll","shlwapi.dll","ole32.dll","oleaut32.dll","clbcatq.dll","advapi32.dll","user32.dll","combase.dll","msctf.dll","kernel32.dll","imm32.dll","msvcrt.dll","nsi.dll","SHCore.dll","psapi.dll","sechost.dll","gdi32.dll","ws2_32.dll","rpcrt4.dll","shell32.dll","setupapi.dll","ntdll.dll"],"Mozilla Corporation":["xul.dll","thunderbird.exe","rnp.dll","nssckbi.dll","nss3.dll","freebl3.dll","softokn3.dll","mozglue.dll","lgpllibs.dll"]}
Notes:
FP(D00-L1000-W0000100-T000) DWrite? DWrite+ WR? WR+
ProductID: {3550f703-e582-4d05-9a08-453d09bdfdc6}
ProductName: Thunderbird
ReleaseChannel: release
SafeMode: 0
SecondsSinceLastCrash: 14767389
StartupCacheValid: 1
StartupCrash: 0
StartupTime: 1698661879
SubmittedFrom: Client
SystemMemoryUsePercentage: 54
TelemetryEnvironment: {"build":{"applicationId":"{3550f703-e582-4d05-9a08-453d09bdfdc6}","applicationName":"Thunderbird","architecture":"x86-64","buildId":"20231024181440","version":"115.4.1","vendor":null,"displayVersion":"115.4.1","platformVersion":"115.4.0","xpcomAbi":"x86_64-msvc","updaterAvailable":true},"partner":{"distributionId":null,"distributionVersion":null,"partnerId":null,"distributor":null,"distributorChannel":null,"partnerNames":[]},"system":{"memoryMB":16302,"virtualMaxMB":134217728,"cpu":{"isWindowsSMode":false,"count":6,"cores":6,"vendor":"GenuineIntel","name":"Intel(R) Core(TM) i5-9600K CPU @ 3.70GHz","family":6,"model":158,"stepping":12,"l2cacheKB":256,"l3cacheKB":9216,"speedMHz":3696,"extensions":["hasMMX","hasSSE","hasSSE2","hasSSE3","hasSSSE3","hasSSE4_1","hasSSE4_2","hasAVX","hasAVX2","hasAES"]},"os":{"installYear":2022,"hasSuperfetch":true,"hasPrefetch":true,"name":"Windows_NT","version":"10.0","locale":"en-US","servicePackMajor":0,"servicePackMinor":0,"windowsBuildNumber":22621,"windowsUBR":2428},"hdd":{"binary":{"model":"Samsung SSD 970 EVO 250GB","revision":"2B2QEXE7","type":"SSD"},"profile":{"model":"Samsung SSD 970 EVO 250GB","revision":"2B2QEXE7","type":"SSD"},"system":{"model":"Samsung SSD 970 EVO 250GB","revision":"2B2QEXE7","type":"SSD"}},"gfx":{"D2DEnabled":false,"DWriteEnabled":true,"ContentBackend":"Skia","Headless":false,"EmbeddedInFirefoxReality":false,"adapters":[{"description":"NVIDIA GeForce GT 730","vendorID":"0x10de","deviceID":"0x1287","subsysID":"37333842","RAM":2048,"driver":"C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumdx.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumdx.dll C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumd.dll,C:\WINDOWS\System32\DriverStore\FileRepository\nv_dispi.inf_amd64_351d5a47f9f176b5\nvldumd.dll","driverVendor":null,"driverVersion":"30.0.14.7444","driverDate":"5-11-2023","GPUActive":true}],"monitors":[{"screenWidth":1920,"screenHeight":1080,"refreshRate":60,"pseudoDisplay":false}],"features":{"compositor":"webrender","hwCompositing":{"status":"available"},"gpuProcess":{"status":"available"},"webrender":{"status":"available"},"wrCompositor":{"status":"available"},"openglCompositing":{"status":"unused"},"omtp":{"status":"unused"},"d3d11":{"status":"available","version":45056,"warp":false,"textureSharing":true,"blocklisted":false},"d2d":{"status":"available","version":"1.1"}}},"appleModelId":null,"hasWinPackageId":false,"sec":{"antivirus":null,"antispyware":null,"firewall":null},"isWow64":false,"isWowARM64":false},"settings":{"blocklistEnabled":true,"e10sEnabled":true,"e10sMultiProcesses":8,"fissionEnabled":true,"telemetryEnabled":false,"locale":"en-US","intl":{"requestedLocales":["en-US"],"availableLocales":["en-US"],"appLocales":["en-US"],"systemLocales":["en-US"],"regionalPrefsLocales":["en-US"],"acceptLanguages":["en-US","en"]},"update":{"channel":"release","enabled":true,"autoDownload":true,"background":true},"userPrefs":{"browser.cache.disk.capacity":1048576,"browser.fixup.alternate.enabled":false,"browser.search.region":"US","network.trr.strict_native_fallback":false,"widget.content.gtk-high-contrast.enabled":true},"sandbox":{"effectiveContentProcessLevel":1,"contentWin32kLockdownState":15},"launcherProcessState":0,"addonCompatibilityCheckEnabled":true,"isDefaultBrowser":null,"defaultSearchEngine":"ddg","defaultSearchEngineData":{"loadPath":"[addon][e-mail]","name":"DuckDuckGo","origin":"default","submissionURL":"https://duckduckgo.com/?q="}},"profile":{"creationDate":18783,"firstUseDate":18783},"addons":{"activeAddons":{},"theme":{"id":"[e-mail]","blocklisted":false,"description":"A theme with a light color scheme.","name":"Light","userDisabled":false,"appDisabled":false,"version":"1.3","scope":4,"foreignInstall":false,"hasBinaryComponents":false,"installDay":18899,"updateDay":18899},"activeGMPlugins":{"dummy-gmp":{"version":"0.1","userDisabled":false,"applyBackgroundUpdates":1}}}}
Throttleable: 1
TotalPageFile: 20717686784
TotalPhysicalMemory: 17093808128
TotalVirtualMemory: 140737488224256
URL:
UptimeTS: 99340.94864
User32BeforeBlocklist: 1
Version: 115.4.1
Winsock_LSP: MSAFD Tcpip [TCP/IPv6] : 2 : 23 : 1 : 6 : 0x20066 : 0x8 : %SystemRoot%\system32\mswsock.dll : : f9eab0c0-26d4-11d0-bbbf-00aa006c34e4
MSAFD Tcpip [UDP/IPv6] : 2 : 23 : 2 : 17 : 0x20609 : 0x8 : %SystemRoot%\system32\mswsock.dll : : f9eab0c0-26d4-11d0-bbbf-00aa006c34e4
MSAFD Tcpip [RAW/IPv6] : 2 : 23 : 3 : 0 : 0x20609 : 0xc : %SystemRoot%\system32\mswsock.dll : : f9eab0c0-26d4-11d0-bbbf-00aa006c34e4
MSAFD Tcpip [TCP/IP] : 2 : 2 : 1 : 6 : 0x20066 : 0x8 : %SystemRoot%\system32\mswsock.dll : : e70f1aa0-ab8b-11cf-8ca3-00805f48a192
MSAFD Tcpip [UDP/IP] : 2 : 2 : 2 : 17 : 0x20609 : 0x8 : %SystemRoot%\system32\mswsock.dll : : e70f1aa0-ab8b-11cf-8ca3-00805f48a192
MSAFD Tcpip [RAW/IP] : 2 : 2 : 3 : 0 : 0x20609 : 0xc : %SystemRoot%\system32\mswsock.dll : : e70f1aa0-ab8b-11cf-8ca3-00805f48a192
RSVP TCPv6 Service Provider : 2 : 23 : 1 : 6 : 0x22066 : 0x8 : %SystemRoot%\system32\mswsock.dll : : 9d60a9e0-337a-11d0-bd88-0000c082e69a
RSVP TCP Service Provider : 2 : 2 : 1 : 6 : 0x22066 : 0x8 : %SystemRoot%\system32\mswsock.dll : : 9d60a9e0-337a-11d0-bd88-0000c082e69a
RSVP UDPv6 Service Provider : 2 : 23 : 2 : 17 : 0x22609 : 0x8 : %SystemRoot%\system32\mswsock.dll : : 9d60a9e0-337a-11d0-bd88-0000c082e69a
RSVP UDP Service Provider : 2 : 2 : 2 : 17 : 0x22609 : 0x8 : %SystemRoot%\system32\mswsock.dll : : 9d60a9e0-337a-11d0-bd88-0000c082e69a
Hyper-V RAW : 2 : 34 : 1 : 1 : 0x20026 : 0x8 : %SystemRoot%\system32\mswsock.dll : : 1234191b-4bf7-4ca7-86e0-dfd7c32b5445
AF_UNIX : 2 : 1 : 1 : 0 : 0x20026 : 0x8 : %SystemRoot%\system32\mswsock.dll : : a00943d9-9c2e-4633-9b59-0057a3160994
MSAFD L2CAP [Bluetooth] : 2 : 32 : 1 : 256 : 0x20006 : 0x8 : %SystemRoot%\system32\mswsock.dll : : 9fc48064-7298-43e4-b7bd-181f2089792a
MSAFD RfComm [Bluetooth] : 2 : 32 : 1 : 3 : 0x20026 : 0x8 : %SystemRoot%\system32\mswsock.dll : : 9fc48064-7298-43e4-b7bd-181f2089792a
useragent_locale: en-US

This report also contains technical information about the state of the application when it crashed.(In reply to Arthur K. (he/him) from comment #83)

(In reply to kgbstrat from comment #82)

Spoke too soon

If you go to Help > Troubleshooting Information > scroll down to Crash Reports > is there a crash report shown there? If yes, can you copy the link and post it here?
https://crash-stats.mozilla.org/report/index/0a5057e4-e2b3-4eb2-86af-f47af0231030

Comment 85

[Arthur K. (he/him)]

(In reply to kgbstrat from comment #84)

(In reply to kgbstrat from comment #82)

Spoke too soon

If you go to Help > Troubleshooting Information > scroll down to Crash Reports > is there a crash report shown there? If yes, can you copy the link and post it here?
https://crash-stats.mozilla.org/report/index/0a5057e4-e2b3-4eb2-86af-f47af0231030

Based on this crash info, I need to ask: Is your profile on your C: drive?

Comment 86

[kgbstrat]

(In reply to Arthur K. (he/him) from comment #85)

(In reply to kgbstrat from comment #84)

(In reply to kgbstrat from comment #82)

Spoke too soon

If you go to Help > Troubleshooting Information > scroll down to Crash Reports > is there a crash report shown there? If yes, can you copy the link and post it here?
https://crash-stats.mozilla.org/report/index/0a5057e4-e2b3-4eb2-86af-f47af0231030

Based on this crash info, I need to ask: Is your profile on your C: drive?

Yes, it is located on the C: Drive

Comment 87

[Wayne Mery (:wsmwk)]

In version 115, the crash rate has doubled. So there is some combination of
a) more people using unified folders,
b) a new outright regression,
c) something other than a) and b) making the previous crash more common.

I'm not sure yet what b or c might be. But perhaps it would help to continue the work begun in Bug 1731177 - Refactor nsMsgLocalMailFolder message copying - and related bugs?

Comment 88

[Wayne Mery (:wsmwk)]

Can anyone more easily reproduce this in version 115? With comment 23? (not comment 25)

Comment 89

[Bogomil Shopov[:Bogomil]]

I was not able to reproduce this with 115.4.3, using the comment 23 instructions. I am using Linux, maybe this is not relevant for my OS.

Comment 90

[Anje]

tested in beta 122.0b1 following same as comment 23
Cannot reproduce crash.
All worked as expected.

Comment 91

[Hartmut Welpmann [:welpy-cw]]

Steps to reproduce:

1. Open a cross-folder view.
2. Open any message amidst this view in a new window.
3. Close the three-pane window.
4. Delete the message in the new window.
5. Repeat step 4, if still possible.

This is my understanding of the problem:

When a message is displayed in a three-pane window or opened in a separate single window, the database view is cloned. In a cross-folder db view this involves copying the table of threads. Unfortunately the copy in the clone contains references to the thread objects of the original view, each of them including a pointer to the original db view, originating here.

The original db view is closed in step 3. In steps 4 and 5, the cloned view receives a notification about the deleted message, resulting in a notification for the already closed view here.

Aside from this crash, there are various other issues with the shallow copies of the xf view threads. Newly added headers are duplicated in the xf threads in each of the clones, while the multiplied deletions cause other strange effects regarding the threading representation, including the infamous empty mails from 1970. This is also responsible for the wrong unread and total message counts in xf threads.

Comment 92

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 646168 - When cloning a cross-folder view, make a deep copy of the threads/groups table. r=#thunderbird-reviewers

Comment 93

[Hartmut Welpmann [:welpy-cw]]

The suggested patch is supposed to fix bug 1776920, bug 1834801 and bug 1859639 as well.

Comment 94

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/81f34ca42e40
When cloning a cross-folder view, make a deep copy of the threads/groups table. r=mkmelin

Comment 95

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9370586 [details]
Bug 646168 - When cloning a cross-folder view, make a deep copy of the threads/groups table. r=#thunderbird-reviewers

[Approval Request Comment]
Regression caused by (bug #): Apparently this has been never implemented correctly.
User impact if declined: See comment 91.
Testing completed (on c-c, etc.): c-c
Risk to taking this patch (and alternatives if risky): This backend fix may be a bit more risky, but I think it's worth to test it thoroughly in beta.

Comment 96

[Wayne Mery (:wsmwk)]

Thanks. We'll hold this until next week's beta.

Comment 97

[Wayne Mery (:wsmwk)]

(In reply to Wayne Mery (:wsmwk) from comment #96)

Thanks. We'll hold this until next week's beta.

We will likely skip next week's beta, which means this will ride the train to beta 123 shipping ~Wednesday Jan 24. If all goes well, this might be in 115.8.something two weeks after that.

Comment 98

[Wayne Mery (:wsmwk)]

We need to check whether these go away:

• nsRefreshDriver::GetVsyncId which first appears in 115.6.0, precisely when bug 1859470 signature disappears. @ nsTArray_base<T>::Length | nsTArray_Impl<T>::IndexOf | nsTArray_Impl<T>::IndexOf | nsAutoTObserverArray<T>::IndexOf
  bp-6cc73fc5-41b4-4f82-92e7-f3d3d0240113

0	xul.dll	nsRefreshDriver::GetVsyncId()	layout/base/nsRefreshDriver.cpp:3014
1	xul.dll	nsMsgXFViewThread::RemoveChildHdr(nsIMsgDBHdr*, nsIDBChangeAnnouncer*)	mailnews/base/src/nsMsgXFViewThread.cpp:291
2	xul.dll	nsMsgSearchDBView::OnHdrDeleted(nsIMsgDBHdr*, unsigned int, int, nsIDBChangeListener*)	mailnews/base/src/nsMsgSearchDBView.cpp:223
3	xul.dll	nsMsgDatabase::NotifyHdrDeletedAll(nsIMsgDBHdr*, unsigned int, int, nsIDBChangeListener*)	mailnews/db/msgdb/src/nsMsgDatabase.cpp:756
4	xul.dll	nsMsgDatabase::DeleteHeader(nsIMsgDBHdr*, nsIDBChangeListener*, bool, bool)	mailnews/db/msgdb/src/nsMsgDatabase.cpp:1775
5	xul.dll	nsMsgDatabase::DeleteMessages(nsTArray<unsigned int> const&, nsIDBChangeListener*)	mailnews/db/msgdb/src/nsMsgDatabase.cpp:1724
6	xul.dll	nsImapMailFolder::CopyMessagesOffline(nsIMsgFolder*, nsTArray<RefPtr<nsIMsgDBHdr> > const&, bool, nsIMsgWindow*

• mozilla::detail::InvalidArrayIndex_CRASH | nsMsgGroupView::OnHdrDeleted
  Crash report: https://crash-stats.mozilla.org/report/index/c62ef62d-af42-45c9-a441-b72a90240113

Reason: EXCEPTION_BREAKPOINT

Top 10 frames of crashing thread:

0  mozglue.dll  MOZ_Crash  mfbt/Assertions.h:264
0  mozglue.dll  mozilla::detail::InvalidArrayIndex_CRASH  mfbt/Assertions.cpp:50
1  xul.dll  nsMsgGroupView::OnHdrDeleted  mailnews/base/src/nsMsgGroupView.cpp:686
2  xul.dll  nsMsgDatabase::NotifyHdrDeletedAll  mailnews/db/msgdb/src/nsMsgDatabase.cpp:756
3  xul.dll  nsMsgDatabase::DeleteHeader  mailnews/db/msgdb/src/nsMsgDatabase.cpp:1775
4  xul.dll  nsMsgDatabase::DeleteMessages  mailnews/db/msgdb/src/nsMsgDatabase.cpp:1724
5  xul.dll  nsImapMailFolder::UpdateImapMailboxInfo  mailnews/imap/src/nsImapMailFolder.cpp:2638
6  xul.dll    mailnews/imap/src/nsSyncRunnableHelpers.cpp:122
7  xul.dll  mozilla::RunnableTask::Run  xpcom/threads/TaskController.cpp:555
8  xul.dll  mozilla::TaskController::DoExecuteNextTaskOnlyMainThreadInternal  xpcom/threads/TaskController.cpp:879

Comment 99

[Wayne Mery (:wsmwk)]

Comment on attachment 9370586 [details]
Bug 646168 - When cloning a cross-folder view, make a deep copy of the threads/groups table. r=#thunderbird-reviewers

This will be in next week's beta, after the merge

Comment 100

[Hartmut Welpmann [:welpy-cw]]

Unfortunately, I just discovered a massive problem with single-folder saved searches grouped by sort. Simply selecting a message causes Thunderbird to crash. The following patch seems to work, but I haven't had much time to test it.

Can we exclude the main patch from merging into beta to have some more time to test this follow-up?

Comment 101

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 646168 - Follow-up fix for grouped-by-sort single-folder search views. r=#thunderbird-reviewers

Comment 102

[Magnus Melin [:mkmelin]]

I think then it's easiest to back out and re-land later with the other fix.

Comment 103

[Rob Lemley [:rjl]]

Backout (comment 94):
https://hg.mozilla.org/comm-central/rev/a87826e6e872a3734114a86bd9ef78f984794b0c

Comment 104

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/26e671149a11
When cloning a cross-folder view, make a deep copy of the threads/groups table. r=mkmelin
https://hg.mozilla.org/comm-central/rev/98812c2301c8
Follow-up fix for grouped-by-sort single-folder search views. r=mkmelin

Comment 106

[Wayne Mery (:wsmwk)]

Patch may have had an impact on beta crash rate for nsMsgSearchDBView::OnHdrDeleted.

There may be a slight impact on beta crash rate for nsMsgXFViewThread::RemoveChildHdr. But it is far from gone:

• bp-90af2471-7ed5-4859-9383-964340240201 123.0b2
• bp-aa16b76e-a3c9-4871-9e15-f84280240215 123.0b4
• bp-b661fcba-83dc-4824-a640-cbcd10240220. 123.0b5

In fact, Windows only beta crash rate, appears to have no change.

Comment 107

[Hartmut Welpmann [:welpy-cw]]

This hasn't been uplifted to beta yet.

Comment 108

[Wayne Mery (:wsmwk)]

(In reply to Hartmut Welpmann [:welpy-cw] from comment #107)

This hasn't been uplifted to beta yet.

Thanks. I forgot about the backout. I was going by target milestone.

Comment 109

[Wayne Mery (:wsmwk)]

We may have a winner - beta 124 so far has no crashes for nsMsgXFViewThread::RemoveChildHdr

And no regression bug reports that I can see. Shall we try uplifting to 115?

Comment 110

[Hartmut Welpmann [:welpy-cw]]

(In reply to Wayne Mery (:wsmwk) from comment #109)

Shall we try uplifting to 115?

Well, I think so!

Comment 111

[Hartmut Welpmann [:welpy-cw]]

As this is based on code changed in Bug 1866951, that one should be uplifted as well.

Comment 112

[Wayne Mery (:wsmwk)]

Comment on attachment 9370586 [details]
Bug 646168 - When cloning a cross-folder view, make a deep copy of the threads/groups table. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 113

[Wayne Mery (:wsmwk)]

Comment on attachment 9375455 [details]
Bug 646168 - Follow-up fix for grouped-by-sort single-folder search views. r=#thunderbird-reviewers

[Triage Comment]
Approved for esr115

Comment 114

[Rob Lemley [:rjl]]

Thunderbird 115.9.0:
https://hg.mozilla.org/releases/comm-esr115/rev/438c0c28c468
https://hg.mozilla.org/releases/comm-esr115/rev/1479ea7a0296

Comment 116

[Wayne Mery (:wsmwk)]

Anyone who crashed on beta or release(esr) 115 ...

Should find this fixed in beta 124 and 115.9.0 Windows or 115.9.0 Mac

Comment 117

[Wayne Mery (:wsmwk)]

So far, there are no crash reports from 115.9.0, most notably from the highest crash rate signature nsMsgXFViewThread::RemoveChildHdr.

Comment 121

[Wayne Mery (:wsmwk)]

Hartmut, great job killing the ancient crash.

Comment 123

[Magnus Melin [:mkmelin]]

Indeed, thanks Hartmut! \o/