82262 - IMAP Renaming folder unsets every customized folder property: charset, sortby, favorites, retention policy, "check this folder", etc

Status: NEW

(MailNews Core :: Backend, defect, P3)

Description

[marina]

This could be related to bug # 81786
Steps to reproduce:
- select a folder that has a charset assigned to it ( say Cyrillic KOI8-R);
- rename the folder;
//note: headers with nomime are turned into ????, if you go and view folder 
charset you'll see that cyrillic koi8-r is unset ( unfortunately there is no 
list available to reset the encoding)

Comment 1

[nhottanscp]

Please try with 2001-05-17-08-mtrunk build which does not include bug 81786.

Comment 2

[marina]

yes, the fact that as soon as you change the folder name the folder's charset is 
back to the first one on the list, arabic ( so it is immediatly changed); the 
only difference is that in 2001-05-17 build you can correct it by choosing the 
same (charset again). could that be that it is as designed...?

Comment 3

[nhottanscp]

Could you check that other folder properties are preserved after rename?

Comment 4

[marina]

except Folder's encoding and " Apply to all.." that gets unchecked all other 
properties are preserved

Comment 5

[ji]

On 05/23 trunk builds (after the fix of bug 81786), renaming folder will reset 
the folder charset to the global view default charset. 

Comment 6

[nhottanscp]

Bug 81786 is fixed, please try again when the build is available.

Comment 7

[marina]

now i don't think that those 2 bugs are related.Since bug # 81786 got fixed 
nothing is changed in the behavior of this bug: the original folder charset is 
unset after renaming and is reverted back to the global default specified in 
Prefs

Comment 8

[nhottanscp]

Is this IMAP specific?

Comment 9

[marina]

yes, it is IMAP specific probelm and doesn't happen with Local folders

Comment 10

[nhottanscp]

Move to future, it might be related to bug 84385.
Cc to bienvenu, is charset attribute in msgdb supposed to be copied in case of
rename?

Comment 11

[David :Bienvenu]

I don't believe renaming copies any of the old settings to the new folder. It's
probably doable but not trivial - but if what you're getting at is that we
should be transferring the charset when we do transfer info (this transfer
happens when you compact a local folder, or when a local folder and its db get
out of sync, or when an imap folder's uid validity changes), then I agree with
you. Do you want to file a new bug for that?

Comment 12

[nhottanscp]

Using my debug build, folder charset was not reset after compacting the local
folder.
Marina, please try with release build when you have time, thanks.

Comment 13

[David :Bienvenu]

hmm, well, it probably should have been :-) but maybe the charset is stored in
panacea.dat?

Comment 14

[marina]

Naoki, are you saying that the local folder charset wasn't reset after renaming?
But local folders are fine, it happens only on IMAP

Comment 15

[nhottanscp]

Marina, I tested compact folder not rename.
David, what is "panacea.dat"?

Comment 16

[David :Bienvenu]

panacea.dat contains the summary of the global db information for every folder,
so that we don't have to open the db's for every folder to get things like the
total msg count and the unread count. But never mind, it's keyed by URI, and if
you rename a folder, the uri changes so we can't be getting that info from
panacea.dat.

Comment 17

[marina]

still happens with 2002-02-11 build

Comment 18

[shattered]

Still happends in Seamonkey 1.1.3.

Comment 22

[Wayne Mery (:wsmwk)]

rkent in bug 391641 writes "I would expect this to be an easy bug to solve."


from bug 536892
(In reply to David :Bienvenu from comment #4)
> ah, ok, that's a bit trickier, given the nature of imap, but it could be
> done somehow. We'd need to remember the settings, and then apply them once
> we'd run folder discovery and discovered the new imap folder.
(In reply to David :Bienvenu from comment #7)
> renaming an imap folder doesn't try to maintain any information currently.
> It gets a bit more complicated when you rename a folder hierarchy.

from bug 126489
(In reply to Navin Gupta from comment #0)
> We also need to decide what we have to do with mailboxName in 
> dbFolderInfo->GetTransferInfo.

Comment 23

[Hiroyuki Ikezoe (:hiro)]

When I was investigating bug 901959, I have noticed renaming IMAP folder does remove .msf file in nsImapMailFolder::RenameLocal(). So all of properties in .msf are lost while renaming.

Comment 27

[infinity0]

The most annoying thing for me that is lost is the "use offline" flag, i.e. in "Account Settings -> Sync & Storage -> Message Sync -> Advanced" I need to re-check the flag for the folder under the new name.

The behaviour is especially counterintuitive in that, if I rename the folder on "Profile 1", and then go into "Profile 2" it will automatically detect the new folder and apply the flag automatically in "Profile 2", even though "Profile 1" was the one that did the actual moving - and has more information to fix the situation! But no, I still have to fix things manually in "Profile 1".

Comment 28

[Mike Douglass]

For some time I've noticed that renaming a folder loses the favorite status. I'm on 68.4.2.

Is this still the same bug?

Comment 29

[Wayne Mery (:wsmwk)]

Is this still the same bug?

Yes, same issue.

Comment 30

[Wayne Mery (:wsmwk)]

Magnus, Kent felt this should be easy to fix, and I think it should just be a matter of copying the folder attributes. Pretty sure we fixed this for compact a few years ago, perhaps in this list https://mzl.la/38mW4RV - Aceman might remember. Can you set a priority?

Comment 32

[Magnus Melin [:mkmelin]]

Seems that the "offline" usage does survive a rename. The others don't.

Comment 33

[Wayne Mery (:wsmwk)]

(In reply to Magnus Melin [:mkmelin] from comment #32)

Seems that the "offline" usage does survive a rename.

Indeed it does. That's odd

Comment 34

[Magnus Melin [:mkmelin]]

Looking at bug 1633205 is likely helpful.

Comment 35

[Wayne Mery (:wsmwk)]

Ben, Do you still want this on your plate?

Comment 36

[Ben Campbell]

(In reply to Wayne Mery (:wsmwk) from comment #35)

Ben, Do you still want this on your plate?

Taking myself off it for now - too much else going on. But happy to come back to it.
It's one of those annoying ones that should be trivial, but ends up either as an icky workaround or a catalyst for a proper refactoring project to sort it out properly.

Comment 41

[Nico D.]

Bug 2060192 landed for 156 and covers part of this: on an IMAP rename or move a folder now keeps "select for offline use", "check this folder for new messages", favourite, its retention policy and its place in a manually sorted list, and the color survives on every account type.

What is left here is the view state in the folder database: sortType, sortOrder, viewType, viewFlags - the "sortby" of the summary - and columnStates, the columns reported in the duplicate bug 1998230. Only IMAP loses them, because only there does the rename replace the database.

The charset from the summary looks obsolete: there is no per-folder charset left in nsIMsgFolder.idl or nsIDBFolderInfo.idl.

I would like to take this on. It is the same place in the code as bug 2060192, nsImapIncomingServer::OnlineFolderRename, and the test file for it already exists.