Add page load size, speed, and time remaining to status bar

NEW
Assigned to

Status

()

--
enhancement
17 years ago
2 years ago

People

(Reporter: benjamin, Assigned: jag-mozilla)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 5 obsolete attachments)

(Reporter)

Description

17 years ago
Like in NS, I think the status bar should display the download speed and the
remaining time or "xxxk read" instead of "Transfering Data from.." after
reasonable delay when the file takes time. For exemple Quicktime Movie, long
text file(http://europa.eu.int/en/comm/eurostat/research/isi/glossaryfe.htm),
"huge" image...

Comment 1

17 years ago
Seems reasonable, confirming as NEW.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Summary: [REQUEST] Add download speed and remaining time in status bar → [RFE] Add download speed and remaining time in status bar

Comment 2

17 years ago
*** Bug 90773 has been marked as a duplicate of this bug. ***

Updated

17 years ago
Keywords: 4xp

Comment 3

17 years ago
*** Bug 92832 has been marked as a duplicate of this bug. ***

Comment 4

17 years ago
*** Bug 92989 has been marked as a duplicate of this bug. ***

Comment 5

17 years ago
*** Bug 75247 has been marked as a duplicate of this bug. ***

Comment 6

17 years ago
Yes please. One day I'll get around to doing a full spec for status bar text, 
but for now here's a mini-spec for the loading part.

If you know the size of all objects in the page:

    14 K of 62 K read (7.4 K/second), 3 seconds remaining ...

If you know the size of the main document and all HTML/XML frames, but you 
don't know the size of pictures, plain text objects, etc. embedded in them:

    14 K of 34 K read (7.4 K/second) ...
    [the total figure increases as you find out more, but that's ok]

If you don't know the size of the main document and all HTML/XML frames:

    14 K read (7.4 K/second) ...

This bug may end up being fixed in several small steps, so please keep
non-patch spam in the bug report to a minimum.

--> Networking.
Assignee: mpt → neeti
Component: User Interface Design → Networking
QA Contact: zach → benc

Updated

17 years ago
Summary: [RFE] Add download speed and remaining time in status bar → Add download speed and remaining time in status bar

Updated

17 years ago
Priority: -- → P3
Target Milestone: --- → mozilla0.9.7

Updated

17 years ago
Target Milestone: mozilla0.9.7 → Future
*** Bug 120428 has been marked as a duplicate of this bug. ***

Comment 8

17 years ago
-> file manager
Assignee: neeti → new-network-bugs

Comment 9

17 years ago
-> file handling
Assignee: new-network-bugs → law
Component: Networking → File Handling
QA Contact: benc → sairuh

Comment 10

17 years ago
*** Bug 139130 has been marked as a duplicate of this bug. ***

Comment 11

17 years ago
*** Bug 140246 has been marked as a duplicate of this bug. ***

Comment 12

17 years ago
*** Bug 140594 has been marked as a duplicate of this bug. ***

Comment 13

17 years ago
*** Bug 143111 has been marked as a duplicate of this bug. ***

Comment 14

16 years ago
*** Bug 156417 has been marked as a duplicate of this bug. ***

Comment 15

16 years ago
*** Bug 157901 has been marked as a duplicate of this bug. ***

Updated

16 years ago
Summary: Add download speed and remaining time in status bar → Add page load size, speed, and time remaining to status bar

Comment 16

16 years ago
*** Bug 159523 has been marked as a duplicate of this bug. ***
*** Bug 166586 has been marked as a duplicate of this bug. ***

Comment 18

16 years ago
Please note that the time display has been removed intentionally by bug 48436.
Helge, that has nothing to do with this bug, as this bug covers the information
_while the page loads_
QA Contact: sairuh → petersen

Comment 20

16 years ago
*** Bug 175231 has been marked as a duplicate of this bug. ***

Comment 21

16 years ago
yes, pleeeeeeeze! I don't know why it's been taken out in the first place (since
it was in the original Netscape codebase). 
I think it's useful information: If a page takes long time to load, is it
because my connection is slow or because the author wrote a **** 200k+ page?
If I see that my connection speed is slow I know who and how to address the
problem. If it's the page's fault I know not to visit it anymore. So it really
is useful info. I even like how Opera shows the loaded/total no. of images but I
don't know wether there'll be a majority for it. 
I don't think that Mozilla/Phoenix are about hiding what's going on under the hood. 
- Stephan 

PS: could this maybe be realized as an extension? So people who want it, install
it and the others don't.
>I don't know why it's been taken out in the first place (since
>it was in the original Netscape codebase). 

there was a rewrite of the whole code, so it was not "taken out".
please don't add useless comments like the one you added.

Comment 23

16 years ago
*** Bug 205827 has been marked as a duplicate of this bug. ***

Comment 24

15 years ago
Yes this enhancement should definitely be impletemented ASAP. It is very useful
and nearly all really good browsers have it.
It is very important to know the size, time it took to load the page and
connection speed. Switching from Opera to Firebird this feature is one i deeply
miss.

Comment 25

15 years ago
Yes this enhancement should definitely be impletemented ASAP. It is very useful
and nearly all really good browsers have it.
It is very important to know the size, time it took to load the page and
connection speed. Switching from Opera to Firebird this feature is one i deeply
miss.

Updated

15 years ago
Attachment #128851 - Flags: superreview?(jaggernaut)
Attachment #128851 - Flags: review?(jaggernaut)
Comment on attachment 128851 [details] [diff] [review]
Patch

+      this.status2 = "   ["+parseInt(aCurTotalProgress/1024)+" of "
+	 +parseInt(aMaxTotalProgress/1024)+" kB ("+parseInt(percentage)+"%) at
"
+	 +parseInt(100*aCurTotalProgress/(1024*elapsed))/100+" kB/s, "
+	
+parseInt(elapsed*(aMaxTotalProgress-aCurTotalProgress)/aCurTotalProgress+1)+"
s remaining]";

this needs to be localizable

Also, you can avoid the parseInt if you use the bitwise shift operator instead
of /1024, i.e.:
aCurTotalProgress>>10

+    if (aMessage.indexOf("Transferring") == 0) {

This will not work in non-english locales

thanks for making a patch!
Attachment #128851 - Flags: superreview?(jaggernaut)
Attachment #128851 - Flags: review?(jaggernaut)
Attachment #128851 - Flags: review-

Comment 28

15 years ago
localizable? how do i make into that?
sorry for being such a newbie :)

Comment 29

15 years ago
Created attachment 128859 [details] [diff] [review]
Patch v2
Attachment #128851 - Attachment is obsolete: true

Comment 30

15 years ago
Created attachment 128860 [details] [diff] [review]
Patch v2.1

I just saw I replaced one "start" too much...
Attachment #128859 - Attachment is obsolete: true

Updated

15 years ago
Attachment #128860 - Flags: superreview?(cbiesinger)
Attachment #128860 - Flags: review?(cbiesinger)

Comment 31

15 years ago
i applied the patch to those two files.. still didnt see any difference in the
status bar? any ideas?

Comment 32

15 years ago
@Vegeta: It will only work if the progress bar is also working. This is only the
case on some pages (but that is another Bug). Try
<http://msdn.microsoft.com/vstudio/downloads/updates/sp/vs6/sp5/>.

Comment 33

15 years ago
my progress bar is working..
Comment on attachment 128860 [details] [diff] [review]
Patch v2.1

well, I just tried applying the patch... didn't work well:
patching file nsBrowserStatusHandler.js
Hunk #5 FAILED at 369.
Hunk #6 FAILED at 76.
patch unexpectedly ends in middle of line
2 out of 6 hunks FAILED -- saving rejects to file nsBrowserStatusHandler.js.rej
patch unexpectedly ends in middle of line

Also, I can't superreview patches, and jag must either review or super-review
xpfe patches. as I don't really know this code here well, I'd prefer it if jag
reviewed it

+      this.statusProgress = "	 ["+(aCurTotalProgress>>10)+" of "
+	 +(aMaxTotalProgress>>10)+" kB ("+parseInt(percentage)+"%) at "
+	 +parseInt(100*(aCurTotalProgress>>10)/elapsed)/100+" kB/s, "
+	
+parseInt(elapsed*(aMaxTotalProgress-aCurTotalProgress)/aCurTotalProgress+1)+"
s "+remaining+"]";

this is still not localizable

+    if (aMessage.indexOf(transferring) == 0) {

+    if (aMessage.indexOf(transferring) == 0) {

well, I can't say I like this... is there no better way? Can you do this in
onStateChange instead, and check aStateFlags?
Attachment #128860 - Flags: superreview?(cbiesinger)
Attachment #128860 - Flags: review?(cbiesinger)
Attachment #128860 - Flags: review-

Comment 35

15 years ago
Do the statistics remain in the statusbar after the page is done loading?
They should, otherwise they will be unnoticed in most cases...

Comment 36

15 years ago
onStateChange has one Problem: aWebProgress and aRequest are always null, and
aStateFlags is either STATE_START || STATE_IS_REQUEST || STATE_IS_DOCUMENT ||
STATE_IS_NETWORK or STATE_STOP || STATE_IS_NETWORK || STATE_IS_WINDOW. I also
tried aWebProgress, aRequest and aStatus in onStatusChange. They are always null.

Comment 37

15 years ago
Created attachment 128962 [details] [diff] [review]
Patch v3
Attachment #128860 - Attachment is obsolete: true

Updated

15 years ago
Attachment #128962 - Flags: superreview?(jaggernaut)
Attachment #128962 - Flags: review?(jaggernaut)
(Assignee)

Comment 38

15 years ago
Comment on attachment 128962 [details] [diff] [review]
Patch v3

Also see bug 175231.

Just use |(new Date).getTime()| or |Date.now()| instead of using a helper
variable.

Don't use parseInt to get an integer from a float, it's slow. Use Math.floor
and Math.ceil instead.

Don't hardcode spaces for UI in your JS. Add another string to the .properties
file composed of the complete text you want with proper substitution
placeholders.

How come you're setting statusProgress on both this.status (causing
statusTextField.label to be updated) and statusMeter.label? Is this going to
show up twice in our UI?
Attachment #128962 - Flags: superreview?(jaggernaut) → superreview-
(Assignee)

Comment 39

15 years ago
Assigning to me purely to keep track of this.
Assignee: law → jaggernaut

Comment 40

15 years ago
Created attachment 129646 [details] [diff] [review]
Patch v4
Attachment #128962 - Attachment is obsolete: true

Updated

15 years ago
Attachment #128962 - Flags: review?(jag)

Updated

15 years ago
Attachment #129646 - Flags: superreview?(jag)
Attachment #129646 - Flags: review?(jag)

Comment 41

15 years ago
Comment on attachment 129646 [details] [diff] [review]
Patch v4

I didn't see that "www.web.de"...
Attachment #129646 - Flags: superreview?(jag)
Attachment #129646 - Flags: review?(jag)

Comment 42

15 years ago
Created attachment 129824 [details] [diff] [review]
Patch v4.1
Attachment #129646 - Attachment is obsolete: true

Updated

15 years ago
Attachment #129824 - Flags: superreview?(jag)
Attachment #129824 - Flags: review?(jag)
Attachment #129824 - Flags: review?(jag) → review?(neil.parkwaycc.co.uk)

Comment 43

15 years ago
Latest patch, though applies to trunk cleanly, doesn't add any statistics to
status bar. I see usual "Transferring data from". Final document load time is
there though: "Done [0.138s]".

Comment 44

14 years ago
Comment on attachment 129824 [details] [diff] [review]
Patch v4.1

doesn't apply anymore
Attachment #129824 - Flags: superreview?(jag)
Attachment #129824 - Flags: review?(neil.parkwaycc.co.uk)

Comment 45

14 years ago
darin: Since your checkin for Bug 192022 this patch doesn't work any more, but I
cannot figure out any good way to forward the old size values to
nsBrowserStatusHandler.js. Any ideas?

Comment 46

14 years ago
(In reply to comment #45)
> darin: Since your checkin for Bug 192022 this patch doesn't work any more, but I
> cannot figure out any good way to forward the old size values to
> nsBrowserStatusHandler.js. Any ideas?

sorry, no... i don't have any suggestions.  perhaps you could explain in detail
how your patch is meant to work.  then, i might be able to spot the problem.
Created attachment 192153 [details] [diff] [review]
Find items remaining during page load

This would display "n items remaining" in the status bar if it wasn't
immediately overwritten with "Transferring data from...".  Maybe it'll be
useful if someone else can figure out the rest.
QA Contact: chrispetersen → file-handling

Updated

2 years ago
Component: File Handling → File Handling
Priority: P3 → --
Product: Core → Firefox
Target Milestone: Future → ---
Version: Trunk → unspecified
You need to log in before you can comment on or make changes to this bug.