Closed Bug 1194096 Opened 5 years ago Closed 4 years ago

[browser] Firefox Account sync settings page

Categories

(Firefox OS Graveyard :: Gaia::TV, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.5+)

RESOLVED FIXED
FxOS-S10 (30Oct)
feature-b2g 2.5+

People

(Reporter: yifan, Assigned: ferjm)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])

Attachments

(1 file)

46 bytes, text/x-github-pull-request
yifan
: review+
selee
: review+
yifan
: feedback+
Details | Review
Implement Firefox Account sync settings page in TV browser.
No longer blocks: 1194091, 1194092, 1194094
Depends on: 1194097
Depends on: 1194098
No longer depends on: 1194098
Depends on: TV_FxAccount
Blocks: TV_FxAccount
No longer depends on: TV_FxAccount
No longer blocks: 1187830
No longer blocks: 1187840
No longer blocks: 1187838
Blocks: TV_Pocket
No longer blocks: TV_Pocket
feature-b2g: --- → 2.5+
Whiteboard: [ft:conndevices][partner-blocker]
Blocks: 1202376
Depends on: 1203898
No longer depends on: 1203898
Assignee: nobody → dhuang
Depends on: 1207481
No longer depends on: 1207481
Depends on: 1207483
No longer depends on: 1207483
Depends on: 1207488
No longer depends on: 1207488
Blocks: fxos-sync
Target Milestone: --- → FxOS-S9 (16Oct)
Target Milestone: FxOS-S9 (16Oct) → FxOS-S10 (30Oct)
Hi YiFan,
Will Dan still help on this?
Thanks!
Flags: needinfo?(yliao)
Assignee: dhuang → yliao
Flags: needinfo?(yliao)
Priority: -- → P1
Assignee: yliao → ferjmoreno
Attached file Gaia PR
I need to write some tests and we are still waiting for the final UX spec, but I would appreciate some feedback in the mean time :)

Thank you!
Attachment #8676184 - Flags: feedback?(yliao)
Attachment #8676184 - Flags: feedback?(selee)
Comment on attachment 8676184 [details] [review]
Gaia PR

Thank you very much for the effort! That's heaps of refinements. The rewrite is very well organized much easier to work on.
Attachment #8676184 - Flags: feedback?(yliao) → feedback+
Hey Fernando,

Thanks a lot that you provide these features and refactor for this bug!
just one question here...
Won't we need the button for 'Resend verification mail' and 'Forget this account' anymore?
Flags: needinfo?(ferjmoreno)
We don't need creating account. :)
Flags: needinfo?(ferjmoreno)
Attachment #8676184 - Flags: review?(yliao)
Attachment #8676184 - Flags: review?(selee)
Attachment #8676184 - Flags: feedback?(selee)
Blocks: 1194091
Comment on attachment 8676184 [details] [review]
Gaia PR

Looks great! Thanks for the help! r+ with a couple nits.
Attachment #8676184 - Flags: review?(yliao) → review+
Comment on attachment 8676184 [details] [review]
Gaia PR

Hey Fernando, Thanks for adding the code to bookmark/history! LGTM.
Attachment #8676184 - Flags: review?(selee) → review+
https://github.com/mozilla-b2g/gaia/commit/a019b49ca19f09e11a8bda0e1eaa4ff895833677
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
I think this will require late-l10n, don't know if the TV l10n is working in a different way tbh.
Flags: needinfo?(ferjmoreno)
Keywords: late-l10n
I have no idea
Flags: needinfo?(ferjmoreno) → needinfo?(awu)
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices][partner-blocker][partner-cherry-pick]
In tv_apps folder so taking out the late-l10n keyword. thanks
Keywords: late-l10n
Flags: needinfo?(awu)
You need to log in before you can comment on or make changes to this bug.